D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread trmdi
trmdi edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread trmdi
trmdi edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


Re: [sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

2018-11-03 Thread Ben Cooksley
On Sun, 4 Nov 2018, 14:18 Aleix Pol  I'm confused, this adds rsync and comments rsync out.
>

I had to comment rsync out because we can't rebuild the image at the moment.

I added it to the image for later on, when we can rebuild the image again.

Once we can, then that part of this commit can be reverted.


On Sat, Nov 3, 2018 at 4:48 AM Ben Cooksley  wrote:
> >
> > Git commit a01c4d1ba8fd31f1112c207b61542b14aab3e9e8 by Ben Cooksley.
> > Committed on 03/11/2018 at 03:48.
> > Pushed by bcooksley into branch 'master'.
> >
> > Disable parts of the System Dependency building on Android CI until
> rsync can be made available.
> > The Docker image for Android CI currently can't be built due to missing
> tags/branches in the Qt Git repositories which were previously present.
> > See
> https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.11%20SDK/
> for more information.
> >
> > CCMAIL: kde-frameworks-devel@kde.org
> > CCMAIL: aleix...@kde.org
> >
> > M  +1-1pipeline-templates/AndroidQt5.11.template
> > M  +1-0system-images/android/sdk/Dockerfile
> >
> >
> https://commits.kde.org/sysadmin/ci-tooling/a01c4d1ba8fd31f1112c207b61542b14aab3e9e8
> >
> > diff --git a/pipeline-templates/AndroidQt5.11.template
> b/pipeline-templates/AndroidQt5.11.template
> > index 17d21da..1c5f1b1 100644
> > --- a/pipeline-templates/AndroidQt5.11.template
> > +++ b/pipeline-templates/AndroidQt5.11.template
> > @@ -68,7 +68,7 @@ timestamps {
> >
> > \$systemDependencies
> >
> > -   rsync -Ha
> '\$DESTDIR/\$APP_INSTALL_PREFIX/' '\$APP_INSTALL_PREFIX/'
> > +   #rsync -Ha
> '\$DESTDIR/\$APP_INSTALL_PREFIX/' '\$APP_INSTALL_PREFIX/'
> > """
> > }
> >
> > diff --git a/system-images/android/sdk/Dockerfile
> b/system-images/android/sdk/Dockerfile
> > index 14deab2..14034ea 100644
> > --- a/system-images/android/sdk/Dockerfile
> > +++ b/system-images/android/sdk/Dockerfile
> > @@ -13,6 +13,7 @@ RUN apt-get -qq update && apt-get install -qq \
> >  build-essential \
> >  gperf gettext \
> >  python3 python3-paramiko python3-lxml python3-yaml \
> > +rsync \
> >  bison flex \
> >  ruby wget \
> >  libxml2-utils \
>


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 90 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/90/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 01:30:31 +
 Build duration:
9 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2913/3612)48%
(4381/9196)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(1000/1267)45%
(479/1073)src.extractors100%
(12/12)100%
(12/12)74%
(1097/1481)47%
(2143/4512)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/109/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 01:30:31 +
 Build duration:
1 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2912/3612)48%
(4396/9232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(999/1267)45%
(478/1073)src.extractors100%
(12/12)100%
(12/12)74%
(1097/1481)47%
(2159/4548)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 71 - Failure!

2018-11-03 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/71/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 04 Nov 2018 01:27:17 +
 Build duration:
2 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 544.88 KB...][ 49%] Building CXX object autotests/CMakeFiles/kcoredirlister_benchmark.dir/kcoredirlister_benchmark_autogen/mocs_compilation.cpp.objmocs_compilation.cppC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\autotests\deletejobtest.cpp(46): warning C4566: character represented by universal-character-name '\u8A66' cannot be represented in the current code page (1252)[ 49%] Building CXX object autotests/CMakeFiles/ksambashareprivatetest.dir/__/src/core/kiocoredebug.cpp.obj[ 49%] Linking CXX executable ..\bin\udsentry_benchmark.exe[ 49%] Linking CXX executable ..\bin\mkpathjobtest.exeC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(438): warning C4273: 'KSambaShare::KSambaShare': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(128): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(450): warning C4273: 'KSambaShare::~KSambaShare': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(107): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(460): warning C4273: 'KSambaShare::smbConfPath': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(118): note: see previous definition of 'smbConfPath'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(467): warning C4273: 'KSambaShare::isDirectoryShared': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(52): note: see previous definition of 'isDirectoryShared'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(473): warning C4273: 'KSambaShare::isShareNameAvailable': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(71): note: see previous definition of 'isShareNameAvailable'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(479): warning C4273: 'KSambaShare::shareNames': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(81): note: see previous definition of 'shareNames'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(485): warning C4273: 'KSambaShare::sharedDirectories': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(60): note: see previous definition of 'sharedDirectories'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(491): warning C4273: 'KSambaShare::getShareByName': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(93): note: see previous definition of 'getShareByName'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(497): warning C4273: 'KSambaShare::getSharesByPath': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(105): note: see previous definition of 'getSharesByPath'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(511): warning C4273: 'KSambaShare::instance': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(43): note: see previous definition of 'instance'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(73): warning C4273: 'KSambaShare::qt_static_metacall': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(37): note: see previous definition of 'qt_static_metacall'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(94): warning C4273: 'staticMetaObject': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(37): note: see previous definition of 'public: static QMetaObject const KSambaShare::staticMetaObject'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(94): error C2491: 'KSambaShare::staticMetaObject': definition of dllimport static data member not allowedC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(101): warning C4273: 'KSambaShare::metaObject': inconsistent dll 

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R286:3129ba1798fd: [XmlExtractor] Use QXmlStreamReader for 
better performance (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16591?vs=44647=44812

REVISION DETAIL
  https://phabricator.kde.org/D16591

AFFECTED FILES
  autotests/xmlextractortest.cpp
  src/extractors/xmlextractor.cpp

To: bruns, #frameworks, astippich, apol
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 299 - Fixed!

2018-11-03 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/299/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 01:21:11 +
 Build duration:
6 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(31990/59951)38%
(16483/43890)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9078/9517)48%
(4274/8942)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8332/14289)50%
(4653/9239)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3885/7921)34%
(1589/4691)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(525/1023)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1774/4316)35%
(1304/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
(697/1372)42%

D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-11-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:35c861bf146a: [KSambaShare] Add unit test for net 
usershare info parser (authored by bruns).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16466?vs=44322=44811

REVISION DETAIL
  https://phabricator.kde.org/D16466

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksambashareprivatetest.cpp
  autotests/ksambashareprivatetest.h

To: bruns, #frameworks, broulik, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread trmdi
trmdi added a comment.


  @ngraham
  How to see the full file content from this page?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16465: [KSambaShare] Make "net usershare info" parser testable

2018-11-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:253d58f6734e: [KSambaShare] Make net usershare 
info parser testable (authored by bruns).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16465?vs=44321=44810

REVISION DETAIL
  https://phabricator.kde.org/D16465

AFFECTED FILES
  src/core/ksambashare.cpp
  src/core/ksambashare_p.h

To: bruns, #frameworks, broulik, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


Re: [sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

2018-11-03 Thread Aleix Pol
I'm confused, this adds rsync and comments rsync out.
On Sat, Nov 3, 2018 at 4:48 AM Ben Cooksley  wrote:
>
> Git commit a01c4d1ba8fd31f1112c207b61542b14aab3e9e8 by Ben Cooksley.
> Committed on 03/11/2018 at 03:48.
> Pushed by bcooksley into branch 'master'.
>
> Disable parts of the System Dependency building on Android CI until rsync can 
> be made available.
> The Docker image for Android CI currently can't be built due to missing 
> tags/branches in the Qt Git repositories which were previously present.
> See 
> https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.11%20SDK/
>  for more information.
>
> CCMAIL: kde-frameworks-devel@kde.org
> CCMAIL: aleix...@kde.org
>
> M  +1-1pipeline-templates/AndroidQt5.11.template
> M  +1-0system-images/android/sdk/Dockerfile
>
> https://commits.kde.org/sysadmin/ci-tooling/a01c4d1ba8fd31f1112c207b61542b14aab3e9e8
>
> diff --git a/pipeline-templates/AndroidQt5.11.template 
> b/pipeline-templates/AndroidQt5.11.template
> index 17d21da..1c5f1b1 100644
> --- a/pipeline-templates/AndroidQt5.11.template
> +++ b/pipeline-templates/AndroidQt5.11.template
> @@ -68,7 +68,7 @@ timestamps {
>
> \$systemDependencies
>
> -   rsync -Ha '\$DESTDIR/\$APP_INSTALL_PREFIX/' 
> '\$APP_INSTALL_PREFIX/'
> +   #rsync -Ha '\$DESTDIR/\$APP_INSTALL_PREFIX/' 
> '\$APP_INSTALL_PREFIX/'
> """
> }
>
> diff --git a/system-images/android/sdk/Dockerfile 
> b/system-images/android/sdk/Dockerfile
> index 14deab2..14034ea 100644
> --- a/system-images/android/sdk/Dockerfile
> +++ b/system-images/android/sdk/Dockerfile
> @@ -13,6 +13,7 @@ RUN apt-get -qq update && apt-get install -qq \
>  build-essential \
>  gperf gettext \
>  python3 python3-paramiko python3-lxml python3-yaml \
> +rsync \
>  bison flex \
>  ruby wget \
>  libxml2-utils \


D16591: [XmlExtractor] Use QXmlStreamReader for better performance

2018-11-03 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16591

To: bruns, #frameworks, astippich, apol
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-11-03 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16465: [KSambaShare] Make "net usershare info" parser testable

2018-11-03 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16465

To: bruns, #frameworks, broulik, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread trmdi
trmdi added a comment.


  In D16643#353670 , @bruns wrote:
  
  > This is not covered by your summary - you have only listed cases where the 
drag is erroneously **not** accepted. Please update the summary.
  
  
  I wrote it in the first line:
  
  > m_enabled could change while moving.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread trmdi
trmdi added a comment.


  In D16643#353670 , @bruns wrote:
  
  > No. The event loop is running in a single thread. m_enabled is constant 
during the function.
  
  
  Can it be changed from outside?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread Stefan Brüns
bruns added a comment.


  In D16643#353669 , @trmdi wrote:
  
  > @bruns
  >  If `setAccepted` goes below the first if:
  >
  > - if there is a change that make m_enabled change from true -> false while 
moving, the cursor still display the draggable icon
  >
  >   So I let it be on the top to make the cursor be able to change the icon 
to forbidden one right away.
  
  
  No. The event loop is running in a single thread. m_enabled is constant 
during the function.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread trmdi
trmdi added a comment.


  @bruns
  If `setAccepted` goes below the first if:
  
  - if there is a change that make m_enabled change from true -> false while 
moving, the cursor still display the dragable icon
  
  So I let it be on the top to make the cursor be able to change the icon to 
forbidden one right away.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16579: Fix APE tag extraction

2018-11-03 Thread James Smith
smithjd added a comment.


  In D16579#352887 , @astippich 
wrote:
  
  > You're doing the exact opposite of what we're asking for.
  >  Look, I'd love to merge the bug fix for the DISC property. But we need 
compatibility.
  >  I'll give you another reason: KFileMetaData has basically required that 
users use the DISCNUMBER field until now. And now you want to change that 
without providing any suitable transition. That's not user-friendly.
  
  
  Despite the large amount of tagger information attached to this review, it's 
still impossible to find a tagger that defaults to an alternative to the DISC 
field name for APE, Some taggers implement the ability to add arbitrary fields 
to APE tags, and nothing is stopping anyone from populating a DISCNUMBER field, 
though ignoring the more-established DISC field name is counterintuitive and 
this should be regarded as a specialized use-case of the APE tag. Similarly the 
non-standard AlbumArtist alternative to the Album Artist APE field name has 
been accepted (albeit as an alternative to an established field name) since 
about the time the disk number property was introduced. Because one of the 
primary motivations behind multimedia tagging is seemless portability, 
specialized application of APE tags should not be encouraged over existing 
standard field names.
  
  Forcing compliance with established tag field names is lower maintenance, and 
not the end of the world for KDE APE tag users. Forcing these users to adopt 
established field names to make full use of the KDE metadata infrastructure is 
a responsible thing to do anyway, and users already understand they must put 
effort into their tags to reap the full benefit anyway. Ending the parsing of 
field names that have widely-implemented counterparts should be effected with 
no regard for compatibility with *any* specialised application of APE tags, and 
with *no* transition period. KDE is very specific about the types of metadata 
it can make use of and requiring users to make the extra effort to get better 
use of its capabilities is not unreasonable. It is also not unreasonable for 
the user to expect that this effort would be maximally re-useable elsewhere by 
default.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams


KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 123 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/123/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 22:35:50 +
 Build duration:
5 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 67 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/67/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 22:35:50 +
 Build duration:
1 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16633: Add root version of drive-harddisk

2018-11-03 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:67312861ffa3: Add root version of drive-harddisk 
(authored by ndavis, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16633?vs=44797=44809

REVISION DETAIL
  https://phabricator.kde.org/D16633

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-03 Thread Nathaniel Graham
ngraham added a reviewer: bruns.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16633: Add root version of drive-harddisk

2018-11-03 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  drive-harddisk-root_and_home (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-03 Thread Nathaniel Graham
ngraham added a dependent revision: D15739: [Places panel] Don't show Root by 
default.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D7446: [Places panel] Add a Recently Used item by default

2018-11-03 Thread Nathaniel Graham
ngraham edited the summary of this revision.
ngraham added a dependency: D15739: [Places panel] Don't show Root by default.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, 
gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, 
ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp


D15739: [Places panel] Don't show Root by default

2018-11-03 Thread Nathaniel Graham
ngraham added a dependent revision: D7446: [Places panel] Add a Recently Used 
item by default.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, michaelh, ngraham


D16633: Add root version of drive-harddisk

2018-11-03 Thread Nathaniel Graham
ngraham added a comment.


  Awesome, let's do it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D15739: [Places panel] Don't show Root by default

2018-11-03 Thread Nathaniel Graham
ngraham edited the summary of this revision.
ngraham added a dependency: D16653: Use the new `drive-harddisk-root` icon for 
the root volume.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, michaelh, ngraham


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-03 Thread Nathaniel Graham
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-03 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16633: Add root version of drive-harddisk

2018-11-03 Thread Nathaniel Graham
ngraham added a dependent revision: D16653: Use the new `drive-harddisk-root` 
icon for the root volume.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-03 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: romangg, VDG, Dolphin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Use the new `drive-harddisk-root` icon to mark the root volume. This makes it 
obvious which disk corresponds to `/` when there are multiple disks, and allows 
us to remove the root entry from the top section of the Places panel
  
  Depends on D16633 

TEST PLAN
  [images go here]

REPOSITORY
  R245 Solid

BRANCH
  root-disk-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16653

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, romangg, #vdg, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-11-03 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9a0505af2dbf: Introduce AbstractAnnotationItemDelegate for 
more control by consumer (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8708?vs=43868=44806#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=43868=44806

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/utils/ktexteditor.cpp
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau, #kate, #kdevelop, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread Stefan Brüns
bruns added a comment.


  So if I understand it correctly, the sequence of events is:
  
  - an object is dragged to the target area
  - m_enabled is initially false
  - m_enabled becomes true because the object is acceptable
  - the mouse is moved, but the //integer// position probably is unchanged, so 
the event is ignored/rejected
  
  In any  case, I think the `setAccepted(m_enabled)` should go below the first 
`if` statement, and as `m_enabled == true` holds afterwards, you can use 
`event->accept()`.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 11 - Fixed!

2018-11-03 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/11/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 03 Nov 2018 12:01:51 +
 Build duration:
6 hr 59 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 169 - Fixed!

2018-11-03 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/169/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 18:35:43 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(12/24)67%
(114/170)67%
(114/170)60%
(5490/9196)41%
(2073/5014)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(40/40)100%
(14/14)autotests.integration100%
(3/3)100%
(3/3)95%
(239/252)67%
(63/94)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(38/38)61%
(11/18)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(719/719)55%
(190/348)autotests.unit.file100%
(11/11)100%
(11/11)98%
(862/883)55%
(285/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(405/416)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)86%
(125/145)73%
(35/48)src.engine95%
(35/37)95%
(35/37)80%
(1716/2136)59%
(668/1139)src.file63%
(24/38)63%
(24/38)51%
(843/1647)42%
(433/1042)src.file.extractor14%
(1/7)14%
(1/7)9%
(18/196)7%
(5/76)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(21/21)75%
(6/8)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/233)0%
(0/191)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)48%
(464/958)43%
(255/599)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
(0/70)0%
   

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 137 - Fixed!

2018-11-03 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/137/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 18:35:43 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(12/24)68%
(115/170)68%
(115/170)60%
(5502/9198)41%
(2079/5014)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(40/40)100%
(14/14)autotests.integration100%
(3/3)100%
(3/3)95%
(239/252)67%
(63/94)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(38/38)61%
(11/18)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(719/719)55%
(190/348)autotests.unit.file100%
(11/11)100%
(11/11)98%
(862/883)55%
(285/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(405/416)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)86%
(125/145)73%
(35/48)src.engine95%
(35/37)95%
(35/37)80%
(1716/2136)59%
(668/1139)src.file66%
(25/38)66%
(25/38)52%
(855/1649)42%
(439/1042)src.file.extractor14%
(1/7)14%
(1/7)9%
(18/196)7%
(5/76)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(21/21)75%
(6/8)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/233)0%
(0/191)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)48%
(464/958)43%
(255/599)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
(0/70)0%
 

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis updated this revision to Diff 44797.
ndavis added a comment.


  Change color of forward slash to grey

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16633?vs=44759=44797

BRANCH
  drive-harddisk-root_and_home (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16633

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 52 - Fixed!

2018-11-03 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/52/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 03 Nov 2018 18:35:43 +
 Build duration:
6 min 19 sec and counting

D16643: Correct the accept flag of the event object on DragMove

2018-11-03 Thread trmdi
trmdi retitled this revision from "Correct m_enabled on DragMove " to "Correct 
the accept flag of the event object on DragMove ".

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: dkorth, ngraham, kde-frameworks-devel, michaelh, bruns


KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 52 - Fixed!

2018-11-03 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/52/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 03 Nov 2018 18:35:43 +
 Build duration:
2 min 26 sec and counting

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 71 - Still unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/71/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 18:24:08 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24651/29124)52%
(9741/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)96%
(11563/12057)49%
(6116/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5728/6933)64%
(1506/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6926/8188)64%
(1950/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16643: Correct m_enabled on DragMove

2018-11-03 Thread trmdi
trmdi added a comment.


  In D16643#353517 , @ngraham wrote:
  
  > Wow, does this really fix 396011!? If so, congratulations! I wish I could 
test, but alas (or thankfully?) I don't experience the problem.
  
  
  Yes, it fixes the problem on my system.
  But I am not sure, because I've just started learning C++ recently and this 
is my first patch. It could be wrong, but I hope someone else could improve it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: dkorth, ngraham, kde-frameworks-devel, michaelh, bruns


D16643: Correct m_enabled on DragMove

2018-11-03 Thread David Korth
dkorth added a comment.


  This fixes the issue for me for both desktop icons and panel widgets.
  
  Using KF 5.51, Plasma 5.14.2, and Qt 5.11.2.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: dkorth, ngraham, kde-frameworks-devel, michaelh, bruns


KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/97/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 18:24:08 +
 Build duration:
5 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24818/29126)53%
(9860/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11700/12056)49%
(6217/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5733/6934)64%
(1506/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6951/8190)64%
(1968/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16633: Add root version of drive-harddisk

2018-11-03 Thread Nathaniel Graham
ngraham added a comment.


  That's true. Okay, let's stay with a slash for now and just make it Icon 
Gray. In general I'd like to see us reduce our use of the red color for things 
that aren't actually destructive or errors, which I think will make it more 
meaningful for things that are.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis added a comment.


  In D16633#353510 , @ngraham wrote:
  
  > Hmm, you're right.
  >
  > Maybe we could use a slash for the 16px version, and the plasma logo for 
the larger ones?
  
  
  That would cause confusion though. The meaning of a forward slash is 
completely different from the meaning of a plasma logo and the association 
between the two would only be apparent to us. Not only that, but there are 
already other icons that use the Plasma logo in a meaningless way (see the 
other 64px device icons).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D16643: Correct m_enabled on DragMove

2018-11-03 Thread Nathaniel Graham
ngraham added reviewers: broulik, Plasma, hein, davidedmundson.
ngraham added a comment.


  Wow, does this really fix 396011!? If so, congratulations! I wish I could 
test, but alas (or thankfully?) I don't experience the problem.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D16633: Add root version of drive-harddisk

2018-11-03 Thread Nathaniel Graham
ngraham added a comment.


  Hmm, you're right.
  
  Maybe we could use a slash for the 16px version, and the plasma logo for the 
larger ones?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D16643: Correct m_enabled on DragMove

2018-11-03 Thread trmdi
trmdi created this revision.
trmdi added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  - `m_enabled` could change while moving.
  - Don't call `setAccepted(false)` wrongly if `event->pos() == m_oldDragMovePo`
  
  BUG: 396011

TEST PLAN
  - Drag a file from Dolphin -> Desktop (Desktop containment layout) -> too 
difficult -> fixed
  - Drag an icon on Desktop (Folder view layout) from one place to another one 
-> too difficult -> fixed
  - Add widgets to the Plasma panel -> too difficult -> fixed
  - Drag a file from Dolphin -> Desktop (Folder view layout) -> still easy

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

AFFECTED FILES
  src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp

To: trmdi, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 51 - Failure!

2018-11-03 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/51/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 03 Nov 2018 14:55:11 +
 Build duration:
2 hr 17 min and counting
   CONSOLE OUTPUT
  [...truncated 121.83 KB...]Call Stack (most recent call first):  C:/CI/Software Installs/baloo/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets)  src/lib/CMakeLists.txt:90 (ecm_add_qch)-- No such tag file "C:/CI/Software Installs/kfilemetadata/bin/data/doc/qch/KF5FileMetaData.tags" found for KF5FileMetaData_QCH when calling ecm_add_qch().CMake Warning at C:/CI/Software Installs/baloo/share/ECM/modules/ECMAddQch.cmake:391 (message):  No linking to API dox of KF5FileMetaData_QCH.Call Stack (most recent call first):  C:/CI/Software Installs/baloo/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets)  src/lib/CMakeLists.txt:90 (ecm_add_qch)-- The following features have been enabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following REQUIRED packages have been found: * ECM (required version >= 5.52.0), Extra CMake Modules,  * Qt5DBus * Qt5Gui (required version >= 5.11.2) * Qt5Widgets * Qt5Network (required version >= 5.11.2) * Qt5Qml * Qt5Quick * Qt5Test * Qt5 (required version >= 5.8.0) * KF5CoreAddons (required version >= 5.52.0) * KF5Config (required version >= 5.52.0) * KF5DBusAddons (required version >= 5.52.0) * Gettext * KF5I18n (required version >= 5.52.0) * KF5IdleTime (required version >= 5.52.0) * KF5Solid (required version >= 5.52.0) * KF5FileMetaData (required version >= 5.52.0) * KF5Crash (required version >= 5.52.0) * KF5KIO (required version >= 5.52.0) * KF5 (required version >= 5.52.0) * LMDB, Lightning Memory-Mapped Database (LMDB),  * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Core-- The following features have been disabled: * EXP, Build experimental features-- The following OPTIONAL packages have not been found: * Inotify   Filesystem alteration notifications using inotify-- Configuring done-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks/baloo/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[kf5-qt5 WindowsMSVCQt5.11] Running batch scriptC:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target KF5BalooCodecs_autogenScanning dependencies of target BalooDBusInterfacesScanning dependencies of target KF5Baloo_QCHError: dependent '..\docs\faq.md' does not exist.[  3%] Automatic MOC for target KF5BalooCodecs[  5%] Built target KF5BalooCodecs_autogen[  3%] Generating org.kde.baloo.main.xml[  3%] Generating org.kde.baloo.scheduler.xml[  5%] Generating org.kde.baloo.fileindexer.xml[  6%] Generating fileindexerinterface.cpp, fileindexerinterface.h[  7%] Generating schedulerinterface.cpp, schedulerinterface.h[  9%] Generating maininterface.cpp, maininterface.h[ 10%] Generating fileindexerinterface.moc[ 11%] Generating maininterface.moc[ 13%] Generating schedulerinterface.mocjom: C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [src\lib\CMakeFiles\KF5Baloo_QCH.dir\all] Error 2jom: C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\build\Makefile [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis added a comment.


  In D16633#353308 , @ngraham wrote:
  
  > Thank you! Two comments:
  >
  > - I'm not sure using the negative color is appropriate here. That color is 
used for dangerous operations or error conditions, neither of which apply to 
the OS volume. It's true that you could potentially blow yourself up by messing 
with it, but I don't really think that fits. The current red icon for root was 
never appropriate in the first place IMHO. Either Icon Blue or just the regular 
Icon Grey color seem more appropriate to me.
  
  
  I understand what you're saying, but throughout the Breeze theme, red is also 
used for root. If we used grey it would probably still be fine, but blue would 
stick out.
  
  > - Could we experiment with using the Plasma logo instead of a slash? The 
idea of using a slash to represent the root disk will be immediately apparent 
to technical users, but will be lost on everyone else. The Plasma logo might be 
more easily comprehensible for everyone.
  
  I do agree that the forward slash isn't a great symbol for root for 
non-technical users, but it's very difficult to fit anything even slightly 
complex onto the 16 px icons without it becoming difficult to read. The Plasma 
logo works fine for 64px, but it's not very good at the smaller sizes.
  
  This is my best attempt at getting the plasma logo to fit on the 16px icon:
  F6388344: Screenshot_20181103_120444.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 136 - Failure!

2018-11-03 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/136/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 14:55:11 +
 Build duration:
7 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 119.36 KB...]-- The following REQUIRED packages have been found: * ECM (required version >= 5.52.0), Extra CMake Modules,  * Qt5DBus * Qt5Gui (required version >= 5.9.6) * Qt5Widgets * Qt5Network (required version >= 5.9.6) * Qt5Qml * Qt5Quick * Qt5Test * Qt5 (required version >= 5.8.0) * KF5CoreAddons (required version >= 5.52.0) * KF5Config (required version >= 5.52.0) * KF5DBusAddons (required version >= 5.52.0) * Gettext * KF5I18n (required version >= 5.52.0) * KF5IdleTime (required version >= 5.52.0) * KF5Solid (required version >= 5.52.0) * KF5FileMetaData (required version >= 5.52.0) * KF5Crash (required version >= 5.52.0) * KF5KIO (required version >= 5.52.0) * KF5 (required version >= 5.52.0) * LMDB, Lightning Memory-Mapped Database (LMDB),  * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Core-- The following features have been disabled: * EXP, Build experimental features-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project baloo --branchGroup kf5-qt5 --platform SUSEQt5.9 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target BalooDBusInterfacesScanning dependencies of target KF5BalooCodecs_autogen[  0%] Generating org.kde.baloo.main.xml[  0%] Automatic MOC for target KF5BalooCodecs[  1%] Generating org.kde.baloo.scheduler.xml[  1%] Built target KF5BalooCodecs_autogenScanning dependencies of target KF5FileMetaData_QCH[  1%] Generating org.kde.baloo.fileindexer.xml[  1%] Built target KF5FileMetaData_QCH[  1%] Generating maininterface.cpp, maininterface.hScanning dependencies of target KF5CoreAddons_QCH[  1%] Generating schedulerinterface.cpp, schedulerinterface.h[  1%] Built target KF5CoreAddons_QCH[  1%] Generating fileindexerinterface.cpp, fileindexerinterface.hScanning dependencies of target extractorIOTest_autogen[  1%] Automatic MOC for target extractorIOTest[  1%] Generating maininterface.moc[  2%] Generating schedulerinterface.moc[  2%] Generating fileindexerinterface.moc[  2%] Built target extractorIOTest_autogen[  2%] Built target BalooDBusInterfacesScanning dependencies of target baloosearchmodule_autogenScanning dependencies of target advancedqueryparsertest_autogen[  2%] Generating baloosearchmodule.jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/kdedmodule.desktop"Found property definition "X-KDE-FactoryName" with type "QString"Found property definition "X-KDE-Kded-autoload" with type "bool"Found property definition "X-KDE-Kded-load-on-demand" with type "bool"Found property definition "X-KDE-Kded-phase" with type "int"Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"Generated  "/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/build/src/kioslaves/kded/baloosearchmodule.json" [  3%] Automatic MOC for target advancedqueryparsertest[  3%] Automatic MOC for target baloosearchmodule[  3%] Built target advancedqueryparsertest_autogenScanning dependencies of target KF5BalooCodecs[  3%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/doctermscodec.cpp.o[  3%] Built target baloosearchmodule_autogenScanning dependencies of target KF5Baloo_QCHmake[2]: *** No rule to make target '../docs/faq.md', needed by 'src/lib/KF5Baloo.qch'.  Stop.make[1]: *** [CMakeFiles/Makefile2:845: src/lib/CMakeFiles/KF5Baloo_QCH.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[  3%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/positioncodec.cpp.o[  3%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/postingcodec.cpp.o[  4%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/coding.cpp.o[  4%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/KF5BalooCodecs_autogen/mocs_compilation.cpp.o[  4%] Linking CXX static library ../../lib/libKF5BalooCodecs.a[  4%] Built target KF5BalooCodecsmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 51 - Failure!

2018-11-03 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/51/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Sat, 03 Nov 2018 14:55:11 +
 Build duration:
28 sec and counting
   CONSOLE OUTPUT
  [...truncated 92.21 KB...]-- The following OPTIONAL packages have been found: * Inotify, inotify API on the *BSD family of operating systems.,Filesystem alteration notifications using inotify-- The following REQUIRED packages have been found: * ECM (required version >= 5.52.0), Extra CMake Modules,  * Qt5DBus * Qt5Gui (required version >= 5.11.1) * Qt5Widgets * Qt5Network (required version >= 5.11.1) * Qt5Qml * Qt5Quick * Qt5Test * Qt5 (required version >= 5.8.0) * KF5CoreAddons (required version >= 5.52.0) * KF5Config (required version >= 5.52.0) * KF5DBusAddons (required version >= 5.52.0) * Gettext * KF5I18n (required version >= 5.52.0) * KF5IdleTime (required version >= 5.52.0) * KF5Solid (required version >= 5.52.0) * KF5FileMetaData (required version >= 5.52.0) * KF5Crash (required version >= 5.52.0) * KF5KIO (required version >= 5.52.0) * KF5 (required version >= 5.52.0) * LMDB, Lightning Memory-Mapped Database (LMDB),  * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Core-- The following features have been disabled: * EXP, Build experimental features-- Configuring done-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 FreeBSDQt5.11] Running shell script+ python3.5 -u ci-tooling/helpers/compile-build.py --product Frameworks --project baloo --branchGroup kf5-qt5 --platform FreeBSDQt5.11 --usingInstall /home/jenkins/install-prefix/Scanning dependencies of target KF5FileMetaData_QCHScanning dependencies of target KF5BalooCodecs_autogenScanning dependencies of target BalooDBusInterfacesScanning dependencies of target advancedqueryparsertest_autogenScanning dependencies of target Qt5Core_QCHScanning dependencies of target KF5CoreAddons_QCHScanning dependencies of target extractorIOTest_autogenScanning dependencies of target baloosearchmodule_autogen[  0%] Built target KF5CoreAddons_QCH[  0%] Built target KF5FileMetaData_QCH[  0%] Generating org.kde.baloo.main.xml[  1%] Automatic MOC for target extractorIOTest[  1%] Automatic MOC for target KF5BalooCodecs[  2%] Generating org.kde.baloo.scheduler.xml[  2%] Automatic MOC for target advancedqueryparsertest[  2%] Built target Qt5Core_QCH[  3%] Generating baloosearchmodule.json[  3%] Generating org.kde.baloo.fileindexer.xmlScanning dependencies of target KF5Baloo_QCHgmake[2]: *** No rule to make target '../docs/faq.md', needed by 'src/lib/KF5Baloo.qch'.  Stop.gmake[1]: *** [CMakeFiles/Makefile2:890: src/lib/CMakeFiles/KF5Baloo_QCH.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobsAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/kdedmodule.desktop"Found property definition "X-KDE-FactoryName" with type "QString"Found property definition "X-KDE-Kded-autoload" with type "bool"Found property definition "X-KDE-Kded-load-on-demand" with type "bool"Found property definition "X-KDE-Kded-phase" with type "int"Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"Generated  "/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/build/src/kioslaves/kded/baloosearchmodule.json" [  3%] Generating fileindexerinterface.cpp, fileindexerinterface.h[  3%] Generating maininterface.cpp, maininterface.h[  3%] Automatic MOC for target baloosearchmodule[  3%] Generating schedulerinterface.cpp, schedulerinterface.h[  3%] Generating maininterface.moc[  3%] Generating fileindexerinterface.moc[  3%] Built target KF5BalooCodecs_autogen[  4%] Generating schedulerinterface.moc[  4%] Built target BalooDBusInterfaces[  4%] Built target extractorIOTest_autogen[  4%] Built target baloosearchmodule_autogen[  4%] Built target advancedqueryparsertest_autogengmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 168 - Failure!

2018-11-03 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/168/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 14:55:11 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 115.30 KB...] * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have been found: * Inotify   Filesystem alteration notifications using inotify-- The following REQUIRED packages have been found: * ECM (required version >= 5.52.0), Extra CMake Modules,  * Qt5DBus * Qt5Gui (required version >= 5.10.1) * Qt5Widgets * Qt5Network (required version >= 5.10.1) * Qt5Qml * Qt5Quick * Qt5Test * Qt5 (required version >= 5.8.0) * KF5CoreAddons (required version >= 5.52.0) * KF5Config (required version >= 5.52.0) * KF5DBusAddons (required version >= 5.52.0) * Gettext * KF5I18n (required version >= 5.52.0) * KF5IdleTime (required version >= 5.52.0) * KF5Solid (required version >= 5.52.0) * KF5FileMetaData (required version >= 5.52.0) * KF5Crash (required version >= 5.52.0) * KF5KIO (required version >= 5.52.0) * KF5 (required version >= 5.52.0) * LMDB, Lightning Memory-Mapped Database (LMDB),  * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Core-- The following features have been disabled: * EXP, Build experimental features-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project baloo --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target BalooDBusInterfacesScanning dependencies of target KF5BalooCodecs_autogenScanning dependencies of target KF5FileMetaData_QCHScanning dependencies of target extractorIOTest_autogenScanning dependencies of target KF5CoreAddons_QCHScanning dependencies of target baloosearchmodule_autogenScanning dependencies of target advancedqueryparsertest_autogen[  0%] Automatic MOC for target KF5BalooCodecs[  0%] Built target KF5FileMetaData_QCH[  0%] Generating org.kde.baloo.main.xml[  1%] Automatic MOC for target advancedqueryparsertest[  2%] Generating org.kde.baloo.scheduler.xml[  2%] Generating org.kde.baloo.fileindexer.xml[  2%] Automatic MOC for target extractorIOTest[  2%] Built target KF5CoreAddons_QCH[  2%] Generating baloosearchmodule.json[  2%] Generating fileindexerinterface.cpp, fileindexerinterface.hAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/kdedmodule.desktop"Found property definition "X-KDE-FactoryName" with type "QString"Found property definition "X-KDE-Kded-autoload" with type "bool"Found property definition "X-KDE-Kded-load-on-demand" with type "bool"Found property definition "X-KDE-Kded-phase" with type "int"Found property definition "X-KDE-OnlyShowOnQtPlatforms" with type "QStringList"Generated  "/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/build/src/kioslaves/kded/baloosearchmodule.json" [  2%] Generating maininterface.cpp, maininterface.h[  2%] Generating schedulerinterface.cpp, schedulerinterface.hScanning dependencies of target KF5Baloo_QCHmake[2]: *** No rule to make target '../docs/faq.md', needed by 'src/lib/KF5Baloo.qch'.  Stop.make[1]: *** [CMakeFiles/Makefile2:845: src/lib/CMakeFiles/KF5Baloo_QCH.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[  2%] Automatic MOC for target baloosearchmodule[  2%] Built target KF5BalooCodecs_autogen[  2%] Generating fileindexerinterface.moc[  2%] Generating maininterface.moc[  3%] Generating schedulerinterface.moc[  3%] Built target BalooDBusInterfaces[  3%] Built target advancedqueryparsertest_autogen[  3%] Built target extractorIOTest_autogen[  3%] Built target baloosearchmodule_autogenmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D12045: Clean up existing documentation

2018-11-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:580d2feff619: Clean up existing documentation (authored 
by michaelh, committed by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12045?vs=31739=44774

REVISION DETAIL
  https://phabricator.kde.org/D12045

AFFECTED FILES
  MAINTAINER
  README.md
  docs/development/coding-style.md
  docs/distributing.md
  docs/faq.md
  docs/updatedb.md
  metainfo.yaml

To: bruns, #baloo, ngraham, michaelh
Cc: kde-frameworks-devel, ngraham, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams


D12045: Clean up existing documentation

2018-11-03 Thread Stefan Brüns
bruns commandeered this revision.
bruns added a reviewer: michaelh.

REPOSITORY
  R293 Baloo

BRANCH
  doc-cleanup

REVISION DETAIL
  https://phabricator.kde.org/D12045

To: bruns, #baloo, ngraham, michaelh
Cc: kde-frameworks-devel, ngraham, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams


D16594: Add context to kcmodule connection to lambdas

2018-11-03 Thread Stefan Brüns
bruns accepted this revision.
bruns added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcmoduleqml.cpp:74
> Technically yes, but there's no sane scope for a code path where configModule 
> is emitting anything between deleting d and this.

Thanks for the confirmation, hope nobody finds an insane one ;-)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16594

To: davidedmundson, #plasma, broulik, bruns
Cc: bruns, kde-frameworks-devel, michaelh, ngraham


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 108 - Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/108/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 14:34:11 +
 Build duration:
1 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2907/3607)48%
(4386/9218)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(999/1267)45%
(478/1073)src.extractors100%
(12/12)100%
(12/12)74%
(1092/1476)47%
(2149/4534)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 89 - Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/89/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 14:34:11 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2908/3607)48%
(4371/9182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(1000/1267)45%
(479/1073)src.extractors100%
(12/12)100%
(12/12)74%
(1092/1476)47%
(2133/4498)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
bruns marked 2 inline comments as done.
Closed by commit R286:497a69ca846b: [ExtractorCollection] Use only best 
matching extractor plugin (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16593?vs=44658=44772

REVISION DETAIL
  https://phabricator.kde.org/D16593

AFFECTED FILES
  autotests/extractorcollectiontest.cpp
  src/extractorcollection.cpp
  src/extractorcollection.h

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16592: [ExtractorCollection] Add unit-test to verify only specific extractor is used

2018-11-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:7e484b968fd9: [ExtractorCollection] Add unit-test to 
verify only specific extractor is used (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16592?vs=44657=44771

REVISION DETAIL
  https://phabricator.kde.org/D16592

AFFECTED FILES
  autotests/extractorcollectiontest.cpp

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 68 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/68/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 14:00:26 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8429)43%
(10151/23419)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5802/11905)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 124 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/124/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 14:00:25 +
 Build duration:
8 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6331/8429)43%
(10151/23423)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D16633: Add root version of drive-harddisk

2018-11-03 Thread Nathaniel Graham
ngraham added a comment.


  Thank you! Two comments:
  
  - I'm not sure using the negative color is appropriate here. That color is 
used for dangerous operations or error conditions, neither of which apply to 
the OS volume. It's true that you could potentially blow yourself up by messing 
with it, but I don't really think that fits. The current red icon for root was 
never appropriate in the first place IMHO. Either Icon Blue or just the regular 
Icon Grey color seem more appropriate to me.
  - Could we experiment with using the Plasma logo instead of a slash? The idea 
of using a slash to represent the root disk will be immediately apparent to 
technical users, but will be lost on everyone else. The Plasma logo might be 
more easily comprehensible for everyone.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 176 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/176/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 12:03:27 +
 Build duration:
1 hr 20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5178/13179)29%
(2736/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1698/3504)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(424/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
 

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 70 - Still Failing!

2018-11-03 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/70/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 12:02:51 +
 Build duration:
1 hr 9 min and counting
   CONSOLE OUTPUT
  [...truncated 554.50 KB...][ 87%] Building CXX object autotests/client/CMakeFiles/testXdgShellStable.dir/testXdgShellStable_autogen/mocs_compilation.cpp.o[ 87%] Linking CXX executable ../../bin/testXdgShellStable[ 87%] Built target testXdgShellStableScanning dependencies of target testNoXdgRuntimeDir[ 87%] Building CXX object autotests/server/CMakeFiles/testNoXdgRuntimeDir.dir/test_no_xdg_runtime_dir.cpp.o[ 87%] Building CXX object autotests/server/CMakeFiles/testNoXdgRuntimeDir.dir/testNoXdgRuntimeDir_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX executable ../../bin/testNoXdgRuntimeDir[ 88%] Built target testNoXdgRuntimeDirScanning dependencies of target testWaylandServerDisplay[ 88%] Building CXX object autotests/server/CMakeFiles/testWaylandServerDisplay.dir/test_display.cpp.o[ 88%] Building CXX object autotests/server/CMakeFiles/testWaylandServerDisplay.dir/testWaylandServerDisplay_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX executable ../../bin/testWaylandServerDisplay[ 88%] Built target testWaylandServerDisplayScanning dependencies of target testQtSurfaceExtension[ 88%] Building CXX object autotests/server/CMakeFiles/testQtSurfaceExtension.dir/test_qt_surface_extension.cpp.o[ 88%] Building CXX object autotests/server/CMakeFiles/testQtSurfaceExtension.dir/testQtSurfaceExtension_autogen/mocs_compilation.cpp.o[ 88%] Linking CXX executable ../../bin/testQtSurfaceExtension[ 88%] Built target testQtSurfaceExtensionScanning dependencies of target testServer[ 88%] Building CXX object tests/CMakeFiles/testServer.dir/waylandservertest.cpp.o[ 89%] Building CXX object tests/CMakeFiles/testServer.dir/testServer_autogen/mocs_compilation.cpp.o[ 89%] Linking CXX executable ../bin/testServer[ 89%] Built target testServerScanning dependencies of target testWaylandServerSeatScanning dependencies of target testRenderingServerScanning dependencies of target testFilter[ 90%] Building CXX object tests/CMakeFiles/testRenderingServer.dir/renderingservertest.cpp.o[ 90%] Building CXX object autotests/server/CMakeFiles/testWaylandServerSeat.dir/test_seat.cpp.o[ 90%] Building CXX object autotests/client/CMakeFiles/testFilter.dir/test_wayland_filter.cpp.oScanning dependencies of target org-kde-kf5-kwayland-testserverScanning dependencies of target testPointerConstraints[ 91%] Building CXX object src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/main.cpp.o[ 91%] Building CXX object autotests/client/CMakeFiles/testPointerConstraints.dir/test_pointer_constraints.cpp.o[ 91%] Building CXX object src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/testserver.cpp.oScanning dependencies of target testXdgShellV5[ 91%] Building CXX object tests/CMakeFiles/testRenderingServer.dir/testRenderingServer_autogen/mocs_compilation.cpp.oScanning dependencies of target testXdgShellV6Scanning dependencies of target testWaylandOutputManagement[ 91%] Building CXX object autotests/client/CMakeFiles/testXdgShellV5.dir/test_xdg_shell.cpp.o[ 92%] Building CXX object autotests/client/CMakeFiles/testXdgShellV6.dir/test_xdg_shell.cpp.oScanning dependencies of target testFakeInput[ 92%] Building CXX object autotests/server/CMakeFiles/testWaylandServerSeat.dir/testWaylandServerSeat_autogen/mocs_compilation.cpp.o[ 93%] Building CXX object autotests/client/CMakeFiles/testWaylandOutputManagement.dir/test_wayland_outputmanagement.cpp.o[ 93%] Linking CXX executable ../bin/testRenderingServer[ 93%] Building CXX object autotests/client/CMakeFiles/testFakeInput.dir/test_fake_input.cpp.o[ 93%] Linking CXX executable ../../bin/testWaylandServerSeat[ 93%] Building CXX object autotests/client/CMakeFiles/testFilter.dir/testFilter_autogen/mocs_compilation.cpp.o[ 93%] Linking CXX executable ../../bin/testFilter[ 93%] Built target testWaylandServerSeat[ 93%] Built target testRenderingServerScanning dependencies of target testPlasmaVirtualDesktopScanning dependencies of target testRemoteAccess[ 93%] Building CXX object autotests/client/CMakeFiles/testPlasmaVirtualDesktop.dir/test_plasma_virtual_desktop.cpp.o[ 93%] Building CXX object autotests/client/CMakeFiles/testRemoteAccess.dir/test_remote_access.cpp.o[ 93%] Built target testFilterScanning dependencies of target testServerSideDecorationPalette[ 94%] Building CXX object autotests/client/CMakeFiles/testServerSideDecorationPalette.dir/test_server_side_decoration_palette.cpp.o[ 94%] Building CXX object src/tools/testserver/CMakeFiles/org-kde-kf5-kwayland-testserver.dir/org-kde-kf5-kwayland-testserver_autogen/mocs_compilation.cpp.o[ 94%] Linking CXX executable ../../../bin/org-kde-kf5-kwayland-testserver[ 94%] Building CXX object 

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 37 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/37/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 12:03:01 +
 Build duration:
1 hr 9 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7099/9494)55%
(3475/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(773/1377)45%
(294/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/62/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 12:02:01 +
 Build duration:
1 hr 4 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1154/2122)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 298 - Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/298/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 12:01:15 +
 Build duration:
1 hr 4 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 60 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(261/397)66%
(261/397)53%
(32008/59958)38%
(16492/43894)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(56/56)100%
(56/56)95%
(9078/9517)48%
(4275/8942)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8323/14294)50%
(4649/9243)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3907/7923)34%
(1596/4691)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(525/1023)37%
(315/850)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1774/4316)35%
(1305/3684)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
   

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 25 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/25/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 12:01:06 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-xcf
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)82%
(14/17)82%
(14/17)45%
(1613/3581)36%
(715/1999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)72%
(272/378)53%
(76/144)src.imageformats91%
(10/11)91%
(10/11)44%
(1337/3069)35%
(637/1797)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 46 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/46/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 12:00:00 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45961)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 67 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/67/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 11:59:41 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8428)43%
(10153/23417)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2776)49%
(5804/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 66 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/66/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 03 Nov 2018 11:58:44 +
 Build duration:
47 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/96/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 12:02:51 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24807/29127)52%
(9846/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11686/12057)49%
(6201/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5735/6934)64%
(1507/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6952/8190)64%
(1969/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/49/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 12:03:01 +
 Build duration:
34 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7102/9494)55%
(3477/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(775/1377)45%
(295/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4657)60%
(1917/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 250 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/250/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 12:03:27 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13119)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/84/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 12:02:01 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1154/2122)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/72/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 12:00:00 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45959)38%
(13051/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/31/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 12:01:06 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1484/3579)32%
(647/1999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)75%
(282/378)53%
(77/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1198/3067)32%
(568/1797)tests33%
(1/3)33%
(1/3)3%
(4/134)3%
(2/58)

D16434: Fix keyboard layout change notifications

2018-11-03 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:4d28bd4183d2: Fix keyboard layout change notifications 
(authored by fvogt).

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16434?vs=44765=44766

REVISION DETAIL
  https://phabricator.kde.org/D16434

AFFECTED FILES
  CMakeLists.txt
  src/runtime/plugins/CMakeLists.txt
  src/runtime/plugins/xcb/CMakeLists.txt
  src/runtime/plugins/xcb/kglobalaccel_x11.cpp
  src/runtime/plugins/xcb/kglobalaccel_x11.h

To: fvogt, #frameworks, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns


KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/62/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 12:00:20 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 123 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/123/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 11:59:40 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6332/8428)43%
(10160/23421)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2702/2776)49%
(5810/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D16434: Fix keyboard layout change notifications

2018-11-03 Thread Fabian Vogt
fvogt updated this revision to Diff 44765.
fvogt marked 2 inline comments as done.
fvogt added a comment.


  This file needs to be reformatted anyway.

REPOSITORY
  R268 KGlobalAccel

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16434?vs=44715=44765

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16434

AFFECTED FILES
  CMakeLists.txt
  src/runtime/plugins/CMakeLists.txt
  src/runtime/plugins/xcb/CMakeLists.txt
  src/runtime/plugins/xcb/kglobalaccel_x11.cpp
  src/runtime/plugins/xcb/kglobalaccel_x11.h

To: fvogt, #frameworks, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns


KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 122 - Still Unstable!

2018-11-03 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/122/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 03 Nov 2018 11:58:43 +
 Build duration:
5 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16434: Fix keyboard layout change notifications

2018-11-03 Thread Roman Gilg
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Pls do the coding style improvements and push.

INLINE COMMENTS

> kglobalaccel_x11.cpp:75
> + const xcb_query_extension_reply_t *reply = 
> xcb_get_extension_data(QX11Info::connection(), _xkb_id);
> + if (reply && reply->present)
> + m_xkb_first_event = reply->first_event;

https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces

> kglobalaccel_x11.cpp:207
>  const uint8_t responseType = event->response_type & ~0x80;
> -switch (responseType) {
> -case XCB_MAPPING_NOTIFY:
> -qCDebug(KGLOBALACCELD) << "Got XMappingNotify event";
> -xcb_refresh_keyboard_mapping(m_keySymbols, 
> reinterpret_cast(event));
> -x11MappingNotify();
> -return true;
> -
> -case XCB_KEY_PRESS:
> +if(responseType == XCB_MAPPING_NOTIFY) {
> +x11MappingNotify();

https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces space after 
`if`

> kglobalaccel_x11.cpp:213
> +}
> +else if(responseType == XCB_KEY_PRESS) {
>  #ifdef KDEDGLOBALACCEL_TRACE

https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces space and on 
same line as closing brace

REPOSITORY
  R268 KGlobalAccel

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16434

To: fvogt, #frameworks, #plasma, romangg
Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns


D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16633: Add root version of drive-harddisk

2018-11-03 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  BUG: 399307
  I did not add `drive-harddisk-home` in this commit because it was simply too 
difficult to make an easily readable symbol for home on the 16px version.

REPOSITORY
  R266 Breeze Icons

BRANCH
  drive-harddisk-root_and_home (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16633

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-03 Thread Laurent Montel
mlaurent added inline comments.

INLINE COMMENTS

> emateli wrote in batchrenamedialog.h:69
> You mean to initialize them to nullptr on the header file or using a 
> constructor initialization list? Also see what problem?

in header file.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns