D16677: Add BrightScript syntax

2018-11-04 Thread Daniel Levin
dlevin updated this revision to Diff 44885.
dlevin added a comment.


  Changed syntax license to MIT.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16677?vs=44881=44885

REVISION DETAIL
  https://phabricator.kde.org/D16677

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/input/brightscript.brs.syntax
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, #framework_syntax_highlighting
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16677: Add BrightScript syntax

2018-11-04 Thread Christoph Cullmann
cullmann added a comment.


  Hi, thanks for the contribution.
  Could you use the MIT license for the files?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-04 Thread Ben Cooksley
bcooksley added a comment.


  As noted in the build log on the CI system, kfilemetadata doesn't depend on 
kcoreaddons so you therefore cannot rely on the kde5.xml file being available:
  
[kf5-qt5 SUSEQt5.9] Running shell script
+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product 
Frameworks --project kfilemetadata --branchGroup kf5-qt5 --environment 
production --platform SUSEQt5.9 --installTo /home/jenkins//install-prefix/
Retrieving: Frameworks-extra-cmake-modules-kf5-qt5
Retrieving: Frameworks-ki18n-kf5-qt5
Retrieving: Frameworks-karchive-kf5-qt5
  
  The CI system is working correctly in this case and as designed, only 
allowing actual dependencies of a project to be used during it's build and 
testing.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: bcooksley, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


Re: [sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

2018-11-04 Thread Ben Cooksley
On Mon, Nov 5, 2018 at 2:01 PM Aleix Pol  wrote:
>
> On Sun, Nov 4, 2018 at 2:52 AM Ben Cooksley  wrote:
> >
> > On Sun, 4 Nov 2018, 14:18 Aleix Pol  >>
> >> I'm confused, this adds rsync and comments rsync out.
> >
> >
> > I had to comment rsync out because we can't rebuild the image at the moment.
> >
> > I added it to the image for later on, when we can rebuild the image again.
> >
> > Once we can, then that part of this commit can be reverted.
> >
> >
> >> On Sat, Nov 3, 2018 at 4:48 AM Ben Cooksley  wrote:
> >> >
> >> > Git commit a01c4d1ba8fd31f1112c207b61542b14aab3e9e8 by Ben Cooksley.
> >> > Committed on 03/11/2018 at 03:48.
> >> > Pushed by bcooksley into branch 'master'.
> >> >
> >> > Disable parts of the System Dependency building on Android CI until 
> >> > rsync can be made available.
> >> > The Docker image for Android CI currently can't be built due to missing 
> >> > tags/branches in the Qt Git repositories which were previously present.
> >> > See 
> >> > https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.11%20SDK/
> >> >  for more information.
> >> >
> >> > CCMAIL: kde-frameworks-devel@kde.org
> >> > CCMAIL: aleix...@kde.org
> >> >
> >> > M  +1-1pipeline-templates/AndroidQt5.11.template
> >> > M  +1-0system-images/android/sdk/Dockerfile
> >> >
> >> > https://commits.kde.org/sysadmin/ci-tooling/a01c4d1ba8fd31f1112c207b61542b14aab3e9e8
> >> >
> >> > diff --git a/pipeline-templates/AndroidQt5.11.template 
> >> > b/pipeline-templates/AndroidQt5.11.template
> >> > index 17d21da..1c5f1b1 100644
> >> > --- a/pipeline-templates/AndroidQt5.11.template
> >> > +++ b/pipeline-templates/AndroidQt5.11.template
> >> > @@ -68,7 +68,7 @@ timestamps {
> >> >
> >> > \$systemDependencies
> >> >
> >> > -   rsync -Ha 
> >> > '\$DESTDIR/\$APP_INSTALL_PREFIX/' '\$APP_INSTALL_PREFIX/'
> >> > +   #rsync -Ha 
> >> > '\$DESTDIR/\$APP_INSTALL_PREFIX/' '\$APP_INSTALL_PREFIX/'
> >> > """
> >> > }
> >> >
> >> > diff --git a/system-images/android/sdk/Dockerfile 
> >> > b/system-images/android/sdk/Dockerfile
> >> > index 14deab2..14034ea 100644
> >> > --- a/system-images/android/sdk/Dockerfile
> >> > +++ b/system-images/android/sdk/Dockerfile
> >> > @@ -13,6 +13,7 @@ RUN apt-get -qq update && apt-get install -qq \
> >> >  build-essential \
> >> >  gperf gettext \
> >> >  python3 python3-paramiko python3-lxml python3-yaml \
> >> > +rsync \
> >> >  bison flex \
> >> >  ruby wget \
> >> >  libxml2-utils \
>
> Build is fixed now, sorry for the trouble.

No worries - thanks for sorting this out.

I've now restored the rsync command execution.

>
> Aleix

Cheers,
Ben


D16678: Fix root disk icon change so that it doesn't erroneously change other icons

2018-11-04 Thread Kai Uwe Broulik
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  fix-root-icon-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16678

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16678: Fix root disk icon change so that it doesn't erroneously change other icons

2018-11-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 44884.
ngraham added a comment.


  Use `isStorageAccess()` rather than `isStorageVolume()`

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16678?vs=44883=44884

BRANCH
  fix-root-icon-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16678

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16678: Fix root disk icon change so that it doesn't erroneously change other icons

2018-11-04 Thread Nathaniel Graham
ngraham marked 2 inline comments as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16678

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16678: Fix root disk icon change so that it doesn't erroneously change other icons

2018-11-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 44883.
ngraham added a comment.


  Address review comments

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16678?vs=44882=44883

BRANCH
  fix-root-icon-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16678

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16678: Fix root disk icon change so that it doesn't erroneously change other icons

2018-11-04 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> udisksdevice.cpp:874
> +{
> +if (queryDeviceInterface(Solid::DeviceInterface::StorageAccess)) {
> +const UDisks2::StorageAccess accessIface(const_cast(this));

Can you check whether using `isStorageAccess()` is more desirable/performant?

> udisksdevice.h:84
>  bool isEncryptedCleartext() const;
> +bool isRoot() const; // @since 5.53
>  bool isSwap() const;

This isn't public API, you don't need this comment, also perhaps `isRootVolume`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16678

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-04 Thread Nathaniel Graham
ngraham added a comment.


  Hopefully this should fix it: D16678 

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D16678: Fix root disk icon change so that it doesn't erroneously change other icons

2018-11-04 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16678

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16678: Fix root disk icon change so that it doesn't erroneously change other icons

2018-11-04 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: bruns, broulik, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  I committed D16653  too soon without 
enough testing, because it had the effect of applying the default 
`drive-harddisk` icon to more device types. Oops. Sorry about that. :(
  
  This patch fixes the problem, and is better tested.

TEST PLAN
  Other device types are not affected:
  [image goes here]

REPOSITORY
  R245 Solid

BRANCH
  fix-root-icon-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16678

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-04 Thread Nathaniel Graham
ngraham added a comment.


  This broke icons for other things; currently investigating and will fix ASAP.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D16677: Add BrightScript syntax

2018-11-04 Thread Daniel Levin
dlevin created this revision.
dlevin added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  Accurate implementation of BrightScript language, mostly used by Roku
  channel developers and documented at Roku SDK portal:
  
  https://sdkdocs.roku.com/display/sdkdoc/Roku+SDK+Documentation
  
  Highlight sytax covers:
  
  - function and sub definitions, both global and inline
  - comments: ' and REM
  - macros
  - print statement
  - library imports
  - literal type narrowing with: $, %, !, #, &
  - conditionals and loops with: if, for and while
  - built-in and library functions
  - standard Roku Scene Graph keywords: m, top, global
  - array, function calls
  - goto and label statements
  - built-in types used in function/sub arguments and return
  - constants: true, false, invalid
  - distinct assignment and unary/binary ops, e.g.: if a = b c = d ' first = is 
a comparison, second = is an assignment
  - invalid syntax detection in some cases
  
  No folding is supported at this point.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/input/brightscript.brs.syntax
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann


D16643: Correct the accept flag of the event object on DragMove

2018-11-04 Thread trmdi
trmdi added a comment.


  In D16643#354120 , @bruns wrote:
  
  > `m_enabled` may change between //consecutive// DragMove events, but not 
during an event.
  >
  > In this case, though, it does not, and is constantly true. You can verify 
this by attaching a debugger or by adding debug statements.
  >
  > The only wrong code part is the `setAccepted(false)`, which should be 
`setAccepted(true)` (or just `accept()`, both are equivalent).
  
  
  Please see these videos, note the cursor icon:
  
  - If I place `setAccept(true)` below the first if like you said: 
https://streamable.com/oj1j4 -> the cursor does not change
  - If I place it above the first if like I've done in my patch: 
https://streamable.com/2g58g -> the cursor changes

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16633: Add root version of drive-harddisk

2018-11-04 Thread Andrew Crouthamel
acrouthamel added a comment.


  > I did not add drive-harddisk-home in this commit because it was simply too 
difficult to make an easily readable symbol for home on the 16px version.
  
  What about
  
~
  
  or
  
$
  
  ?
  
  Tilde would probably be the best, and you could exaggerate the waviness for 
the 16px version to make it legible.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg, ngraham
Cc: acrouthamel, ngraham, kde-frameworks-devel, michaelh, bruns


D16676: [server] Put (de-)activate, en-/disable callbacks in child classes

2018-11-04 Thread Roman Gilg
romangg added a dependency: D16675: [server] Put set surrounding text callback 
with uint in v0 class.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16676

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16675: [server] Put set surrounding text callback with uint in v0 class

2018-11-04 Thread Roman Gilg
romangg added a dependent revision: D16676: [server] Put (de-)activate, 
en-/disable callbacks in child classes.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16675

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16676: [server] Put (de-)activate, en-/disable callbacks in child classes

2018-11-04 Thread Roman Gilg
romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The activate/deactivate and enable/disable callback functionality was in the
  TextInputInterface::Private interface, but these calls are each specific to v0
  and v2 of the protocol.
  
  Since v3 will have again a different function signature, put all the callbacks
  and their helper functions in the protocol version specific child classes.

TEST PLAN
  Compiles, runs.

REPOSITORY
  R127 KWayland

BRANCH
  textInputActivateEnable

REVISION DETAIL
  https://phabricator.kde.org/D16676

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


Re: [sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

2018-11-04 Thread Aleix Pol
On Sun, Nov 4, 2018 at 2:52 AM Ben Cooksley  wrote:
>
> On Sun, 4 Nov 2018, 14:18 Aleix Pol >
>> I'm confused, this adds rsync and comments rsync out.
>
>
> I had to comment rsync out because we can't rebuild the image at the moment.
>
> I added it to the image for later on, when we can rebuild the image again.
>
> Once we can, then that part of this commit can be reverted.
>
>
>> On Sat, Nov 3, 2018 at 4:48 AM Ben Cooksley  wrote:
>> >
>> > Git commit a01c4d1ba8fd31f1112c207b61542b14aab3e9e8 by Ben Cooksley.
>> > Committed on 03/11/2018 at 03:48.
>> > Pushed by bcooksley into branch 'master'.
>> >
>> > Disable parts of the System Dependency building on Android CI until rsync 
>> > can be made available.
>> > The Docker image for Android CI currently can't be built due to missing 
>> > tags/branches in the Qt Git repositories which were previously present.
>> > See 
>> > https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.11%20SDK/
>> >  for more information.
>> >
>> > CCMAIL: kde-frameworks-devel@kde.org
>> > CCMAIL: aleix...@kde.org
>> >
>> > M  +1-1pipeline-templates/AndroidQt5.11.template
>> > M  +1-0system-images/android/sdk/Dockerfile
>> >
>> > https://commits.kde.org/sysadmin/ci-tooling/a01c4d1ba8fd31f1112c207b61542b14aab3e9e8
>> >
>> > diff --git a/pipeline-templates/AndroidQt5.11.template 
>> > b/pipeline-templates/AndroidQt5.11.template
>> > index 17d21da..1c5f1b1 100644
>> > --- a/pipeline-templates/AndroidQt5.11.template
>> > +++ b/pipeline-templates/AndroidQt5.11.template
>> > @@ -68,7 +68,7 @@ timestamps {
>> >
>> > \$systemDependencies
>> >
>> > -   rsync -Ha 
>> > '\$DESTDIR/\$APP_INSTALL_PREFIX/' '\$APP_INSTALL_PREFIX/'
>> > +   #rsync -Ha 
>> > '\$DESTDIR/\$APP_INSTALL_PREFIX/' '\$APP_INSTALL_PREFIX/'
>> > """
>> > }
>> >
>> > diff --git a/system-images/android/sdk/Dockerfile 
>> > b/system-images/android/sdk/Dockerfile
>> > index 14deab2..14034ea 100644
>> > --- a/system-images/android/sdk/Dockerfile
>> > +++ b/system-images/android/sdk/Dockerfile
>> > @@ -13,6 +13,7 @@ RUN apt-get -qq update && apt-get install -qq \
>> >  build-essential \
>> >  gperf gettext \
>> >  python3 python3-paramiko python3-lxml python3-yaml \
>> > +rsync \
>> >  bison flex \
>> >  ruby wget \
>> >  libxml2-utils \

Build is fixed now, sorry for the trouble.

Aleix


D16665: Add programmaticaly useful error signalling

2018-11-04 Thread Aleix Pol Gonzalez
apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> engine.h:430
> + */
> +void signalErrorCode(const KNSCore::ErrorCode , const QVariant 
> );
>  

I would include the error message here and deprecate `signalError`. Otherwise 
it's going to be a mess matching both signals.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns


D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-04 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16674

To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D15999: Add icons with added background to system.svgz

2018-11-04 Thread Nathaniel Graham
ngraham added a comment.


  Hmm, I just deployed with the latest change and suddenly the icons are weird:
  
  F6391195: Weird icons.jpeg 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D16672: Add support for speex files to taglibextractor

2018-11-04 Thread Stefan Brüns
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  speex

REVISION DETAIL
  https://phabricator.kde.org/D16672

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:b34d13cb1861: Use the new `drive-harddisk-root` icon for 
the root volume (authored by ngraham).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16653?vs=44871=44875

REVISION DETAIL
  https://phabricator.kde.org/D16653

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-04 Thread Andres Betts
abetts accepted this revision.
abetts added a comment.


  Minor detail with great impact. Thank you for the work.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D16653

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D16675: [server] Put set surrounding text callback with uint in v0 class

2018-11-04 Thread Roman Gilg
romangg added a comment.


  Could the renaming be problematic in regards to binary compatibility? All are 
private interfaces though.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16675

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16675: [server] Put set surrounding text callback with uint in v0 class

2018-11-04 Thread Roman Gilg
romangg retitled this revision from "[server] Set surrounding text callback 
with uint in v0 class" to "[server] Put set surrounding text callback with uint 
in v0 class".

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16675

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16675: [server] Set surrounding text callback with uint in v0 class

2018-11-04 Thread Roman Gilg
romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The set surrounding text request is only in v0 of text-input with uint 
arguments,
  in v2 and v3 the call has the same signature.
  
  To increase readability put the uint version in the v0 class implementation
  and rename callbacks.

TEST PLAN
  Compiles

REPOSITORY
  R127 KWayland

BRANCH
  textInputSurroundingTextCallback

REVISION DETAIL
  https://phabricator.kde.org/D16675

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp
  src/server/textinput_interface_v2.cpp

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 73 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/73/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 22:29:31 +
 Build duration:
5 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24801/29127)52%
(9850/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11685/12057)49%
(6209/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5733/6934)64%
(1506/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6949/8190)64%
(1966/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/99/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 22:29:31 +
 Build duration:
5 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24818/29127)52%
(9858/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11700/12057)49%
(6215/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5733/6934)64%
(1506/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6951/8190)64%
(1968/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-04 Thread David Faure
dfaure created this revision.
dfaure added reviewers: akrutzler, elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald edited subscribers, added: kfm-devel, kde-frameworks-devel; removed: 
Dolphin.
dfaure requested review of this revision.

REVISION SUMMARY
  KIO says the following:
  listDir() did not call finished() or error()! Please fix the "kio_mtp" KIO 
slave
  
  and message boxes are annoying anyway, better use the error mechanism
  for actual errors.

TEST PLAN
  Not fully tested I admit, but seems obvious :-)

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16674

AFFECTED FILES
  mtp/kio_mtp.cpp

To: dfaure, akrutzler, elvisangelaccio
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov


D12114: Revive 'Description' property for DublinCore metadata

2018-11-04 Thread Stefan Brüns
bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> office2007extractortest.cpp:52
>  QCOMPARE(result.properties().value(Property::Language), 
> QVariant(QStringLiteral("en-US")));
> +QCOMPARE(result.properties().value(Property::PageCount), QVariant(1));
> +QCOMPARE(result.properties().value(Property::WordCount), QVariant(4));

Strictly speaking, this should be part of another commit.
Feel free to split it off and git push without review.

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams


KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 38 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/38/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 22:20:56 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7094/9494)55%
(3466/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3137)51%
(1260/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(773/1377)45%
(294/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3310/4657)59%
(1909/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 72 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/72/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 22:20:46 +
 Build duration:
8 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24795/29126)52%
(9845/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11679/12056)49%
(6205/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5733/6934)64%
(1505/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6949/8190)64%
(1966/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16673: [server] Put some text-input v0 exclusive callbacks in v0 class

2018-11-04 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:be0ad76729b6: [server] Put some text-input v0 exclusive 
callbacks in v0 class (authored by romangg).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16673?vs=44870=44872

REVISION DETAIL
  https://phabricator.kde.org/D16673

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp

To: romangg, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-04 Thread Stefan Brüns
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D16653

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 44871.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Fix embarrassing errors

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16653?vs=44808=44871

BRANCH
  arcpatch-D16653

REVISION DETAIL
  https://phabricator.kde.org/D16653

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/50/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 22:20:56 +
 Build duration:
4 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7101/9494)55%
(3475/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(774/1377)45%
(293/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4657)60%
(1917/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

D16653: Use the new `drive-harddisk-root` icon for the root volume

2018-11-04 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> udisksdevice.cpp:619
> +const UDisks2::StorageAccess accessIface(const_cast(this));
> +if (accessIface.filePath() == "/") {
> +return "drive-harddisk-root";

QLatin1String

> udisksdevice.cpp:620
> +if (accessIface.filePath() == "/") {
> +return "drive-harddisk-root";
> +}

QStringLiteral

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 47 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/47/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 22:17:21 +
 Build duration:
5 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45961)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/73/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 22:17:21 +
 Build duration:
3 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45959)38%
(13051/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D16673: [server] Put some text-input v0 exclusive callbacks in v0 class

2018-11-04 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  textInputRestructure

REVISION DETAIL
  https://phabricator.kde.org/D16673

To: romangg, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16673: [server] Put some text-input v0 exclusive callbacks in v0 class

2018-11-04 Thread Roman Gilg
romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Requests
  
  - reset
  - commit_state
  - invoke_action
  
  are used in text-input v0 only and neither in v2 and upcoming
  v3 of the unstable text-input protocol.
  
  To increase readability put their callbacks in v0 interface class only.

TEST PLAN
  Compiles

REPOSITORY
  R127 KWayland

BRANCH
  textInputRestructure

REVISION DETAIL
  https://phabricator.kde.org/D16673

AFFECTED FILES
  src/server/textinput_interface.cpp
  src/server/textinput_interface_p.h
  src/server/textinput_interface_v0.cpp

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16643: Correct the accept flag of the event object on DragMove

2018-11-04 Thread Stefan Brüns
bruns added a comment.


  In D16643#353672 , @trmdi wrote:
  
  > In D16643#353670 , @bruns wrote:
  >
  > > This is not covered by your summary - you have only listed cases where 
the drag is erroneously **not** accepted. Please update the summary.
  >
  >
  > I wrote it in the first line:
  >
  > > m_enabled could change while moving.
  
  
  You made the summary worse ...
  
  `m_enabled` may change between //consecutive// DragMove events, but not 
during an event.
  
  In this case, though, it does not, and is constantly true. You can verify 
this by attaching a debugger or by adding debug statements.
  
  The only wrong code part is the `setAccepted(false)`, which should be 
`setAccepted(true)` (or just `accept()`, both are equivalent).

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread Nathaniel Graham
ngraham added a comment.


  FWIW, inline "what's this" help is something we're considering removing 
altogether for a variety of reasons (T9986 
), so I would prefer to ensure 
user-friendliness via an intuitive UI, tooltips, and non-inline documentation. 
Often a little inline note can work. Here's an example from Gwenview's settings 
dialog, which makes use of this paradigm:
  
  F6391043: Screenshot_20181104_140414.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16370

To: rjvbb, #ktexteditor
Cc: dhaumann, ngraham, cullmann, kde-frameworks-devel, kwrite-devel, michaelh, 
bruns, demsking, head7, kfunk, sars


D16672: Add support for speex files to taglibextractor

2018-11-04 Thread Alexander Stippich
astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Probably not widely used anymore, but support
  can easily be extended to support it

REPOSITORY
  R286 KFileMetaData

BRANCH
  speex

REVISION DETAIL
  https://phabricator.kde.org/D16672

AFFECTED FILES
  autotests/samplefiles/test.spx
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16671: Refactor embedded image extractor for greater extensibility

2018-11-04 Thread Alexander Stippich
astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  refactor the embedded image data extractor so that
  support for different mime types can be added 
  in the future more easily

REPOSITORY
  R286 KFileMetaData

BRANCH
  refactor_embedded_image

REVISION DETAIL
  https://phabricator.kde.org/D16671

AFFECTED FILES
  src/embeddedimagedata.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D15999: Add icons with added background to system.svgz

2018-11-04 Thread Phil Stefan
pstefan edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D15999: Add icons with added background to system.svgz

2018-11-04 Thread Phil Stefan
pstefan updated this revision to Diff 44862.
pstefan added a comment.


  - Sized down icons somewhat
  - Added "*-translucent" option of the icons in go.svgz (go-home, go-previous, 
etc). 32px only for now
  - Made background darker
  - Removed outer circle
  - Merge branch 'master' of git://anongit.kde.org/plasma-framework

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=43051=44862

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread René J . V . Bertin
rjvbb added a comment.


  > I would prefer to set this in the ui file: The maximum is already set to 99.
  
  Of course. FWIW, I decided against it because my approach ensures the range 
is always symmetric and esp. because the comment makes it less likely that 
someone will clamp the minimum back to 0 because of some pre-conceived idea 
about priority values.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16370

To: rjvbb, #ktexteditor
Cc: dhaumann, ngraham, cullmann, kde-frameworks-devel, kwrite-devel, michaelh, 
bruns, demsking, head7, kfunk, sars


D16643: Correct the accept flag of the event object on DragMove

2018-11-04 Thread trmdi
trmdi updated this revision to Diff 44860.
trmdi added a comment.


  git diff -U -- DeclarativeDropArea.cpp > patch.diff

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16643?vs=44784=44860

REVISION DETAIL
  https://phabricator.kde.org/D16643

AFFECTED FILES
  src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread Dominik Haumann
dhaumann added subscribers: ngraham, dhaumann.
dhaumann added inline comments.

INLINE COMMENTS

> katemodeconfigpage.cpp:95
> +// having to increase the priority of (all) those definitions.
> +ui->sbPriority->setMinimum(-ui->sbPriority->maximum());
> +// make the context help a bit easier to access

I would prefer to set this in the ui file: The maximum is already set to 99. I 
think it makes sense to set the minimum to -99 there. Can you provide an 
updated patch?

> katemodeconfigpage.cpp:97
> +// make the context help a bit easier to access
> +ui->sbPriority->setToolTip(ui->sbPriority->whatsThis());
> +

I agree with Christoph, we have no tooltip anywhere so far, so this would be 
inconsistent.

@ngraham Do you have any comment on this from a usability perspective? I have 
the feeling that how to show whats-this infos should be maybe solved in a more 
general way, and not for just one specific spin box.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16370

To: rjvbb, #ktexteditor
Cc: dhaumann, ngraham, cullmann, kde-frameworks-devel, kwrite-devel, michaelh, 
bruns, demsking, head7, kfunk, sars


D16665: Add programmaticaly useful error signalling

2018-11-04 Thread Dan Leinir Turthra Jensen
leinir created this revision.
leinir added reviewers: KNewStuff, apol.
leinir added a project: KNewStuff.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Previously, KNSCore only signalled errors using string messages, which were 
useful for fault finding, but not useful when attempting to handle errors 
during general operation. This patch adds a signal which is fired at the same 
time as some error messages, and which provides error condition information 
which is useful in a programmatical fashion.
  
  This patch would allow https://bugs.kde.org/show_bug.cgi?id=395937 to be 
fixed in a non-hackish fashion.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/core/CMakeLists.txt
  src/core/engine.cpp
  src/core/engine.h
  src/core/errorcode.h
  src/core/provider.h

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns


D16298: prevent avahi signal racing

2018-11-04 Thread Nathaniel Graham
ngraham added a reviewer: Frameworks.

REPOSITORY
  R272 KDNSSD

REVISION DETAIL
  https://phabricator.kde.org/D16298

To: sitter, mdawson, broulik, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-11-04 Thread Nathaniel Graham
ngraham added a comment.


  OK, I guess that's the best we can do for now. Can we push forward on this?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: bcooksley, ngraham, kde-frameworks-devel, kfm-devel, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov


D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-04 Thread Stefan Brüns
bruns added a subscriber: bcooksley.
bruns added a comment.


  In D16593#353801 , @astippich 
wrote:
  
  > This or the commit before causes CI to fail the ExtractorCollectionTest on 
Qt 5.9, 5.10, and Windows
  
  
  Most likely the new check in D16592 . It 
fails to find an extractor for application/x-kvtml
  
  Apparently it either does not find "application/x-kvtml" at all, or it is not 
registered as subtype of application/xml.
  
  This may be a setup issue of the CI system - @bcooksley ?
  
  Currently it relies on the application/x-kvtml entry from 
mime/packages/kde5.xml, which is part of kcoreaddons. Should be possible to 
switch to another entry if this is not available.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: bcooksley, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread René J . V . Bertin
rjvbb added a comment.


  >   For the tooltip stuff: I am not sure if that is not inconsistent with the 
remaining stuff on these pages.
  
  Is there a platform-agnostic way to trigger the display of the "what's this" 
pop-up? If so a reminder of that could be shown somewhere, somehow?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16370

To: rjvbb, #ktexteditor
Cc: cullmann, kde-frameworks-devel, kwrite-devel, michaelh, ngraham, bruns, 
demsking, head7, kfunk, sars, dhaumann


D16643: Correct the accept flag of the event object on DragMove

2018-11-04 Thread Nathaniel Graham
ngraham added a comment.


  In D16643#353679 , @trmdi wrote:
  
  > @ngraham
  >  How to see the full file content from this page? "Show raw file" doesn't 
work. Sorry, I'm new to Phabricator.
  
  
  You need to either use `arc` to create the diff (see 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist) or else 
add context manually by using `git diff -U` to generate your diff.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh


D16370: KTextEditor : syntax definition priority UI usability

2018-11-04 Thread Christoph Cullmann
cullmann added a comment.


  +1 for the negative priority idea, might help some people.
  
  For the tooltip stuff: I am not sure if that is not inconsistent with the 
remaining stuff on these pages.
  
  Other opinions?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16370

To: rjvbb, #ktexteditor
Cc: cullmann, kde-frameworks-devel, kwrite-devel, michaelh, ngraham, bruns, 
demsking, head7, kfunk, sars, dhaumann


D16196: add a description property to KFileMetaData

2018-11-04 Thread Alexander Stippich
astippich added a dependent revision: D12114: Revive 'Description' property for 
DublinCore metadata.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16196

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D12114: Revive 'Description' property for DublinCore metadata

2018-11-04 Thread Alexander Stippich
astippich updated this revision to Diff 44834.
astippich edited the summary of this revision.
astippich added a comment.


  - rebase on top of D16196 

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=44833=44834

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  autotests/samplefiles/test_libreoffice.docx
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams


D12114: Revive 'Description' property for DublinCore metadata

2018-11-04 Thread Alexander Stippich
astippich added a dependency: D16196: add a description property to 
KFileMetaData.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams


D12114: Revive 'Description' property for DublinCore metadata

2018-11-04 Thread Alexander Stippich
astippich retitled this revision from "Revive 'Description' property" to 
"Revive 'Description' property for DublinCore metadata".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams


D12114: Revive 'Description' property

2018-11-04 Thread Alexander Stippich
astippich updated this revision to Diff 44833.
astippich edited the summary of this revision.
astippich added a comment.


  - use description property for dublincore description

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=31887=44833

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  autotests/samplefiles/test_libreoffice.docx
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams


D12114: Revive 'Description' property

2018-11-04 Thread Alexander Stippich
astippich commandeered this revision.
astippich added a reviewer: michaelh.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, michaelh
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams


D12114: Revive 'Description' property

2018-11-04 Thread Alexander Stippich
astippich edited reviewers, added: bruns; removed: michaelh.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 115 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/115/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 10:55:38 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)80%
(2862/3560)47%
(4286/9032)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(1001/1269)44%
(460/1045)src.extractors100%
(12/12)100%
(12/12)73%
(1046/1428)47%
(2068/4378)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 94 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/94/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 10:55:37 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)80%
(2863/3560)47%
(4271/8996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(1002/1269)44%
(461/1045)src.extractors100%
(12/12)100%
(12/12)73%
(1046/1428)47%
(2052/4342)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

D16196: add a description property to KFileMetaData

2018-11-04 Thread Alexander Stippich
astippich updated this revision to Diff 44832.
astippich added a comment.


  - rebase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16196?vs=43586=44832

BRANCH
  description_property

REVISION DETAIL
  https://phabricator.kde.org/D16196

AFFECTED FILES
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2018-11-04 Thread David Faure
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  This map will keep growing and growing...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16311

To: broulik, #frameworks, dfaure, lbeltrame
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns


D16593: [ExtractorCollection] Use only best matching extractor plugin

2018-11-04 Thread Alexander Stippich
astippich added a comment.


  This or the commit before causes CI to fail the ExtractorCollectionTest on Qt 
5.9, 5.10, and Windows

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 93 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/93/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 09:50:22 +
 Build duration:
2 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)80%
(2863/3560)47%
(4271/8996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(1002/1269)44%
(461/1045)src.extractors100%
(12/12)100%
(12/12)73%
(1046/1428)47%
(2052/4342)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/114/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 09:50:22 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)80%
(2862/3560)47%
(4286/9032)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(1001/1269)44%
(460/1045)src.extractors100%
(12/12)100%
(12/12)73%
(1046/1428)47%
(2068/4378)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

D16583: use qlatin1 for embedded image extractor

2018-11-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0a26d39b27cb: use qlatin1 for embedded image extractor 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16583?vs=44718=44826

REVISION DETAIL
  https://phabricator.kde.org/D16583

AFFECTED FILES
  src/embeddedimagedata.cpp

To: astippich, mgallien, bruns, apol
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 92 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/92/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 09:48:01 +
 Build duration:
1 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)80%
(2861/3558)48%
(4289/9024)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(1000/1267)45%
(479/1073)src.extractors100%
(12/12)100%
(12/12)73%
(1046/1428)47%
(2052/4342)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 91 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/91/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 04 Nov 2018 09:39:41 +
 Build duration:
8 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2913/3612)48%
(4381/9196)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(1000/1267)45%
(479/1073)src.extractors100%
(12/12)100%
(12/12)74%
(1097/1481)47%
(2143/4512)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/113/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 09:45:59 +
 Build duration:
1 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)80%
(2860/3558)48%
(4304/9060)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(999/1267)45%
(478/1073)src.extractors100%
(12/12)100%
(12/12)73%
(1046/1428)47%
(2068/4378)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/112/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 09:44:28 +
 Build duration:
1 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2900/3598)47%
(4325/9120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(999/1267)45%
(478/1073)src.extractors100%
(12/12)100%
(12/12)74%
(1085/1467)47%
(2088/4436)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

D16560: create a separate test file for embedded images test

2018-11-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:e04ef70aa855: create a separate test file for embedded 
images test (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16560?vs=44582=44824

REVISION DETAIL
  https://phabricator.kde.org/D16560

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/samplefiles/cover.jpg

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D16554: move supported mimetypes to static string list

2018-11-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0375eee8a128: move supported mimetypes to static string 
list (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16554?vs=44661=44825

REVISION DETAIL
  https://phabricator.kde.org/D16554

AFFECTED FILES
  src/extractors/epubextractor.cpp
  src/extractors/exiv2extractor.cpp
  src/extractors/ffmpegextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp
  src/extractors/plaintextextractor.cpp
  src/extractors/poextractor.cpp
  src/extractors/popplerextractor.cpp
  src/extractors/taglibextractor.cpp
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 111 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/111/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 09:42:31 +
 Build duration:
1 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2900/3598)47%
(4325/9120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(999/1267)45%
(478/1073)src.extractors100%
(12/12)100%
(12/12)74%
(1085/1467)47%
(2088/4436)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

D16618: add explicit to constructors

2018-11-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2b20e8720ae3: add explicit to constructors (authored by 
astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16618?vs=44731=44822

REVISION DETAIL
  https://phabricator.kde.org/D16618

AFFECTED FILES
  src/externalextractor.h
  src/writers/taglibwriter.h

To: astippich, #frameworks, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


D16585: simplify handling of id3 tags

2018-11-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:053de81bafc1: simplify handling of id3 tags (authored by 
astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16585?vs=44621=44823

REVISION DETAIL
  https://phabricator.kde.org/D16585

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

2018-11-04 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/110/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 04 Nov 2018 09:39:41 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2912/3612)48%
(4396/9232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(775/795)49%
(1687/3448)src75%
(18/24)75%
(18/24)79%
(999/1267)45%
(478/1073)src.extractors100%
(12/12)100%
(12/12)74%
(1097/1481)47%
(2159/4548)src.writers100%
(1/1)100%
(1/1)98%
(41/42)48%
(72/151)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

D16619: add missing license information

2018-11-04 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2fb80c005e95: add missing license information (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16619?vs=44726=44821

REVISION DETAIL
  https://phabricator.kde.org/D16619

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/config-kfilemetadata.h.in
  src/writers/taglibwriter.cpp
  src/writers/taglibwriter.h

To: astippich, #frameworks, bruns, apol
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams