KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 76 - Failure!

2018-11-07 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/76/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 08 Nov 2018 07:45:17 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 75 - Aborted!

2018-11-07 Thread CI System
BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/75/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 06 Nov 2018 14:36:21 + Build duration: 1 day 17 hr and counting

Re: Regression in Frameworks - DBus Hangs

2018-11-07 Thread Ben Cooksley
On Sat, Nov 3, 2018 at 4:41 PM Ben Cooksley wrote: > > Hi all, > > Following commits made to Frameworks somewhere in the October 21 to > October 28 time frame, the unit tests of Konsole on the CI system have > started to hang following completion. > > This hang is occurring due to a behaviour of

D15739: [Places panel] Don't show Root by default

2018-11-07 Thread David C
davidc added a comment. Okay, I was only referring to the Places section, not the entire panel. I do think changing the default label of `Root`'s mounted device would prevent the confusion of the one user who wanted it removed from Devices. But that was only one of many criticisms of

D15739: [Places panel] Don't show Root by default

2018-11-07 Thread Nathaniel Graham
ngraham added a comment. In D15739#356008 , @davidc wrote: > Are you referring to the mounted device under the Devices section? Yes. > I'm unaware of how to get to the root directory in a single click using Places, if the existing

D15739: [Places panel] Don't show Root by default

2018-11-07 Thread David C
davidc added a comment. Are you referring to the mounted device under the Devices section? I'm unaware of how to get to the root directory in a single click using Places, if the existing link is removed. My question to users addressed the Devices point and I also provided the user

D15739: [Places panel] Don't show Root by default

2018-11-07 Thread Nathaniel Graham
ngraham added a comment. I do not understand why this change provokes any negative reactions. Right now, the Places panel has two items that both lead to the exact same location. This patch simply removes one of them by default, and adding it again if you want is a 10 second operation. No

D15739: [Places panel] Don't show Root by default

2018-11-07 Thread David C
davidc added a comment. I strongly advise against this. This change goes against Plasma's brand identity and will provoke a strongly negative reaction from our core audiences. Plasma is strongly associated with powerful tools and high utility. Users also love having many options. Every

D15739: [Places panel] Don't show Root by default

2018-11-07 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. This blows up the places tests; will fix them in this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg, tcanabrava Cc: tcanabrava, ndavis, romangg, bruns,

D16742: Fix iconitemtest regression

2018-11-07 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16742 To: joselema, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

2018-11-07 Thread trmdi
trmdi added a comment. In D16643#355965 , @bruns wrote: > If it does not receive any events, it can and must not accept. All events go to the parent. `DeclarativeDropArea::dragMoveEvent(QDragMoveEvent *event)` is called only when it

D16643: Correct the accept flag of the event object on DragMove

2018-11-07 Thread Stefan Brüns
bruns added a comment. In D16643#355964 , @trmdi wrote: > In D16643#355177 , @bruns wrote: > > > You have a conceptual misunderstanding of the enabled property, see QQuickItem

D16643: Correct the accept flag of the event object on DragMove

2018-11-07 Thread trmdi
trmdi added a comment. In D16643#355177 , @bruns wrote: > You have a conceptual misunderstanding of the enabled property, see QQuickItem > > > enabled : bool > > This property

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Unstable!

2018-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/69/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 07 Nov 2018 23:34:00 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 125 - Still Unstable!

2018-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/125/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Nov 2018 23:34:00 + Build duration: 10 min and counting JUnit Tests Name: (root)

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
This revision was automatically updated to reflect the committed changes. Closed by commit R244:eb916c305a5c: Fix crash if XDG_CACHE_HOME directory is too small or out of space (authored by alexeymin). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. switch would require ugly fall-through, I prefer this code. REPOSITORY R244 KCoreAddons BRANCH bug400610 REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure,

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin added a comment. In D16744#355899 , @cfeck wrote: > Would a switch be more readable? Did you mean a block with `if (result == ENOSPC) {` ? Strictly speaking this whole block is not necessary, but it can provide some useful info

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Christoph Feck
cfeck added a reviewer: mpyne. cfeck added a comment. Would a switch be more readable? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure, #frameworks, mpyne Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin updated this revision to Diff 45077. alexeymin added a comment. - Fix typo "in" -> "on" REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16744?vs=45074=45077 BRANCH bug400610 REVISION DETAIL https://phabricator.kde.org/D16744 AFFECTED

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin added a reviewer: Frameworks. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin edited the test plan for this revision. alexeymin added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread Alexey Min
alexeymin created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexeymin requested review of this revision. REVISION SUMMARY Incorrect checking for error return code of posix_fallocate() causes function to think that all is OK while it is

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-07 Thread Nathaniel Graham
ngraham added a comment. In D14631#355791 , @mlaurent wrote: > For me seems good +1 You still have a "Request changes" status for this patch. If you're happy with it now, can you change that to "Accepted? Thanks! REPOSITORY R241 KIO

D16742: Fix iconitemtest regression

2018-11-07 Thread José Manuel Santamaría Lema
joselema created this revision. joselema added reviewers: mart, apol. Herald added a project: Frameworks. Herald removed a subscriber: Frameworks. joselema requested review of this revision. REVISION SUMMARY Hi, after this commit

D16735: Implement text_input_unstable_v3

2018-11-07 Thread Roman Gilg
romangg added a task: T9815: Improve touch/virtual keyboard. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16735 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-07 Thread Laurent Montel
mlaurent added a comment. For me seems good +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

2018-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/105/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Nov 2018 16:24:23 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 79 - Still Unstable!

2018-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/79/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 07 Nov 2018 16:24:23 + Build duration: 7 min 52 sec and counting JUnit Tests Name: (root)

D16701: Correct version of newly added PlasmaVirtualDesktop interface

2018-11-07 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:2db50b2be381: Correct version of newly added PlasmaVirtualDesktop interface (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D7446: [Places panel] Revamp the Recently Saved section

2018-11-07 Thread Nathaniel Graham
ngraham added a comment. In D7446#355675 , @andreask wrote: > I would suggest to have by default detail view instead of icon view cause with detail view it's easier to read the paths. That's a good idea, let me see what I can do.

D7446: [Places panel] Revamp the Recently Saved section

2018-11-07 Thread Nathaniel Graham
ngraham retitled this revision from "[Places panel] Add a Recently Used item by default" to "[Places panel] Revamp the Recently Saved section". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL

D7446: [Places panel] Add a Recently Used item by default

2018-11-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 45043. ngraham added a comment. Rebase on master Updating D7446 : [Places panel] Add a Recently Used item by default REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D7446: [Places panel] Add a Recently Used item by default

2018-11-07 Thread Andreas Kainz
andreask added a comment. I would suggest to have by default detail view instead of icon view cause with detail view it's easier to read the paths. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg,

D15739: [Places panel] Don't show Root by default

2018-11-07 Thread Tomaz Canabrava
tcanabrava accepted this revision. tcanabrava added a comment. This revision is now accepted and ready to land. too many +1 to not be accepted. REPOSITORY R241 KIO BRANCH remote-root-from-places-panel (branched from master) REVISION DETAIL https://phabricator.kde.org/D15739 To:

D7446: [Places panel] Add a Recently Used item by default

2018-11-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 45040. ngraham added a comment. - Revamp the whole section REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=42865=45040 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D16735: Implement text_input_unstable_v3

2018-11-07 Thread Roman Gilg
romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Adds support for the text_input_unstable_v3 protocol to our current

D16665: Add programmaticaly useful error signalling

2018-11-07 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D16665#355578 , @apol wrote: > Maybe it would be good to produce the Discover patch before committing this to make sure the API is the one we want. Good idea, yes, i'll get that whipped together and submitted

D16665: Add programmaticaly useful error signalling

2018-11-07 Thread Aleix Pol Gonzalez
apol added a comment. Maybe it would be good to produce the Discover patch before committing this to make sure the API is the one we want. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16665 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff,

D16665: Add programmaticaly useful error signalling

2018-11-07 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16665 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!

2018-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/78/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 07 Nov 2018 13:41:17 + Build duration: 6 min 51 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

2018-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/104/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Nov 2018 13:41:17 + Build duration: 7 min 7 sec and counting JUnit Tests Name: (root)

D16708: [server] Text input content hint and purpose per protocol version

2018-11-07 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R127:7c0f6cfa2eae: [server] Text input content hint and purpose per protocol version (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16708?vs=44970=45033#toc REPOSITORY

D16708: [server] Text input content hint and purpose per protocol version

2018-11-07 Thread Roman Gilg
romangg marked an inline comment as done. REPOSITORY R127 KWayland BRANCH textInputEnums REVISION DETAIL https://phabricator.kde.org/D16708 To: romangg, #kwin, #frameworks, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16665: Add programmaticaly useful error signalling

2018-11-07 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 45032. leinir marked an inline comment as done. leinir added a comment. Adjust the patch to address @apol's comment about deprecating the old error signal REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D16665: Add programmaticaly useful error signalling

2018-11-07 Thread Dan Leinir Turthra Jensen
leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in engine.h:430 > I would include the error message here and deprecate `signalError`. Otherwise > it's going to be a mess matching both signals. Quite a good point, yes - i've done a bit of

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 64 - Still Unstable!

2018-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/64/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 07 Nov 2018 12:46:32 + Build duration: 5 min 51 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

2018-11-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/86/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 07 Nov 2018 12:46:32 + Build duration: 5 min 0 sec and counting JUnit Tests Name: (root)

D16733: Capture package metadata before install start

2018-11-07 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R290:451b1785e8d0: Capture package metadata before install start (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16733?vs=45026=45028#toc REPOSITORY R290 KPackage

D16733: Capture package metadata before install start

2018-11-07 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I would add a comment saying "please don't call d->package from the lambda because it breaks". REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D16733

D16733: Capture package metadata before install start

2018-11-07 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KPackage (despite being supposedly internally shared) is not kept as a strong reference inside