D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45220.
andreyorst added a comment.


  - made controll buttons 1.2px instead of 1px. Now 16 and 22 px icons will 
have slope somewhat between proposed variants. Looks crisp enough on my setup

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8912?vs=45219=45220

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8912

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games.svg

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D16677: Add BrightScript syntax

2018-11-09 Thread Daniel Levin
dlevin added a comment.


  @ngraham, so I have to match commit authors in syntax-highlighting Git 
project against that list? Curious whether all those people have rights to push 
patches particularly into this project. Still it feels like this is not an easy 
task to do that manually, so I would rather annoy you guys in this message 
thread with my push request (-:

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars


D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45219.
andreyorst added a comment.


  fix links

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8912?vs=45202=45219

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8912

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games.svg

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2018-11-09 Thread Friedrich W. H. Kossebau
kossebau added a subscriber: aacid.
kossebau added a comment.


  @aacid Thanks for providing your ftp server, served its purpose.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16770

To: kossebau, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns


D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2018-11-09 Thread Friedrich W. H. Kossebau
kossebau retitled this revision from "[ftp kio-slave] Fix deletion of directory 
with non-latin parent path" to "[ftp kio-slave] Fix deletion of directory with 
non-latin1/utf8 parent path".
kossebau edited the summary of this revision.
kossebau edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16770

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 124 - Still Unstable!

2018-11-09 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/124/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 09 Nov 2018 22:26:37 +
 Build duration:
5 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 68 - Still Unstable!

2018-11-09 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/68/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 09 Nov 2018 22:26:37 +
 Build duration:
4 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e2270613fc25: Add new icons for root (authored by ndavis, 
committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16772?vs=45209=45213

REVISION DETAIL
  https://phabricator.kde.org/D16772

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons-dark/devices/symbolic/drive-harddisk-root-symbolic.svg
  icons-dark/places/16/folder-root.svg
  icons-dark/places/22/folder-root.svg
  icons-dark/places/32/folder-root.svg
  icons-dark/places/64/folder-root.svg
  icons-dark/places/symbolic/folder-root-symbolic.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg
  icons/devices/symbolic/drive-harddisk-root-symbolic.svg
  icons/places/16/folder-root.svg
  icons/places/22/folder-root.svg
  icons/places/32/folder-root.svg
  icons/places/64/folder-root.svg
  icons/places/symbolic/folder-root-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns


D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham
ngraham added a comment.


  Other VDG folks in chat seem happy as well. Landing it!
  
  Nice work.

REPOSITORY
  R266 Breeze Icons

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns


D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham
ngraham added a comment.


  Usually the time is right when someone recommends that you do so! :-)

REPOSITORY
  R266 Breeze Icons

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns


D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis added a comment.


  In D16772#357086 , @ngraham wrote:
  
  > Makes sense to me. Now that I see them all together, I agree that /_ is a 
bit better. It seems much better for the folder, and at least no worse (and 
probably a bit better) for the disk.
  >
  > Any other VDG comments, or should we land this?
  >
  > BTW, @ndavis, you're doing so much good work that I would recommend you 
apply for a Developer account so you can land your own patches. You can read 
about that here: 
https://community.kde.org/Infrastructure/Get_a_Developer_Account
  >
  > BTW, once this goes in, I'll submit a KIO patch to use the new icon for the 
current Root Places Panel item. If we end up not removing it after all, we 
might as well use the nice new icon! :)
  
  
  Thanks! I've been thinking about when I should get a developer account.

REPOSITORY
  R266 Breeze Icons

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns


D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis updated this revision to Diff 45208.
ndavis added a comment.


  Update commit message to more accurately describe the changes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16772?vs=45196=45208

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons-dark/places/16/folder-root.svg
  icons-dark/places/22/folder-root.svg
  icons-dark/places/32/folder-root.svg
  icons-dark/places/64/folder-root.svg
  icons-dark/places/symbolic/folder-root-symbolic.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg
  icons/places/16/folder-root.svg
  icons/places/22/folder-root.svg
  icons/places/32/folder-root.svg
  icons/places/64/folder-root.svg
  icons/places/symbolic/folder-root-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added a comment.


  In D8912#357075 , @ndavis wrote:
  
  > In D8912#357072 , @bruns wrote:
  >
  > > Try making the buttons somewhat larger. A 1px circle ends up as light 
gray square.
  >
  >
  > Think that's perfectly fine. If they were larger, they would completely 
dominate the icon and the design of the icon would be have to be completely 
changed to match. With large buttons, a SNES style controller would have to be 
used.
  
  
  Just slightly - 1.1 to 1.2 px diameter.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D16677: Add BrightScript syntax

2018-11-09 Thread Nathaniel Graham
ngraham added a comment.


  In D16677#356620 , @dhaumann wrote:
  
  > Unless you have a KDE commit account you can not commit yourself. 
Unfortunately we cannot see on Phabricator whether you have one or not.
  
  
  BTW, you can check to see whether someone has a contributor account by trying 
to find their username on 
https://websvn.kde.org/trunk/kde-common/accounts?view=markup

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: ngraham, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, 
bruns, demsking, sars


D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment.


  In D8912#357074 , @ngraham wrote:
  
  > In D8912#357052 , @ndavis wrote:
  >
  > > F6403963: Screenshot_20181109_154449.png 

  > >
  > > Ah, that's much better. The buttons and D-pad are much easier to see. Try 
making the sides straight since the angle is pretty small for that size 
already. Kind of like this: F6404002: Screenshot_20181109_161045.png 

  >
  >
  > TBH, I kind of prefer the sloped-side version to the proposed straight-side 
version. It looks a bit too much like a Pac-Man ghost to me!
  
  
  Fair enough, though I don't see similarity to Pac-Man ghosts as a con.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment.


  In D8912#357072 , @bruns wrote:
  
  > Try making the buttons somewhat larger. A 1px circle ends up as light gray 
square.
  
  
  Think that's perfectly fine. If they were larger, they would completely 
dominate the icon and the design of the icon would be have to be completely 
changed to match. With large buttons, a SNES style controller would have to be 
used.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Nathaniel Graham
ngraham added a comment.


  In D8912#357052 , @ndavis wrote:
  
  > F6403963: Screenshot_20181109_154449.png 

  >
  > Ah, that's much better. The buttons and D-pad are much easier to see. Try 
making the sides straight since the angle is pretty small for that size 
already. Kind of like this: F6404002: Screenshot_20181109_161045.png 

  
  
  TBH, I kind of prefer the sloped-side version to the proposed straight-side 
version. It looks a bit too much like a Pac-Man ghost to me!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added a comment.


  Try making the buttons somewhat larger. A 1px circle ends up as light gray 
square.

INLINE COMMENTS

> folder-games.svg:93
> + transform="translate(0,-292.76667)">
> + +   width="0"

Remove all these leftover rects ..

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> folder-games.svg:73
> + inkscape:cy="10.469244"
> + inkscape:document-units="mm"
> + inkscape:current-layer="layer1-3-5"

switch the document units to px, the values are shorter then.

> folder-games.svg:1
> +/home/andreyorst/Git/breeze-icons/icons-dark/places/16/folder-games.svg

make sure the symlink is a relative one

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: bruns, ngraham, kde-frameworks-devel, ndavis, michaelh


D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment.


  F6403963: Screenshot_20181109_154449.png 

  
  Ah, that's much better. The buttons and D-pad are much easier to see. Try 
making the sides straight since the angle is pretty small for that size 
already. Kind of like this: F6404002: Screenshot_20181109_161045.png 

  
  Here's the SVG of that example icon if you want it. I made the shapes with 
rectangles, circles, Path->Union (`Ctrl`+`+`) and Path->Difference 
(`Ctrl`+`-`). BTW, I'm not saying you have to do it like that, it's still your 
project.
  F6404009: game_controller16.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst updated this revision to Diff 45202.
andreyorst added a comment.


  Changed icons so they look crisp

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8912?vs=22644=45202

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8912

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games.svg

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D16788: fixed game folder icons to be crisp on 1px grid

2018-11-09 Thread Andrey Orst
andreyorst created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
andreyorst requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16788

AFFECTED FILES
  icons-dark/places/16/folder-games.svg
  icons-dark/places/22/folder-games.svg
  icons-dark/places/32/folder-games.svg
  icons-dark/places/64/folder-games.svg
  icons-dark/places/symbolic/folder-games.svg
  icons/places/16/folder-games.svg
  icons/places/22/folder-games.svg
  icons/places/32/folder-games.svg
  icons/places/64/folder-games.svg
  icons/places/symbolic/folder-games.svg

To: andreyorst
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16677: Add BrightScript syntax

2018-11-09 Thread Christoph Cullmann
cullmann added a comment.


  The merge should show up here and you should get a notification mail like for 
any other action.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16677: Add BrightScript syntax

2018-11-09 Thread Daniel Levin
dlevin added a comment.


  Thanks a lot for helping me with this! One last question: how do I know that 
patch was finally merged, by periodically checking the github mirror git 
repository? https://github.com/KDE/syntax-highlighting.git

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis updated this revision to Diff 45196.
ndavis added a comment.


  Change style to `/_`. The reason for this is that `/` by itself looks kind of 
empty and it's easy to confuse the meaning with disabled or inactive, 
especially for drive-harddisk-root.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16772?vs=45150=45196

BRANCH
  folder-root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16772

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk-root.svg
  icons-dark/devices/22/drive-harddisk-root.svg
  icons-dark/devices/64/drive-harddisk-root.svg
  icons-dark/places/16/folder-root.svg
  icons-dark/places/22/folder-root.svg
  icons-dark/places/32/folder-root.svg
  icons-dark/places/64/folder-root.svg
  icons-dark/places/symbolic/folder-root-symbolic.svg
  icons/devices/16/drive-harddisk-root.svg
  icons/devices/22/drive-harddisk-root.svg
  icons/devices/64/drive-harddisk-root.svg
  icons/places/16/folder-root.svg
  icons/places/22/folder-root.svg
  icons/places/32/folder-root.svg
  icons/places/64/folder-root.svg
  icons/places/symbolic/folder-root-symbolic.svg

To: ndavis, #vdg
Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns


D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis retitled this revision from "Add folder-root icon" to "Add new icons for 
root".
ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg
Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns


D8912: Added a set of Game Folder icons

2018-11-09 Thread Andrey Orst
andreyorst added a comment.


  Understood. Yeh, now I see it. I have very poor eyesight, I'll fixt it

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D16677: Add BrightScript syntax

2018-11-09 Thread Christoph Cullmann
cullmann added a comment.


  I can push that for you, just need to fixup my local dev setup again ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16677: Add BrightScript syntax

2018-11-09 Thread Daniel Levin
dlevin added a comment.


  I do not have a KDE commit account, so I guess I need your help to integrate 
this patch.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, sars


D16772: Add folder-root icon

2018-11-09 Thread Noah Davis
ndavis added a comment.


  Alternative style. If I choose this style, I will also change the style of 
`drive-harddisk-root`.
  F6403388: Screenshot_20181109_102458.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16772

To: ndavis, #vdg
Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns


D8912: Added a set of Game Folder icons

2018-11-09 Thread Noah Davis
ndavis added a comment.


  In D8912#356590 , @andreyorst wrote:
  
  > > @andreyorst, if you're still around, we can review this patch and land it 
once necessary changes are made.
  >
  > Yeah, I'm here! I'd like to make desired changes myself.
  >
  > > Nice job on the 64 px icons! However, I noticed that the 16 and 22 px 
icons use a different style and are blurry. Perhaps you should try making the 
styles more similar to the 64 px style and see if you can move, resize or 
remove any details that don't line up with pixels.
  >
  > So the reason behind this was, that with outline style for 16 and 22 px 
icons all elements like buttons were too small and looked really bad. I've 
tried lot of variants and decided to go for filled icon in the same way how it 
is done for `network-server` icon, which is using (sort of) outline for 64 px 
and solid for 22 px. However (the ticket is quite old) I've changed this 
somewhere during this year, and currently in my system all icons are using 
filled icons, since I feel that this fits more with original style of 
`applications-games` icon (and most of game controllers are black too). I'll 
submit updated patch this evening.
  
  
  Fair enough. I'll be waiting.
  
  >> I noticed that the 16 and 22 px icons use a different style and are blurry
  > 
  > What screen resolution do you have? Rightnow it looks fine on my system 
with 1920x1080 screen. I'll check it at work with 2k screen and scaling turned 
off.
  
  I also have 1920x1080 screen, but it shouldn't matter as long as we're both 
at 1x scaling. You don't see how blurry it is compared to the other icons in 
your screenshot?
  F6403322: Screenshot_20181109_091658.png 

  
  Let me show you the issue up close. You see how it doesn't line up well with 
the grid? 1 grid square = 1 pixel.
  F6403326: Screenshot_20181109_092307.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8912

To: andreyorst, #vdg
Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns


D16665: Add programmaticaly useful error signalling

2018-11-09 Thread Dan Leinir Turthra Jensen
leinir added a dependent revision: D16776: Better error handling in KNewStuff 
backend.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D16665

To: leinir, #knewstuff, apol
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns


D15464: [server] Touch drag support

2018-11-09 Thread Roman Gilg
romangg updated this revision to Diff 45164.
romangg added a comment.


  - No touch motion on drag
  - Add touch dnd autotest

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15464?vs=41923=45164

BRANCH
  touchDrag

REVISION DETAIL
  https://phabricator.kde.org/D15464

AFFECTED FILES
  autotests/client/test_drag_drop.cpp
  src/server/datadevice_interface.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h
  src/server/touch_interface.cpp

To: romangg, #kwin, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns