D16825: Export again KFilePlaceEditDialog

2018-11-13 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R241 KIO BRANCH export-kfileplaceeditdialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D16825 To: elvisangelaccio, #dolphin, dfaure, ngraham, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-13 Thread Emirald Mateli
emateli updated this revision to Diff 45438. emateli marked 9 inline comments as done. emateli added a comment. - create on stack - upd define - remove unused import - use qstringliteral - remove unused export - match file name - remove import prefixes - remove q_unused on used

D16141: Disable unmount option for / or /home

2018-11-13 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:45597c32627f: Disable unmount option for / or /home (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16141?vs=45378=45437 REVISION DETAIL

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-13 Thread Thomas Surrel
thsurrel edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D16857 To: thsurrel, #dolphin, #frameworks, bruns Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-13 Thread Stefan Brüns
bruns added a comment. I think this is correct, but the summary can be improved a little bit. The problem is caused by the fact device interfaces returned by Solid (e.g. `item->device().as()`) are not full objects, but only references/pointers to a per-device-object, i.e. requesting the

D16825: Export again KFilePlaceEditDialog

2018-11-13 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH export-kfileplaceeditdialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D16825 To: elvisangelaccio, #dolphin, dfaure, ngraham Cc: kde-frameworks-devel,

Re: Regression in Frameworks - DBus Hangs

2018-11-13 Thread Ben Cooksley
On Tue, Nov 13, 2018 at 2:25 PM David Edmundson wrote: > > I don't think application CI jobs run with workspace available. I also can't > think of anything that's been merged in workspace. That's correct. CI Jobs are only provided with the things they depend on. > > --- >

D16832: fix empty runner list after switching to new locale

2018-11-13 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D16832 To: shaforostoff, #plasma_workspaces, davidedmundson, kossebau, #frameworks Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, skadinna, huftis

D16867: Don't generate appstream data for files that lack a description

2018-11-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this looks like a good fix. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D16867 To: apol, #plasma, #frameworks, ngraham Cc: ngraham,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

2018-11-13 Thread Mélanie Chauvel
achauvel added a comment. Is anybody interested in helping me figure out how I can implement that properly? I would be glad to start working again on it, but I don’t know enough about KIO right now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel,

R134:7f6caf385809: Better error handling in KNewStuff backend

2018-11-13 Thread Ben Cooksley
bcooksley added a comment. They are updated once every week, by the Dependency Build jobs (anything which isn't part of a Product but which is needed by something in a Product is built by these jobs) The status of the Dependency Build jobs can be found at

T8349: Improve Places panel usability and presentation

2018-11-13 Thread Nicolas Fella
nicolasfella updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham, nicolasfella Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, ggrysuk, alexde, IohannesPetros, sourabhboss, feverfew, trickyricky26,

D11365: also test for value types in taglibextractortest and fix errors

2018-11-13 Thread Alexander Stippich
astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh Cc: kde-frameworks-devel, bruns, michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, abrahams

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:2ae8a0c374cd: Show list of tags in PlacesView (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7700?vs=45414=45426#toc REPOSITORY R241 KIO CHANGES SINCE LAST

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > ngraham wrote in kfileplacesmodel.cpp:187 > const. But in fact, does this even need to be a variable? It's only used once. Will fix on push REPOSITORY R241 KIO BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde.org/D7700

D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor

2018-11-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:a167548830fb: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D16867: Don't generate appstream data for files that lack a description

2018-11-13 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY They end up being broken appstream files and it fails on the users' faces. Have

D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor

2018-11-13 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16686 To: davidedmundson, #kwin, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation. REPOSITORY R241 KIO BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde.org/D7700 To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham Cc: kde-frameworks-devel, bruns, rkflx, mmustac,

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. A surprisingly small amount of code for a nice feature. Code looks good to me except for one minor thing. This works great in my testing now. I say let's ship it, especially because it

D16801: Fix build on macOS

2018-11-13 Thread Harald Fernengel
harald abandoned this revision. harald added a comment. Abandoned, already fixed by https://phabricator.kde.org/D16862 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16801 To: harald Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15479: fix for macOS

2018-11-13 Thread Aleix Pol Gonzalez
apol added a comment. In D15479#358797 , @vonreth wrote: > thx, we where using the patch since ages on binary-factory, https://cgit.kde.org/craft-blueprints-kde.git/commit/?id=b84b9f3fd64594bb5e7959472a58309d54ee06fa Then please don't

D16801: Fix build on macOS

2018-11-13 Thread Harald Fernengel
harald removed a reviewer: apol. This revision now requires review to proceed. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16801 To: harald, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

R134:7f6caf385809: Better error handling in KNewStuff backend

2018-11-13 Thread Dan Leinir Turthra Jensen
leinir added a subscriber: kde-frameworks-devel. leinir added a comment. Through pushing this patch, i have discovered there is no easily discoverable documentation regarding when Frameworks are updated for unstable builds. According to

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nicolas Fella
nicolasfella updated this revision to Diff 45414. nicolasfella added a comment. - Merge branch 'master' into arcpatch-D7700 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=38100=45414 BRANCH arcpatch-D7700 REVISION DETAIL

D16862: Fix CMake condition

2018-11-13 Thread Hannah von Reth
This revision was automatically updated to reflect the committed changes. Closed by commit R268:c54307f8520b: Fix CMake condition (authored by vonreth). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16862?vs=45410=45413 REVISION DETAIL

D16862: Fix CMake condition

2018-11-13 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D16862 To: vonreth, cgiboudeaux Cc: bcooksley, kfunk, #craft, kde-frameworks-devel, michaelh, ngraham, bruns

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nathaniel Graham
ngraham added a comment. Me neither. Can you rebase this on current master? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7700 To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham Cc: kde-frameworks-devel, bruns, rkflx, mmustac, spoorun, michaelh,

D16862: Fix CMake condition

2018-11-13 Thread Hannah von Reth
vonreth added subscribers: Craft, kfunk, bcooksley. vonreth added a comment. Maybe we should look into the non Linux backends too... REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16862 To: vonreth Cc: bcooksley, kfunk, #craft, kde-frameworks-devel, michaelh,

D16862: Fix CMake condition

2018-11-13 Thread Hannah von Reth
vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REVISION SUMMARY 11:29:37 CMake Error at src/runtime/plugins/CMakeLists.txt:1 (if): 11:29:37 if given arguments: 11:29:37

D16852: Add Documents to the default list of Places

2018-11-13 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation. REPOSITORY R241 KIO BRANCH add-documents (branched from master) REVISION DETAIL https://phabricator.kde.org/D16852 To: acrouthamel, #frameworks, #dolphin, ngraham Cc: davidc, elvisangelaccio,

D16852: Add Documents to the default list of Places

2018-11-13 Thread David C
davidc added a comment. Just wanted to say thanks for this. Adding Documents is the first thing I do when I open Dolphin on a fresh install. REPOSITORY R241 KIO BRANCH add-documents (branched from master) REVISION DETAIL https://phabricator.kde.org/D16852 To: acrouthamel,

D16141: Disable unmount option for / or /home

2018-11-13 Thread Nathaniel Graham
ngraham added a comment. Cool, go for it! REPOSITORY R241 KIO BRANCH arc_unmount (branched from master) REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, ngraham Cc: dfaure, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-13 Thread Nathaniel Graham
ngraham edited reviewers, added: Frameworks, bruns; removed: VDG. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D16857 To: thsurrel, #dolphin, #frameworks, bruns, #vdg Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros,

D13777: KMessageWidget : revert to using highlight colour for Information style

2018-11-13 Thread René J . V . Bertin
rjvbb retitled this revision from "KMessageWidget : revert to using highlight colour for Information style (WIP)" to "KMessageWidget : revert to using highlight colour for Information style". REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb,

D7283: KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too

2018-11-13 Thread René J . V . Bertin
rjvbb retitled this revision from "WIP: KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too" to "KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too". Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION

D5070: Allow to play the default system sound (beep) instead of a specific sound file

2018-11-13 Thread René J . V . Bertin
rjvbb retitled this revision from "Allow to play the default system sound (beep) instead of a specific sound file (WIP)" to "Allow to play the default system sound (beep) instead of a specific sound file". Herald added a subscriber: kde-frameworks-devel. REPOSITORY R289 KNotifications

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps

2018-11-13 Thread René J . V . Bertin
rjvbb retitled this revision from "qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)" to "qqc2-desktop-style: basic support for QGuiApplication-based apps". REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D14000 To:

D15479: fix for macOS

2018-11-13 Thread Hannah von Reth
vonreth added a comment. thx, we where using the patch since ages on binary-factory, https://cgit.kde.org/craft-blueprints-kde.git/commit/?id=b84b9f3fd64594bb5e7959472a58309d54ee06fa REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D15479 To: yurikoles, arichardson

D15479: fix for macOS

2018-11-13 Thread Hannah von Reth
This revision was automatically updated to reflect the committed changes. Closed by commit R272:4eb0a90c7dd9: fix for macOS (authored by Hessel van der Molen hmolen.scie...@gmail.com, committed by vonreth). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE