D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-24 Thread Shubham
shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-24 Thread Shubham
shubham updated this revision to Diff 46174. shubham added a comment. @since 5.53 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=45951=46174 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 341 - Fixed!

2018-11-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/341/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Nov 2018 04:26:28 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 0

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-24 Thread Nathaniel Graham
ngraham added a comment. Sorry for the extended review time; I've found myself super busy with family stuff during this vacation. :) Please address Elvis' inline comment and then this will look good to me. INLINE COMMENTS > global.h:249 > +ERR_CANNOT_CREATE_SLAVE =

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 340 - Unstable!

2018-11-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/340/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Nov 2018 20:21:51 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 1

T8349: Improve Places panel usability and presentation

2018-11-24 Thread Nathaniel Graham
ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, alexde, IohannesPetros, sourabhboss, feverfew, trickyricky26, crozbo, spoorun, ndavis,

D17139: Add highlighting file for Wayland Debug Traces

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. > I am ok with that ;=) === REPOSITORY R216 Syntax Highlighting BRANCH feature/waylandLogHighlighting REVISION DETAIL https://phabricator.kde.org/D17139

D16671: Refactor embedded image extractor for greater extensibility

2018-11-24 Thread Alexander Stippich
astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16671 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-24 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:fc5a98db98a8: [KUrlNavigator] Re-activate on mouse middle button click (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17114?vs=46049=46155

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-24 Thread Thomas Surrel
thsurrel added a comment. I tried that too, but it was not working for Dolphin. It did reactivate correctly the disabled split view, but the tab was not opened, I guess we were missing an event. REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL

D17139: Add highlighting file for Wayland Debug Traces

2018-11-24 Thread Andreas Cord-Landwehr
cordlandwehr updated this revision to Diff 46148. cordlandwehr added a comment. - Fix detection of interface names with numbers - Fix reference for nomal text itemData - Add test data for Wayland trace highlighting REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

2018-11-24 Thread loh tar
loh.tar added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17056 To: loh.tar, #frameworks Cc: mludwig, kde-frameworks-devel, michaelh, ngraham, bruns

D17055: Avoid Q_FOREACH

2018-11-24 Thread loh tar
loh.tar added a reviewer: davidedmundson. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17055 To: loh.tar, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-11-24 Thread loh tar
loh.tar added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

2018-11-24 Thread loh tar
loh.tar added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17137: File menu: Put Save, Print and Export in submenus

2018-11-24 Thread gregormi
gregormi edited the summary of this revision. gregormi added a reviewer: KDevelop. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars,

D8649: move detecting comments to before operators so -- is interpreted as a comment, not an operator

2018-11-24 Thread Christoph Cullmann
cullmann abandoned this revision. cullmann added a comment. Already fix in current master. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8649 To: cullmann, #framework_syntax_highlighting, dhaumann, genethomas Cc: kwrite-devel, kde-frameworks-devel,

D8649: move detecting comments to before operators so -- is interpreted as a comment, not an operator

2018-11-24 Thread Christoph Cullmann
cullmann commandeered this revision. cullmann added a reviewer: genethomas. cullmann added a comment. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. These fixes are already in the current state in our git ;=) Thanks

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-24 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. elvisangelaccio added a comment. We could have used `KUrlNavigator::mouseReleaseEvent()` where we already have the same check, but this is also fine. REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL

D16370: KTextEditor : syntax definition priority UI usability

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think we merge the change here now. The tooltip is no real issue, we can try to consolidate what-this-tooltip-inline help an other time if somebody has interest. Allowing negative

D12295: Supporting nested brackets for Kate autobrackets

2018-11-24 Thread Christoph Cullmann
cullmann added a comment. Hi, I like the improvements, just want some feedback on my questions above. Still alive? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: sraizada, #ktexteditor, #kate, cullmann, dhaumann, brauch Cc: brauch, ngraham,

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

2018-11-24 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:c7095834d282: Expose Toggle Comment feature through tools menu and default shortcut (authored by slenz, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. As long as the old shortcuts stay, I think this is ok. REPOSITORY R39 KTextEditor BRANCH arcpatch-D17008_1 REVISION DETAIL https://phabricator.kde.org/D17008 To: slenz, #vdg, ngraham, #kate, #ktexteditor, cullmann Cc:

D17128: DocumentPrivate: Remove comment mark when joining lines

2018-11-24 Thread Christoph Cullmann
cullmann added a comment. Whereas I think such an extension is good, I am not sure if the normal join lines should try to be that clever. ATM it is very "deterministic" what happens and I think people like that. It would make more sense to have an extra action for such a "smart" variant

D17092: Add syntax highlighting for TypeScript & TypeScript React

2018-11-24 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a25ce26d2c6b: Add syntax highlighting for TypeScript TypeScript React (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17092: Add syntax highlighting for TypeScript & TypeScript React

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I like that ;=) And its a very nice show-case for the keyword list inclusion. Cool! REPOSITORY R216 Syntax Highlighting BRANCH add-typescript REVISION DETAIL

D17139: Add highlighting file for Wayland Debug Traces

2018-11-24 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Could you add a minimal test case to the auto-tests? Otherwise all fine with having this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D17093: Rust & Yacc/Bison: improve comments

2018-11-24 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6643d91bbbaa: Rust Yacc/Bison: improve comments (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17093: Rust & Yacc/Bison: improve comments

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Good idea => will apply it. Thanks! REPOSITORY R216 Syntax Highlighting BRANCH improve-comments-rust-yacc REVISION DETAIL https://phabricator.kde.org/D17093 To: nibags,

D17083: Fix hidden languages in the mode menu

2018-11-24 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:bb5f34d7224d: Fix hidden languages in the mode menu (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17083: Fix hidden languages in the mode menu

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks good, thanks! REPOSITORY R39 KTextEditor BRANCH fix-hidden-modes REVISION DETAIL https://phabricator.kde.org/D17083 To: nibags, #ktexteditor, cullmann Cc: cullmann,

D17084: Prolog & Lua: fix shebang

2018-11-24 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6f109cf88198: Prolog Lua: fix shebang (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17084?vs=45991=46137

D17084: Prolog & Lua: fix shebang

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, has tests, will be applied, thanks! REPOSITORY R216 Syntax Highlighting BRANCH fix-shebang REVISION DETAIL https://phabricator.kde.org/D17084 To: nibags,

D17139: Add highlighting file for Wayland Debug Traces

2018-11-24 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cordlandwehr requested review of this revision. REVISION SUMMARY When running a Wayland application with parameter WAYLAND_DEBUG=1, all communication

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

2018-11-24 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:edbf2e36c805: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17123: KTextEditor::ViewPrivate: Avoid warning "Text requested for invalid range"

2018-11-24 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:db6be05824b5: KTextEditor::ViewPrivate: Avoid warning Text requested for invalid range (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

2018-11-24 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think neither the dialog/spellcheck bar nor the context menu things got any love in the close past. If you have time to improve this, any patch is welcome! I will apply this

D17137: File menu: Put Save, Print and Export in submenus

2018-11-24 Thread gregormi
gregormi edited the summary of this revision. gregormi added a reviewer: Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17137: File menu: Put Save, Print and Export in submenus

2018-11-24 Thread gregormi
gregormi updated this revision to Diff 46132. gregormi added a comment. rebase on master REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17137?vs=46128=46132 BRANCH arcpatch-D17137 REVISION DETAIL https://phabricator.kde.org/D17137 AFFECTED FILES

D17137: File menu: Put Save, Print and Export in submenus

2018-11-24 Thread gregormi
gregormi retitled this revision from "File menu: Put Save, Print and Export in submenus With https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before. This is the corresponding patch for Kate: TODO (screenshots are there)..." to "File

D17137: File menu: Put Save, Print and Export in submenusWith https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before.This is the correspondi

2018-11-24 Thread gregormi
gregormi created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gregormi requested review of this revision. REVISION SUMMARY ...NOTE: I assume that dependent applications like KWrite and KDevelop must be adapted, too. So, a

D17132: Add 22px dialog-warning icon

2018-11-24 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b23134a4220a: Add 22px dialog-warning icon (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D17132: Add 22px dialog-warning icon

2018-11-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this works! REPOSITORY R266 Breeze Icons BRANCH add-dialog-warning-22px (branched from master) REVISION DETAIL https://phabricator.kde.org/D17132 To: trickyricky26, #vdg,

D17114: [KUrlNavigator] Re-activate on mouse middle button click

2018-11-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This approach makes sense to me and works beautifully! REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 To:

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

2018-11-24 Thread Alexander Schlarb
ntninja added a comment. Thanks, I'll keep that in mind for next time. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: ntninja, dfaure Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-24 Thread Shubham
shubham added a comment. @ngraham @bruns do you have any objections? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.10 - Build # 104 - Fixed!

2018-11-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.10/104/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Nov 2018 12:12:14 + Build duration: 4 min 22 sec and counting JUnit Tests Name:

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.9 - Build # 80 - Fixed!

2018-11-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.9/80/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Nov 2018 12:12:14 + Build duration: 3 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.11 - Build # 18 - Fixed!

2018-11-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.11/18/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 24 Nov 2018 12:12:13 + Build duration: 46 sec and counting

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 FreeBSDQt5.11 - Build # 18 - Fixed!

2018-11-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20FreeBSDQt5.11/18/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 24 Nov 2018 12:12:14 + Build duration: 27 sec and counting

D16929: Remove dead search provider

2018-11-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:abfddc54afc0: Remove dead search providers (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16929?vs=45632=46112#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D16946: Port more search providers to HTTPS

2018-11-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:719461805318: Port more search providers to HTTPS (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16946?vs=45635=46111#toc REPOSITORY R241 KIO CHANGES SINCE LAST

D16929: Remove dead search provider

2018-11-24 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16929 To: vkrause, #frameworks, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D16929: Remove dead search provider

2018-11-24 Thread Volker Krause
vkrause added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16929 To: vkrause, #frameworks Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D16954: Add find module for Google's libphonenumber

2018-11-24 Thread Volker Krause
vkrause added reviewers: Build System, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16954 To: vkrause, #build_system, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17132: Add 22px dialog-warning icon

2018-11-24 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17132 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D17132: Add 22px dialog-warning icon

2018-11-24 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-dialog-warning-22px (branched from master) REVISION DETAIL

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Unstable!

2018-11-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.11/16/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 24 Nov 2018 11:03:48 + Build duration: 13 min and counting JUnit Tests

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

2018-11-24 Thread David Faure
dfaure closed this revision. dfaure added a comment. https://commits.kde.org/frameworkintegration/4cc12a5ad1fa92f8b934f02ff2e401539ec9b9f7 REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: ntninja, dfaure Cc: dfaure, apol,

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

2018-11-24 Thread David Faure
dfaure added a comment. Ah, you need to specify that you don't have a developer account, otherwise the assumption is simply that you'll push the patch once approved. I'll land it now. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To:

D16825: Export again KFilePlaceEditDialog

2018-11-24 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:7ad161b1a2bb: Export again KFilePlaceEditDialog (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16825?vs=45313=46109 REVISION DETAIL

D15368: [Comic Thumbnailer] support more image formats

2018-11-24 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15368 To: fleger, broulik, #frameworks, elvisangelaccio Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, alexde,

D15368: [Comic Thumbnailer] support more image formats

2018-11-24 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > comiccreator.cpp:101 > QMap entryMap; > -Q_FOREACH(const QString& entry, entries) { > -if (entry.endsWith(QLatin1String(".gif"), Qt::CaseInsensitive) || > -entry.endsWith(QLatin1String(".jpg"),

D15367: [Comic Thumbnailer] fix CBR thumbnail generation

2018-11-24 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Sorry for taking so long. Please give us the email address we should use for pushing this patch on your behalf. REPOSITORY R320 KIO Extras BRANCH

D17079: Provide a qqc2/kirigami-based about page

2018-11-24 Thread Volker Krause
vkrause added a comment. In D17079#364308 , @mart wrote: > In D17079#364263 , @apol wrote: > > > In D17079#364163 , @ltoscano wrote: > > > > >

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Failure!

2018-11-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20WindowsMSVCQt5.11/17/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 24 Nov 2018 09:36:03 + Build duration: 1 min 1 sec and counting CONSOLE

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.10 - Build # 103 - Failure!

2018-11-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.10/103/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 24 Nov 2018 09:36:03 + Build duration: 51 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.9 - Build # 79 - Failure!

2018-11-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.9/79/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 24 Nov 2018 09:36:03 + Build duration: 48 sec and counting CONSOLE OUTPUT

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps

2018-11-24 Thread René J . V . Bertin
This revision was automatically updated to reflect the committed changes. Closed by commit R858:1e02355c1786: Support for QGuiApplication-based apps (authored by rjvbb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14000?vs=44083=46108#toc REPOSITORY R858 Qt Quick Controls 2:

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 FreeBSDQt5.11 - Build # 17 - Failure!

2018-11-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20FreeBSDQt5.11/17/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 24 Nov 2018 09:36:02 + Build duration: 35 sec and counting CONSOLE OUTPUT