D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-25 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  In D17086#366120 , @ngraham wrote:
  
  > Looks great to me then!
  >
  > But how do I make this work? I compiled and installed the icon and verified 
that it's installed in the right place. But my AppImage isn't getting the new 
icon, not even after running `update-desktop-database`.
  >
  > F6441744: Weird.png 
  >
  > What am I doing wrong here?
  
  
  There might be the chance that the icon cache is not updated autpmagically 
after the icon installation. Try removing `.cache/icon-cache.kcache` before 
running a new instance of dolphin. Not sure if some index counter needs to be 
changed as welll for new icons, could not find some related change on new icon 
commits.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-25 Thread Nathaniel Graham
ngraham accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-25 Thread Shubham
shubham added a comment.


  "transferred" done
  request @ngraham @dfaure @bruns to give thumbs up again.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-25 Thread Shubham
shubham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-25 Thread Shubham
shubham updated this revision to Diff 46235.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16249?vs=46174=46235

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/global.h
  src/core/job_error.cpp

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham


D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 46234.
ngraham added a comment.


  Match existing brace style for inline initializer

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17167?vs=46233=46234

BRANCH
  custom-icons-for-non-xdg-dirs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17167

AFFECTED FILES
  src/core/kioglobal_p.cpp

To: ngraham, #frameworks, cfeck, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 46233.
ngraham added a comment.


  Correct typo in the comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17167?vs=46232=46233

BRANCH
  custom-icons-for-non-xdg-dirs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17167

AFFECTED FILES
  src/core/kioglobal_p.cpp

To: ngraham, #frameworks, cfeck, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-25 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Frameworks, cfeck, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch adds a new folder-to-icon map that makes it possible to assign 
default icons for non-XDG directories. It is pre-populated with `~/Games`, as 
requested in 401218.
  
  The new map includes entries for the localized and non-located string, 
because some people like to use English names even with a different locale.
  
  BUG: 401218
  FIXED-IN: 5.53

TEST PLAN
  - Created `~/Games`; it got the new `folder-games` icon
  - Created a new user account and checked out its homedir; all XDG dirs 
continued to get the correct icon

REPOSITORY
  R241 KIO

BRANCH
  custom-icons-for-non-xdg-dirs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17167

AFFECTED FILES
  src/core/kioglobal_p.cpp

To: ngraham, #frameworks, cfeck, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17013: Show menu bar, how to re-enable, common shortcut dialog

2018-11-25 Thread Nathaniel Graham
ngraham added a comment.


  Even though a lot of inline comments have been marked as resolved, I don't 
actually see that the requested changes have been made.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-25 Thread Nathaniel Graham
ngraham added a comment.


  Looks great to me then!
  
  But how do I make this work? I compiled and installed the icon and verified 
that it's installed in the right place. But my AppImage isn't getting the new 
icon, not even after running `update-desktop-database`.
  
  F6441744: Weird.png 
  
  What am I doing wrong here?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-25 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  In D17086#366111 , @ngraham wrote:
  
  > Thanks, that looks great! As for the background color, I'd say it's okay to 
use a different shade of blue if it would better match the AppImage branding.
  
  
  For now I favor breeze palette usage, given the same IIRC is also done 
elsewhere with brand logo usage in Breeze icons.
  
  > Don't worry about participating in the style change discussion; if that 
ever bears any fruit, we'll change this icon as a part of it.
  
  Happy to have SVG editing skilled people take over, Inkscape is really in my 
way here :)
  
  > The images I posted came from the Cuttlefish app:
  >  F6441674: Cuttlefish.png 
  
  Ha, I noticed the very same time it be just screenshots snippets from 
cuttlefish when I looked at it during task-related usage :) Thanks for sharing 
the how.
  Might be a nice feature addition to have cuttlefish create such summary 
renderings as pixmaps itself to copy here & elsewhere, without the need to go 
via screenshot tool? Noted for fun hacks times...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-25 Thread Friedrich W. H. Kossebau
kossebau retitled this revision from "Add icons for application-vnd.appimage" 
to "Add icons for application-vnd.appimage/x-iso9660-appimage".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage

2018-11-25 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 46231.
kossebau added a comment.


  - add symlinks for application-x-iso9660-appimage to application-vnd.appimage

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17086?vs=46229=46231

BRANCH
  addappimageiconv2

REVISION DETAIL
  https://phabricator.kde.org/D17086

AFFECTED FILES
  icons/mimetypes/16/application-vnd.appimage.svg
  icons/mimetypes/16/application-x-iso9660-appimage.svg
  icons/mimetypes/22/application-vnd.appimage.svg
  icons/mimetypes/22/application-x-iso9660-appimage.svg
  icons/mimetypes/32/application-vnd.appimage.svg
  icons/mimetypes/32/application-x-iso9660-appimage.svg
  icons/mimetypes/64/application-vnd.appimage.svg
  icons/mimetypes/64/application-x-iso9660-appimage.svg

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage

2018-11-25 Thread Nathaniel Graham
ngraham added a comment.


  Thanks, that looks great! As for the background color, I'd say it's okay to 
use a different shade of blue if it would better match the AppImage branding.
  
  Don't worry about participating in the style change discussion; if that ever 
bears any fruit, we'll change this icon as a part of it.
  
  The images I posted came from the Cuttlefish app:
  F6441674: Cuttlefish.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage

2018-11-25 Thread TheAssassin
TheAssassin added a comment.


  Quoting myself:
  
  > You might also add a 1 somewhere in there to indicate the type, but as both 
are still relevant and should mostly work equally, that's not really necessary.
  
  I think more and more that there shouldn't be different icons. The user 
shouldn't have to worry about the actual type.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage

2018-11-25 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  F6441665: Screenshot_20181126_014024.png 
 for an updated example usage.
  
  @ngraham How do you create those summary pictures you used above for the 
comparison previews?
  
  In D17086#366097 , @TheAssassin 
wrote:
  
  > The new logos look great!
  
  
  Happy to learn you like them :)
  
  In D17086#366099 , @TheAssassin 
wrote:
  
  > AFAIK `vnd.appimage` resolves to type 2, whereas `x-[iso9660-]appimage` 
resolves to type 1. At least that's the MIME data I've been working with all 
the time so far.
  
  
  Ah, so alias with the other then, okay. For a start I guess that giving 
"application/x-iso9660-appimage" the same icon might work (using the icon 
shared linking system), not sure if there needs to be any indication in the 
icon itself about the type, also no idea how to mark type 1 and how type 2.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage

2018-11-25 Thread TheAssassin
TheAssassin added a comment.


  AFAIK `vnd.appimage` resolves to type 2, whereas `x-[iso9660-]appimage` 
resolves to type 1. At least that's the MIME data I've been working with all 
the time so far.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage

2018-11-25 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  In D17086#363977 , @ngraham wrote:
  
  > We have two options here:
  >
  > 1. Follow the style and make the AppImage icon look like a document with a 
folded-over corner that has an the AppImage logo  in the middle
  > 2. Engage #VDG  and Come up a new 
icon style for executables, and then make the AppImage icon in that new style
  >
  >   [...] Feel free to do #1 for now.
  
  
  Sadly no time currently to engage in such discussion, so quickly did #1 to 
have something for now.
  
  In D17086#364095 , @TheAssassin 
wrote:
  
  > The dark blue is quite nice, but I thought perhaps a color from the 
official AppImage logo might fit better.
  
  
  I guess one should stick to the Breeze color palette for the icons, for 
consistent look. Other logos are also matched to closes Breeze palette color 
from what I quickly looked at, But exactly sure.
  
  > The logo could by the way also be used for the type 1 MIME type, 
`application/x-iso9660-appimage` and `application/x-appimage` IIRC. 
  >  You might also add a `1` somewhere in there to indicate the type, but as 
both are still relevant and should mostly work equally, that's not really 
necessary.
  
  No clue yet about the "application/x-iso9660-appimage" MIME type, what is the 
difference?
  "application/x-appimage" is an outdated alias to "application/vnd.appimage", 
no? So that should be resolved by the alias logic of shared-mime-info at the 
core, no need for explicit own icon entry,

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage

2018-11-25 Thread TheAssassin
TheAssassin added a comment.


  The new logos look great!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17086: Add icons for application-vnd.appimage

2018-11-25 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 46229.
kossebau added a comment.


  - use document-style icon shape, to match other existing icons for executables
  - use Breeze palette color that is more close to AppImage logo one

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17086?vs=45976=46229

BRANCH
  addappimageiconv2

REVISION DETAIL
  https://phabricator.kde.org/D17086

AFFECTED FILES
  icons/mimetypes/16/application-vnd.appimage.svg
  icons/mimetypes/22/application-vnd.appimage.svg
  icons/mimetypes/32/application-vnd.appimage.svg
  icons/mimetypes/64/application-vnd.appimage.svg

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns


D17161: Replace Latin1 character remnant with escaped UTF-8 sequence

2018-11-25 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17161

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-25 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> bruns wrote in job_error.cpp:1079
> "transeferred"

"transeferred"? - not done ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham


D17162: Harmonize handling of underscore in query parser

2018-11-25 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The engine differentiates between independent terms, and adjacent terms
  forming a phrase. The latter is e.g. used for mail addresses and file
  names, "i...@fire.com" or "foo_bar.png". In the database these are stored
  without any punctuation characters, but with their relative positions.
  
  While most punctuation characters (e.g. ".", ",", "/", "-", ...) are
  treated the same, underscore was handled differently. A query for
  "foo-bar.png" searches for the three adjacent terms, while "foo_bar png"
  searches for the three terms in any order.
  
  Treat "_" like any other punctuation character. For this to work, the
  delimiter has to be checked from the original input string, not the
  text mangled for QTextBoundaryFinder.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17162

AFFECTED FILES
  autotests/unit/engine/queryparsertest.cpp
  src/engine/queryparser.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17161: Replace Latin1 character remnant with escaped UTF-8 sequence

2018-11-25 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17161

AFFECTED FILES
  autotests/unit/engine/queryparsertest.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17160: Remove extra spaces from Debug output, insert delimiters between fields

2018-11-25 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When a single query is streamed, the fields may be separated with multiple
  spaces, while subqueries, which are streamed via recursion from QVector,
  may lack any spaces between fields.
  
  Disable any automatic insertion of spaces and add delimiters manually
  where necessary.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17160

AFFECTED FILES
  src/engine/enginequery.h

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16919: Re-add DBus test

2018-11-25 Thread Kurt Hindenburg
hindenburg added a comment.


  Yes, I was actually surprised I managed to get it all to run.  Are there 
official docs on how to setup an ci image and run applications?  If not, it 
would be helpful.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16919

To: davidedmundson, #konsole, #frameworks, hindenburg
Cc: bcooksley, hindenburg, konsole-devel, ngraham, maximilianocuria


D17048: Restore sendfile support

2018-11-25 Thread Sefa Eyeoglu
sefaeyeoglu added a comment.


  Can someone benchmark this? Would be nice to know how much this affects 
performance.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17048

To: davidedmundson, dfaure
Cc: sefaeyeoglu, ngraham, apol, kde-frameworks-devel, michaelh, bruns


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-25 Thread Shubham
shubham added a comment.


  @bruns is it good to go?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-25 Thread Nathaniel Graham
ngraham accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham


D17139: Add highlighting file for Wayland Debug Traces

2018-11-25 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:abb86831466b: Add highlighting file for Wayland Debug 
Traces (authored by cordlandwehr).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17139?vs=46148=46201

REVISION DETAIL
  https://phabricator.kde.org/D17139

AFFECTED FILES
  autotests/folding/wayland.txt.fold
  autotests/html/wayland.txt.html
  autotests/input/wayland.txt
  autotests/input/wayland.txt.syntax
  autotests/reference/wayland.txt.ref
  data/syntax/wayland-trace.xml

To: cordlandwehr, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann


D16412: Add the possibility to have a keyboard shortcut to create a file

2018-11-25 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8100e99e1465: Add the possibility to have a keyboard 
shortcut to create a file (authored by thsurrel).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16412?vs=45292=46197

REVISION DETAIL
  https://phabricator.kde.org/D16412

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp
  src/filewidgets/knewfilemenu.h

To: thsurrel, #frameworks, dfaure, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D17128: DocumentPrivate: Remove comment mark when joining lines

2018-11-25 Thread Christoph Cullmann
cullmann added a comment.


  > An extra action looks to me at first sight a little overdone, but an option 
how join behaves may appropriate.
  
  An option in the settings would work for me, too.
  I just don't want to destroy the work-flow of people that rely on the current 
behavior.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann


T10112: KDEInstallDirs on Mac

2018-11-25 Thread René J . V . Bertin
rjvbb added a comment.


  You will notice that I plan to maintain an option to disable the 
Apple-specific behaviour for anyone who depends on the current behaviour (that 
includes me, but your script would also continue to work). Cf. the 
`APPLE_FORCE_X11` option
  
  A priori /Library/Application Support is admin-writable and I cannot really 
conceive that anyone using (managing) a MacPorts, Fink or HomeBrew installtion 
would NOT have an admin account. But then I've been tweaking permissions since 
10.2 and have only some outdated experience with Fink besides my intimate 
knowledge of MacPorts (and those both require root permissions to install 
packages).

TASK DETAIL
  https://phabricator.kde.org/T10112

To: rjvbb
Cc: yurikoles, kde-mac, #kde_applications, #frameworks, #build_system


T10112: KDEInstallDirs on Mac

2018-11-25 Thread Yurii Kolesnykov
yurikoles added a comment.


/Library/Application Support/kf5
  
  This will be incompatible with homebrew packages 
, since they are built inside sandbox 
and own prefix.
  
  I had created a shell script 
 that 
sets up needed symlinks, it needs to be run manually.
  
  I think If this patch will be accepted, we will end up with install errors 
due to sandbox limitation, or my script will require a sudo, because 
`/Library/Application Support/` is not writable by arbitrary users.

TASK DETAIL
  https://phabricator.kde.org/T10112

To: rjvbb, yurikoles
Cc: yurikoles, kde-mac, #kde_applications, #frameworks, #build_system


D17017: Fix assert when cleaning up symlinks in PreviewJob

2018-11-25 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17017

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16412: Add the possibility to have a keyboard shortcut to create a file

2018-11-25 Thread Elvis Angelaccio
elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  newfileshortcut (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16412

To: thsurrel, #frameworks, dfaure, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D16919: Re-add DBus test

2018-11-25 Thread Ben Cooksley
bcooksley added a comment.


  Okay, that is odd.
  
  I'll try reproducing the issue on the CI nodes in the next day or so - you 
changed 'kcalcore' in that example to 'konsole' I assume?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16919

To: davidedmundson, #konsole, #frameworks, hindenburg
Cc: bcooksley, hindenburg, konsole-devel, ngraham, maximilianocuria


D16370: KTextEditor : syntax definition priority UI usability

2018-11-25 Thread René J . V . Bertin
rjvbb added a comment.


  >   Allowing negative prios makes sense.
  
  Yes, they do make life a bit more bearable but aren't the ultimate solution 
either, at least not on Mac. The other day I had to work my way through the 
entire list to set a whole bunch of positive priorities (which I never set) to 
0 or -1 because C, C++ and ObjC++ and related files kept being treated as 
anything but the correct format in KDevelop. Not just inappropriate C-like 
formats (Ansi C89, SystemC, GCCExtensions) but also completely wrong formats 
(source code being treated as "Makefile" or vice-versa).
  The UI is REALLY not suitable for that kind of mass editing... at the very 
least it could let the "Delete" button act in some kind of way on built-in 
formats (hide from list, and then use some Mod-Click to unhide all, a bit like 
how one can treat system notifications).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16370

To: rjvbb, #ktexteditor, cullmann
Cc: dhaumann, ngraham, cullmann, kde-frameworks-devel, kwrite-devel, michaelh, 
bruns, demsking, head7, kfunk, sars


D16370: KTextEditor : syntax definition priority UI usability

2018-11-25 Thread René J . V . Bertin
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:4009bc1e919d: Allow negative syntax definition priorities. 
(authored by rjvbb).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16370?vs=45380=46185

REVISION DETAIL
  https://phabricator.kde.org/D16370

AFFECTED FILES
  src/dialogs/filetypeconfigwidget.ui
  src/mode/katemodeconfigpage.cpp

To: rjvbb, #ktexteditor, cullmann
Cc: dhaumann, ngraham, cullmann, kde-frameworks-devel, kwrite-devel, michaelh, 
bruns, demsking, head7, kfunk, sars


D17128: DocumentPrivate: Remove comment mark when joining lines

2018-11-25 Thread loh tar
loh.tar added a comment.


  > I am not sure if the normal join lines should try to be that clever.
  
  But consider the "auto comment" feature after you hit "Return", it's also 
somehow "special clever" but very useful. This tries to add the corresponding 
functionality. Well, the true opposite would be when you hit "Del" at the on of 
a line. Yeah, sounds good, will look at that too but it is (almost, see next 
note) independent from this aim.
  
  I'm currently digging into the wrap functionally which is broken since a 
decade BUG135737 . Sometimes it 
works already pretty well (with normal text) but sometimes it drives nuts 
(without selection in a code file). Very strange. Why I mention this? There I 
have follow a suggestion posted in that bug report, just o trigger a "Return" 
input at the right place. Now, while writing this text I came up with this 
"Del" idea. So, it may a good idea to re-design this patch (?)
  
  > It would make more sense to have an extra action for such a "smart" variant 
in my eyes.
  
  An extra action looks to me at first sight a little overdone, but an option 
how join behaves may appropriate. Let me know where to place that in the Edit 
Options page if you (and other) like that idea

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann


D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-25 Thread David Faure
dfaure accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, 
ngraham