D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, that was it. Looks beautiful. Ship it! REPOSITORY R266 Breeze Icons BRANCH addappimageiconv2 REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham

D17013: Show menu bar, how to re-enable, common shortcut dialog

aacid added a comment. the documentation is mising a @since 5.SOMETHING REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

T10112: KDEInstallDirs on Mac

rjvbb added a comment. A more complete draft: F6442989: patch-mac-installdirs.diff TASK DETAIL https://phabricator.kde.org/T10112 To: rjvbb Cc: yurikoles, kde-mac, #kde_applications, #frameworks, #build_system

D17084: Prolog & Lua: fix shebang

dhaumann added a comment. Btw, I think in this case the fix is correct. But sometimes, detecting a Shebang in an extra context introduces regressions when the language is used in other xml files via IncludeRules. This seems not the case here, though, so all is fine. REPOSITORY R216

D16878: Resolve symlinks in exclude folders

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=342224? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16878 To: poboiko, #frameworks, #baloo Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D17178: Don't ask for confimation when reloading

nicolasfella edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17178 To: nicolasfella, #kate, ngraham Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17178: Don't ask for confimation when reloading

nicolasfella created this revision. nicolasfella added reviewers: Kate, ngraham. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nicolasfella requested review of this revision. REVISION SUMMARY When reloading the document it is unnecessary

Setting bug report address in KPlugin json data?

Hi, I cannot seem to find how to set a bug reporting address in a plugin json file. Is that possible and if so, how? I'm a bit annoyed by the default "please use BKO to report bugs" ... Thanks, R

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/73/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 26 Nov 2018 16:57:05 + Build duration: 4 min 0 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/129/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Nov 2018 16:57:05 + Build duration: 3 min 52 sec and counting JUnit Tests Name: (root)

D17079: Provide a qqc2/kirigami-based about page

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:673981634266: Provide a qqc2/kirigami-based about page (authored by apol). REPOSITORY R134 Discover Software Store

D17078: Make it possible to use KAboutData/License/Person from QML

apol closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure, aacid Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

apol marked 2 inline comments as done. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure, aacid Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

aacid accepted this revision. aacid added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kaboutdata.h:92 > + * > + * Default arguments @since 5.53 > */ Change "Default arguments @since 5.53" to "name default argument @since 5.53" REPOSITORY

D17161: Replace Latin1 character remnant with escaped UTF-8 sequence

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c405714eb8e6: Replace Latin1 character remnant with escaped UTF-8 sequence (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17161?vs=46224=46275

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 46274. apol added a comment. @since REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=46273=46274 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 AFFECTED FILES src/lib/kaboutdata.cpp

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 46273. apol added a comment. More @since REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=46272=46273 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 AFFECTED FILES

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 46272. apol added a comment. Polishing REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=46271=46272 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 AFFECTED FILES

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me, visually speaking! REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham,

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 46271. apol added a subscriber: aacid. apol added a comment. Add CONSTANT as suggested by @aacid REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=45984=46271 BRANCH master REVISION DETAIL

D17078: Make it possible to use KAboutData/License/Person from QML

apol added a comment. Can somebody accept it or reject it, please? :P REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar edited the test plan for this revision. loh.tar added a reviewer: VDG. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli added a comment. Usually the message should be always shown, but I think there there are some exceptions. - for Kate the message is supposed to be off till its code base is upgraded with the removal of ts own popup. - for dolphin the message should be shown only if the

D17017: Fix assert when cleaning up symlinks in PreviewJob

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7ce34436a038: Fix assert when cleaning up symlinks in PreviewJob (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17017?vs=45809=46264

D17013: Show menu bar, how to re-enable, common shortcut dialog

ngraham added a comment. Looking better now. Do we really want to only optionally show the warning with a bool argument? In general bool arguments to functions are discouraged because they're not very readable. And if the whole point of this function is to always show a consistent message,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 269 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/269/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Nov 2018 13:54:59 + Build duration: 13 min and counting JUnit Tests Name: (root)

D17173: Add error value for job owner dying

davidedmundson added inline comments. INLINE COMMENTS > global.h:249 > +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > +ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between > kuiserver and views when the job

D17173: Add error value for job owner dying

broulik added a comment. +1 INLINE COMMENTS > global.h:249 > +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > +ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between > kuiserver and views when the job owner

D17173: Add error value for job owner dying

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY When kuiserver detects that a job owner has terminated whilst jobs are still running we need an error

D17013: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli updated this revision to Diff 46248. lsartorelli added a comment. Hi, you are right, I did not realize a bit of mess in between my revisions. Now all the requests should have been fulfilled properly. Thanks for this massive support and please, just let me know if I need

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a comment. bump? REPOSITORY R32 KDevelop REVISION DETAIL https://phabricator.kde.org/D16882 To: rjvbb, #kdevelop, kossebau Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight,

D16919: Re-add DBus test

bcooksley added a comment. The best we have documentation wise is https://phabricator.kde.org/w/continuous-integration/ however these are quite out of date (and incomplete). REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole,

D17017: Fix assert when cleaning up symlinks in PreviewJob

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17017 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns