D15829: make units and prefixes of formatValue translatable

2018-11-27 Thread Alexander Stippich
astippich added a comment. If no-one objects or has any comments regarding coding, I'm going to land this revision in one week REPOSITORY R244 KCoreAddons BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 To: astippich, bruns, safaalfulaij Cc:

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 85 - Unstable!

2018-11-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/85/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 28 Nov 2018 07:43:22 + Build duration: 3 min 55 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 258 - Unstable!

2018-11-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/258/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 28 Nov 2018 07:43:22 + Build duration: 2 min 26 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 202 - Unstable!

2018-11-27 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/202/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 28 Nov 2018 07:43:22 + Build duration: 2 min 24 sec and counting JUnit Tests Name:

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Antonio Rojas
arojas abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12761 To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales,

D17185: Added ip-tunnel settings

2018-11-27 Thread Jan Grulich
jgrulich added inline comments. INLINE COMMENTS > CMakeLists.txt:31 > wirelesssecuritysettingtest > +iptunnelsettingtest > ) Can you please add the test in alphabetic order? > iptunnelsettingtest.cpp:79 > + > +map.insert(QLatin1String(NMQT_SETTING_IP_TUNNEL_CONFIG_MODE), mode); >

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c45565159924: BrightScript: Allow sub to be unnamed (authored by dlevin, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sure :/ I missed to change author last time, I normally am just patching/landing via arc, but that doesn't always contain that. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Andreas Sturmlechner
asturmlechner added a comment. In D12761#367223 , @arojas wrote: > @asturmlechner can you post that in a new review request? I'll abandon this one. Done, this is now in https://phabricator.kde.org/D17205 REPOSITORY R320 KIO Extras

D17205: Build kio_nfs against standalone libtirpc

2018-11-27 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added reviewers: Dolphin, dfaure, rdieter. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. asturmlechner requested review of this revision. REVISION SUMMARY Since glibc-2.26, cmake skipped

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Antonio Rojas
arojas added a comment. @asturmlechner can you post that in a new review request? I'll abandon this one. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12761 To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux Cc: kde-frameworks-devel, kfm-devel,

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin added a comment. Thanks for the review. Btw, is there any chance to preserve my name/email in the final commit? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17204 To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh,

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin updated this revision to Diff 46371. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17204?vs=46369=46371 REVISION DETAIL https://phabricator.kde.org/D17204 AFFECTED FILES autotests/html/brightscript.brs.html

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Looks reasonable, but you need to increase the version. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17204 To: dlevin, cullmann Cc:

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY Subs and functions could be unnamed in closures. REPOSITORY R216

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 346 - Failure!

2018-11-27 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/346/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 28 Nov 2018 04:28:20 + Build duration: 3 min 26 sec and counting CONSOLE OUTPUT [...truncated 678.52

D17200: Avoid writing unchanged data to terms dbs

2018-11-27 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense, thanks! REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17200 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc:

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Andreas Sturmlechner
asturmlechner added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:4 > Any solution is fine however, we now patched ours kdebase4-runtime package to > disable kio-nfs completely. Pick the solution you prefer. Thanks, your FindTIRPC works for me. This is what I came up

D7446: [Places panel] Revamp the Recently Saved section

2018-11-27 Thread Nathaniel Graham
ngraham added a comment. Ping! #VDG , #dolphin , or #frameworks folks? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham,

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:4 > I added the solution we use in openSUSE: https://paste.kde.org/pscug8tik Any solution is fine however, we now patched ours kdebase4-runtime package to disable kio-nfs completely. Pick the solution you

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > asturmlechner wrote in CMakeLists.txt:4 > Could you suggest an alternative? Gentoo shares a similarity with Arch there, > because otherwise libtirpc could collide with older versions of glibc. I added the solution we use in openSUSE:

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Andreas Sturmlechner
asturmlechner added inline comments. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. INLINE COMMENTS > CMakeLists.txt:175 > + add_feature_info("NFS kioslave" RPC_H_DIR "The RPC library is needed to > build the NFS kioslave") > +

D17197: Reserve space in pending operations vector

2018-11-27 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:707beb19da7c: Reserve space in pending operations vector (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17197?vs=46347=46361 REVISION DETAIL

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-27 Thread TheAssassin
TheAssassin added a comment. Yep, it's really nice, thanks @kossebau! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17197: Reserve space in pending operations vector

2018-11-27 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17197 To: bruns, #baloo, #frameworks, ngraham, poboiko, davidedmundson Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-27 Thread Nathaniel Graham
ngraham added a comment. Thanks for the nice new icon! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-27 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R266:e3266db59d2f: Add icons for application-vnd.appimage/x-iso9660-appimage (authored by kossebau). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-27 Thread Friedrich W. H. Kossebau
kossebau added a comment. Thanks for feedback/review :) REPOSITORY R266 Breeze Icons BRANCH addappimageiconv2 REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17200: Avoid writing unchanged data to terms dbs

2018-11-27 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The termlist returned from replaceTerms may be identical

D17199: Add unittest to check if commiting the same change twice works

2018-11-27 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The fileindexer is only aware some terms/properties *may*

D17198: Add unit test for position DB

2018-11-27 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY This increases test coverage significantly: - the

D17197: Reserve space in pending operations vector

2018-11-27 Thread Stefan Brüns
bruns edited the test plan for this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17197 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D17197: Reserve space in pending operations vector

2018-11-27 Thread Stefan Brüns
bruns updated this revision to Diff 46347. bruns added a comment. also reverse in replaceTerms REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17197?vs=46346=46347 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17197 AFFECTED FILES

D17197: Reserve space in pending operations vector

2018-11-27 Thread Stefan Brüns
bruns created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17197 AFFECTED FILES

D17188: Notification portal: support pixmaps in notifications

2018-11-27 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R289:8ae44d819bbb: Notification portal: support pixmaps in notifications (authored by jgrulich). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D17195: Avoid constantly increasing Qt event queue in KIO slaves

2018-11-27 Thread David Edmundson
davidedmundson edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17195 To: davidedmundson, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17195: Avoid constantly increasing Qt event queue in KIO slaves

2018-11-27 Thread Nathaniel Graham
ngraham added a comment. Wow, awesome! Might this huge improvement in small file copy speed be enough to call it a definitive fix for https://bugs.kde.org/show_bug.cgi?id=342056? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17195 To: davidedmundson, dfaure Cc:

D17195: Avoid constantly increasing Qt event queue in KIO slaves

2018-11-27 Thread David Edmundson
davidedmundson edited the summary of this revision. davidedmundson edited the test plan for this revision. davidedmundson added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17195 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

D17195: Avoid constantly increasing Qt event queue in KIO slaves

2018-11-27 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Connection is used in two places SlaveBase (file.so etc) and SlaveInterface (dolphin etc). In

D17188: Notification portal: support pixmaps in notifications

2018-11-27 Thread Jan Grulich
jgrulich updated this revision to Diff 46331. jgrulich added a comment. Move definition of PortalIcon structure out from the header file REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17188?vs=46318=46331 BRANCH master REVISION DETAIL

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

2018-11-27 Thread Christoph Cullmann
cullmann added a comment. For: It could make sense to actually exert some effort to support it properly. There seems to be no interest to spend effort on by anybody. Therefore I would say we shall close this and D5803 . REPOSITORY R39 KTextEditor

D17178: Don't ask for confimation when reloading

2018-11-27 Thread Christoph Cullmann
cullmann added a comment. I don't think the change is a bad idea, thought should not the delete m_modOnHdHandler; stay, to avoid we have the pending message visible? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17178 To: nicolasfella, #kate,

D17178: Don't ask for confimation when reloading

2018-11-27 Thread Christoph Cullmann
cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17178 To: nicolasfella, #kate, ngraham, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham,

D17013: Show menu bar, how to re-enable, common shortcut dialog

2018-11-27 Thread loh tar
loh.tar added a comment. Hi, I accidentally went by. How about to add an icon to some (main) toolbar, if any is present? That would the need to show such a message reduce to cases where no tool bar is available. If that icon was added, and not already there, could that pop up a small

D17193: KateViewInternal: Remove unneeded functions

2018-11-27 Thread Christoph Cullmann
cullmann added a comment. Simplifications in that way are ok in my eye, given the extra level of functions have no gain. (not even encapsulation) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17193 To: loh.tar, #ktexteditor Cc: cullmann, kwrite-devel,

D17188: Notification portal: support pixmaps in notifications

2018-11-27 Thread Jan Grulich
jgrulich added a comment. In D17188#366802 , @apol wrote: > Maybe it would make sense to rename this file to `notifybyportal.cpp` (and class..) I can rename it in a different review. This was done a long time ago, when only Flatpak was

D17193: KateViewInternal: Remove unneeded functions

2018-11-27 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. TEST PLAN This is only an example snippet to show that obviously something

D17190: Add level api from Kirigami.Heading

2018-11-27 Thread Marco Martin
mart added a comment. In D17190#366854 , @ngraham wrote: > In those screenshots, "< Fonts" is basically just a named back button. Should it really have the same size and visual weight as the active KCMs' title? I think so, it's the title

D17190: Add level api from Kirigami.Heading

2018-11-27 Thread Nathaniel Graham
ngraham added a comment. In D17190#366840 , @mart wrote: > F6443889: image.png > > with a QWidget KCM > F6443893: image.png In those screenshots, "<

D17191: Perfect alignment between QML and QWidget KCM titles

2018-11-27 Thread Marco Martin
mart added a comment. QML KCM: F6443898: image.png QWidget KCM: F6443900: image.png REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D17191 To: mart, #plasma, #vdg Cc:

D17191: Perfect alignment between QML and QWidget KCM titles

2018-11-27 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY uses spacing metrics synced with systemsettings to have the title perfectly aligned with

D17013: Show menu bar, how to re-enable, common shortcut dialog

2018-11-27 Thread Luca Sartorelli
lsartorelli updated this revision to Diff 46321. lsartorelli added a comment. Added @since and @author in the header documentation REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17013?vs=46248=46321 REVISION DETAIL

D17190: Add level api from Kirigami.Heading

2018-11-27 Thread Marco Martin
mart added a comment. F6443889: image.png with a QWidget KCM F6443893: image.png REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17190 To: mart, #plasma, #vdg Cc:

D17190: Add level api from Kirigami.Heading

2018-11-27 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY add a "level" api that has the same meaning as in the Kirigami Heading component, This

D17188: Notification portal: support pixmaps in notifications

2018-11-27 Thread Kai Uwe Broulik
broulik added a comment. +1 INLINE COMMENTS > notifybyflatpak.h:40 > public: > +struct PortalIcon { > +QString str; Does this need to be in the header file? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17188 To: jgrulich,

D17188: Notification portal: support pixmaps in notifications

2018-11-27 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Maybe it would make sense to rename this file to `notifybyportal.cpp` (and class..) REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17188 To:

D17188: Notification portal: support pixmaps in notifications

2018-11-27 Thread Jan Grulich
jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REVISION SUMMARY From portal documentation: The portal only accepts serialized GThemedIcon and GBytesIcons. Both of these have the

D17188: Notification portal: support pixmaps in notifications

2018-11-27 Thread Jan Grulich
jgrulich added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17188 To: jgrulich, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17185: Added ip-tunnel settings

2018-11-27 Thread Pranav Gade
pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added ip-tunnel settings according to

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-27 Thread TheAssassin
TheAssassin accepted this revision. REPOSITORY R266 Breeze Icons BRANCH addappimageiconv2 REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns