D15829: make units and prefixes of formatValue translatable

[Alexander Stippich]

astippich added a comment.


  If no-one objects or has any comments regarding coding, I'm going to land 
this revision in one week

REPOSITORY
  R244 KCoreAddons

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 85 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/85/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 28 Nov 2018 07:43:22 +
 Build duration:
3 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: TestSuite.folding_test

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 258 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/258/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 28 Nov 2018 07:43:22 +
 Build duration:
2 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2656/3384)66%
(1869/2818)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(667/731)59%
(434/730)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/100)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(212/276)src.lib90%
(27/30)90%
(27/30)85%
(1767/2072)73%
(1223/1672)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 202 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/202/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 28 Nov 2018 07:43:22 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2656/3384)66%
(1869/2818)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(667/731)59%
(434/730)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/100)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(212/276)src.lib90%
(27/30)90%
(27/30)85%
(1767/2072)73%
(1223/1672)

D12761: Allow building kio-nfs against standalone libtirpc

[Antonio Rojas]

arojas abandoned this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D17185: Added ip-tunnel settings

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> CMakeLists.txt:31
>  wirelesssecuritysettingtest
> +iptunnelsettingtest
>  )

Can you please add the test in alphabetic order?

> iptunnelsettingtest.cpp:79
> +
> +map.insert(QLatin1String(NMQT_SETTING_IP_TUNNEL_CONFIG_MODE), mode);
> +
> map.insert(QLatin1String(NMQT_SETTING_IP_TUNNEL_CONFIG_PATH_MTU_DISCOVERY), 
> pathMtuDiscovery);

Use NetworkManager defines, do not define your own new defines, there is no 
reason for that.

> iptunnelsettingtest.h:2
> +/*
> +Copyright 2016 Jan Grulich 
> +

You should add yourself here.

> CMakeLists.txt:229
>WirelessSetting
> +  IpTunnelSetting
>  

Please add this in alphabetic order.

> connectionsettings.cpp:195
>  addSetting(Setting::Ptr(new Ipv6Setting()));
> +addSetting(Setting::Ptr(new IpTunnelSetting()));
>  break;

IpTunnel setting is not part of Tun connection, it should be completely 
separated connection type.

> iptunnelsetting.cpp:27
> +NetworkManager::IpTunnelSettingPrivate::IpTunnelSettingPrivate()
> +: name(NM_SETTING_IP_TUNNEL_SETTING_NAME)
> +, mode(IpTunnelSetting::DefaultMode)

Coding style, missing indentation. This applies also for lines below.

> iptunnelsetting.h:29
> +
> +#define NMQT_SETTING_IP_TUNNEL_CONFIG_ENCAPSULATION_LIMIT   
> NM_SETTING_IP_TUNNEL_ENCAPSULATION_LIMIT
> +#define NMQT_SETTING_IP_TUNNEL_CONFIG_FLAGS 
> "flags"//NM_SETTING_IP_TUNNEL_FLAGS

There is no reason to create your own defines, use just those 
NM_SETTING_IP_TUNNEL_PROPERTY_NAME.

> iptunnelsetting.h:57
> +typedef QList List;
> +enum Mode { DefaultMode, Ipip, Gre };
> +

There are other modes, they are just not documented in the documentation, but 
can be found in the source code.

See:
typedef enum {
NM_IP_TUNNEL_MODE_UNKNOWN = 0,
NM_IP_TUNNEL_MODE_IPIP= 1,
NM_IP_TUNNEL_MODE_GRE = 2,
NM_IP_TUNNEL_MODE_SIT = 3,
NM_IP_TUNNEL_MODE_ISATAP  = 4,
NM_IP_TUNNEL_MODE_VTI = 5,
NM_IP_TUNNEL_MODE_IP6IP6  = 6,
NM_IP_TUNNEL_MODE_IPIP6   = 7,
NM_IP_TUNNEL_MODE_IP6GRE  = 8,
NM_IP_TUNNEL_MODE_VTI6= 9,
} NMIPTunnelMode;

> iptunnelsetting.h:74
> +
> +void setFlags(quint32 flags);
> +quint32 flags() const;

Maybe turn this into QFlags?

See:
typedef enum { /*< flags, prefix=NM_IP_TUNNEL_FLAG >*/
NM_IP_TUNNEL_FLAG_NONE   = 0x0,
NM_IP_TUNNEL_FLAG_IP6_IGN_ENCAP_LIMIT= 0x1,
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_TCLASS= 0x2,
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FLOWLABEL = 0x4,
NM_IP_TUNNEL_FLAG_IP6_MIP6_DEV   = 0x8,
NM_IP_TUNNEL_FLAG_IP6_RCV_DSCP_COPY  = 0x10,
NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FWMARK= 0x20,
} NMIPTunnelFlags;

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17185

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17204: BrightScript: Allow sub to be unnamed

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c45565159924: BrightScript: Allow sub to be unnamed 
(authored by dlevin, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17204?vs=46371=46375

REVISION DETAIL
  https://phabricator.kde.org/D17204

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17204: BrightScript: Allow sub to be unnamed

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Sure :/ I missed to change author last time, I normally am just 
patching/landing via arc, but that doesn't always contain that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D12761: Allow building kio-nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D12761#367223 , @arojas wrote:
  
  > @asturmlechner can you post that in a new review request? I'll abandon this 
one.
  
  
  Done, this is now in https://phabricator.kde.org/D17205

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D17205: Build kio_nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added reviewers: Dolphin, dfaure, rdieter.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  Since glibc-2.26, cmake skipped over nfs when standalone tirpc
  was installed in tirpc subdir (as done by Debian, Fedora, Arch, Gentoo...)
  
  Use FindTIRPC and make kio_nfs optional that way
  FindTIRPC taken from https://phabricator.kde.org/D12761

TEST PLAN
  Built with libtirpc successfully.

REPOSITORY
  R320 KIO Extras

BRANCH
  kio_nfs

REVISION DETAIL
  https://phabricator.kde.org/D17205

AFFECTED FILES
  CMakeLists.txt
  cmake/FindTIRPC.cmake
  nfs/CMakeLists.txt

To: asturmlechner, #dolphin, dfaure, rdieter
Cc: kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D12761: Allow building kio-nfs against standalone libtirpc

[Antonio Rojas]

arojas added a comment.


  @asturmlechner can you post that in a new review request? I'll abandon this 
one.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D17204: BrightScript: Allow sub to be unnamed

[Daniel Levin]

dlevin added a comment.


  Thanks for the review. Btw, is there any chance to preserve my name/email in 
the final commit?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17204: BrightScript: Allow sub to be unnamed

[Daniel Levin]

dlevin updated this revision to Diff 46371.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17204?vs=46369=46371

REVISION DETAIL
  https://phabricator.kde.org/D17204

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17204: BrightScript: Allow sub to be unnamed

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Looks reasonable, but you need to increase the version.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17204: BrightScript: Allow sub to be unnamed

[Daniel Levin]

dlevin created this revision.
dlevin added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  Subs and functions could be unnamed in closures.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

AFFECTED FILES
  autotests/html/brightscript.brs.html
  autotests/input/brightscript.brs
  autotests/reference/brightscript.brs.ref
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 346 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/346/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 28 Nov 2018 04:28:20 +
 Build duration:
3 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 678.52 KB...][ 84%] Linking CXX executable ../bin/accessmanagertest[ 84%] Built target kfileitemactionstest[ 84%] Building CXX object autotests/CMakeFiles/clipboardupdatertest.dir/clipboardupdatertest_autogen/mocs_compilation.cpp.o[ 84%] Building CXX object autotests/CMakeFiles/kdynamicjobtrackernowidgetstest.dir/kdynamicjobtrackernowidgetstest_autogen/mocs_compilation.cpp.o[ 84%] Built target accessmanagertest[ 85%] Linking CXX executable ../bin/kdynamicjobtrackernowidgetstest[ 85%] Linking CXX shared library ../../bin/libKF5KIOFileWidgets.so[ 85%] Built target kdynamicjobtrackernowidgetstest[ 85%] Linking CXX executable ../bin/clipboardupdatertest[ 85%] Built target clipboardupdatertest[ 85%] Built target KF5KIOFileWidgetsScanning dependencies of target kfilecopytomenutest_autogen[ 85%] Automatic MOC for target kfilecopytomenutest[ 85%] Built target kfilecopytomenutest_autogenScanning dependencies of target kfileplacesviewtest_autogen[ 85%] Automatic MOC for target kfileplacesviewtest[ 85%] Built target kfileplacesviewtest_autogenScanning dependencies of target kdiroperatortest_autogen[ 85%] Automatic MOC for target kdiroperatortest[ 85%] Built target kdiroperatortest_autogenScanning dependencies of target runapplication_autogen[ 85%] Automatic MOC for target runapplication[ 85%] Built target runapplication_autogenScanning dependencies of target kprotocolinfo_dumper_autogen[ 85%] Automatic MOC for target kprotocolinfo_dumper[ 85%] Built target kprotocolinfo_dumper_autogenScanning dependencies of target kdirmodeltest_gui_autogen[ 86%] Automatic MOC for target kdirmodeltest_gui[ 86%] Built target kdirmodeltest_gui_autogenScanning dependencies of target kdirlistertest_gui_autogen[ 87%] Automatic MOC for target kdirlistertest_gui[ 87%] Built target kdirlistertest_gui_autogenScanning dependencies of target kencodingfiledialogtest_gui_autogen[ 87%] Automatic MOC for target kencodingfiledialogtest_gui[ 87%] Built target kencodingfiledialogtest_gui_autogenScanning dependencies of target kfilewidgettest_gui_autogen[ 87%] Automatic MOC for target kfilewidgettest_gui[ 87%] Built target kfilewidgettest_gui_autogenScanning dependencies of target kopenwithtest_autogen[ 87%] Automatic MOC for target kopenwithtest[ 87%] Built target kopenwithtest_autogenScanning dependencies of target kruntest_autogen[ 87%] Automatic MOC for target kruntest[ 87%] Built target kruntest_autogenScanning dependencies of target kioslavetest_autogen[ 87%] Automatic MOC for target kioslavetest[ 87%] Built target kioslavetest_autogenScanning dependencies of target kfilecustomdialogtest_gui_autogen[ 87%] Automatic MOC for target kfilecustomdialogtest_gui[ 87%] Built target kfilecustomdialogtest_gui_autogenScanning dependencies of target udsentrybenchmark_autogen[ 87%] Automatic MOC for target udsentrybenchmark[ 87%] Built target udsentrybenchmark_autogenScanning dependencies of target kurlrequestertest_gui_autogen[ 87%] Automatic MOC for target kurlrequestertest_gui[ 87%] Built target kurlrequestertest_gui_autogenScanning dependencies of target kurlnavigatortest_gui_autogen[ 87%] Automatic MOC for target kurlnavigatortest_gui[ 87%] Built target kurlnavigatortest_gui_autogenScanning dependencies of target kpropertiesdialogtest_autogen[ 88%] Automatic MOC for target kpropertiesdialogtest[ 88%] Built target kpropertiesdialogtest_autogenScanning dependencies of target getalltest_autogen[ 88%] Automatic MOC for target getalltest[ 88%] Built target getalltest_autogenScanning dependencies of target listrecursivetest_autogen[ 88%] Automatic MOC for target listrecursivetest[ 88%] Built target listrecursivetest_autogenScanning dependencies of target kmountpoint_debug_autogen[ 88%] Automatic MOC for target kmountpoint_debug[ 88%] Built target kmountpoint_debug_autogenScanning dependencies of target ksycocaupdatetest_autogen[ 89%] Automatic MOC for target ksycocaupdatetest[ 89%] Built target ksycocaupdatetest_autogenScanning dependencies of target previewtest_autogen[ 89%] Automatic MOC for target previewtest[ 89%] Built target previewtest_autogenScanning dependencies of target listjobtest_autogen[ 89%] Automatic MOC for target listjobtest[ 89%] Built target listjobtest_autogenScanning dependencies of target kionetrctest_autogen[ 89%] Automatic MOC for target kionetrctest[ 89%] Built target kionetrctest_autogenScanning dependencies of target kfilecopytomenutest[ 89%] Building CXX object autotests/CMakeFiles/kfilecopytomenutest.dir/kfilecopytomenutest.cpp.o[ 89%] Building CXX object autotests/CMakeFiles/kfilecopytomenutest.dir/kfilecopytomenutest_autogen/mocs_compilation.cpp.o[ 90%] Linking CXX executable 

D17200: Avoid writing unchanged data to terms dbs

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense, thanks!

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17200

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D12761: Allow building kio-nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in CMakeLists.txt:4
> Any solution is fine however, we now patched ours kdebase4-runtime package to 
> disable kio-nfs completely. Pick the solution you prefer.

Thanks, your FindTIRPC works for me. This is what I came up with using it: 
https://paste.pound-python.org/show/zgu3uRLCJzKqXj97mL5b/

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Ping! #VDG , #dolphin 
, or #frameworks 
 folks?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, 
andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, 
davidedmundson, ltoscano, #konqueror, alexde, sourabhboss, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D12761: Allow building kio-nfs against standalone libtirpc

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in CMakeLists.txt:4
> I added the solution we use in openSUSE: https://paste.kde.org/pscug8tik

Any solution is fine however, we now patched ours kdebase4-runtime package to 
disable kio-nfs completely. Pick the solution you prefer.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D12761: Allow building kio-nfs against standalone libtirpc

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> asturmlechner wrote in CMakeLists.txt:4
> Could you suggest an alternative? Gentoo shares a similarity with Arch there, 
> because otherwise libtirpc could collide with older versions of glibc.

I added the solution we use in openSUSE: https://paste.kde.org/pscug8tik

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D12761: Allow building kio-nfs against standalone libtirpc

[Andreas Sturmlechner]

asturmlechner added inline comments.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.

INLINE COMMENTS

> CMakeLists.txt:175
> +   add_feature_info("NFS kioslave" RPC_H_DIR "The RPC library is needed to 
> build the NFS kioslave")
> +   if(RPC_H_DIR)
>   add_subdirectory( nfs )

I would prefer a real build option instead of automagic here, and the detection 
below that conditional. I'm aware that's more than what we have right now.

> cgiboudeaux wrote in CMakeLists.txt:4
> This won't work for openSUSE:  the tirpc headers are installed in 
> /usr/include directly.

Could you suggest an alternative? Gentoo shares a similarity with Arch there, 
because otherwise libtirpc could collide with older versions of glibc.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D12761

To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux
Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D17197: Reserve space in pending operations vector

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:707beb19da7c: Reserve space in pending operations vector 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17197?vs=46347=46361

REVISION DETAIL
  https://phabricator.kde.org/D17197

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, davidedmundson
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[TheAssassin]

TheAssassin added a comment.


  Yep, it's really nice, thanks @kossebau!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17197: Reserve space in pending operations vector

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17197

To: bruns, #baloo, #frameworks, ngraham, poboiko, davidedmundson
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the nice new icon!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e3266db59d2f: Add icons for 
application-vnd.appimage/x-iso9660-appimage (authored by kossebau).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17086?vs=46231=46359

REVISION DETAIL
  https://phabricator.kde.org/D17086

AFFECTED FILES
  icons/mimetypes/16/application-vnd.appimage.svg
  icons/mimetypes/16/application-x-iso9660-appimage.svg
  icons/mimetypes/22/application-vnd.appimage.svg
  icons/mimetypes/22/application-x-iso9660-appimage.svg
  icons/mimetypes/32/application-vnd.appimage.svg
  icons/mimetypes/32/application-x-iso9660-appimage.svg
  icons/mimetypes/64/application-vnd.appimage.svg
  icons/mimetypes/64/application-x-iso9660-appimage.svg

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for feedback/review :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  addappimageiconv2

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17200: Avoid writing unchanged data to terms dbs

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The termlist returned from replaceTerms may be identical to the current
  DB contents. Avoid blowing up the write transaction by commits which are
  actually noops. CPU cycles are cheaper than disk writes and flushes.
  
  Comparing old and new terms is typically cheap (adding or removing files
  changes the term list size). File updates often do not change the terms
  for all DBs, e.g. a rename changes the ctime and also triggers an update
  of the XAttr entry and vice versa. Appending to a file or doing any other
  action which changes the mtime triggers a DocumentTermsDB update, while
  the set of unique terms may be unchanged.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17200

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17199: Add unittest to check if commiting the same change twice works

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The fileindexer is only aware some terms/properties *may* have changed,
  but may also submit a document again which is identical to the current
  DB contents.
  Ideally, the engine should catch these cases and remove any noops from
  the transaction.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17199

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17198: Add unit test for position DB

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  This increases test coverage significantly:
  
  - the PositionDB was completely untested
  - adding of new documents for existing terms in the PostingDB was also 
untested

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17198

AFFECTED FILES
  autotests/integration/dbstate.h
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17197: Reserve space in pending operations vector

[Stefan Brüns]

bruns edited the test plan for this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17197

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17197: Reserve space in pending operations vector

[Stefan Brüns]

bruns updated this revision to Diff 46347.
bruns added a comment.


  also reverse in replaceTerms

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17197?vs=46346=46347

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17197

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17197: Reserve space in pending operations vector

[Stefan Brüns]

bruns created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17197

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17188: Notification portal: support pixmaps in notifications

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:8ae44d819bbb: Notification portal: support pixmaps in 
notifications (authored by jgrulich).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17188?vs=46331=46335

REVISION DETAIL
  https://phabricator.kde.org/D17188

AFFECTED FILES
  src/notifybyflatpak.cpp
  src/notifybyflatpak.h

To: jgrulich, broulik, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17195: Avoid constantly increasing Qt event queue in KIO slaves

[David Edmundson]

davidedmundson edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17195

To: davidedmundson, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17195: Avoid constantly increasing Qt event queue in KIO slaves

[Nathaniel Graham]

ngraham added a comment.


  Wow, awesome!
  
  Might this huge improvement in small file copy speed be enough to call it a 
definitive fix for https://bugs.kde.org/show_bug.cgi?id=342056?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17195

To: davidedmundson, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17195: Avoid constantly increasing Qt event queue in KIO slaves

[David Edmundson]

davidedmundson edited the summary of this revision.
davidedmundson edited the test plan for this revision.
davidedmundson added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17195

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17195: Avoid constantly increasing Qt event queue in KIO slaves

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Connection is used in two places SlaveBase (file.so etc) and
  SlaveInterface (dolphin etc).
  
  In SlaveInterface it operates in a normal event-driven Qt way with
  signals when data is ready. If data is ready and a client reads one
  line, it emitted dataReady again next event loop to tell the client to
  read the next line.
  
  SlaveBase has a custom event loop. We're either polling the task queue
  or blocking for a more low level signal, we don't ever process the Qt
  event queue.
  The one exception is  QCoreApplication::sendPostedEvents(nullptr,
  QEvent::DeferredDelete); which we called manually after we've dispatched
  each task.
  
  If we're copying a lot of files, SlaveBase reads the first command
  there's still many commands left so in the SlaveBase we post an event,
  which won't get used, into the queue.
  
  This is a problem as now when we call sendPostedEvents(DefferedDelete)
  qApp itterates through the list of pending events in linear time,
  without clearing anything. After each command we're itterating through a
  bigger and bigger list until we're spending all our CPU time here.
  
  This patch splits Connection to have distinct modes for use by SlaveBase
  and SlaveInterface as SlaveBase wasn't going to ever run those queued
  events anyway.
  
  Copying 1 million 10 byte text files on my machine:
  Before: 14 hours
  After: 10 minutes

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17195

AFFECTED FILES
  src/core/connection.cpp
  src/core/connection_p.h
  src/core/slavebase.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17188: Notification portal: support pixmaps in notifications

[Jan Grulich]

jgrulich updated this revision to Diff 46331.
jgrulich added a comment.


  Move definition of PortalIcon structure out from the header file

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17188?vs=46318=46331

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17188

AFFECTED FILES
  src/notifybyflatpak.cpp
  src/notifybyflatpak.h

To: jgrulich, broulik, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

[Christoph Cullmann]

cullmann added a comment.


  For: It could make sense to actually exert some effort to support it properly.
  
  There seems to be no interest to spend effort on by anybody.
  Therefore I would say we shall close this and D5803 
.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff
Cc: kossebau, cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff, 
kwrite-devel, hase, michaelh, ngraham, bruns, demsking, sars

D17178: Don't ask for confimation when reloading

[Christoph Cullmann]

cullmann added a comment.


  I don't think the change is a bad idea, thought should not the
  
delete m_modOnHdHandler;
  
  stay, to avoid we have the pending message visible?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17178

To: nicolasfella, #kate, ngraham
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17178: Don't ask for confimation when reloading

[Christoph Cullmann]

cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17178

To: nicolasfella, #kate, ngraham, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17013: Show menu bar, how to re-enable, common shortcut dialog

[loh tar]

loh.tar added a comment.


  Hi, I accidentally went by.
  How about to add an icon to some (main) toolbar, if any is present? 
  That would the need to show such a message reduce to cases where no tool bar 
is available. If that icon was added, and not already there, could that pop up 
a small tool tip to get some attention.
  A quick search here in my browser give no hit for "isVisible". There should 
be no need to show such message when the action is somewhere seen.
  
  Sorry for the noise, if I should completely wrong :-)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: loh.tar, aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17193: KateViewInternal: Remove unneeded functions

[Christoph Cullmann]

cullmann added a comment.


  Simplifications in that way are ok in my eye, given the extra level of 
functions have no gain. (not even encapsulation)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17193

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17188: Notification portal: support pixmaps in notifications

[Jan Grulich]

jgrulich added a comment.


  In D17188#366802 , @apol wrote:
  
  > Maybe it would make sense to rename this file to `notifybyportal.cpp` (and 
class..)
  
  
  I can rename it in a different review. This was done a long time ago, when 
only Flatpak was using portals, now when also Snap can use them, it makes more 
sense to have more general name.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17188

To: jgrulich, broulik, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17193: KateViewInternal: Remove unneeded functions

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

TEST PLAN
  This is only an example snippet to show that obviously something could be 
simplified.
  
  Let me know if it is desired to go further or if there is a good reason why 
it is so complicated. 
  Depend of your answer I will enhance this patch or abandon.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17193

AFFECTED FILES
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17190: Add level api from Kirigami.Heading

[Marco Martin]

mart added a comment.


  In D17190#366854 , @ngraham wrote:
  
  > In those screenshots, "< Fonts" is basically just a named back button. 
Should it really have the same size and visual weight as the active KCMs' title?
  
  
  I think so, it's the title of what the underlying listview is about, which is 
"the other kcm you can open now" which should have the same weight as what the 
current kcm is
  
  that's for D17192  btw

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

[Nathaniel Graham]

ngraham added a comment.


  In D17190#366840 , @mart wrote:
  
  > F6443889: image.png 
  >
  > with a QWidget KCM
  >  F6443893: image.png 
  
  
  In those screenshots, "< Fonts" is basically just a named back button. Should 
it really have the same size and visual weight as the active KCMs' title?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17191: Perfect alignment between QML and QWidget KCM titles

[Marco Martin]

mart added a comment.


  QML KCM:
  F6443898: image.png 
  
  QWidget KCM:
  F6443900: image.png 

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D17191

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17191: Perfect alignment between QML and QWidget KCM titles

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  uses spacing metrics synced with systemsettings to have
  the title perfectly aligned with the subcategory title column
  and the title of QWidget kcms
  depends from D17190 

TEST PLAN
  loaded a lot of kcms

REPOSITORY
  R295 KCMUtils

BRANCH
  phab/perfectalignment

REVISION DETAIL
  https://phabricator.kde.org/D17191

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli updated this revision to Diff 46321.
lsartorelli added a comment.


  Added @since and @author in the header documentation

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17013?vs=46248=46321

REVISION DETAIL
  https://phabricator.kde.org/D17013

AFFECTED FILES
  src/CMakeLists.txt
  src/ktoggleshowmenubaraction.cpp
  src/ktoggleshowmenubaraction.h

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17190: Add level api from Kirigami.Heading

[Marco Martin]

mart added a comment.


  F6443889: image.png 
  
  with a QWidget KCM
  F6443893: image.png 

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17190: Add level api from Kirigami.Heading

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  add a "level" api that has the same meaning as in the Kirigami Heading 
component,
  This makes easier for QWidget apps to follow the typographi HIG at
  https://www.my-scratch.de/HIG/style/typography.html
  QWidget and QML apps will look more similar and config dialogs
  the same.
  together other diffs introduces more consistency within SystemSettings
  between QWidget and QML based kcms

TEST PLAN
  ran a lot of config dialogs

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  phab/heading

REVISION DETAIL
  https://phabricator.kde.org/D17190

AFFECTED FILES
  src/ktitlewidget.cpp
  src/ktitlewidget.h

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17188: Notification portal: support pixmaps in notifications

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> notifybyflatpak.h:40
>  public:
> +struct PortalIcon {
> +QString str;

Does this need to be in the header file?

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17188

To: jgrulich, broulik, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17188: Notification portal: support pixmaps in notifications

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Maybe it would make sense to rename this file to `notifybyportal.cpp` (and 
class..)

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17188

To: jgrulich, broulik, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17188: Notification portal: support pixmaps in notifications

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  From portal documentation:
  The portal only accepts serialized GThemedIcon and GBytesIcons. Both of
  these have the form (sv). For themed icons, the string is "themed",
  and the value is an array of strings containing the icon names.
  For bytes icons, the string is "bytes", and the value is a bytestring
  containing the icon data in png, jpeg or svg form. For historical
  reasons, it is also possible to send a simple string for themed
  icons with a single icon name.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17188

AFFECTED FILES
  src/notifybyflatpak.cpp
  src/notifybyflatpak.h

To: jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17188: Notification portal: support pixmaps in notifications

[Jan Grulich]

jgrulich added a reviewer: broulik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17188

To: jgrulich, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17185: Added ip-tunnel settings

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added ip-tunnel settings according to 
https://developer.gnome.org/NetworkManager/stable/settings-ip-tunnel.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17185

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/iptunnelsettingtest.cpp
  autotests/settings/iptunnelsettingtest.h
  src/CMakeLists.txt
  src/settings/connectionsettings.cpp
  src/settings/iptunnelsetting.cpp
  src/settings/iptunnelsetting.h
  src/settings/iptunnelsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[TheAssassin]

TheAssassin accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  addappimageiconv2

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham, TheAssassin
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns