D15999: Add icons with added background to system.svgz

2018-11-30 Thread Phil Stefan
pstefan added a comment.


  In D15999#369135 , @ndavis wrote:
  
  > In D15999#369134 , @pstefan 
wrote:
  >
  > > In D15999#369132 , @ndavis 
wrote:
  > >
  > > > In D15999#369131 , @pstefan 
wrote:
  > > >
  > > > > In D15999#369066 , @ndavis 
wrote:
  > > > >
  > > > > > With colorschemes applied, these will be your colors:
  > > > > >
  > > > > >   | Ring| Background | Symbol  |
  > > > > >   | --- | -- | --- |
  > > > > >Breeze | #fcfcfc | #eff0f1| #232627 |
  > > > > >   Breeze Dark | #232629 | #31363b| #eff0f1 |
  > > > > >
  > > > >
  > > > >
  > > > > Why would the ring and the background have different colors? They 
both have the same class attribute.
  > > >
  > > >
  > > > I must have had a slightly older version of the patch because I swear I 
saw the ring using `ViewBackground` and the background using `Background`. I 
downloaded the patch again and everything looks fine there. `go.svgz` still has 
`#31363b` and `#232629` as the default colors for the background and ring. Is 
this intentional?
  > >
  > >
  > > They do not have a default color for me.
  >
  >
  > Here's what I'm seeing: F6449126: Screenshot_20181201_013830.png 

  
  
  Ahh, now I get what you mean. Yes that was intentional. But only insofar as 
to check if I had set the class attributes correctly. I will change it when I 
get home.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D15999: Add icons with added background to system.svgz

2018-11-30 Thread Noah Davis
ndavis added a comment.


  In D15999#369134 , @pstefan wrote:
  
  > In D15999#369132 , @ndavis wrote:
  >
  > > In D15999#369131 , @pstefan 
wrote:
  > >
  > > > In D15999#369066 , @ndavis 
wrote:
  > > >
  > > > > With colorschemes applied, these will be your colors:
  > > > >
  > > > >   | Ring| Background | Symbol  |
  > > > >   | --- | -- | --- |
  > > > >Breeze | #fcfcfc | #eff0f1| #232627 |
  > > > >   Breeze Dark | #232629 | #31363b| #eff0f1 |
  > > > >
  > > >
  > > >
  > > > Why would the ring and the background have different colors? They both 
have the same class attribute.
  > >
  > >
  > > I must have had a slightly older version of the patch because I swear I 
saw the ring using `ViewBackground` and the background using `Background`. I 
downloaded the patch again and everything looks fine there. `go.svgz` still has 
`#31363b` and `#232629` as the default colors for the background and ring. Is 
this intentional?
  >
  >
  > They do not have a default color for me.
  
  
  Here's what I'm seeing: F6449126: Screenshot_20181201_013830.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D15999: Add icons with added background to system.svgz

2018-11-30 Thread Phil Stefan
pstefan added a comment.


  In D15999#369132 , @ndavis wrote:
  
  > In D15999#369131 , @pstefan 
wrote:
  >
  > > In D15999#369066 , @ndavis 
wrote:
  > >
  > > > With colorschemes applied, these will be your colors:
  > > >
  > > >   | Ring| Background | Symbol  |
  > > >   | --- | -- | --- |
  > > >Breeze | #fcfcfc | #eff0f1| #232627 |
  > > >   Breeze Dark | #232629 | #31363b| #eff0f1 |
  > > >
  > >
  > >
  > > Why would the ring and the background have different colors? They both 
have the same class attribute.
  >
  >
  > I must have had a slightly older version of the patch because I swear I saw 
the ring using `ViewBackground` and the background using `Background`. I 
downloaded the patch again and everything looks fine there. `go.svgz` still has 
`#31363b` and `#232629` as the default colors for the background and ring. Is 
this intentional?
  
  
  They do not have a default color for me.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread loh tar
loh.tar added a comment.


  >> @cfeck wrote:
  > 
  > It looked strange on the list of names of all committers.
  
  A look at your page indicates that you are doing some public relations? 
Should you copy some data from an auto generated list, feel free to 
remove me.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: cfeck, smartins, kde-frameworks-devel, michaelh, ngraham, bruns


D15999: Add icons with added background to system.svgz

2018-11-30 Thread Noah Davis
ndavis added a comment.


  In D15999#369131 , @pstefan wrote:
  
  > In D15999#369066 , @ndavis wrote:
  >
  > > With colorschemes applied, these will be your colors:
  > >
  > >   | Ring| Background | Symbol  |
  > >   | --- | -- | --- |
  > >Breeze | #fcfcfc | #eff0f1| #232627 |
  > >   Breeze Dark | #232629 | #31363b| #eff0f1 |
  > >
  >
  >
  > Why would the ring and the background have different colors? They both have 
the same class attribute.
  
  
  I must have had a slightly older version of the patch because I swear I saw 
the ring using `ViewBackground` and the background using `Background`. I 
downloaded the patch again and everything looks fine there. `go.svgz` still has 
`#31363b` and `#232629` as the default colors for the background and ring. Is 
this intentional?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D15999: Add icons with added background to system.svgz

2018-11-30 Thread Phil Stefan
pstefan added a comment.


  In D15999#369066 , @ndavis wrote:
  
  > With colorschemes applied, these will be your colors:
  >
  >   | Ring| Background | Symbol  |
  >   | --- | -- | --- |
  >Breeze | #fcfcfc | #eff0f1| #232627 |
  >   Breeze Dark | #232629 | #31363b| #eff0f1 |
  >
  
  
  Why would the ring and the background have different colors? They both have 
the same class attribute.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D17274: Remove duplicated code for rating property

2018-11-30 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17274

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17272: Fix searches for rating 10 (5 stars)

2018-11-30 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LOL whoops! Nice catch. Works great.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17272

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17273: Extend unit tests to check comparisons of multi-digit numeric properties

2018-11-30 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17273

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16617: fix extraction of GPS altitude for exif data

2018-11-30 Thread Stefan Brüns
bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> exiv2extractor.cpp:217
>  
>  if (altitude) {
>  result->add(Property::PhotoGpsAltitude, altitude);

This is bogus, why am I not allowed to take photos at sea level? Or in 
Greenwhich, at the Equator?

Invalid data should **not** be signaled by 0.0

> astippich wrote in exiv2extractor.cpp:285
> true, but why not use the converted value directly? Otherwise the conversion 
> would have to be made manually by dividing, see fetchGpsDouble()

You are correct, the implicit conversions done by Exiv2 are easy to miss.

> exiv2extractor.cpp:294
> +}
> +return alt;
> +}

You could return `std::numeric_limits::quiet_NaN()` here for the error 
case.

REPOSITORY
  R286 KFileMetaData

BRANCH
  exif_gps_altitude

REVISION DETAIL
  https://phabricator.kde.org/D16617

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D17272: Fix searches for rating 10 (5 stars)

2018-11-30 Thread Stefan Brüns
bruns added a dependent revision: D17274: Remove duplicated code for rating 
property.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17272

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17274: Remove duplicated code for rating property

2018-11-30 Thread Stefan Brüns
bruns added a dependency: D17272: Fix searches for rating 10 (5 stars).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17274

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17274: Remove duplicated code for rating property

2018-11-30 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The rating can be handled like any other integer valued property, i.e.
  using the generic property<->prefix mapping.

TEST PLAN
  $> baloosearch 'rating>=5'

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17274

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17272: Fix searches for rating 10 (5 stars)

2018-11-30 Thread Stefan Brüns
bruns updated this revision to Diff 46593.
bruns added a comment.


  Use qlonglong for comparing numeric properties

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17272?vs=46591=46593

REVISION DETAIL
  https://phabricator.kde.org/D17272

AFFECTED FILES
  autotests/unit/engine/postingdbtest.cpp
  src/engine/postingdb.cpp
  src/engine/postingdb.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/lib/searchstore.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17273: Extend unit tests to check comparisons of multi-digit numeric properties

2018-11-30 Thread Stefan Brüns
bruns added a dependency: D17272: Fix searches for rating 10 (5 stars).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17273

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17272: Fix searches for rating 10 (5 stars)

2018-11-30 Thread Stefan Brüns
bruns added a dependent revision: D17273: Extend unit tests to check 
comparisons of multi-digit numeric properties.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17272

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17273: Extend unit tests to check comparisons of multi-digit numeric properties

2018-11-30 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The unit test only checked for single digit values, and failed to check
  for multi digit values. One prominent example is Rating=10, but this
  also affected any other numeric comparison.

TEST PLAN
  $ ctest
  $ baloosearch 'linecount>=100'
  $ baloosearch 'rating>9'

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17273

AFFECTED FILES
  autotests/unit/engine/postingdbtest.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D17272: Fix searches for rating 10 (5 stars)

2018-11-30 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The comparator callback/lambda used a string comparision, which returned
  the wrong documents, as "2" > "10", and "10" < "9", i.e. selecting the
  "Highest rating" in dolphin returned all documents with a rating of 2
  or higher.
  
  Convert the numeric suffix of the rating term ("R2 
", "R10 
", ...) to
  an integer value and use it for comparision.
  
  BUG: 357960

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17272

AFFECTED FILES
  autotests/unit/engine/postingdbtest.cpp
  src/engine/postingdb.cpp
  src/engine/postingdb.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/lib/searchstore.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D15999: Add icons with added background to system.svgz

2018-11-30 Thread Noah Davis
ndavis added a comment.


  With colorschemes applied, these will be your colors:
  
| Ring| Background | Symbol  |
| --- | -- | --- |
 Breeze | #fcfcfc | #eff0f1| #232627 |
Breeze Dark | #232629 | #31363b| #eff0f1 |

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

2018-11-30 Thread gregormi
gregormi added inline comments.

INLINE COMMENTS

> kurlnavigatorbutton.cpp:414
> +url = KIO::upUrl(m_url);
> +} else if ((m_url.scheme() == QLatin1String("tar")) || (m_url.scheme() 
> == QLatin1String("zip"))) {
> +// We are in an archive, check whether the subdir we have to list is 
> part of the archive

When I click a zip file I get this in the URL bar:

  krarc:/home/gregor/Downloads/kfk_10p.zip/

This could mean that "krarc" should be added to this if statement.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17270

To: thsurrel, #frameworks
Cc: gregormi, kde-frameworks-devel, michaelh, ngraham, bruns


D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

2018-11-30 Thread Thomas Surrel
thsurrel updated this revision to Diff 46589.
thsurrel added a comment.


  Fix deleted empty line.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17270?vs=46588=46589

BRANCH
  arc_urlnavigatorbutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17270

AFFECTED FILES
  src/filewidgets/kurlnavigatorbutton.cpp

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

2018-11-30 Thread Thomas Surrel
thsurrel created this revision.
thsurrel added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  When we are navigating in an archive, trying to use the navigator
  buttons to list the subdir of a parent folder of the archive was
  not working because the protocol would still be 'tar' instead of
  'file'.

TEST PLAN
  In Dolphin, click on a zip file. Then in the URL bar (breadcrumb
  mode), try to list the sub directories of the folder containing
  that zip file by clicking on the litlle arrow on the right of the
  folder's name.

REPOSITORY
  R241 KIO

BRANCH
  arc_urlnavigatorbutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17270

AFFECTED FILES
  src/filewidgets/kurlnavigatorbutton.cpp

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread loh tar
loh.tar added a comment.


  >   ..but I cannot remember we didn't ask contributors for their real name 
for contributions.
  
  Um, what? I was asked. I hope it's ok as it is.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: cfeck, smartins, kde-frameworks-devel, michaelh, ngraham, bruns


D17220: Improve symbolism for off and muted status icon

2018-11-30 Thread TrickyRicky
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns


D17220: Improve symbolism for off and muted status icon

2018-11-30 Thread TrickyRicky
trickyricky26 updated this revision to Diff 46587.
trickyricky26 added a comment.


  - enlarge muted symbol in 22px microphone-sensitivity-muted icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17220?vs=46577=46587

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

AFFECTED FILES
  icons-dark/status/16/audio-off.svg
  icons-dark/status/16/audio-volume-low.svg
  icons-dark/status/16/audio-volume-medium.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/camera-off.svg
  icons-dark/status/16/mic-off.svg
  icons-dark/status/16/microphone-sensitivity-low.svg
  icons-dark/status/16/microphone-sensitivity-medium.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-off.svg
  icons-dark/status/22/audio-on.svg
  icons-dark/status/22/audio-ready.svg
  icons-dark/status/22/audio-volume-low.svg
  icons-dark/status/22/audio-volume-medium.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/camera-off.svg
  icons-dark/status/22/input-touchpad-off.svg
  icons-dark/status/22/mic-off.svg
  icons-dark/status/22/microphone-sensitivity-low.svg
  icons-dark/status/22/microphone-sensitivity-medium.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/status/16/audio-off.svg
  icons/status/16/audio-volume-low.svg
  icons/status/16/audio-volume-medium.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/camera-off.svg
  icons/status/16/mic-off.svg
  icons/status/16/microphone-sensitivity-low.svg
  icons/status/16/microphone-sensitivity-medium.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-off.svg
  icons/status/22/audio-on.svg
  icons/status/22/audio-ready.svg
  icons/status/22/audio-volume-low.svg
  icons/status/22/audio-volume-medium.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/camera-off.svg
  icons/status/22/input-touchpad-off.svg
  icons/status/22/mic-off.svg
  icons/status/22/microphone-sensitivity-low.svg
  icons/status/22/microphone-sensitivity-medium.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns


D17220: Improve symbolism for off and muted status icon

2018-11-30 Thread TrickyRicky
trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  I will make changes to the muted symbol in the microphone icons as well

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns


D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread Christoph Feck
cfeck added a comment.


  I do not know if there is a written rule that we require commits with real 
names (for legal reasons), but I cannot remember we didn't ask contributors for 
their real name for contributions.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: cfeck, smartins, kde-frameworks-devel, michaelh, ngraham, bruns


D17204: BrightScript: Allow sub to be unnamed

2018-11-30 Thread Daniel Levin
dlevin added a comment.


  This language does not have folding test. I did not provide validation for it 
before. Should I do that?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17269: Fix build failure in neon by adding QVariant include.

2018-11-30 Thread Scarlett Clark
scarlettclark updated this revision to Diff 46584.
scarlettclark added a comment.


  Remove class QVariant as per bruns review comment.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17269?vs=46581=46584

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17269

AFFECTED FILES
  src/lib/kaboutdata.h

To: scarlettclark, apol, mart, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh


D15999: Add icons with added background to system.svgz

2018-11-30 Thread Phil Stefan
pstefan updated this revision to Diff 46583.
pstefan added a comment.


  - Remove hardcoded background color; Switch background to 
"ColorScheme-ViewBackground"
  - Reintroduce the outline border on top of the background. Opacity set to 0.3
  - Removed superfluous entries in the style properties

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=45137=46583

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D17245: Add string formatting function to property info

2018-11-30 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> astippich wrote in formatstrings.cpp:83
> How about using the descriptions from D15503 
> , which are also consistent with digiKam 
> and Gwenview? The best solution is probably to make D15503 
>  work, but this is out of scope for this 
> revision. And a text is still better than a plain number.

IMHO thats not better at all - what does "top, left" refer to? And whats the 
difference to "left, top"?

Every orientation save "normal" and "rotated 180" is ambiguous without further 
description. It is of no interest for most users, even serious photographers, 
as it is a technical **implementation** detail. Creation times, aperture, 
exposure time ... are useful for users.

So we should hide it by default, and for the 0.1% interested in it we can give 
a description they can lookup themselves, e.g. "Rotated 90° CCW (6)"

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D17269: Fix build failure in neon by adding QVariant include.

2018-11-30 Thread Stefan Brüns
bruns added a comment.


  The right reference here is likely https://phabricator.kde.org/D17078

INLINE COMMENTS

> kaboutdata.h:38
>  class QJsonObject;
>  class QVariant;
>  class KAboutData;

No longer needed

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17269

To: scarlettclark, apol, mart, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh


KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.9 - Build # 106 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.9/106/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Nov 2018 18:30:17 +
 Build duration:
2 min 14 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5Purpose_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)22%
(477/2210)19%
(219/1132)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(150/155)58%
(61/106)src100%
(8/8)100%
(8/8)74%
(243/327)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%

D17269: Fix build failure in neon by adding QVariant include.

2018-11-30 Thread Aleix Pol Gonzalez
apol accepted this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17269

To: scarlettclark, apol, mart, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh


D17269: Fix build failure in neon by adding QVariant include.

2018-11-30 Thread Aleix Pol Gonzalez
apol added a comment.


  Thanks!

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17269

To: scarlettclark, apol, mart, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh


KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.9 - Build # 105 - Unstable!

2018-11-30 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.9/105/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Nov 2018 18:20:42 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report13%
(3/23)19%
(10/53)19%
(10/53)17%
(383/2205)17%
(198/1132)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests50%
(1/2)50%
(1/2)75%
(116/155)46%
(49/106)src100%
(8/8)100%
(8/8)73%
(238/327)58%
(121/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/49)0%

D17269: Fix build failure in neon by adding QVariant include.

2018-11-30 Thread Stefan Brüns
bruns added a comment.


  This should reference the appropriate Qt or KF5 version which removed the 
implicit QVariant include.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17269

To: scarlettclark, apol, mart, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh


D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread loh tar
loh.tar added a comment.


  Well, neither of that. My "online me" is loh.tar but that was rejected by 
Phabricator, so the dot had to go. Lastly used ngraham uppercase letters, what 
looks even more strange to me :-)
  
  Should you intend to commit this, thanks in advance! May you look at D17055 
 too?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: cfeck, smartins, kde-frameworks-devel, michaelh, ngraham, bruns


D17269: Fix build failure in neon by adding QVariant include.

2018-11-30 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fixes it for me.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17269

To: scarlettclark, apol, mart, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D17269: Fix build failure in neon by adding QVariant include.

2018-11-30 Thread Nathaniel Graham
ngraham added reviewers: apol, mart.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17269

To: scarlettclark, apol, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17269: Fix build failure in neon by adding QVariant include.

2018-11-30 Thread Scarlett Clark
scarlettclark created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
scarlettclark requested review of this revision.

REVISION SUMMARY
  Build failed with error: invalid use of incomplete type ‘class QVariant’
  By adding #include  it now builds.

TEST PLAN
  Builds successfully on neon.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17269

AFFECTED FILES
  src/lib/kaboutdata.h

To: scarlettclark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17220: Improve symbolism for off and muted status icon

2018-11-30 Thread TrickyRicky
trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns


D17220: Improve symbolism for off and muted status icon

2018-11-30 Thread TrickyRicky
trickyricky26 updated this revision to Diff 46577.
trickyricky26 added a comment.


  - Lower opacity of inactive sound waves; improve sound muted icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17220?vs=46504=46577

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

AFFECTED FILES
  icons-dark/status/16/audio-off.svg
  icons-dark/status/16/audio-volume-low.svg
  icons-dark/status/16/audio-volume-medium.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/camera-off.svg
  icons-dark/status/16/mic-off.svg
  icons-dark/status/16/microphone-sensitivity-low.svg
  icons-dark/status/16/microphone-sensitivity-medium.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-off.svg
  icons-dark/status/22/audio-on.svg
  icons-dark/status/22/audio-ready.svg
  icons-dark/status/22/audio-volume-low.svg
  icons-dark/status/22/audio-volume-medium.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/camera-off.svg
  icons-dark/status/22/input-touchpad-off.svg
  icons-dark/status/22/mic-off.svg
  icons-dark/status/22/microphone-sensitivity-low.svg
  icons-dark/status/22/microphone-sensitivity-medium.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/status/16/audio-off.svg
  icons/status/16/audio-volume-low.svg
  icons/status/16/audio-volume-medium.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/camera-off.svg
  icons/status/16/mic-off.svg
  icons/status/16/microphone-sensitivity-low.svg
  icons/status/16/microphone-sensitivity-medium.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-off.svg
  icons/status/22/audio-on.svg
  icons/status/22/audio-ready.svg
  icons/status/22/audio-volume-low.svg
  icons/status/22/audio-volume-medium.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/camera-off.svg
  icons/status/22/input-touchpad-off.svg
  icons/status/22/mic-off.svg
  icons/status/22/microphone-sensitivity-low.svg
  icons/status/22/microphone-sensitivity-medium.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns


D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread Christoph Feck
cfeck added a comment.


  Is your full name really "loh tar", spelled with lower case letters? It 
looked strange on the list of names of all committers.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: cfeck, smartins, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.10 - Build # 377 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.10/377/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Nov 2018 16:46:47 +
 Build duration:
4 min 56 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5Kirigami2_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/17)0%
(0/17)0%
(0/1309)0%
(0/915)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/10)0%
(0/10)0%
(0/790)0%
(0/566)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/511)0%
(0/349)

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.11 - Build # 193 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.11/193/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 30 Nov 2018 16:46:47 +
 Build duration:
2 min 22 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.9 - Build # 293 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.9/293/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Nov 2018 16:46:47 +
 Build duration:
1 min 40 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5Kirigami2_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/17)0%
(0/17)0%
(0/1309)0%
(0/915)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/10)0%
(0/10)0%
(0/790)0%
(0/566)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/511)0%
(0/349)

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.11 - Build # 112 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.11/112/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 30 Nov 2018 16:46:47 +
 Build duration:
2 min 11 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.11 - Build # 103 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.11/103/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 30 Nov 2018 16:46:47 +
 Build duration:
1 min 3 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.10 - Build # 376 - Failure!

2018-11-30 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.10/376/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Nov 2018 16:31:57 +
 Build duration:
2 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 102.93 KB...] * Qt5Svg * Qt5QuickControls2 * Qt5 (required version >= 5.9.0) * ECM (required version >= 5.52.0), Extra CMake Modules.,  * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Core-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target copyScanning dependencies of target KF5Kirigami2_autogen[  3%] Automatic MOC for target KF5Kirigami2[  3%] Built target copyScanning dependencies of target KF5Kirigami2_QCH[  6%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tagsBuilding up file structure...Insert custom filters...Insert help data for filter section (1 of 1)...Insert files...Insert contents...Insert indices...Documentation successfully generated.[  6%] Built target KF5Kirigami2_QCHScanning dependencies of target applicationitemapp_autogen[  6%] Built target KF5Kirigami2_autogen[ 10%] Automatic MOC for target applicationitemapp[ 13%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[ 13%] Built target applicationitemapp_autogen[ 16%] Generating qrc_resources.cpp[ 20%] Generating tabletmodemanager_interface.mocScanning dependencies of target applicationitemapp[ 23%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.oScanning dependencies of target KF5Kirigami2[ 26%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 30%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 33%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 36%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[ 40%] Linking CXX executable ../../bin/applicationitemapp[ 40%] Built target applicationitemapp[ 43%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 46%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 50%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[ 53%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 56%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 60%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 60%] Built target KF5Kirigami2Scanning dependencies of target kirigamiplugin_autogen[ 63%] Automatic MOC for target kirigamiplugin[ 63%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 70%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 70%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[ 73%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.10/src/delegaterecycler.cpp: In member function ���void DelegateRecycler::setSourceComponent(QQmlComponent*)���:/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.10/src/delegaterecycler.cpp:168:93: error: no match for ���operator=��� (operand types are ���QMap::const_iterator��� and ���QMap::iterator���) it = propertiesTrackerComponent.insert(engine, new QQmlComponent(engine, engine)); ^In file included from /usr/include/qt5/QtCore/qvariant.h:47, from /usr/include/qt5/QtQml/qqmlprivate.h:57, from /usr/include/qt5/QtQml/qqml.h:43, from /usr/include/qt5/QtQuick/qquickitem.h:44, from /usr/include/qt5/QtQuick/QQuickItem:1, from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.10/src/delegaterecycler.h:23, from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.10/src/delegaterecycler.cpp:21:/usr/include/qt5/QtCore/qmap.h:464:11: note: candidate: ���QMap::const_iterator& QMap::const_iterator::operator=(const QMap::const_iterator&)��� class 

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.11 - Build # 192 - Failure!

2018-11-30 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.11/192/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 30 Nov 2018 16:31:57 +
 Build duration:
2 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 90.11 KB...] * Qt5 (required version >= 5.9.0) * ECM (required version >= 5.52.0), Extra CMake Modules.,  * Qt5AndroidExtras (required version >= 5.9.0) * Qt5Core-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have not been found: * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target KF5Kirigami2_autogenScanning dependencies of target copyScanning dependencies of target applicationitemapp_autogen[  3%] Automatic MOC for target KF5Kirigami2[  7%] Automatic MOC for target applicationitemapp[  7%] Built target copy[  7%] Built target applicationitemapp_autogen[ 11%] Generating qrc_resources.cppScanning dependencies of target applicationitemapp[ 11%] Built target KF5Kirigami2_autogen[ 19%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 19%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 23%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.oScanning dependencies of target KF5Kirigami2[ 26%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 30%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 38%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 42%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 46%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 50%] Linking CXX executable ../../bin/applicationitemapp[ 53%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 53%] Built target applicationitemapp[ 53%] Built target KF5Kirigami2Scanning dependencies of target kirigamiplugin_autogen[ 57%] Automatic MOC for target kirigamiplugin[ 57%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 61%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 65%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[ 69%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o[ 73%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[ 76%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 80%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[ 84%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o/home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.11/src/delegaterecycler.cpp: In member function 'void DelegateRecycler::setSourceComponent(QQmlComponent*)':/home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.11/src/delegaterecycler.cpp:168:16: error: no match for 'operator=' (operand types are 'QMap::const_iterator' and 'QMap::iterator') it = propertiesTrackerComponent.insert(engine, new QQmlComponent(engine, engine));^/home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.11/src/delegaterecycler.cpp:168:16: note: candidates are:In file included from /opt/Qt/5.11.0/android_armv7/include/QtCore/qvariant.h:47:0, from /opt/Qt/5.11.0/android_armv7/include/QtQml/qqmlprivate.h:57, from /opt/Qt/5.11.0/android_armv7/include/QtQml/qqml.h:43, from /opt/Qt/5.11.0/android_armv7/include/QtQuick/qquickitem.h:44, from /opt/Qt/5.11.0/android_armv7/include/QtQuick/QQuickItem:1, from /home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.11/src/delegaterecycler.h:23, from /home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.11/src/delegaterecycler.cpp:21:/opt/Qt/5.11.0/android_armv7/include/QtCore/qmap.h:464:11: note: QMap::const_iterator& QMap::const_iterator::operator=(const QMap::const_iterator&) class const_iterator   

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.11 - Build # 111 - Failure!

2018-11-30 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.11/111/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 30 Nov 2018 16:31:57 +
 Build duration:
1 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 109.56 KB...] * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Core-- Configuring done-- Generating done-- Build files have been written to: C:/CI/workspace/Frameworks/kirigami/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] batC:\CI\workspace\Frameworks\kirigami\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"  Visual Studio 2017 Developer Command Prompt v15.7.3** Copyright (c) 2017 Microsoft Corporation**[vcvarsall.bat] Environment initialized for: 'x64'jom 1.1.2 - empower your coresjom: parallel job execution disabled for MakefileScanning dependencies of target KF5Kirigami2_autogenScanning dependencies of target KF5Kirigami2_QCHScanning dependencies of target copyScanning dependencies of target applicationitemapp_autogen[ 11%] Automatic MOC for target KF5Kirigami2[ 11%] Automatic MOC for target applicationitemapp[ 11%] Built target applicationitemapp_autogen[ 14%] Built target KF5Kirigami2_autogen[  3%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[ 14%] Generating qrc_resources.cppScanning dependencies of target applicationitemapp[ 22%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.obj[ 22%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.obj[ 25%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.objmain.cpp[ 25%] Built target copymocs_compilation.cppqrc_resources.cppScanning dependencies of target KF5Kirigami2[ 29%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.obj[ 37%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.obj[ 37%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.obj[ 40%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.obj[ 44%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.obj[ 48%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.objplatformtheme.cppmocs_compilation.cpp[ 48%] Built target KF5Kirigami2_QCHtabletmodewatcher.cpploggingcategory.cppkirigamipluginfactory.cppbasictheme.cpp[ 51%] Linking CXX shared library ..\..\bin\KF5Kirigami2.dll[ 55%] Linking CXX executable ..\..\bin\applicationitemapp.exe   Creating library ..\..\lib\KF5Kirigami2.lib and object ..\..\lib\KF5Kirigami2.exp   Creating library ..\..\lib\applicationitemapp.lib and object ..\..\lib\applicationitemapp.exp   Creating library ..\..\lib\KF5Kirigami2.lib and object ..\..\lib\KF5Kirigami2.exp[ 55%] Built target KF5Kirigami2Scanning dependencies of target kirigamiplugin_autogen[ 59%] Automatic MOC for target kirigamiplugin[ 59%] Built target kirigamiplugin_autogen   Creating library ..\..\lib\applicationitemapp.lib and object ..\..\lib\applicationitemapp.exp[ 59%] Built target applicationitemappScanning dependencies of target kirigamiplugin[ 66%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.obj[ 66%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.obj[ 70%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.obj[ 74%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.obj[ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.obj[ 81%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.obj[ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.obj[ 88%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.objkirigamiplugin.cppdelegaterecycler.cppC:\CI\workspace\Frameworks\kirigami\kf5-qt5 WindowsMSVCQt5.11\src\delegaterecycler.cpp(168): error C2679: binary '=': no operator found which takes a right-hand operand of type 'QMap::iterator' (or there is no acceptable conversion)C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qmap.h(522): note: could be 'QMap::const_iterator ::const_iterator::operator =(QMap::const_iterator &&)'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\include\qt5\QtCore/qmap.h(522): note: or   'QMap::const_iterator ::const_iterator::operator =(const 

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.9 - Build # 292 - Failure!

2018-11-30 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.9/292/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Nov 2018 16:31:57 +
 Build duration:
1 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 108.20 KB...]-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.9/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.9 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5Kirigami2_autogen[  3%] Automatic MOC for target KF5Kirigami2[  3%] Built target KF5Kirigami2_autogenScanning dependencies of target applicationitemapp_autogen[  6%] Automatic MOC for target applicationitemapp[  6%] Built target applicationitemapp_autogen[ 10%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[ 13%] Generating tabletmodemanager_interface.mocScanning dependencies of target KF5Kirigami2[ 16%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 20%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[ 23%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 26%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[ 30%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 33%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 36%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 40%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 40%] Built target KF5Kirigami2[ 43%] Generating qrc_resources.cppScanning dependencies of target applicationitemapp[ 46%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 50%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[ 53%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 56%] Linking CXX executable ../../bin/applicationitemapp[ 56%] Built target applicationitemappScanning dependencies of target KF5Kirigami2_QCH[ 60%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tagsBuilding up file structure...Insert custom filters...Insert help data for filter section (1 of 1)...Insert files...Insert contents...Insert indices...Documentation successfully generated.[ 60%] Built target KF5Kirigami2_QCHScanning dependencies of target copy[ 60%] Built target copyScanning dependencies of target kirigamiplugin_autogen[ 63%] Automatic MOC for target kirigamiplugin[ 63%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 66%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.oIn file included from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.9/src/kirigamiplugin.cpp:27:/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.9/src/mnemonicattached.h:113:10: warning: ���virtual bool MnemonicAttached::eventFilter(QObject*, QEvent*)��� can be marked override [-Wsuggest-override] bool eventFilter(QObject *watched, QEvent *e);  ^~~[ 70%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o[ 73%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin_autogen/mocs_compilation.cpp.o[ 76%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[ 80%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[ 83%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.oIn file included from /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.9/src/mnemonicattached.cpp:20:/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.9/src/mnemonicattached.h:113:10: warning: ���virtual bool MnemonicAttached::eventFilter(QObject*, QEvent*)��� can be marked override [-Wsuggest-override] bool eventFilter(QObject *watched, QEvent *e);  ^~~[ 86%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o[ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 96%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.9/src/delegaterecycler.cpp: In member function ���void DelegateRecycler::setSourceComponent(QQmlComponent*)���:/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.9/src/delegaterecycler.cpp:168:93: error: no match for 

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.11 - Build # 102 - Failure!

2018-11-30 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.11/102/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Fri, 30 Nov 2018 16:31:57 +
 Build duration:
42 sec and counting
   CONSOLE OUTPUT
  [...truncated 77.04 KB...]-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.11.1) * Qt5Qml (required version >= 5.11.1) * Qt5Quick * Qt5Gui * Qt5Widgets (required version >= 5.11.1) * Qt5Svg * Qt5QuickControls2 * Qt5 (required version >= 5.9.0) * ECM (required version >= 5.52.0), Extra CMake Modules.,  * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Core-- Configuring done-- Generating done-- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh+ python3.5 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform FreeBSDQt5.11 --usingInstall /home/jenkins/install-prefix/Scanning dependencies of target copyScanning dependencies of target Qt5Core_QCHScanning dependencies of target KF5Kirigami2_autogen[  3%] Automatic MOC for target KF5Kirigami2Scanning dependencies of target applicationitemapp_autogen[  3%] Built target Qt5Core_QCH[  6%] Automatic MOC for target applicationitemappScanning dependencies of target KF5Kirigami2_QCH[  6%] Built target copy[ 10%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[ 10%] Built target applicationitemapp_autogen[ 13%] Generating qrc_resources.cppScanning dependencies of target applicationitemapp[ 16%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[ 20%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[ 23%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[ 23%] Built target KF5Kirigami2_autogen[ 26%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[ 30%] Generating tabletmodemanager_interface.mocScanning dependencies of target KF5Kirigami2[ 33%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[ 36%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[ 40%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[ 43%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[ 46%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[ 50%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[ 53%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.oBuilding up file structure...Insert custom filters...Insert help data for filter section (1 of 1)...Insert files...Insert contents...Insert indices...Documentation successfully generated.[ 53%] Built target KF5Kirigami2_QCH[ 56%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[ 60%] Linking CXX executable ../../bin/applicationitemapp[ 60%] Built target KF5Kirigami2Scanning dependencies of target kirigamiplugin_autogen[ 63%] Automatic MOC for target kirigamiplugin[ 63%] Built target applicationitemapp[ 63%] Built target kirigamiplugin_autogenScanning dependencies of target kirigamiplugin[ 66%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin.cpp.o[ 70%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/enums.cpp.o[ 73%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/desktopicon.cpp.o[ 76%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/delegaterecycler.cpp.o[ 83%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/formlayoutattached.cpp.o[ 83%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/scenepositionattached.cpp.o[ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/mnemonicattached.cpp.o[ 90%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/settings.cpp.o[ 93%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/ECMQmLoader-libkirigami2plugin_qt.cpp.o[ 96%] Building CXX object src/CMakeFiles/kirigamiplugin.dir/kirigamiplugin_autogen/mocs_compilation.cpp.o/usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.11/src/delegaterecycler.cpp:168:16: error: no viable overloaded '='it = propertiesTrackerComponent.insert(engine, new QQmlComponent(engine, engine));~~ ^ /usr/local/include/qt5/QtCore/qmap.h:464:11: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'QMap::iterator' to 'const 

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

2018-11-30 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17260

To: davidedmundson, apol
Cc: apol, broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D16867: Don't generate appstream data for files that lack a description

2018-11-30 Thread Aleix Pol Gonzalez
apol added a comment.


  Tests fixed, sorry about that.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D16867

To: apol, #plasma, #frameworks, ngraham
Cc: dfaure, ngraham, kde-frameworks-devel, michaelh, bruns


D17245: Add string formatting function to property info

2018-11-30 Thread Alexander Stippich
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:83
> Of course I can look this up. But this information is not available when the 
> user looks at the string.
> 
> Probably we should ask what is the target audience here? The average user 
> only wants the image to be displayed correctly, i.e. apply the transform and 
> be done with it. This IMHO also implies never showing this value by default.
> 
> For power users, it may be better to also show the numerical value, so they 
> can look up whats meant.
> 
> Otherwise, it is not only necessary to mention CW or CCW, but also if this is 
> the transform which has been applied to the image, or the inverse transform 
> required to show the image correctly.

How about using the descriptions from D15503 
, which are also consistent with digiKam 
and Gwenview? The best solution is probably to make D15503 
 work, but this is out of scope for this 
revision. And a text is still better than a plain number.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

2018-11-30 Thread David Edmundson
davidedmundson updated this revision to Diff 46570.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17260?vs=46565=46570

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17260

AFFECTED FILES
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h
  src/core/job.cpp
  src/core/job_base.h

To: davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

2018-11-30 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/91/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Nov 2018 15:31:32 +
 Build duration:
4 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 69 - Still Unstable!

2018-11-30 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/69/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Nov 2018 15:31:31 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

2018-11-30 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in filecopyjob.cpp:225
> Why this change?

m_copyJob is a superclass of DirectCopyJob which doesn't have the signal.

so it's this or

q->connect(qobject_cast(m_copyJob), )

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17260

To: davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

2018-11-30 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> filecopyjob.cpp:225
>  KIO_ARGS << m_src << m_dest << m_permissions << (qint8)(m_flags & 
> Overwrite);
> -m_copyJob = new DirectCopyJob(slave_url, packedArgs);
> +auto job = new DirectCopyJob(slave_url, packedArgs);
> +m_copyJob = job;

Why this change?

> filecopyjob.cpp:259
> +
> +q->connect(job, ::processedSize, [this](KJob *job, qulonglong 
> processedSize) {
> +   slotProcessedSize(job, processedSize);

Add `q` context

> filecopyjob.cpp:260
> +q->connect(job, ::processedSize, [this](KJob *job, qulonglong 
> processedSize) {
> +   slotProcessedSize(job, processedSize);
> +});

All `slotProcessedSize` does is call `q->setProcessedAmount` so you can 
probably call this directly

> filecopyjob.cpp:263
>  
> -q->connect(job, SIGNAL(processedSize(KJob*,qulonglong)),
> -   SLOT(slotProcessedSize(KJob*,qulonglong)));
> +q->connect(job, QOverload::of(::percent), [this](KJob 
> *job, ulong percent) {
> +slotPercent(job, percent);

Same as `processedSize`

> job.cpp:88
>  // Forward information from that subjob.
> -connect(job, SIGNAL(speed(KJob*,ulong)),
> -SLOT(slotSpeed(KJob*,ulong)));
> -
> +connect(job, ::speed, this, [=](KJob *job, ulong speed) {
> +Q_UNUSED(job);

Capture only `this`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17260

To: davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

2018-11-30 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:25118c3e80ce: Fixed a bug(error?) in ipv4  ipv6 
settings (authored by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17258?vs=46563=46566

REVISION DETAIL
  https://phabricator.kde.org/D17258

AFFECTED FILES
  src/settings/ipv4setting.cpp
  src/settings/ipv6setting.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

2018-11-30 Thread Jan Grulich
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17258

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

2018-11-30 Thread Jan Grulich
jgrulich added a comment.


  Thanks for spotting this. I wonder how it's possible this passed the test, I 
guess comparing it the way we do, it doesn't compare it properly. I'll check 
the tests further.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17258

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread loh tar
loh.tar added a comment.


  @davidedmundson  
  May I ask how does this here will progress? You seemed to request a change 
which was not clear to me, but it's anyway "green flagged".

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17028

To: loh.tar, davidedmundson
Cc: smartins, kde-frameworks-devel, michaelh, ngraham, bruns


D17245: Add string formatting function to property info

2018-11-30 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> astippich wrote in formatstrings.cpp:83
> CCW, see 
> https://docs.microsoft.com/en-us/uwp/api/windows.storage.fileproperties.photoorientation.

Of course I can look this up. But this information is not available when the 
user looks at the string.

Probably we should ask what is the target audience here? The average user only 
wants the image to be displayed correctly, i.e. apply the transform and be done 
with it. This IMHO also implies never showing this value by default.

For power users, it may be better to also show the numerical value, so they can 
look up whats meant.

Otherwise, it is not only necessary to mention CW or CCW, but also if this is 
the transform which has been applied to the image, or the inverse transform 
required to show the image correctly.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

2018-11-30 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KJob's are quite QObject heavy, we lose a non-trivial amount of time in
  signal matching strings. This ports some Q_PRIVATE_SLOTS in FileCopyJob
  and the Job base.

TEST PLAN
  Relevant unit tests
  Copied some files

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17260

AFFECTED FILES
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h
  src/core/job.cpp
  src/core/job_base.h

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

2018-11-30 Thread Pranav Gade
pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Fixed a couple of misplaced lines of code

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17258

AFFECTED FILES
  src/settings/ipv4setting.cpp
  src/settings/ipv6setting.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17257: KateViewInternal: S

2018-11-30 Thread loh tar
loh.tar added a comment.


  Only 'm_view->' => 'view()' has plenty of hits, the others only a few.
  
  Please do a grep for m_startPos. To replace these few would  require a 
changed or added function.
  
  Last note: I hope you test all these changes thoroughly. At the last 
mentioned m_startPos S was suddenly the scrolling broken: Hence undo to only 
one change.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17257

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D17257: KateViewInternal: S

2018-11-30 Thread loh tar
loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - 'm_view->' => 'view()'
  - 'm_startPos.line()' => 'startLine()'
  - 'm_startX' => 'startX()'
  - 'startPos().line()' => 'startLine()'
  - 'm_startPos' => 'startPos()'

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17257

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D17167: Provide a method of assigning custom default icons for non-XDG dirs

2018-11-30 Thread David Faure
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  This feels *very* special cased. Where does this automagic ends? Any why only 
in $HOME? We'll keep adding entries here forever... Why don't people use a 
.directory file for this?
  If ~/Games is a de-facto standard, whoever creates it could add a .directory 
in there. If it's not, then that makes my point.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17167

To: ngraham, #frameworks, cfeck, broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17195: Avoid constantly increasing Qt event queue in KIO slaves

2018-11-30 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Very nice catch.
  
  Just in case, please wait for after the tagging this weekend before pushing; 
an old performance issue is better than a possible major regression.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17195

To: davidedmundson, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive

2018-11-30 Thread Thomas Surrel
thsurrel created this revision.
thsurrel added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  When navigating in a archive file in Dolphin and then
  using the URL navigator to go back to a parent folder,
  the selection was wrong because we were calling
  urlSelectionRequested with an URL that still had the
  tar: scheme instead of file:.

TEST PLAN
  Navigate in a .zip archive within Dolphin. Click on any
  parent folder, the selection should now be on the last
  previously opened item (either a foler or the .zip file).

REPOSITORY
  R241 KIO

BRANCH
  arc_archivefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17256

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17253: Fix colors for vector image mimetypes

2018-11-30 Thread Noah Davis
ndavis retitled this revision from "Fix inconsistent x-office-drawing icon 
color" to "Fix colors for vector image mimetypes".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17253

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17253: Fix inconsistent x-office-drawing icon color

2018-11-30 Thread Noah Davis
ndavis planned changes to this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17253

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17253: Fix inconsistent x-office-drawing icon color

2018-11-30 Thread Noah Davis
ndavis added a comment.


  I just ran into 2 other issues.
  
  `libreoffice-drawing` has the same consistency problem with the same 
inconsistent color, but at 16px. I also noticed that the `libreoffice-drawing 
icons have a color that is the same as or almost the same as the 
`x-office-drawing` icons, which the svg icons are symlinked to. Do we want SVGs 
and LibreOffice Draw files to have the same color?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17253

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17253: Fix inconsistent x-office-drawing icon color

2018-11-30 Thread Noah Davis
ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17253

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17253: Fix inconsistent x-office-drawing icon color

2018-11-30 Thread Noah Davis
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17253

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17253: Fix inconsistent x-office-drawing icon color

2018-11-30 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The 22px `x-office-drawing` mimetype icon had a color that was inconsistent 
with the other icons for that mimetype. I have fixed this and reduced the size 
of the other icons for the same mimetype.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-svg-mimetype (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17253

AFFECTED FILES
  icons/mimetypes/16/x-office-drawing.svg
  icons/mimetypes/22/x-office-drawing.svg
  icons/mimetypes/32/x-office-drawing.svg
  icons/mimetypes/64/x-office-drawing.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17239: ovs-bridge and ovs-interface setting

2018-11-30 Thread Jan Grulich
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:2d72fc8c496c: Add ovs-bridge and ovs-interface setting 
(authored by pranavgade, committed by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17239?vs=46542=46547#toc

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17239?vs=46542=46547

REVISION DETAIL
  https://phabricator.kde.org/D17239

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovsbridgesettingtest.cpp
  autotests/settings/ovsbridgesettingtest.h
  autotests/settings/ovsinterfacesettingtest.cpp
  autotests/settings/ovsinterfacesettingtest.h
  src/CMakeLists.txt
  src/settings/ovsbridgesetting.cpp
  src/settings/ovsbridgesetting.h
  src/settings/ovsbridgesetting_p.h
  src/settings/ovsinterfacesetting.cpp
  src/settings/ovsinterfacesetting.h
  src/settings/ovsinterfacesetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

2018-11-30 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/55/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Nov 2018 11:01:45 +
 Build duration:
7 min 57 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5WindowSystem_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7113/9546)54%
(3484/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3136)51%
(1262/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4662)60%
(1917/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 86 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/86/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 30 Nov 2018 11:00:45 +
 Build duration:
8 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.11 - Build # 20 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.11/20/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 30 Nov 2018 10:59:55 +
 Build duration:
5 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 43 - Still Unstable!

2018-11-30 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/43/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Nov 2018 11:01:45 +
 Build duration:
4 min 3 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5WindowSystem_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)74%
(7111/9546)54%
(3485/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3004/3136)51%
(1263/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(786/1391)45%
(303/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4662)60%
(1916/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 259 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/259/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Nov 2018 11:00:45 +
 Build duration:
3 min 19 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5SyntaxHighlighting_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2655/3384)66%
(1868/2818)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(666/731)59%
(433/730)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/100)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(212/276)src.lib90%
(27/30)90%
(27/30)85%
(1767/2072)73%
(1223/1672)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.9 - Build # 203 - Fixed!

2018-11-30 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.9/203/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Nov 2018 11:00:45 +
 Build duration:
2 min 37 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5SyntaxHighlighting_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2656/3384)66%
(1869/2818)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(667/731)59%
(434/730)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/100)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/40)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(212/276)src.lib90%
(27/30)90%
(27/30)85%
(1767/2072)73%
(1223/1672)

D17204: BrightScript: Allow sub to be unnamed

2018-11-30 Thread Christoph Cullmann
cullmann added a comment.


  Upsa, you are right.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D16867: Don't generate appstream data for files that lack a description

2018-11-30 Thread David Faure
dfaure added a comment.


  More casualties: the kpackage unittests...
  
  
https://build.kde.org/job/Frameworks/view/Everything/job/kpackage/job/kf5-qt5%20SUSEQt5.10/90/testReport/junit/(root)/TestSuite/testjsonmetadatapackage_appstream/
  and 5 others 
(https://build.kde.org/job/Frameworks/view/Everything/job/kpackage/job/kf5-qt5%20SUSEQt5.10/90/#showFailuresLink)
  
  Please fix.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D16867

To: apol, #plasma, #frameworks, ngraham
Cc: dfaure, ngraham, kde-frameworks-devel, michaelh, bruns


D17204: BrightScript: Allow sub to be unnamed

2018-11-30 Thread David Faure
dfaure added a comment.


  It seems this commit is the reason for the unittest failure below?
  
  
https://build.kde.org/job/Frameworks/view/Everything/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/258/testReport/junit/(root)/TestSuite/folding_test/
  
--- "/home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 
SUSEQt5.10/autotests/folding/brightscript.brs.fold" 2018-11-28 
07:43:45.708060965 +
+++ "/home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 
SUSEQt5.10/build/autotests/folding.out/brightscript.brs.fold"   2018-11-28 
07:45:08.202953752 +
@@ -96,4 +96,10 @@
 
 b.foo("string",1,{a:b},1.5,[1,2,3])
 a = b.foo("string",1,{a:b},1.5,[1,2,3])
+
+unnamed_function = function ( a as Integer ) as Float
+end function
+
+unnamed_sub = sub ( a as Integer ) as Void
+end sub
 endFunction
FAIL!  : FoldingTest::testFolding(brightscript.brs) Compared values are not 
the same
   Actual   (proc.exitCode()): 1
   Expected (0)  : 0

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17204

To: dlevin, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17252: ovs-patch and ovs-port setting

2018-11-30 Thread Pranav Gade
pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added ovs-patch and ovs-port setting according to: 
   https://developer.gnome.org/NetworkManager/stable/settings-ovs-patch.html 
https://developer.gnome.org/NetworkManager/stable/settings-ovs-port.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17252

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovspatchsettingtest.cpp
  autotests/settings/ovspatchsettingtest.h
  autotests/settings/ovsportsettingtest.cpp
  autotests/settings/ovsportsettingtest.h
  src/CMakeLists.txt
  src/settings/ovspatchsetting.cpp
  src/settings/ovspatchsetting.h
  src/settings/ovspatchsetting_p.h
  src/settings/ovsportsetting.cpp
  src/settings/ovsportsetting.h
  src/settings/ovsportsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15999: Add icons with added background to system.svgz

2018-11-30 Thread Filip Fila
filipf added a comment.


  In D15999#368500 , @ngraham wrote:
  
  > In D15999#368499 , @filipf wrote:
  >
  > > But there is a tangible problem here - imagine what the logout screen 
when using dark themes would look like if the circles were dark[;] They would 
be weird looking and would be superfluous.
  >
  >
  > That's precisely why I wanted a subtle outline around the edge of the 
background circle, which earlier versions had. With that, a dark circle on a 
dark wallpaper didn't become muddy and fade into the wallpaper; it still looked 
crisp and handsome.
  
  
  
  
  In D15999#368500 , @ngraham wrote:
  
  > In D15999#368499 , @filipf wrote:
  >
  > > But there is a tangible problem here - imagine what the logout screen 
when using dark themes would look like if the circles were dark[;] They would 
be weird looking and would be superfluous.
  >
  >
  > That's precisely why I wanted a subtle outline around the edge of the 
background circle, which earlier versions had. With that, a dark circle on a 
dark wallpaper didn't become muddy and fade into the wallpaper; it still looked 
crisp and handsome.
  
  
  I've made a **very** rough sketch (apologies for the roughness) to test 
things out. It's not that bad.
  
  F6448064: logoutnostroke.png 
  
  Obviously it's a bit better when there's strokes:
  
  F6448068: logoutwstroke.png 
  
  Though I have to admit I usually find strokes and outlines to be visually 
detrimental; in this case they also sort of overwhelm me because my brain is 
saying "there's too many lines". I also don't like how they're not of the same 
color as the icon itself, whereas if you make them white they will poke your 
eyes out.
  
  But there is a more important thing white circles would have going for them - 
how obvious it is which logout option is selected (which was also one of the 
reasons behind adding circles). A dark circle having its opacity lowered on a 
dark background is just less effective than a white circle on a dark 
background. So tl;dr = I still think white circles with dark themes are a 
better choice in the case of the logout screen.
  
  When it comes to SDDM, a lot of our problems stem from how uncustomizable it 
is... but what Phil said, if it could somehow detect the darkness of the 
wallpaper and adjust icons (maybe even other elements?) appropriately, that 
would be fantastic.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D17239: ovs-bridge and ovs-interface setting

2018-11-30 Thread Pranav Gade
pranavgade updated this revision to Diff 46542.
pranavgade marked an inline comment as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17239?vs=46537=46542

REVISION DETAIL
  https://phabricator.kde.org/D17239

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovsbridgesettingtest.cpp
  autotests/settings/ovsbridgesettingtest.h
  autotests/settings/ovsinterfacesettingtest.cpp
  autotests/settings/ovsinterfacesettingtest.h
  src/CMakeLists.txt
  src/settings/ovsbridgesetting.cpp
  src/settings/ovsbridgesetting.h
  src/settings/ovsbridgesetting_p.h
  src/settings/ovsinterfacesetting.cpp
  src/settings/ovsinterfacesetting.h
  src/settings/ovsinterfacesetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17239: ovs-bridge and ovs-interface setting

2018-11-30 Thread Jan Grulich
jgrulich added inline comments.

INLINE COMMENTS

> ovsinterfacesetting.cpp:27
> +#if !NM_CHECK_VERSION(1, 10, 0)
> +#define NM_SETTING_OVS_INTERFACE_SETTING_NAME "ovs-interface"
> +#endif

I forgot that the same problem will be with NM_SETTING_OVS_INTERFACE_TYPE. 
Define it too please.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17239

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17040: Make FindExiv2.cmake work with exiv 0.27.

2018-11-30 Thread Christophe Giboudeaux
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R260:6f4e08953736: Make FindExiv2.cmake work with exiv 0.27. 
(authored by cgiboudeaux).

REPOSITORY
  R260 Gwenview

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17040?vs=45870=46541

REVISION DETAIL
  https://phabricator.kde.org/D17040

AFFECTED FILES
  cmake/FindExiv2.cmake

To: cgiboudeaux, kde-buildsystem, kde-frameworks-devel
Cc: rempt, clintmoyer, tdarboux, huoni, muhlenpfordt, rkflx


D17251: Update Ip-tunnel settings

2018-11-30 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:d2531a32e28d: Update Ip-tunnel settings (authored by 
pranavgade, committed by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17251?vs=46535=46540#toc

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17251?vs=46535=46540

REVISION DETAIL
  https://phabricator.kde.org/D17251

AFFECTED FILES
  src/settings/iptunnelsetting.cpp
  src/settings/iptunnelsetting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17251: Update Ip-tunnel settings

2018-11-30 Thread Jan Grulich
jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> iptunnelsetting.h:28
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_IP_TUNNEL_FLAGS"flags"
> +

No need to define this here, it's already defined in iptunnelsetting.cpp.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17251

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17245: Add string formatting function to property info

2018-11-30 Thread Alexander Stippich
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:81
> Thats somewhat ambigous - flipped along the vertical axis, or top/bottom 
> flipped?

Actually I don't know, I just copied the code from Dolphin into here.
Seems to be a common term though according to 
https://docs.microsoft.com/en-us/uwp/api/windows.storage.fileproperties.photoorientation
GIMP describes Flip vertically as top/bottom, see 
https://docs.gimp.org/2.10/en/gimp-layer-flip-vertical.html

> bruns wrote in formatstrings.cpp:83
> Clockwise or CCW?

CCW, see 
https://docs.microsoft.com/en-us/uwp/api/windows.storage.fileproperties.photoorientation.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D17239: ovs-bridge and ovs-interface setting

2018-11-30 Thread Pranav Gade
pranavgade updated this revision to Diff 46537.
pranavgade marked 8 inline comments as done.
pranavgade added a comment.


  Made the required changes

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17239?vs=46491=46537

REVISION DETAIL
  https://phabricator.kde.org/D17239

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovsbridgesettingtest.cpp
  autotests/settings/ovsbridgesettingtest.h
  autotests/settings/ovsinterfacesettingtest.cpp
  autotests/settings/ovsinterfacesettingtest.h
  src/CMakeLists.txt
  src/settings/ovsbridgesetting.cpp
  src/settings/ovsbridgesetting.h
  src/settings/ovsbridgesetting_p.h
  src/settings/ovsinterfacesetting.cpp
  src/settings/ovsinterfacesetting.h
  src/settings/ovsinterfacesetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17251: Update Ip-tunnel settings

2018-11-30 Thread Pranav Gade
pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Fixed a few things in ip-tunnel settings

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17251

AFFECTED FILES
  src/settings/iptunnelsetting.cpp
  src/settings/iptunnelsetting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


  1   2   >