D17518: Adapt favicon test to www.kde.org changes

2018-12-11 Thread Kai Uwe Broulik
broulik added a comment. I also thought the favicon was too large for `FavIconJob` to download REPOSITORY R241 KIO BRANCH favicon_test REVISION DETAIL https://phabricator.kde.org/D17518 To: bruns, #frameworks, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 207 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/207/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 12 Dec 2018 05:06:01 + Build duration: 47 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 374 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/374/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 12 Dec 2018 05:05:22 + Build duration: 20 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 12 Dec 2018 05:06:01 + Build duration: 8 min 39 sec and counting BUILD ARTIFACTS

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

2018-12-11 Thread Daniel Levin
dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY QtCreator requires that keyword should be wrapped with white spaces

D17518: Adapt favicon test to www.kde.org changes

2018-12-11 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH favicon_test REVISION DETAIL https://phabricator.kde.org/D17518 To: bruns, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17496: Change network/web color icons to consistent style

2018-12-11 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Looks good visually, but the `scalable` test now fails: $ grep -A 1 FAIL.*scalable Testing/Temporary/LastTest.log FAIL! :

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47408. loh.tar added a comment. - Use new (dis)connect style in touched functions - Clean-Up no longer needed MovingRange Thanks for the explaining. Sounds like QScopedPointer(?) I have not used any of them now because it looked to me to have not

D17518: Adapt favicon test to www.kde.org changes

2018-12-11 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The favicon test uses www.kde.org as a peer for testing. As a favicon.ico has been

D5656: Adds method to force the reloading of a document

2018-12-11 Thread Dominik Haumann
dhaumann added a comment. Do we really need this? Or is this a reject? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5656 To: pedroarthurp, dfaure, brauch, dhaumann, cullmann Cc: kde-frameworks-devel, anthonyfieroni, nalvarez, kwrite-devel, hase, michaelh,

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good. Unfortunately the context is missing: Does it nake sense to have a // TODO KF6: make virtual? Or is that the old way? REPOSITORY R39 KTextEditor REVISION DETAIL

D17457: use STL were no implicit sharing is required

2018-12-11 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. Looks still good to me. INLINE COMMENTS > katetextblock.cpp:64 > -// in range > -Q_ASSERT(line < m_lines.size()); > - Is there a reason why this assert is useless now? REPOSITORY R39 KTextEditor BRANCH master REVISION

D17500: Restore mobipocket extractor

2018-12-11 Thread Albert Astals Cid
aacid added a comment. I'm afraid this could be a bit of a dependency loop since kdegraphics-mobipocket has a thumbnailer that depends on kio which is a tier 3 framework while kfilemetadata is a tier2 framework. Is it possible to move the extractor to kdegraphics-mobipocket instead of

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread Christoph Cullmann
cullmann added a comment. For: Um, have updated before read this. have droped your std::unique_ptr because im not familar with, no idea if my solution has ugly drawbacks. Is there a need to delete the hold object now? > Yes, as keeping a MovingRange alive has a cost (it will need to be

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann
cullmann added a comment. My change is BC and should have right naming, Dominik, ok? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16347 To: cullmann, mlaurent, vkrause, dhaumann, demsking Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh,

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann
cullmann updated this revision to Diff 47389. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16347?vs=44008=47389 REVISION DETAIL https://phabricator.kde.org/D16347 AFFECTED FILES src/include/ktexteditor/view.h src/utils/ktexteditor.cpp To:

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann
cullmann commandeered this revision. cullmann edited reviewers, added: demsking; removed: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16347 To: cullmann, mlaurent, vkrause, dhaumann, demsking Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase,

D5656: Adds method to force the reloading of a document

2018-12-11 Thread Christoph Cullmann
cullmann added a comment. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. See e.g. document.cpp: QVector Document::searchText(const KTextEditor::Range , const QString , const SearchOptions options) const { return

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar added a comment. In D17459#375429 , @cullmann wrote: > I am atm a bit busy Thanks for the hint > For the input range, I think it would make sense to store it as std::unique_ptr to have it taking care of "edits" in-between

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47380. loh.tar added a comment. - Fix to remember loop state CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47379=47380 REVISION DETAIL https://phabricator.kde.org/D17459 AFFECTED FILES src/search/katesearchbar.cpp

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread Christoph Cullmann
cullmann added a comment. I am atm a bit busy, but from principle the code goes into the right direction :) Thanks for taking this up! For the input range, I think it would make sense to store it as std::unique_ptr to have it taking care of "edits" in-between the calls (even if that is

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47379. loh.tar added a comment. - Fix crash in replace mode CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47362=47379 REVISION DETAIL https://phabricator.kde.org/D17459 AFFECTED FILES src/search/katesearchbar.cpp

D17457: use STL were no implicit sharing is required

2018-12-11 Thread Christoph Cullmann
cullmann updated this revision to Diff 47378. cullmann added a comment. no copying of cursor sets, only in-place updates REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17457?vs=47377=47378 BRANCH master REVISION DETAIL

D17457: use STL were no implicit sharing is required

2018-12-11 Thread Christoph Cullmann
cullmann updated this revision to Diff 47377. cullmann added a comment. This revision is now accepted and ready to land. STL doesn't need qAsConst REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17457?vs=47376=47377 BRANCH master REVISION DETAIL

D17457: use STL were no implicit sharing is required

2018-12-11 Thread Christoph Cullmann
cullmann planned changes to this revision. cullmann added a comment. I will do some more things, therefore one can wait bit with reviewing, beside if you see some faults ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17457 To: cullmann, dhaumann Cc:

D17457: use STL were no implicit sharing is required

2018-12-11 Thread Christoph Cullmann
cullmann updated this revision to Diff 47376. cullmann added a comment. more in-place changes instead of copying REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17457?vs=47204=47376 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17457

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 11 Dec 2018 18:39:10 + Build duration: 3 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 206 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/206/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 11 Dec 2018 18:39:10 + Build duration: 3 min 23 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 3 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/3/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 11 Dec 2018 18:19:00 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 205 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/205/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 11 Dec 2018 18:19:00 + Build duration: 3 min 50 sec and counting JUnit Tests Name:

D17430: highlight token strings and delimited strings

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 47371. aG0aep6G added a comment. - add test lines for token strings and delimited strings REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17430?vs=47115=47371 BRANCH tokenstring-delimitedstring REVISION

D17496: Change network/web color icons to consistent style

2018-12-11 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17496 To: ndavis, #vdg Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 373 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/373/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 11 Dec 2018 17:47:50 + Build duration: 8 min 31 sec and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/12/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 11 Dec 2018 17:47:50 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS

D17460: fixups for `extern` and `pragma`

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment. In D17460#374942 , @dhaumann wrote: > Could you also extend the unit test in autotest/input/highlight.d? Done. I also noticed that my last patch broke `version = X;` so I fixed that, too. REPOSITORY R216

D17460: fixups for `extern` and `pragma`

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 47369. aG0aep6G added a comment. - update test files - fix `version = foo;` - add some more test lines REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17460?vs=47214=47369 BRANCH extern-and-pragma

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/11/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 11 Dec 2018 16:53:39 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 372 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/372/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 11 Dec 2018 16:53:40 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 0

D17310: Improve Kile icon with LaTeX font

2018-12-11 Thread TrickyRicky
trickyricky26 updated this revision to Diff 47364. trickyricky26 added a comment. - Use the root a design with a pen REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17310?vs=46711=47364 BRANCH improve-kile-icon (branched from master) REVISION

D17469: applications-games icon for dark theme

2018-12-11 Thread Noah Davis
ndavis added a comment. I made a more detailed version, but I'm not sure if it's going overboard.F6471165: Screenshot_20181211_37.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze, #vdg,

D17469: applications-games icon for dark theme

2018-12-11 Thread Nathaniel Graham
ngraham added a comment. That's much better! I think I would still prefer a bit more slope on the sides though. However at this point it's just aesthetic quibbling. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze, #vdg, ndavis

D17469: applications-games icon for dark theme

2018-12-11 Thread Noah Davis
ndavis added a comment. In D17469#375313 , @ngraham wrote: > @ndavis To be honest, I liked the shape and composition of the original icon better than your proposed new one. I'm not a huge fan of the flat sides and lack of visual distinction

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47362. loh.tar edited the summary of this revision. loh.tar added a comment. - Code cosmetic - Add singleShot stuff That's my first draft of that requested singleShot approach, help is now appreciated. - Replace crashes due to (I think) these

D17496: Change network/web color icons to consistent style

2018-12-11 Thread Noah Davis
ndavis updated this revision to Diff 47359. ndavis added a comment. Change `applications-internet` back into a duplicate of `preferences-system-network` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17496?vs=47320=47359 BRANCH

D16694: Improve visibility for Konsole icon when using Breeze Dark

2018-12-11 Thread Nathaniel Graham
ngraham added a comment. App icons shouldn't have monochrome versions except for very limited exceptions like on the system tray. The issue being solved here is a general problem that we have when a dark icon is used with a dark color scheme. It's by no means limited to this icon (see also

D17469: applications-games icon for dark theme

2018-12-11 Thread Nathaniel Graham
ngraham added a comment. @ndavis To be honest, I liked the shape and composition of the original icon better than your proposed new one. I'm not a huge fan of the flat sides and lack of visual distinction between the body and handles. +1 on removing the superfluous Plasma logo though.

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Noah Davis
ndavis added a comment. In D17505#375247 , @broulik wrote: > The stylesheet stuff doesn't work, ie. the icon stays black in Breeze dark. Argh, editing with Inkscape's XML editor apparently automatically inserts hardcoded colors, even if

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Noah Davis
ndavis updated this revision to Diff 47357. ndavis added a comment. Fix stylesheet REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17505?vs=47349=47357 BRANCH bluetooth-battery-icon (branched from master) REVISION DETAIL

D17495: [KMessageBox] Fix minimum dialog size when details are requested

2018-12-11 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17495 To: cfeck, ngraham, elvisangelaccio, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17496: Change network/web color icons to consistent style

2018-12-11 Thread Nathaniel Graham
ngraham added a comment. NooOOOoOooOO Checking patch icons-dark/preferences/32/applications-internet.svg... Checking patch dev/null => icons-dark/categories/32/applications-internet.svg... error: dev/null: does not exist in index Checking patch

Re: KDE Frameworks web page

2018-12-11 Thread Harald Sitter
On Tue, Dec 11, 2018 at 2:17 PM Alexander Potashev wrote: > > Thanks! > > вт, 11 дек. 2018 г. в 15:32, Jonathan Riddell : > > > 2. Text on the blue grid under "Organisation" is not very readable. > > > > Works for me. Again it's copying what's on the Kirigami page. Suggestions > > welcome but

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. The stylesheet stuff doesn't work, ie. the icon stays black in Breeze dark. Also, should it maybe have a "bolt" or something next to it as that's what we normally have for the

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Noah Davis
ndavis added a reviewer: broulik. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17505 To: ndavis, #vdg, #plasma, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY It's exactly the same as the regular 32px bluetooth icon in this file, but D17346

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 371 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/371/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 11 Dec 2018 13:27:58 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 10 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/10/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 11 Dec 2018 13:27:58 + Build duration: 6 min 45 sec and counting JUnit Tests Name: (root) Failed:

D17502: Store timestamp as UTC

2018-12-11 Thread Chinmoy Ranjan Pradhan
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1c3ecda86679: Store timestamp as UTC (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17502?vs=47343=47345 REVISION DETAIL

Re: KDE Frameworks web page

2018-12-11 Thread Alexander Potashev
Thanks! вт, 11 дек. 2018 г. в 15:32, Jonathan Riddell : > > 2. Text on the blue grid under "Organisation" is not very readable. > > Works for me. Again it's copying what's on the Kirigami page. Suggestions > welcome but the page needs some colour to break it up. I don't speak CSS, but placing

D17502: Store timestamp as UTC

2018-12-11 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17502 To: chinmoyr, dfaure Cc: kde-frameworks-devel, davidedmundson, michaelh, ngraham, bruns

D17502: Store timestamp as UTC

2018-12-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY In cases where mtime, ctime and atime are displayed (KPropertiesDialog,

Re: KDE Frameworks web page

2018-12-11 Thread Jonathan Riddell
On Tue, Dec 11, 2018 at 11:01:22AM +0300, Alexander Potashev wrote: > пн, 10 дек. 2018 г. в 16:43, Jonathan Riddell : > > > > Frameworks has no web page and the announcements still point to the > > 5.0 announcement for more information. > > > > So here's a proposal for adding to kde.org/products/

D17498: Xdg Decoration Support

2018-12-11 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > test_xdg_decoration.cpp:104 > +QSignalSpy compositorSpy(m_registry, ::compositorAnnounced); > +QSignalSpy v6xdgShellSpy(m_registry, > ::xdgShellUnstableV6Announced); > +QSignalSpy xdgShellSpy(m_registry, ::xdgShellStableAnnounced); Do

D17425: Added DCB settings

2018-12-11 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R282:4332597370b8: Added DCB settings (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17425?vs=47338=47340#toc REPOSITORY R282 NetworkManagerQt

D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson
davidedmundson marked 5 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17498 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson
davidedmundson updated this revision to Diff 47339. davidedmundson added a comment. zzag's comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17498?vs=47336=47339 BRANCH xdg_deco REVISION DETAIL https://phabricator.kde.org/D17498 AFFECTED

D17425: Added DCB settings

2018-12-11 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D17425: Added DCB settings

2018-12-11 Thread Pranav Gade
pranavgade updated this revision to Diff 47338. pranavgade marked 7 inline comments as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47282=47338 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES

D17425: Added DCB settings

2018-12-11 Thread Jan Grulich
jgrulich added inline comments. INLINE COMMENTS > dcbsetting.cpp:491 > + > +if (priorityFlowControl(7) > 0) { > +setting.insert(QLatin1String(NM_SETTING_DCB_PRIORITY_FLOW_CONTROL), > QVariant::fromValue(priorityFlowControl())); I think all those should be added all the time,

D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson
davidedmundson updated this revision to Diff 47336. davidedmundson added a comment. misc cleanups REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17498?vs=47331=47336 BRANCH xdg_deco REVISION DETAIL https://phabricator.kde.org/D17498 AFFECTED FILES

D17498: Xdg Decoration Support

2018-12-11 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > test_xdg_decoration.cpp:178-181 > + > QTest::addColumn("configuredMode"); > + > QTest::addColumn("configuredModeExp"); > +QTest::addColumn("setMode"); > + > QTest::addColumn("setModeExp"); Do we actually use it? >

D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich updated this revision to Diff 47335. astippich added a comment. - add missing test file REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17500?vs=47334=47335 BRANCH mobi REVISION DETAIL https://phabricator.kde.org/D17500 AFFECTED FILES

D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich added a comment. I was unable to get a version check running with cmake, any help is appreciated REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Restore the mobipocket extractor based on the QMobipocket library,

D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Usual massive boilerplate. Should allow us to remove the

D17245: Add string formatting function to property info

2018-12-11 Thread Alexander Stippich
astippich marked 3 inline comments as done. astippich added a comment. any further comments/objections? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov,

D17301: add documentation to result class

2018-12-11 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. astippich marked an inline comment as done. Closed by commit R293:60d6fc82ae5a: add documentation to result class (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17302: add simple test for string merging

2018-12-11 Thread Alexander Stippich
astippich updated this revision to Diff 47329. astippich added a comment. - updates for master REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=46710=47329 BRANCH test_result REVISION DETAIL https://phabricator.kde.org/D17302 AFFECTED FILES

D16716: fail writing test if mime type is not supported by the extractor

2018-12-11 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:239b0ef2b23b: fail writing test if mime type is not supported by the extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

2018-12-11 Thread Alexander Stippich
astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17338 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

Re: KDE Frameworks web page

2018-12-11 Thread Alexander Potashev
пн, 10 дек. 2018 г. в 16:43, Jonathan Riddell : > > Frameworks has no web page and the announcements still point to the > 5.0 announcement for more information. > > So here's a proposal for adding to kde.org/products/ > > https://www.kde.org/products/frameworks/ Hi, Nice work! Now nitpicking:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/74/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 11 Dec 2018 07:56:57 + Build duration: 1 min 49 sec and counting JUnit Tests Name: (root)