D17518: Adapt favicon test to www.kde.org changes

2018-12-11 Thread Kai Uwe Broulik
broulik added a comment.


  I also thought the favicon was too large for `FavIconJob` to download

REPOSITORY
  R241 KIO

BRANCH
  favicon_test

REVISION DETAIL
  https://phabricator.kde.org/D17518

To: bruns, #frameworks, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 207 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/207/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 12 Dec 2018 05:06:01 +
 Build duration:
47 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13322)18%
(1816/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2247)7%
(96/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2821)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2017)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 374 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/374/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 12 Dec 2018 05:05:22 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32059/60117)38%
(16552/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4273/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8338/14339)50%
(4672/9267)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3909/7970)34%
(1605/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/5/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 12 Dec 2018 05:06:01 +
 Build duration:
8 min 39 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

2018-12-11 Thread Daniel Levin
dlevin created this revision.
dlevin added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  QtCreator requires that keyword should be wrapped with white spaces on
  both ends. Kate requires only trailing white space after keyword. This
  patch replaces detection of 'endsub' and 'endfunction' with
  StringDetect instead of keyword to satisfy both.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17522

AFFECTED FILES
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17518: Adapt favicon test to www.kde.org changes

2018-12-11 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  favicon_test

REVISION DETAIL
  https://phabricator.kde.org/D17518

To: bruns, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17496: Change network/web color icons to consistent style

2018-12-11 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Looks good visually, but the `scalable` test now fails:
  
$ grep -A 1 FAIL.*scalable Testing/Temporary/LastTest.log 
FAIL!  : ScalableTest::test_scalable(icons:Applications) The following 
icons are not available in a scalable directory:
  applications-internet
--
FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following 
icons are not available in a scalable directory:
  applications-internet

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17496

To: ndavis, #vdg, ngraham
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns


D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47408.
loh.tar added a comment.


  - Use new (dis)connect style in touched functions
  - Clean-Up no longer needed MovingRange
  
  Thanks for the explaining. Sounds like QScopedPointer(?)
  I have not used any of them now because it looked to me to have not much 
benefit in this case(?)
  
  BTW: I Always try to avoid a "Standard" version when there is a "Cute" 
available ;-) just only because std stuff looks for me ugly.
  
  The noted odd highlighting still happens when you do successive S() tasks. 
Is it a feature? :-)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47380=47408

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann


D17518: Adapt favicon test to www.kde.org changes

2018-12-11 Thread Stefan Brüns
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The favicon test uses www.kde.org as a peer for testing. As a favicon.ico
  has been added, the negative test no longer returns an error as expected.
  
  Change the URL to some which will likely never succeed. Also change the
  protocol to https, as non-existing URLs are redirected (302) before
  failing (404).

TEST PLAN
  run build/bin/favicontest

REPOSITORY
  R241 KIO

BRANCH
  favicon_test

REVISION DETAIL
  https://phabricator.kde.org/D17518

AFFECTED FILES
  autotests/favicontest.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D5656: Adds method to force the reloading of a document

2018-12-11 Thread Dominik Haumann
dhaumann added a comment.


  Do we really need this? Or is this a reject?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5656

To: pedroarthurp, dfaure, brauch, dhaumann, cullmann
Cc: kde-frameworks-devel, anthonyfieroni, nalvarez, kwrite-devel, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good.
  
  Unfortunately the context is missing: Does it nake sense to have a // TODO 
KF6: make virtual? Or is that the old way?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann


D17457: use STL were no implicit sharing is required

2018-12-11 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.


  Looks still good to me.

INLINE COMMENTS

> katetextblock.cpp:64
> -// in range
> -Q_ASSERT(line < m_lines.size());
> -

Is there a reason why this assert is useless now?

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17457

To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars


D17500: Restore mobipocket extractor

2018-12-11 Thread Albert Astals Cid
aacid added a comment.


  I'm afraid this could be a bit of a dependency loop since 
kdegraphics-mobipocket has a thumbnailer that depends on kio which is a tier 3 
framework while kfilemetadata is a tier2 framework.
  
  Is it possible to move the extractor to kdegraphics-mobipocket instead of 
having it in kfilemetadata? or does it depend on non installed include files?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: aacid, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread Christoph Cullmann
cullmann added a comment.


  For: Um, have updated before read this. have droped your std::unique_ptr 
because im not familar with, no idea if my solution has ugly drawbacks. Is 
there a need to delete the hold object now?
  
  > Yes, as keeping a MovingRange alive has a cost (it will need to be updated 
on each editing action), therefore one should create it before the 
find/replaceAll and delete it afterwards. A unique_ptr doesn't do much more 
than ensuring it is deleted at end of life-time of the object, too.
  
===

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann


D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann
cullmann added a comment.


  My change is BC and should have right naming, Dominik, ok?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann


D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann
cullmann updated this revision to Diff 47389.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16347?vs=44008=47389

REVISION DETAIL
  https://phabricator.kde.org/D16347

AFFECTED FILES
  src/include/ktexteditor/view.h
  src/utils/ktexteditor.cpp

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann


D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann
cullmann commandeered this revision.
cullmann edited reviewers, added: demsking; removed: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann


D5656: Adds method to force the reloading of a document

2018-12-11 Thread Christoph Cullmann
cullmann added a comment.
Herald added a project: Kate.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  See e.g. document.cpp:
  
  QVector Document::searchText(const KTextEditor::Range 
, const QString , const SearchOptions options) const
  {
  
return d->searchText(range, pattern, options);
  
  }
  
  how one can do that.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5656

To: pedroarthurp, dfaure, brauch, dhaumann, cullmann
Cc: kde-frameworks-devel, anthonyfieroni, nalvarez, kwrite-devel, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann, #frameworks


D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar added a comment.


  In D17459#375429 , @cullmann wrote:
  
  > I am atm a bit busy
  
  
  Thanks for the hint
  
  > For the input range, I think it would make sense to store it as 
std::unique_ptr to have it taking care of "edits" 
in-between the calls (even if that is no good idea, but that could avoid some 
issues, and saves the re-creation of the range in each call)
  
  Um, have updated before read this. have droped your std::unique_ptr because 
im not familar with, no idea if my solution has ugly drawbacks. Is there a need 
to delete the hold object now?
  Will do other things for 1-2 days, so please look closer at it and give 
advices in DETAIL ;-)
  
  Ah, I noticed that after a some replace of the highlight looks a little 
strage(?) Could it currently not reproduce

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann


D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47380.
loh.tar added a comment.


  - Fix to remember loop state

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47379=47380

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann


D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread Christoph Cullmann
cullmann added a comment.


  I am atm a bit busy, but from principle the code goes into the right 
direction :)
  Thanks for taking this up!
  For the input range, I think it would make sense to store it as 
std::unique_ptr to have it taking care of "edits" 
in-between the calls (even if that is no good idea, but that could avoid some 
issues, and saves the re-creation of the range in each call)

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann


D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47379.
loh.tar added a comment.


  - Fix crash in replace mode

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47362=47379

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann


D17457: use STL were no implicit sharing is required

2018-12-11 Thread Christoph Cullmann
cullmann updated this revision to Diff 47378.
cullmann added a comment.


  no copying of cursor sets, only in-place updates

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17457?vs=47377=47378

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17457

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h

To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars


D17457: use STL were no implicit sharing is required

2018-12-11 Thread Christoph Cullmann
cullmann updated this revision to Diff 47377.
cullmann added a comment.
This revision is now accepted and ready to land.


  STL doesn't need qAsConst

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17457?vs=47376=47377

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17457

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h

To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars


D17457: use STL were no implicit sharing is required

2018-12-11 Thread Christoph Cullmann
cullmann planned changes to this revision.
cullmann added a comment.


  I will do some more things, therefore one can wait bit with reviewing, beside 
if you see some faults ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17457

To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars


D17457: use STL were no implicit sharing is required

2018-12-11 Thread Christoph Cullmann
cullmann updated this revision to Diff 47376.
cullmann added a comment.


  more in-place changes instead of copying

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17457?vs=47204=47376

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17457

AFFECTED FILES
  src/buffer/katetextblock.cpp
  src/buffer/katetextblock.h

To: cullmann, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 11 Dec 2018 18:39:10 +
 Build duration:
3 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 206 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/206/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 11 Dec 2018 18:39:10 +
 Build duration:
3 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13322)18%
(1817/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2247)7%
(96/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2821)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2017)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 3 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/3/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 11 Dec 2018 18:19:00 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 205 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/205/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 11 Dec 2018 18:19:00 +
 Build duration:
3 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13322)18%
(1817/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2247)7%
(96/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2821)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2017)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
  

D17430: highlight token strings and delimited strings

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 47371.
aG0aep6G added a comment.


  - add test lines for token strings and delimited strings

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17430?vs=47115=47371

BRANCH
  tokenstring-delimitedstring

REVISION DETAIL
  https://phabricator.kde.org/D17430

AFFECTED FILES
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17496: Change network/web color icons to consistent style

2018-12-11 Thread Andres Betts
abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17496

To: ndavis, #vdg
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 373 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/373/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 11 Dec 2018 17:47:50 +
 Build duration:
8 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32054/60117)38%
(16563/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8329/14339)50%
(4670/9267)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/12/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 11 Dec 2018 17:47:50 +
 Build duration:
6 min 17 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5KIO_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32037/60116)38%
(16549/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4280/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8322/14339)50%
(4665/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D17460: fixups for `extern` and `pragma`

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G added a comment.


  In D17460#374942 , @dhaumann wrote:
  
  > Could you also extend the unit test in autotest/input/highlight.d?
  
  
  Done. I also noticed that my last patch broke `version = X;` so I fixed that, 
too.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17460

To: aG0aep6G
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars


D17460: fixups for `extern` and `pragma`

2018-12-11 Thread aG0aep6G aG0aep6G
aG0aep6G updated this revision to Diff 47369.
aG0aep6G added a comment.


  - update test files
  - fix `version = foo;`
  - add some more test lines

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17460?vs=47214=47369

BRANCH
  extern-and-pragma

REVISION DETAIL
  https://phabricator.kde.org/D17460

AFFECTED FILES
  autotests/html/highlight.d.html
  autotests/input/highlight.d
  autotests/reference/highlight.d.ref
  data/syntax/d.xml

To: aG0aep6G
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/11/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 11 Dec 2018 16:53:39 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32095/60118)38%
(16581/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8358/14340)51%
(4679/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(532/1036)37%
(319/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 372 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/372/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 11 Dec 2018 16:53:40 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32088/60117)38%
(16584/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8352/14339)51%
(4685/9267)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
   

D17310: Improve Kile icon with LaTeX font

2018-12-11 Thread TrickyRicky
trickyricky26 updated this revision to Diff 47364.
trickyricky26 added a comment.


  - Use the root a design with a pen

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17310?vs=46711=47364

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

AFFECTED FILES
  icons-dark/apps/48/kile.svg
  icons/apps/48/kile.svg

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns


D17469: applications-games icon for dark theme

2018-12-11 Thread Noah Davis
ndavis added a comment.


  I made a more detailed version, but I'm not sure if it's going 
overboard.F6471165: Screenshot_20181211_37.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: guoyunhe, #breeze, #vdg, ndavis
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns


D17469: applications-games icon for dark theme

2018-12-11 Thread Nathaniel Graham
ngraham added a comment.


  That's much better! I think I would still prefer a bit more slope on the 
sides though. However at this point it's just aesthetic quibbling. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: guoyunhe, #breeze, #vdg, ndavis
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns


D17469: applications-games icon for dark theme

2018-12-11 Thread Noah Davis
ndavis added a comment.


  In D17469#375313 , @ngraham wrote:
  
  > @ndavis To be honest, I liked the shape and composition of the original 
icon better than your proposed new one. I'm not a huge fan of the flat sides 
and lack of visual distinction between the body and handles. +1 on removing the 
superfluous Plasma logo though.
  
  
  What about this?
  
  F6469118: Screenshot_20181210_121913.png 

  
  F6469121: Screenshot_20181210_121948.png 

  
  F6469124: Screenshot_20181210_122025.png 

  
  F6469130: applications-games2.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: guoyunhe, #breeze, #vdg, ndavis
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns


D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47362.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Code cosmetic
  - Add singleShot stuff
  
  That's my first draft of that requested singleShot approach, help is now 
appreciated.
  
  - Replace crashes due to (I think) these pointer instead of reference 
argument mismatch.
  - Find works odd. Most of the time looks good, searching "5" or "A" seams to 
run endless in our fat file
  - Can't see how that loop works, "line" is not incremented and I'm not sure 
if "done" is sufficient set

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47275=47362

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann


D17496: Change network/web color icons to consistent style

2018-12-11 Thread Noah Davis
ndavis updated this revision to Diff 47359.
ndavis added a comment.


  Change `applications-internet` back into a duplicate of 
`preferences-system-network`

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17496?vs=47320=47359

BRANCH
  network-icon-consistency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17496

AFFECTED FILES
  icons-dark/apps/48/internet-web-browser.svg
  icons-dark/categories/32/applications-internet.svg
  icons-dark/preferences/32/applications-internet.svg
  icons-dark/preferences/32/preferences-system-network.svg
  icons-dark/preferences/32/preferences-web-browser-cache.svg
  icons-dark/preferences/32/preferences-web-browser-cookies.svg
  icons-dark/preferences/32/preferences-web-browser-identification.svg
  icons-dark/preferences/32/preferences-web-browser-shortcuts.svg
  icons-dark/preferences/32/preferences-web-browser-ssl.svg
  icons-dark/preferences/32/preferences-web-browser-stylesheets.svg
  icons/apps/48/internet-web-browser.svg
  icons/categories/32/applications-internet.svg
  icons/preferences/32/applications-internet.svg
  icons/preferences/32/preferences-system-network.svg
  icons/preferences/32/preferences-web-browser-cache.svg
  icons/preferences/32/preferences-web-browser-cookies.svg
  icons/preferences/32/preferences-web-browser-identification.svg
  icons/preferences/32/preferences-web-browser-shortcuts.svg
  icons/preferences/32/preferences-web-browser-ssl.svg
  icons/preferences/32/preferences-web-browser-stylesheets.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D16694: Improve visibility for Konsole icon when using Breeze Dark

2018-12-11 Thread Nathaniel Graham
ngraham added a comment.


  App icons shouldn't have monochrome versions except for very limited 
exceptions like on the system tray. The issue being solved here is a general 
problem that we have when a dark icon is used with a dark color scheme. It's by 
no means limited to this icon (see also D17469 
), but we have some visual restrictions on 
resolving it since this is an app icon and we can't really redesign the icon  
like we can in D17469 .

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns


D17469: applications-games icon for dark theme

2018-12-11 Thread Nathaniel Graham
ngraham added a comment.


  @ndavis To be honest, I liked the shape and composition of the original icon 
better than your proposed new one. I'm not a huge fan of the flat sides and 
lack of visual distinction between the body and handles. +1 on removing the 
superfluous Plasma logo though.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: guoyunhe, #breeze, #vdg, ndavis
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns


D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Noah Davis
ndavis added a comment.


  In D17505#375247 , @broulik wrote:
  
  > The stylesheet stuff doesn't work, ie. the icon stays black in Breeze dark.
  
  
  Argh, editing with Inkscape's XML editor apparently automatically inserts 
hardcoded colors, even if you delete them. It should be fixed now.
  
  > Also, should it maybe have a "bolt" or something next to it as that's what 
we normally have for the batteries (optional)
  
  I think that would look weird and it's already implied that there's a battery.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17505

To: ndavis, #vdg, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Noah Davis
ndavis updated this revision to Diff 47357.
ndavis added a comment.


  Fix stylesheet

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17505?vs=47349=47357

BRANCH
  bluetooth-battery-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17505

AFFECTED FILES
  src/desktoptheme/breeze/icons/preferences.svgz

To: ndavis, #vdg, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17495: [KMessageBox] Fix minimum dialog size when details are requested

2018-12-11 Thread Nathaniel Graham
ngraham accepted this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17495

To: cfeck, ngraham, elvisangelaccio, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17496: Change network/web color icons to consistent style

2018-12-11 Thread Nathaniel Graham
ngraham added a comment.


  NooOOOoOooOO
  
Checking patch icons-dark/preferences/32/applications-internet.svg...
Checking patch dev/null => 
icons-dark/categories/32/applications-internet.svg...
error: dev/null: does not exist in index
Checking patch icons-dark/apps/48/internet-web-browser.svg...
Applied patch icons/preferences/32/preferences-web-browser-stylesheets.svg 
cleanly.
  
  Any chance you could omit the symlink changes from this patch?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17496

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


Re: KDE Frameworks web page

2018-12-11 Thread Harald Sitter
On Tue, Dec 11, 2018 at 2:17 PM Alexander Potashev  wrote:
>
> Thanks!
>
> вт, 11 дек. 2018 г. в 15:32, Jonathan Riddell :
> > > 2. Text on the blue grid under "Organisation" is not very readable.
> >
> > Works for me.  Again it's copying what's on the Kirigami page.  Suggestions 
> > welcome but the page needs some colour to break it up.
>
> I don't speak CSS, but placing this white text over its own
> text-shadow in blue (same dark blue as the background's primary color)
> could make it more readable as the grid won't interfere the letters
> anymore. (Sorry, it's just my guess, I didn't actually check how it
> would look.)
>
> > > 4. Can't find no direct link nor straightforward way to go to Git
> > > repos or download source tarballs. I think these must be easy to
> > > access, since KF5 is a developer-oriented product.
> >
> > I added 'download' to the release announcement link which seems to be
> > the best way to point the visitor to the newest release.
>
> https://download.kde.org/stable/frameworks/ could also work as a
> download link. Other products' announcements at
> https://www.kde.org/announcements/ may confuse newcomers.

Well, random tarballs aren't any more useful than mixed release
announcements TBH. Perhaps announcements.php could grow a filter by
Name feature so we can link to it and only get frameworks results? I
mean, even thinking about it makes me uneasy but I fear this is about
the best we could hope for until we actually move the website to
wordpress and can put announcements into categories. So, I think the
announcements link could maybe be refined a bit, but in general I
think this is where we should link.

> IMO the best
> would be a page with links to https://cgit.kde.org/... for each of the
> frameworks.

You mean like https://api.kde.org/frameworks/attica/html/index.html ;)

There's a link to the documentation under the Get Started section on
the frameworks page, it's where it should be and where people would
find it. It's not super helpful to utter newbies, but for the somewhat
proficient cpp and cmake user it's where all the relevant information
of a framework is and where I would go have a look for information on
how to use a framework. After all, release artifacts (e.g. source
tarballs) are only part of the story here, a small one even, the much
bigger part is how do I even use this cool frameworks stuff.

That said in general the is the larger issue here that needs dealing
with eventually (possibly not within the scope of what Jon is doing):
"I learned about frameworks, I think it's cool, I want to write an app
using frameworks. What do I do now?". The current api.kde.org is
kind-of the answer, but then it already assumes a lot of background
knowledge and examples are pretty much not existent either.

Anyway, I am rambling... announcement.php might need tweaks, otherwise
I think we are good. Helping interested third party devs use our
frameworks is something that needs figuring out though.

HS


D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Kai Uwe Broulik
broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  The stylesheet stuff doesn't work, ie. the icon stays black in Breeze dark.
  Also, should it maybe have a "bolt" or something next to it as that's what we 
normally have for the batteries (optional)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17505

To: ndavis, #vdg, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Noah Davis
ndavis added a reviewer: broulik.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17505

To: ndavis, #vdg, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17505: Add preferences-system-bluetooth-battery to preferences.svgz

2018-12-11 Thread Noah Davis
ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  It's exactly the same as the regular 32px bluetooth icon in this file, but 
D17346  needs it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bluetooth-battery-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17505

AFFECTED FILES
  src/desktoptheme/breeze/icons/preferences.svgz

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 371 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/371/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 11 Dec 2018 13:27:58 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32094/60118)38%
(16583/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8352/14339)51%
(4682/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3914/7971)34%
(1605/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 10 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/10/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Tue, 11 Dec 2018 13:27:58 +
 Build duration:
6 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32061/60118)38%
(16552/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4269/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8331/14340)50%
(4663/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%

D17502: Store timestamp as UTC

2018-12-11 Thread Chinmoy Ranjan Pradhan
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1c3ecda86679: Store timestamp as UTC (authored by 
chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17502?vs=47343=47345

REVISION DETAIL
  https://phabricator.kde.org/D17502

AFFECTED FILES
  src/core/copyjob.cpp
  src/widgets/fileundomanager.cpp

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, davidedmundson, michaelh, ngraham, bruns


Re: KDE Frameworks web page

2018-12-11 Thread Alexander Potashev
Thanks!

вт, 11 дек. 2018 г. в 15:32, Jonathan Riddell :
> > 2. Text on the blue grid under "Organisation" is not very readable.
>
> Works for me.  Again it's copying what's on the Kirigami page.  Suggestions 
> welcome but the page needs some colour to break it up.

I don't speak CSS, but placing this white text over its own
text-shadow in blue (same dark blue as the background's primary color)
could make it more readable as the grid won't interfere the letters
anymore. (Sorry, it's just my guess, I didn't actually check how it
would look.)

> > 4. Can't find no direct link nor straightforward way to go to Git
> > repos or download source tarballs. I think these must be easy to
> > access, since KF5 is a developer-oriented product.
>
> I added 'download' to the release announcement link which seems to be
> the best way to point the visitor to the newest release.

https://download.kde.org/stable/frameworks/ could also work as a
download link. Other products' announcements at
https://www.kde.org/announcements/ may confuse newcomers. IMO the best
would be a page with links to https://cgit.kde.org/... for each of the
frameworks.

-- 
Alexander Potashev


D17502: Store timestamp as UTC

2018-12-11 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17502

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, davidedmundson, michaelh, ngraham, bruns


D17502: Store timestamp as UTC

2018-12-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  In cases where mtime, ctime and atime are displayed (KPropertiesDialog, 
RenameDialog, etc) KFileItem::time() does the task of converting them to local 
time.
  In all other cases storing them as UTC will suffice.

TEST PLAN
  1. RenameDialog shows correct mtime
  2. KPropertiesDialog shows correct mtime,ctime and atime.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17502

AFFECTED FILES
  src/core/copyjob.cpp
  src/widgets/fileundomanager.cpp

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, davidedmundson, michaelh, ngraham, bruns


Re: KDE Frameworks web page

2018-12-11 Thread Jonathan Riddell
On Tue, Dec 11, 2018 at 11:01:22AM +0300, Alexander Potashev wrote:
> пн, 10 дек. 2018 г. в 16:43, Jonathan Riddell :
> >
> > Frameworks has no web page and the announcements still point to the
> > 5.0 announcement for more information.
> >
> > So here's a proposal for adding to kde.org/products/
> >
> > https://www.kde.org/products/frameworks/
> 
> Hi,
> 
> Nice work!
> 
> Now nitpicking:
> 
> 1. The titles ending in fullstop look weird:
> "Features."
> "Organisation."
> "Get The Frameworks."

Changed that (it was copying what was on the kirigami page).

> 2. Text on the blue grid under "Organisation" is not very readable.

Works for me.  Again it's copying what's on the Kirigami page.  Suggestions 
welcome but the page needs some colour to break it up.

> 
> 3. I heard that "organisation" is British English, should be
> "organiZation" for the US variant.

Fixed

> 4. Can't find no direct link nor straightforward way to go to Git
> repos or download source tarballs. I think these must be easy to
> access, since KF5 is a developer-oriented product.

I added 'download' to the release announcement link which seems to be
the best way to point the visitor to the newest release.


D17498: Xdg Decoration Support

2018-12-11 Thread Vlad Zagorodniy
zzag added inline comments.

INLINE COMMENTS

> test_xdg_decoration.cpp:104
> +QSignalSpy compositorSpy(m_registry, ::compositorAnnounced);
> +QSignalSpy v6xdgShellSpy(m_registry, 
> ::xdgShellUnstableV6Announced);
> +QSignalSpy xdgShellSpy(m_registry, ::xdgShellStableAnnounced);

Do we need this spy?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17498

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns


D17425: Added DCB settings

2018-12-11 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:4332597370b8: Added DCB settings (authored by pranavgade, 
committed by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17425?vs=47338=47340#toc

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47338=47340

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns


D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson
davidedmundson marked 5 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17498

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns


D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson
davidedmundson updated this revision to Diff 47339.
davidedmundson added a comment.


  zzag's comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17498?vs=47336=47339

BRANCH
  xdg_deco

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns


D17425: Added DCB settings

2018-12-11 Thread Jan Grulich
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns


D17425: Added DCB settings

2018-12-11 Thread Pranav Gade
pranavgade updated this revision to Diff 47338.
pranavgade marked 7 inline comments as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47282=47338

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns


D17425: Added DCB settings

2018-12-11 Thread Jan Grulich
jgrulich added inline comments.

INLINE COMMENTS

> dcbsetting.cpp:491
> +
> +if (priorityFlowControl(7) > 0) {
> +setting.insert(QLatin1String(NM_SETTING_DCB_PRIORITY_FLOW_CONTROL), 
> QVariant::fromValue(priorityFlowControl()));

I think all those should be added all the time, checking whether the last one 
is higher can sometime avoid adding them to the map when one of previous ones 
is set to non-default value.

> dcbsetting.cpp:527
> +dbg.nospace() << NM_SETTING_DCB_PRIORITY_FLOW_CONTROL_FLAGS << ": " << 
> setting.priorityFlowControlFlags() << '\n';
> +
> +return dbg.maybeSpace();

You don't print priorityBandwith, priororityGroupBandwidth and others.

> dcbsetting.h:43
> +
> +enum DcbFlagsType {
> +None = 0,

Rename to DcbFlagType

> dcbsetting.h:124
> +};
> +
> +NETWORKMANAGERQT_EXPORT QDebug operator<<(QDebug dbg, const DcbSetting 
> );

Please also add Q_DECLARE_OPERATORS_FOR_FLAGS(DcbSetting::DcbFlags)

> setting.h:97
>  Q_DECLARE_FLAGS(SecretFlags, SecretFlagType)
> -
> +
>  enum MacAddressRandomization {

Remove trailing spaces. They are not visible here, but once I apply this patch, 
I see them in KDevelop.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns


D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson
davidedmundson updated this revision to Diff 47336.
davidedmundson added a comment.


  misc cleanups

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17498?vs=47331=47336

BRANCH
  xdg_deco

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns


D17498: Xdg Decoration Support

2018-12-11 Thread Vlad Zagorodniy
zzag added inline comments.

INLINE COMMENTS

> test_xdg_decoration.cpp:178-181
> +
> QTest::addColumn("configuredMode");
> +
> QTest::addColumn("configuredModeExp");
> +QTest::addColumn("setMode");
> +
> QTest::addColumn("setModeExp");

Do we actually use it?

> test_xdg_decoration.cpp:219
> +QVERIFY(shellSurfaceIface);
> +qDebug() << decorationIface->surface();
> +QCOMPARE(decorationIface->surface(), shellSurfaceIface);

Please delete it or provide useful output.

> test_xdg_decoration.cpp:237
> +QVERIFY(modeRequestedSpy.wait());
> +qDebug() << modeRequestedSpy.count();
> +qDebug() << modeRequestedSpy.first().first();

Same here.

> registry.h:665
> + * @see createXdgDecorationManager
> + * @since 5.47
> + **/

since 5.54?

> registry.h:1724
> +/**
> + * Emitted whenever a zxdg_decoration_manger_v1 gets removed.
> + * @param name The name of the removed interface

Typo: manger

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17498

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns


D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich updated this revision to Diff 47335.
astippich added a comment.


  - add missing test file

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17500?vs=47334=47335

BRANCH
  mobi

REVISION DETAIL
  https://phabricator.kde.org/D17500

AFFECTED FILES
  CMakeLists.txt
  autotests/mobiextractortest.cpp
  autotests/samplefiles/test.mobi
  cmake/FindQMobipocket.cmake
  src/extractors/mobiextractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich added a comment.


  I was unable to get a version check running with cmake, any help is 
appreciated

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D17500: Restore mobipocket extractor

2018-12-11 Thread Alexander Stippich
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Restore the mobipocket extractor based
  on the QMobipocket library, which was
  apparently dormant since the KF5 transition. 
  Adjust existing code where needed and fix tests.

REPOSITORY
  R286 KFileMetaData

BRANCH
  mobi

REVISION DETAIL
  https://phabricator.kde.org/D17500

AFFECTED FILES
  CMakeLists.txt
  autotests/mobiextractortest.cpp
  cmake/FindQMobipocket.cmake
  src/extractors/mobiextractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D17498: Xdg Decoration Support

2018-12-11 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Usual massive boilerplate.
  
  Should allow us to remove the injection in our QPT, as Qt 5.12 implements 
  this protocol directly. Will probably be relevant for other toolkits as
  it's more standardised than our custom one.
  
  Client is mostly 1:1 with the protocol, server side has some tweaking to
  fit with kwayland turning an event based API into a state based one.

TEST PLAN
  Relevant unit test
  Tried in modified kwin with our QPT disabled

REPOSITORY
  R127 KWayland

BRANCH
  xdg_deco

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17245: Add string formatting function to property info

2018-12-11 Thread Alexander Stippich
astippich marked 3 inline comments as done.
astippich added a comment.


  any further comments/objections?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D17301: add documentation to result class

2018-12-11 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
astippich marked an inline comment as done.
Closed by commit R293:60d6fc82ae5a: add documentation to result class (authored 
by astippich).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17301?vs=46987=47330

REVISION DETAIL
  https://phabricator.kde.org/D17301

AFFECTED FILES
  src/file/extractor/result.h

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D17302: add simple test for string merging

2018-12-11 Thread Alexander Stippich
astippich updated this revision to Diff 47329.
astippich added a comment.


  - updates for master

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17302?vs=46710=47329

BRANCH
  test_result

REVISION DETAIL
  https://phabricator.kde.org/D17302

AFFECTED FILES
  autotests/unit/file/CMakeLists.txt
  autotests/unit/file/resulttest.cpp
  src/file/extractor/result.h

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16716: fail writing test if mime type is not supported by the extractor

2018-12-11 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:239b0ef2b23b: fail writing test if mime type is not 
supported by the extractor (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16716?vs=46990=47328

REVISION DETAIL
  https://phabricator.kde.org/D16716

AFFECTED FILES
  autotests/taglibwritertest.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

2018-12-11 Thread Alexander Stippich
astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17338

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


Re: KDE Frameworks web page

2018-12-11 Thread Alexander Potashev
пн, 10 дек. 2018 г. в 16:43, Jonathan Riddell :
>
> Frameworks has no web page and the announcements still point to the
> 5.0 announcement for more information.
>
> So here's a proposal for adding to kde.org/products/
>
> https://www.kde.org/products/frameworks/

Hi,

Nice work!

Now nitpicking:

1. The titles ending in fullstop look weird:
"Features."
"Organisation."
"Get The Frameworks."

2. Text on the blue grid under "Organisation" is not very readable.

3. I heard that "organisation" is British English, should be
"organiZation" for the US variant.

4. Can't find no direct link nor straightforward way to go to Git
repos or download source tarballs. I think these must be easy to
access, since KF5 is a developer-oriented product.

-- 
Alexander Potashev


KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

2018-12-11 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/74/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 11 Dec 2018 07:56:57 +
 Build duration:
1 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)