KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 378 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/378/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 13 Dec 2018 23:43:18 +
 Build duration:
7 min 34 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5KIO_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32056/60119)38%
(16556/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8331/14341)50%
(4668/9267)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1603/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/17/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 13 Dec 2018 23:43:18 +
 Build duration:
7 min 5 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5KIO_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32073/60120)38%
(16560/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4274/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8343/14342)50%
(4667/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1603/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

ngraham added a comment.


  Reverted. Will find another way. Sorry for the regression, everyone!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

[Thomas Surrel]

thsurrel updated this revision to Diff 47545.
thsurrel added a comment.


  Create KUrlNavigator::isInsideCompressedPath
  Use this function instead of comparing the url scheme with tar, zip, ...

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17270?vs=46589=47545

BRANCH
  arc_urlnavigatorbutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17270

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/filewidgets/kurlnavigatorbutton.cpp

To: thsurrel, #frameworks
Cc: elvisangelaccio, gregormi, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Albert Astals Cid]

aacid added a comment.


  > @aacid what were the changes you had planned here?
  
  As Aleix mentioned the two methods can probably be made to call eachother, or 
maybe not, but needs to be investigated and an answer given to why not if not 
possible.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> slaveinterface_p.h:59
> +QVector sizes;
> +QVector times;
> +QElapsedTimer elapsed_timer;

You could use a struct for both, e.g.:

  struct SpeedSample {
  KIO::filesize_t remainder;
  qint64 elapsedTime;
  }
  QVector transferSpeed;

This would emphasize the two values always come in pairs, and would even remove 
some code above.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D17500: Restore mobipocket extractor

[Stefan Brüns]

bruns added a comment.


  In D17500#376324 , @mgallien wrote:
  
  > In D17500#376221 , @aacid wrote:
  >
  > > Do I understand that the answer to my "Is it possible to move the 
extractor to kdegraphics-mobipocket instead of having it in kfilemetadata? " 
question is no?
  >
  >
  > There is support for external extractors in KFileMetaData. As far as I 
know, it has not yeet been used.
  >  That is probably the safest way to do what you suggest.
  
  
  KFM supports two kinds of extractors, one QPlugin based, and one using 
external processes.
  
  The first one uses the interface defined **and exported** in 
kfilemetadata/extractor.h. Although it is AFAIK currently only used by by the 
extractors bundled in KFM, it can be used by any other Framework or Application.
  
  The second one uses Json over pipes to communicate with a forked process. The 
only available documentation is the sourcecode, i.e. `externalextractor.cpp`. 
It has more overhead (serializing/deserializing json data), but can be used 
where incompatible licenses would forbid linking with KFM.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: mgallien, aacid, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 7 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/7/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 13 Dec 2018 16:16:21 +
 Build duration:
4 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D17496: Change network/web color icons to consistent style

[Nathaniel Graham]

ngraham added a comment.


  Now that this is landed, feel free to change the symlinks by hand.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17496

To: ndavis, #vdg, ngraham
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 94 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/94/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 13 Dec 2018 16:16:21 +
 Build duration:
1 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D17496: Change network/web color icons to consistent style

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:50077910f783: Change network/web color icons to 
consistent style (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17496?vs=47499=47526

REVISION DETAIL
  https://phabricator.kde.org/D17496

AFFECTED FILES
  icons-dark/apps/48/internet-web-browser.svg
  icons-dark/categories/32/applications-internet.svg
  icons-dark/preferences/32/preferences-system-network.svg
  icons-dark/preferences/32/preferences-web-browser-cache.svg
  icons-dark/preferences/32/preferences-web-browser-cookies.svg
  icons-dark/preferences/32/preferences-web-browser-identification.svg
  icons-dark/preferences/32/preferences-web-browser-shortcuts.svg
  icons-dark/preferences/32/preferences-web-browser-ssl.svg
  icons-dark/preferences/32/preferences-web-browser-stylesheets.svg
  icons/apps/48/internet-web-browser.svg
  icons/categories/32/applications-internet.svg
  icons/preferences/32/preferences-system-network.svg
  icons/preferences/32/preferences-web-browser-cache.svg
  icons/preferences/32/preferences-web-browser-cookies.svg
  icons/preferences/32/preferences-web-browser-identification.svg
  icons/preferences/32/preferences-web-browser-shortcuts.svg
  icons/preferences/32/preferences-web-browser-ssl.svg
  icons/preferences/32/preferences-web-browser-stylesheets.svg

To: ndavis, #vdg, ngraham
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17496: Change network/web color icons to consistent style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  network-icon-consistency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17496

To: ndavis, #vdg, ngraham
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D10446: Add KLanguageName

[Harald Sitter]

sitter added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  @aacid what were the changes you had planned here?
  
  Does anyone else have thoughts on kcoreaddons vs. kconfigwidgets? I suppose 
we could move the class along with kf5_entry.desktop to kcoreaddons, since 
kconfigwidgets depends on kcoreaddons anyway it's a compatible change.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns, 
#frameworks

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

ngraham added a comment.


  Actually I feel like this regressed the visuals for the file dialog itself in 
the name of improving the situation for apps that use this view in a sidebar.
  
  Unfortunately, since it also regresses performance, I will be reverting it 
and and will look for another approach.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Andres Betts]

abetts added a comment.


  +1 for improving visuals

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, 
bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  @bcooksley for akonadi-search we need some special settings for the 
abi-create step. Where we should  store such settings?
  
  This is a more general solution, that we can also modify the settings for 
other platforms etc.
  
  `ci-tooling/local-metadata/abi-complience-checker.yaml`:
  
gcc_options:
- "-std=c++11"
- "-fPIC"
skip_include_paths:
- /usr/lib/python3.6/site-packages/utils/fake_libc_include
- /usr/include/clang/AST
- /usr/lib64/clang/6.0.1/include
add_include_paths:
- /usr/lib64/qt5/mkspecs/linux-g++

# "SUSEQt5.10":# platform specific
# gcc_options:
#- "-DSUSE5.10"

#"kde/*":# special settings for all repos in kde (fnmatch)
#   gcc_options:
#   - "-DKDE"

#"kde/pim/*":# special settings for all repos in kde/pim
#   gcc_options:
#   - "-DKDEPIM"
#  "SUSEQt5.10":   # for one specific platform
# gcc_options:
# - "-DKDEPIMSUSEQT5.10"

"kde/pim/akonadi-search": # for one repo
  "SUSEQt5.10":   # for one specific platform
gcc_options:
  - "-std=c++11"
  - "-fPIC"
  - "-DQT_NO_KEYWORDS"
  
  and the Python code to handle this:
  rules are:
  
  - anthing overwrites defauls (outer level)
  - most matching path overwrites less matching path
  - platform specific overwrites non platform stuff
  
  general -> specific
  default -> "basepath/*" -> "basepath/* - platform" -> "basepath/repo" ->  
"basepath/* - platform"
  
import yaml, fnmatch, copy

metadata = yaml.load(open('local-metadata/abi-complience-checker.yaml'))

def getSettings(path, platform):

entries = []
for key in metadata:
if fnmatch.fnmatch(path, key):
entries.append(key)

# sorting all entries - the entries at the end overwrites the former 
settings
# len is efficient, but would fail if we have single letter repo names
entries.sort(key=len)
entries.insert(0, platform) # add platform settings at the start

d = copy.copy(metadata) # load default settings
for entry in entries:
try:
  content = metadata[entry]
  d.update(content)
  d.update(content[platform]) # try to load platform specific 
settings
except KeyError:
  pass
return d

getSettings("kde/pim/akonadi-search",  "SUSEQt5.10")

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham added a comment.


  @dfaure I'm not so familiar writing unit tests. This is one I have made by 
doing some modifications. would you like to give me some help?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham added a comment.


void JobTest::moveDirectoryToInaccessibleFilesystem()
{
#ifdef Q_OS_WIN
QSKIP("Skipping unaccessible folder test on Windows, cannot remove all 
permissions from a folder");
#endif
// Given a directory that cannot be moved to destination beacause 
filesystem is write protected
const QString src = homeTmpDir() + "srcdir";
const QString dest = homeTmpDir() + "destdir";
//QVERIFY(QDir().mkpath(src));
QVERIFY(QFileInfo(src).isDir());
QVERIFY(QFile(dest).setPermissions(QFile::Permissions())); // Make it 
inaccessible

KIO::CopyJob *job = KIO::move(QUrl::fromLocalFile(src), 
QUrl::fromLocalFile(dest), KIO::HideProgressInfo);
job->setUiDelegate(nullptr);
job->setUiDelegateExtension(nullptr);

// The job should fail with "access denied"
QVERIFY(!job->exec());
QCOMPARE(job->error(), (int)KIO::ERR_CANNOT_WRITE);

QVERIFY(QFile::exists(dest));

// Cleanup
QVERIFY(!QFile::exists(src));
}

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17528: Refactor SlaveInterface::calcSpeed

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 47518.
chinmoyr added a comment.


  
  
  1. Updating D17528 : Refactor 
SlaveInterface::calcSpeed #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
  
  Used QVector

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17528?vs=47427=47518

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17528

AFFECTED FILES
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[David Faure]

dfaure added a comment.


  The logic is the same in all cases, the mode doesn't really make a 
difference, so I'm ok with picking one -- let's say Move, so we can also check 
that nothing disappeared.
  File or folder also makes no difference, so I'm ok with just one of these.
  The one thing that does make a difference is having more source items to 
copy/move, as discussed here, so maybe the test could try moving two files or 
two folders.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Nathaniel Graham]

ngraham added a comment.


  In D17461#376509 , @apol wrote:
  
  > Hey, this change makes the file dialog crawl on big directories.
  >  For me, going into /usr/include makes the whole application freeze.
  >
  > We should consider reverting and trying a different approach.
  
  
  Weird, but can confirm. :/ I guess the minimum width calculation for the name 
column is a non-trivial operation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Aleix Pol Gonzalez]

apol added a comment.


  Hey, this change makes the file dialog crawl on big directories.
  For me, going into /usr/include makes the whole application freeze.
  
  We should consider reverting and trying a different approach.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D17528#376349 , @dfaure wrote:
  
  > I'm surprised, how can a QLinkedList (with nodes allocated all over the 
memory) be better than a static array (which fits into the same memory cache) ?
  
  
  IMO It is better only in terms of how the code looks. I saw the for loop 
shifting elements and immediately felt the urge to use QLinkedList. I never 
thought of the memory allocation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham marked an inline comment as done.
shubham added a comment.


  @dfaure do you need tests for all three modes ie. copy,move and link
  And individually for files and folders

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17558: Fix XDGForeign Client header installs

[David Edmundson]

davidedmundson edited the summary of this revision.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17558

To: davidedmundson, zzag
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17558: Fix XDGForeign Client header installs

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17558

To: davidedmundson, zzag
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17558: Fix XDGForeign Client header installs

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  XdgForeign.h contains the public classes that a client could use.
  Xdgforeign_v2 is entirely internal.
  
  Technically this is arguably API break, but every single class exported
  in the installed header isn't exported.
  
  It won't cause an issue.

TEST PLAN
  Installed

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17558

AFFECTED FILES
  src/client/CMakeLists.txt

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> shubham wrote in copyjob.cpp:868-872
>   emitresult() emits the corresponding signal and then commits suicide, hence 
> no such chance possible.

Still, don't call statNextSrc() then.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 377 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/377/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 13 Dec 2018 10:39:43 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32085/60118)38%
(16581/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4278/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8344/14340)50%
(4678/9267)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
   

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in copyjob.cpp:868-872
> emitting a result and then continuing seems questionable, you'll end up with 
> the job emitting another result later

emitresult() emits the corresponding signal and then commits suicide, hence no 
such chance possible.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/16/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 13 Dec 2018 10:39:43 +
 Build duration:
6 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32052/60120)38%
(16554/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4277/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8332/14342)50%
(4669/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  okay with merging D17534  CI now 
successfully builds the abis for the mentioned packages. (I modified the last 
comment)

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, 
knauss, alexeymin, kaning, blazquez

D17545: Do not stat move/copy job if the destination file system does not support writing

[David Edmundson]

davidedmundson added a comment.


  > And there should be a unittest for it.
  
  This still needs doing

INLINE COMMENTS

> copyjob.cpp:867
> +q->setError(ERR_CANNOT_WRITE);
> +q->setErrorText(m_currentDestURL.toDisplayString());
> +q->emitResult();

that's not going to be a helpful error text on it's own.

Code above calls buildErrorString

> copyjob.cpp:868-872
> +q->emitResult();
> +if (that) {
> +statNextSrc();
> +}
> +return;

emitting a result and then continuing seems questionable, you'll end up with 
the job emitting another result later

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[Shubham]

shubham updated this revision to Diff 47503.
shubham marked 3 inline comments as done.
shubham added a comment.


  Done above requested changes.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17545?vs=47465=47503

REVISION DETAIL
  https://phabricator.kde.org/D17545

AFFECTED FILES
  src/core/copyjob.cpp

To: shubham, #frameworks, dfaure
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/15/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 13 Dec 2018 08:59:27 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32095/60120)38%
(16585/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4280/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8357/14342)51%
(4680/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3910/7970)34%
(1606/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
  

D17496: Change network/web color icons to consistent style

[Noah Davis]

ndavis updated this revision to Diff 47499.
ndavis added a comment.


  Re-add `applications-internet` symlink to `preferences/32`

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17496?vs=47359=47499

BRANCH
  network-icon-consistency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17496

AFFECTED FILES
  icons-dark/apps/48/internet-web-browser.svg
  icons-dark/categories/32/applications-internet.svg
  icons-dark/preferences/32/preferences-system-network.svg
  icons-dark/preferences/32/preferences-web-browser-cache.svg
  icons-dark/preferences/32/preferences-web-browser-cookies.svg
  icons-dark/preferences/32/preferences-web-browser-identification.svg
  icons-dark/preferences/32/preferences-web-browser-shortcuts.svg
  icons-dark/preferences/32/preferences-web-browser-ssl.svg
  icons-dark/preferences/32/preferences-web-browser-stylesheets.svg
  icons/apps/48/internet-web-browser.svg
  icons/categories/32/applications-internet.svg
  icons/preferences/32/preferences-system-network.svg
  icons/preferences/32/preferences-web-browser-cache.svg
  icons/preferences/32/preferences-web-browser-cookies.svg
  icons/preferences/32/preferences-web-browser-identification.svg
  icons/preferences/32/preferences-web-browser-shortcuts.svg
  icons/preferences/32/preferences-web-browser-ssl.svg
  icons/preferences/32/preferences-web-browser-stylesheets.svg

To: ndavis, #vdg, ngraham
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 376 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/376/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 13 Dec 2018 08:59:27 +
 Build duration:
6 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32051/60119)38%
(16558/44090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9091/9538)48%
(4276/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8331/14341)50%
(4671/9267)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7970)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)88%
(95/108)68%
(45/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
  

D17554: [KFileItem] Fix isLocal check in checkDesktopFile

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:86e3142f8588: [KFileItem] Fix isLocal check in 
checkDesktopFile (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17554?vs=47493=47498

REVISION DETAIL
  https://phabricator.kde.org/D17554

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, dfaure, davidedmundson, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[David Faure]

dfaure added a comment.


  I'm surprised, how can a QLinkedList (with nodes allocated all over the 
memory) be better than a static array (which fits into the same memory cache) ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> copyjob.cpp:862
> +// if the destination file system doesn't support writing, do not 
> stat
> +QFileInfo destInfo(m_currentDestURL.toString());
> +if ((m_mode == CopyJob::Copy || m_mode == CopyJob::Move) && 
> (destInfo.isDir() && destInfo.isWritable())) {

Wrong mix of URLs and paths. How can this ever work? QFileInfo takes local 
paths, and you're giving it a full URL?

All this should be inside if (m_currentDestURL.isLocalFile()) and use 
m_currentDestURL.toLocalFile() as the path to give to QFileInfo.

> copyjob.cpp:863
> +QFileInfo destInfo(m_currentDestURL.toString());
> +if ((m_mode == CopyJob::Copy || m_mode == CopyJob::Move) && 
> (destInfo.isDir() && destInfo.isWritable())) {
> +QPointer that = q;

Why the "copy or move" test? The only alternative is creating a symlink, which 
also requires being able to write, no?

> copyjob.cpp:865
> +QPointer that = q;
> +emit q->warning(q, buildErrorString(ERR_CYCLIC_COPY, 
> m_currentDestURL.toDisplayString()));
> +if (that) {

This used to be an error, now it gets degraded to a warning. This means 
applications performing the copy will think it actually worked, only the user 
got (maybe) a warning

I think this should be an error.

And there should be a unittest for it. 
JobTest::copyFolderWithUnaccessibleSubfolder shows how to make a folder 
non-writable (and still be able to clean it up at the end). A similar test 
should be added where the destination is the one that is unaccessible (or just 
unwritable).

> broulik wrote in copyjob.cpp:864
> Not sure `ERR_CYCLIC_COPY` is the correct error for this?

It doesn't sound like it, no. This should rather be ERR_CANNOT_WRITE.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17545

To: shubham, #frameworks, dfaure
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17554: [KFileItem] Fix isLocal check in checkDesktopFile

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17554

To: broulik, dfaure, davidedmundson, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns