D17550: Make the open url in tab feature a bit more discoverable

apol updated this revision to Diff 47706. apol added a comment. Remove unrelated change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17550?vs=47705=47706 BRANCH arcpatch-D17550 REVISION DETAIL https://phabricator.kde.org/D17550 AFFECTED FILES

D17550: Make the open url in tab feature a bit more discoverable

apol updated this revision to Diff 47705. apol added a comment. add space REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17550?vs=47481=47705 BRANCH arcpatch-D17550 REVISION DETAIL https://phabricator.kde.org/D17550 AFFECTED FILES

D17550: Make the open url in tab feature a bit more discoverable

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kurlnavigator.cpp:483 > Do we really have to put the folder name in the extry text? This will make > the popup menu very large if the folder name is long. My thinking was that it's the

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham updated this revision to Diff 47703. ngraham marked 3 inline comments as done. ngraham added a comment. Address review comments (thanks @dfaure!) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17617?vs=47699=47703 BRANCH arcpatch-D17617 REVISION

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. > "By consulting https://lxr.kde.org/search?_filestring=&_string=BatchRenameJob we can see that Dolphin is the only application to make use of this BatchRenameJob API."

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 381 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/381/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 16 Dec 2018 22:27:42 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/20/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 16 Dec 2018 22:27:42 + Build duration: 5 min 48 sec and counting BUILD ARTIFACTS

D17617: Display error instead of silently failing when asked to create folder that already exists

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. BTW if you also want the mkpath case to error-if-already-exists, I guess this could be implemented in KIO::mkpath with a flag [and then the if()/else() isn't needed anymore,

D10446: Add KLanguageName

aacid added inline comments. INLINE COMMENTS > kf5_entry.desktop:1 > +[KCM Locale] > +Name=Catalan This is going to be a problem, scripty is going to come and whipe these .desktop files out and then make the translators translate them again. Wonder if we could rename them to

D17623: Add YaST icons

ndavis added a comment. In D17623#378248 , @ngraham wrote: > In D17623#378023 , @ndavis wrote: > > > When the time comes, we can make symlinks with more appropriate names and different sizes. >

D17623: Add YaST icons

ndavis added a comment. LCP, the other openSUSE designer I've been working with, had this to say: > I have to disagree with ngraham here, imagine how many potential conflicts in hicolor we could get if yast icons had no prefix and we can't load those icons from resource like

D17623: Add YaST icons

ngraham added reviewers: cfeck, broulik, elvisangelaccio. ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D17623#378023 , @ndavis wrote: > I'd have to make PRs for ~60 GitHub

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

ngraham added a comment. It might not be the worst thing in the world if you made this a general-purpose rename dialog, so that it handles the simple common case of renaming one items as well as the complicated case where multiple items are renamed. If you do that, I'll abandon D17595

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin, elvisangelaccio Cc: dfaure, emateli, elvisangelaccio, Codezela, kde-frameworks-devel, michaelh, ngraham, bruns

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham updated this revision to Diff 47699. ngraham edited the test plan for this revision. ngraham added a comment. Use a better approach that works in all cases REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17617?vs=47649=47699 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/19/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 16 Dec 2018 20:58:16 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 380 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/380/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 16 Dec 2018 20:58:16 + Build duration: 22 min and counting BUILD ARTIFACTS

D16981: [kfilewidget] Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:33442c012eb2: [kfilewidget] Return editable URL navigator to breadcrumb mode if it has focus… (authored by ngraham).

D16981: [kfilewidget] Return editable URL navigator to breadcrumb mode if it has focus and everything is selected and when Ctrl+L is pressed

ngraham added a comment. Landing this too since its Dolphin companion (D16980 ) has been accepted, and the code change is virtually identical. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16981 To: ngraham, #frameworks, #dolphin

D17617: Display error instead of silently failing when asked to create folder that already exists

dfaure added a comment. What might be easier is: - if the user entered something without '/', use KIO::mkdir() (which will fail with ERR_DIR_ALREADY_EXIST if the dir already exists) - if the user entered something with '/', use KIO::mkpath() as the code currently does. Much

D17617: Display error instead of silently failing when asked to create folder that already exists

dfaure added a comment. In D17617#378199 , @ngraham wrote: > Oh darn, now do I check for the existence of a directory in a network-transparent, KIO-ish way? Use a `listJob` or something? KIO::stat() REPOSITORY R241 KIO REVISION

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli added a subscriber: chinmoyr. emateli added a comment. Pinging @chinmoyr as the original author of the BatchRenameJob class. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: chinmoyr, mlaurent, asensi, rkflx,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli updated this revision to Diff 47694. emateli added a comment. - convert to namespace from class - do not show first captured group - remove help button - Use d-ptr pattern - remove show/hide methods and autoshow dialog - update doc - KFileItemList -> QList; KFileItem usage

D17617: Display error instead of silently failing when asked to create folder that already exists

emateli added a comment. FWIW: The patch over at D11304 changes the behavior to select the currently existing folder instead of doing nothing. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin,

D17310: Improve Kile icon with LaTeX font

ngraham accepted this revision. ngraham added a comment. I like the current version, FWIW. #kile folks ,what do you think? REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham added a comment. Oh darn, now do I check for the existence of a directory in a network-transparent, KIO-ish way? Use a `listJob` or something? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin, elvisangelaccio Cc: elvisangelaccio,

D17545: Do not stat move/copy job if the destination file system does not support writing

dfaure added a comment. My proposal is at https://phabricator.kde.org/D17632 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

dfaure retitled this revision from "Unittest only" to "Move/copy job: skip stat'ing sources if the destination dir isn't writable". dfaure edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17632 To: dfaure, shubham, broulik, bruns Cc:

D17632: Unittest only

dfaure updated this revision to Diff 47689. dfaure added a comment. merge the commits REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17632?vs=47688=47689 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17632 AFFECTED FILES

D17632: Unittest only

dfaure created this revision. dfaure added reviewers: shubham, broulik, bruns. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY Move/copy job: skip stat'ing sources if the

D17631: class Message: Use inclass member initialization

loh.tar accepted this revision. loh.tar added a comment. This revision is now accepted and ready to land. I'm surprised. Obviously have you change something previous (?) REPOSITORY R39 KTextEditor BRANCH message_inclass_member_initializationa REVISION DETAIL

D17545: Do not stat move/copy job if the destination file system does not support writing

dfaure added a comment. In fact this is the wrong location for this code. The checks on the dest dir are in CopyJobPrivate::slotResultStating. I'm working on a different fix. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc:

D17631: class Message: Use inclass member initialization

dhaumann created this revision. dhaumann added a reviewer: loh.tar. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY No change in logic, just some reorganization of initialization

D17624: KTextEditor::Message: Review documentation

dhaumann closed this revision. REVISION DETAIL https://phabricator.kde.org/D17624 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/9/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 16 Dec 2018 18:44:11 + Build duration: 6 min 12 sec and counting BUILD ARTIFACTS

D17624: KTextEditor::Message: Review documentation

dhaumann added a comment. I integrated this now, see a16d082370a44fcbae3a204bfede1db6e6dffe86 - the change also includes the rename of autoHide to autoHideDelay. The function names cannot be changed of course, since it's public API. REVISION DETAIL https://phabricator.kde.org/D17624 To:

D17620: Make setHelp() public

ltoscano added a comment. There may be another way: add a new public method which wraps the protected one, and when moving to KF6 a) make setHelp public and b) deprecate the new wrapper. I think - suggestions needed REPOSITORY R265 KConfigWidgets REVISION DETAIL

D17620: Make setHelp() public

yurchor added a comment. In D17620#378112 , @aacid wrote: > In D17620#378110 , @yurchor wrote: > > > Abandoned due to the policy violation. Despite of the handful help pages invocation, it is

D17620: Make setHelp() public

aacid added a comment. In D17620#378110 , @yurchor wrote: > Abandoned due to the policy violation. Despite of the handful help pages invocation, it is obvious that this change will never happen. > > Just a side note: the protected method is

D17620: Make setHelp() public

yurchor abandoned this revision. yurchor added a comment. Abandoned due to the policy violation. Despite of the handful help pages invocation, it is obvious that this change will never happen. Just a side note: the protected method is useless and can be removed without loss of any

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

ahmadsamir added reviewers: cullmann, davidedmundson. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17630 To: ahmadsamir, cullmann, davidedmundson Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir added a dependent revision: D17630: Don't re-mark words added/ignored to the dictionary as misspelled. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

ahmadsamir created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ahmadsamir requested review of this revision. REVISION SUMMARY When a word is added to the dictionary or ignored via the spellingMenu, the BackgroundChecker

D17624: KTextEditor::Message: Review documentation

loh.tar added a comment. Sorry for the hassle, will revert the update > Further, I would prefer autoHideDelay instead of just delay. Are you refering here to the header or the code part? The old name in the header was "autoHideTimeR" which is pretty wrong. So have I to change this

D17620: Make setHelp() public

aacid added a comment. You can always just use QMetaObject::invokeMethod it's a bit lame, but slots are never really non-public if you use the metaobject system INLINE COMMENTS > elvisangelaccio wrote in kconfigdialog.h:176 > If I'm not mistaken, moving a function from `protected` to

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir added reviewers: davidedmundson, cullmann. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadsamir requested review of this revision. REVISION SUMMARY Add convience method to add a word to BackgroundChecker the session of the currentDict speller. REPOSITORY

D17624: KTextEditor::Message: Review documentation

dhaumann added a comment. Now you are mixing documentation changes with code changes. I would have preferred to have different review requests, especially since the documentation part was already reviewed. Further, I would prefer autoHideDelay instead of just delay. If we use "delay" only,

D17545: Do not stat move/copy job if the destination file system does not support writing

dfaure added inline comments. INLINE COMMENTS > jobtest.cpp:1004 > + > +QSignalSpy spy(job, ::error); > +job->setUiDelegate(nullptr); At runtime, Qt says: QSignalSpy: Not a valid signal: '' Indeed this is the getter, not a signal. `result()` is the signal, but you don't really need

D17619: Unit test and fix for bug 401552

dfaure added a comment. What happened to the unittest promised by the commit log? ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17619 To: jtamate, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17619: Unit test and fix for bug 401552

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoredirlister.cpp:1580 > +while (!dir->lstItems.isEmpty()) { > +const KFileItem oldItem = dir->lstItems.takeFirst(); > +

D17623: Add YaST icons

ndavis added a comment. In D17623#378006 , @ngraham wrote: > Nice work, these are good icons! > > However, I wonder whether we really want to use the `yast-` prefix for these images, especially the ones without explicit opensuse iconography.

D17624: KTextEditor::Message: Review documentation

loh.tar updated this revision to Diff 47678. loh.tar added a comment. -Rename member autoHide->delay to fit accepted change in header file just an offer CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17624?vs=47673=47678 REVISION DETAIL https://phabricator.kde.org/D17624

D17623: Add YaST icons

ngraham added a comment. Nice work, these are good icons! However, I wonder whether we really want to use the `yast-` prefix for these images, especially the ones without explicit opensuse iconography. I can imagine some of these being useful in other apps' settings dialogs as well, but

D17623: Add YaST icons

ndavis updated this revision to Diff 47674. ndavis added a comment. Change printer and scanner icons to 32px since YaST Control Center doesn't want to work with symlinks to 64px device icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D17624: KTextEditor::Message: Review documentation

loh.tar updated this revision to Diff 47673. loh.tar added a comment. - Fix optionally/optional + be I like to suggest that some more eyes take a look at that :-) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17624?vs=47669=47673 REVISION DETAIL

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham added a comment. Did anyone tried it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17624: KTextEditor::Message: Review documentation

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks almost good, except for "optional" and a missing "be". Could you update again? INLINE COMMENTS > message.h:337 > /** > - * Optionally set an icon for this notification.

D17624: KTextEditor::Message: Review documentation

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Reduce redundant text - Change some argument names in the

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Most of these icons are meant to be used in YaST Control Center. There is currently an

D17310: Improve Kile icon with LaTeX font

loh.tar added a comment. The used traffic cone by VLC is for me also nondescript, but that's their icon and therefore we know it. My point is only that your new icon should be somehow similar to the stuff used by Kile, and not to try to describe what we can do with Kile. Should I miss

D17619: Unit test and fix for bug 401552

jtamate updated this revision to Diff 47666. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. I think this time I got the problem right. One of the classics: I was modifying the list while it was being used. REPOSITORY

D17620: Make setHelp() public

elvisangelaccio added inline comments. INLINE COMMENTS > kconfigdialog.h:176 > > +public Q_SLOTS: > +/** If I'm not mistaken, moving a function from `protected` to `public` breaks the ABI REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17620 To:

D17620: Make setHelp() public

yurchor created this revision. yurchor added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. yurchor requested review of this revision. REVISION SUMMARY Sometimes it is useful to connect configuration dialogs directly with the

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

elvisangelaccio added inline comments. INLINE COMMENTS > kurlnavigator.h:297 > + */ > +bool isInsideCompressedPath(const QUrl ) const; > + I'd make this function `static`, since it doesn't depend on the status of a specific `KUrlNavigator` instance. To do so, `isCompressedPath()`

D17500: Restore mobipocket extractor

aacid added a comment. I would really like the module to be in the mobipocket repo, would serve as actual proof the extractors outside the main module work if we have an example of it :) INLINE COMMENTS > FindQMobipocket.cmake:1 > +# - Find QMobipocket > +# Find the Qmobipocket library.

D17245: Add string formatting function to property info

astippich added a comment. String freeze is approaching next week, and I would like to get this in for 5.54 so that I can start porting Dolphin and baloo-widgets. Anyone? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns,

D17245: Add string formatting function to property info

astippich updated this revision to Diff 47660. astippich added a comment. - improve code readability REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=46859=47660 BRANCH display_value REVISION DETAIL https://phabricator.kde.org/D17245

D17550: Make the open url in tab feature a bit more discoverable

elvisangelaccio added inline comments. INLINE COMMENTS > kurlnavigator.cpp:480 > +if (q->receivers(SIGNAL(tabRequested(QUrl))) > 0) { > +for(auto button : qAsConst(m_navButtons)) { > +if (button->geometry().contains(p)) { Space after `for` > kurlnavigator.cpp:483 > +

D17548: Fixed link to the coding style wiki page

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5d9f4415f7a8: Fixed link to the coding style wiki page (authored by janpr, committed by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17310: Improve Kile icon with LaTeX font

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To: trickyricky26, #vdg, ngraham, #kile Cc: loh.tar,

D17310: Improve Kile icon with LaTeX font

trickyricky26 updated this revision to Diff 47658. trickyricky26 added a comment. - Use Cantor formula design with a bigger pen REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17310?vs=47591=47658 BRANCH improve-kile-icon (branched from master)

D17310: Improve Kile icon with LaTeX font

trickyricky26 added a comment. In D17310#377145 , @loh.tar wrote: > For me is these root sign nondescript. When the orig old blue symbol is not desired, how about to freshen it up? How? I don't know. > Perhaps Black & White just as all your

D17619: Unit test and fix for bug 401552

elvisangelaccio added inline comments. INLINE COMMENTS > kdirlistertest.cpp:1299-1308 > +const QString dirX = m_tempDir.path() + "/x"; > +QVERIFY(QDir().mkdir(dirX)); > +const QString dirX1 = m_tempDir.path() + "/x/x1"; > +QVERIFY(QDir().mkdir(dirX1)); > +const QString dirX2

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 379 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/379/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 16 Dec 2018 10:37:57 + Build duration: 8 min 47 sec and counting JUnit Tests Name: (root) Failed: 0

D17619: Unit test and fix for bug 401552

elvisangelaccio added a comment. Unfortunately it's still crashing for me, even with this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17619 To: jtamate, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/18/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 16 Dec 2018 10:37:57 + Build duration: 6 min 49 sec and counting BUILD ARTIFACTS

D17617: Display error instead of silently failing when asked to create folder that already exists

elvisangelaccio added a comment. Note that `mkdir` also doesn't warn if the folder already exists. I guess `KNewFileMenu` was designed to behave accordingly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin, elvisangelaccio Cc:

T3689: Add abi compliance checker to CI

bcooksley added a comment. Okay, there have been a number of comments here since i've last read it, so a bit to catch up on and go over. In regards to `akonadi-mime` I have now re-run it, and it seems to work fine. As long as you're relying only on the master manifest.yaml, then it

D17619: Unit test and fix for bug 401552

jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17619 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate added a comment. Let's continue on D17619 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10742 To: jtamate, #frameworks, dfaure Cc: elvisangelaccio, bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham

D17619: Unit test and fix for bug 401552

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Add a unit test that fails before applying the patch and doesn't after the