D16966: Fix typo in i18n message (cmdline option description)

2018-12-17 Thread Laurent Montel
mlaurent added a comment.


  no commited yet ?:)

REPOSITORY
  R290 KPackage

BRANCH
  opt-i18n

REVISION DETAIL
  https://phabricator.kde.org/D16966

To: aspotashev, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17623: Add YaST icons

2018-12-17 Thread Nathaniel Graham
ngraham added a comment.


  Thanks! Here's a preliminary suggestion:
  
Current icon  What it should be a symlink to

apps/32/yast-apparmor.svg 
preferences/32/preferences-security-apparmor.svg
apps/32/yast-auth-client.svg  
preferences/32/preferences-security-kerberos.svg
apps/32/yast-autoyast.svg 
apps/32/yast-bootloader.svg   
preferences/32/preferences-system-startup.svg
apps/32/yast-checkmedia.svg   
preferences/32/preferences-devices-drive-optical-ok.svg
apps/32/yast-create-new-vm.svgpreferences/32/preferences-vm-add.svg
apps/32/yast-device-tree.svg  preferences/32/preferences-devices.svg
apps/32/yast-dhcp-server.svg  
preferences/32/preferences-system-network-server-dhcp.svg
apps/32/yast-disk.svg 
preferences/32/preferences-devices-drive-harddisk-partitions.svg
apps/32/yast-dns-server.svg   
preferences/32/preferences-system-network-server-dns.svg
apps/32/yast-docker.svg   
preferences/32/preferences-system-docker.svg
apps/32/yast-dsl.svg  
preferences/32/preferences-system-network-modem.svg
apps/32/yast-firewall.svg 
preferences/32/preferences-security-firewall.svg
apps/32/yast-ftp-server.svg   
preferences/32/preferences-system-network-server-ftp.svg
apps/32/yast-hardware.svg preferences/32/preferences-system-cpu.svg
apps/32/yast-host.svg 
preferences/32/preferences-system-network-server.svg
apps/32/yast-http-server.svg  
preferences/32/preferences-system-network-server-http.svg
apps/32/yast-hwinfo.svg   
preferences/32/preferences-system-hwinfo.svg
apps/32/yast-instserver.svg   
preferences/32/preferences-system-network-server-install.svg
apps/32/yast-iscsi-client.svg 
preferences/32/preferences-devices-drive-harddisk-iscsi.svg
apps/32/yast-iscsi-server.svg 
preferences/32/preferences-system-network-server-iscsi.svg
apps/32/yast-journal.svg  preferences/32/preferences-book.svg
apps/32/yast-kerberos-server.svg  
preferences/32/preferences-system-network-server-security.svg
apps/32/yast-kernel.svg   
preferences/32/preferences-system-linux.svg
apps/32/yast-lan.svg  
preferences/32/preferences-system-network-ethernet.svg
apps/32/yast-ldap-server.svg  
preferences/32/preferences-system-network-server-ldap.svg
apps/32/yast-ldap.svg 
preferences/32/preferences-system-network-ldap.svg
apps/32/yast-mail.svg 
preferences/32/preferences-system-network-server-mail.svg
apps/32/yast-messages.svg preferences/32/preferences-system-log.svg
apps/32/yast-nfs-server.svg   
preferences/32/preferences-system-network-server-nfs.svg
apps/32/yast-nis-server.svg   
preferences/32/preferences-system-network-server-nis.svg
apps/32/yast-nis.svg  
preferences/32/preferences-desktop-user-nis.svg
apps/32/yast-ntp-client.svg   
preferences/32/preferences-system-network-ntp.svg
apps/32/yast-printer.svg  
preferences/32/preferences-devices-printer.svg
apps/32/yast-proxy.svg
preferences/32/preferences-system-network-proxy.svg
apps/32/yast-release-notes.svg
preferences/32/preferences-releasenotes.svg
apps/32/yast-remote.svg   
preferences/32/preferences-system-network-remote.svg
apps/32/yast-samba-client.svg 
preferences/32/preferences-system-network-samba.svg
apps/32/yast-samba-server.svg 
preferences/32/preferences-system-network-server-samba.svg
apps/32/yast-scanner.svg  
preferences/32/preferences-devices-scanner.svg
apps/32/yast-security.svg preferences/32/preferences-security.svg
apps/32/yast-services-manager.svg preferences/32/preferences-services.svg
apps/32/yast-slp-server.svg   
preferences/32/preferences-system-network-server-slp.svg
apps/32/yast-snapper.svg  
preferences/32/preferences-devices-drive-harddisk-snapper.svg
apps/32/yast-software.svg 
apps/32/yast-sudo.svg 
preferences/32/preferences-desktop-user-sudo.svg
apps/32/yast-support.svg  preferences/32/preferences-system-help.svg
apps/32/yast-sw_single.svg
apps/32/yast-sw_source.svg
apps/32/yast-sysconfig.svgpreferences/32/preferences.svg
apps/32/yast-system.svg   maybe replace 
preferences/32/preferences-desktop.svg with this and make the icon a symlink to 
it
apps/32/yast-tftp-server.svg  
preferences/32/preferences-system-network-server-tftp.svg
apps/32/yast-update.svg   
apps/32/yast-vm-install.svg   preferences/32/preferences-vm-install.svg
apps/32/yast-vm-migrate.svg   preferences/32/preferences-vm-migrate.svg
apps/32/yast-vm.svg   preferences/32/preferences-vm.svg

D17647: Fix KGlobalAccel build with Qt 5.13 prerelease

2018-12-17 Thread Michael Pyne
mpyne created this revision.
mpyne added reviewers: Frameworks, graesslin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mpyne requested review of this revision.

REVISION SUMMARY
  After a recent system upgrade to Qt git `dev` branch (for upcoming 5.13), 
kglobalaccel started to fail to build due to problems compiling a moc file. 
Oddly, all other frameworks in KF5 (except those depending upon kglobalaccel) 
compiled fine.
  
  I spent some time looking into several potential Qt moc or other issues, but 
to save you all the time I wasted on it, the essence is that you shouldn't 
`#include "foo.moc"` from within a C++ namespace. Previously this would have 
worked since only symbols relevant to the current C++ namespace were defined.
  
  But with updated Qt, the moc generates files that rely on parts of the C++ 
standard library being available, and duly includes a line `#include `. 
At the top namespace level this works great. Including `` from within 
our own namespace works less well, producing error messages that cause LLVM to 
give up early.
  
  I fix by just removing the entry since CMake is automoc'ing anyways. If we 
need to include the entry then moving it to the end of the file instead would 
probably work just as well. Note that moc is itself smart enough to capture the 
namespacing of the class we declare.

TEST PLAN
  Completed build of KGlobalAccel, installs successfully, dependent modules 
install successfully, new Plasma desktop loads fine.
  
  All 2 autotests still pass.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D17647

AFFECTED FILES
  src/runtime/component.cpp

To: mpyne, #frameworks, graesslin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17550: Make the open url in tab feature a bit more discoverable

2018-12-17 Thread Aleix Pol Gonzalez
apol closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17550

To: apol, #dolphin, ngraham, #frameworks, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D17178: Don't ask for confimation when reloading

2018-12-17 Thread Nicolas Fella
nicolasfella updated this revision to Diff 47740.
nicolasfella added a comment.


  - delete m_modOnHdHandler

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17178?vs=46283=47740

BRANCH
  arcpatch-D17178

REVISION DETAIL
  https://phabricator.kde.org/D17178

AFFECTED FILES
  src/document/katedocument.cpp

To: nicolasfella, #kate, ngraham, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann


D17245: Add string formatting function to property info

2018-12-17 Thread Stefan Brüns
bruns added a reviewer: Frameworks.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D17245: Add string formatting function to property info

2018-12-17 Thread Stefan Brüns
bruns added inline comments.

INLINE COMMENTS

> formatstrings.cpp:27
> +
> +const KFormat FormatStrings::form;
> +

I don't think using a static default constructed KFormat is a good idea ...

> formatstrings.cpp:50
> +QTime time = dt.time();
> +if (!time.hour() && !time.minute() && !time.second()){
> +return FormatStrings::form.formatRelativeDate(dt.date(), 
> QLocale::LongFormat);

Why is midnight an invalid time?

> propertyinfo.cpp:567
> +
> +if (d->formatAsString == nullptr) {
> +if (d->valueType == QVariant::StringList) {

I think this would be better written as `d->formatAsString = 
::toStringFunction;`  unconditionally on the top (like 
`d->shouldBeIndexed = true`), and `d->formatAsString = 
::joinStringListFunction;` in the few matching case statements.

> propertyinfo.h:93
> + */
> +QString formatAsDisplayString(const QVariant& value) const;
> +

I think you should hand in a KFormat here if you want to avoid constructing a 
new one for each value.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D17550: Make the open url in tab feature a bit more discoverable

2018-12-17 Thread Elvis Angelaccio
elvisangelaccio accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D17550

REVISION DETAIL
  https://phabricator.kde.org/D17550

To: apol, #dolphin, ngraham, #frameworks, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D17619: Change the path for every item of the subdirectories in a directory rename

2018-12-17 Thread Jaime Torres Amate
jtamate added a comment.


  I'll work on the unit test this weekend. I don't currently have enough free 
time on weekdays.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D17619: Change the path for every item of the subdirectories in a directory rename

2018-12-17 Thread Jaime Torres Amate
jtamate retitled this revision from "fix for bug 401552" to "Change the path 
for every item of the subdirectories in a directory rename".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D17619: fix for bug 401552

2018-12-17 Thread David Faure
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Please change the summary to something more descriptive. A bug number is 
pretty opaque in itself.
  
  The patch itself looks good.
  
  I also don't understand "kdirmodeltest tests this already". It passes for me, 
without this change.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D17619: fix for bug 401552

2018-12-17 Thread Jaime Torres Amate
jtamate edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17619

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D17619: fix for bug 401552

2018-12-17 Thread Jaime Torres Amate
jtamate updated this revision to Diff 47731.
jtamate marked an inline comment as done.
jtamate retitled this revision from "Unit test and fix for bug 401552" to "fix 
for bug 401552".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  There is no need for a unit test, it is already in kdirmodeltest (but perhaps 
could be expanded in another patch).
  
  I've realized that it only modifies all paths of the subdirectories, and 
therefore if all the items of a sorted list change the same values, the order 
is preserved.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17619?vs=47666=47731

REVISION DETAIL
  https://phabricator.kde.org/D17619

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns


D17623: Add YaST icons

2018-12-17 Thread Noah Davis
ndavis added a comment.


  In D17623#378553 , @ngraham wrote:
  
  > In D17623#378253 , @ndavis wrote:
  >
  > > We can turn the `yast-*` into symlinks and rename the real icons to 
proper names when we need them. You're asking me to guess what the right names 
for the future would be before we need them. There's no existing pattern for 
authentication related icons like there is for drives and network stuff.
  >
  >
  > I think we can come up with appropriate new patterns. The reason why I'd 
like to do this is because the new icons are so good that other apps should be 
able to use them too, if appropriate! But if they were prefixed with `yast-`, 
that would just be weird.
  >
  > Could you provide a list of the new icons you created that are not already 
symlinks? It's hard to tell in this diff since new icons are intermixed with 
symlinks.
  
  
  
  
apps/32/yast-apparmor.svg
apps/32/yast-auth-client.svg
apps/32/yast-autoyast.svg
apps/32/yast-bootloader.svg
apps/32/yast-checkmedia.svg
apps/32/yast-create-new-vm.svg
apps/32/yast-device-tree.svg
apps/32/yast-dhcp-server.svg
apps/32/yast-disk.svg
apps/32/yast-dns-server.svg
apps/32/yast-docker.svg
apps/32/yast-dsl.svg
apps/32/yast-firewall.svg
apps/32/yast-ftp-server.svg
apps/32/yast-hardware.svg
apps/32/yast-host.svg
apps/32/yast-http-server.svg
apps/32/yast-hwinfo.svg
apps/32/yast-instserver.svg
apps/32/yast-iscsi-client.svg
apps/32/yast-iscsi-server.svg
apps/32/yast-journal.svg
apps/32/yast-kerberos-server.svg
apps/32/yast-kernel.svg
apps/32/yast-lan.svg
apps/32/yast-ldap-server.svg
apps/32/yast-ldap.svg
apps/32/yast-mail.svg
apps/32/yast-messages.svg
apps/32/yast-nfs-server.svg
apps/32/yast-nis-server.svg
apps/32/yast-nis.svg
apps/32/yast-ntp-client.svg
apps/32/yast-printer.svg
apps/32/yast-proxy.svg
apps/32/yast-release-notes.svg
apps/32/yast-remote.svg
apps/32/yast-samba-client.svg
apps/32/yast-samba-server.svg
apps/32/yast-scanner.svg
apps/32/yast-security.svg
apps/32/yast-services-manager.svg
apps/32/yast-slp-server.svg
apps/32/yast-snapper.svg
apps/32/yast-software.svg
apps/32/yast-sudo.svg
apps/32/yast-support.svg
apps/32/yast-sw_single.svg
apps/32/yast-sw_source.svg
apps/32/yast-sysconfig.svg
apps/32/yast-system.svg
apps/32/yast-tftp-server.svg
apps/32/yast-update.svg
apps/32/yast-vm-install.svg
apps/32/yast-vm-migrate.svg
apps/32/yast-vm.svg
apps/32/yast-vpn.svg
apps/32/yast-wol.svg
apps/32/yast.svg
apps/48/yast-installation.svg
apps/48/yast-sw_single.svg
apps/48/yast.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns


D17623: Add YaST icons

2018-12-17 Thread Nathaniel Graham
ngraham added a comment.


  In D17623#378253 , @ndavis wrote:
  
  > We can turn the `yast-*` into symlinks and rename the real icons to proper 
names when we need them. You're asking me to guess what the right names for the 
future would be before we need them. There's no existing pattern for 
authentication related icons like there is for drives and network stuff.
  
  
  I think we can come up with appropriate new patterns. The reason why I'd like 
to do this is because the new icons are so good that other apps should be able 
to use them too, if appropriate! But if they were prefixed with `yast-`, that 
would just be weird.
  
  Could you provide a list of the new icons you created that are not already 
symlinks? It's hard to tell in this diff since new icons are intermixed with 
symlinks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns


D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-17 Thread Björn Feber
GB_2 edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D17641

To: GB_2, #frameworks, #vdg
Cc: #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, ndavis, firef, ngraham, 
bruns, skadinna, aaronhoneycutt, mbohlender


D17641: Change default sort order in the download dialog to "Most downloads"

2018-12-17 Thread Björn Feber
GB_2 created this revision.
GB_2 added reviewers: Frameworks, VDG.
GB_2 added projects: Frameworks, VDG.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 399163
  
  This changes the default sort ordering of the download dialog to "Most 
downloads" (in 3 months), because the current problem is that the items sorted 
by rating are sometimes very old and often don't work anymore.
  When you change the dort order to "Most downloads" it shows the items that 
are actually popular (many downloads in 3 months) and they are are more up to 
date.

TEST PLAN
  Open a GHNS dialog and see that the default sort ordering of the content is 
by "Most downloads", and that the "Most downloads" radio button is checked.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D17641

AFFECTED FILES
  src/downloadwidget.cpp
  src/downloadwidget.ui

To: GB_2, #frameworks, #vdg
Cc: #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, michaelh, crozbo, ndavis, firef, ngraham, 
bruns, skadinna, aaronhoneycutt, mbohlender


D17528: Refactor SlaveInterface::calcSpeed

2018-12-17 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 47726.
chinmoyr added a comment.


  Removed vector initialization. 
  Increased vector capacity in constructor.
  Appended {0,0} at first.
  Stored time and size before appending to prevent extraction.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17528?vs=47567=47726

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17528

AFFECTED FILES
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h

To: chinmoyr, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham


D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

2018-12-17 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments.

INLINE COMMENTS

> chinmoyr wrote in copyjob.cpp:419
> For file permissions, 'file:' and 'trash:' use the result of QT_LSTAT, 
> 'archive:' makes use of stat, 'sftp:' uses sftp_lstat, and smb sets 
> UDS_ACCESS to 0500. These are the kioslaves(I found) which KDE ships and set 
> UDS_ACCESS entry. I think using UDSEntry can be considered here.

> These are the kioslaves(I found) which KDE ships and set UDS_ACCESS entry. I 
> think using UDSEntry can be considered here.

Well I was completely wrong here. There are plenty other protocols that set 
UDS_ACCESS and someone needs to check if their UDSEntry has the correct 
permission since flags are being set manually. For the time being this TODO 
should be here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17632

To: dfaure, shubham, broulik, bruns
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns


D17617: Display error instead of silently failing when asked to create folder that already exists

2018-12-17 Thread Anthony Fieroni
anthonyfieroni added inline comments.

INLINE COMMENTS

> ngraham wrote in knewfilemenu.cpp:916
> I don't see how that makes sense. What's wrong with the current approach of 
> expecting the jobs themselves to emit errors?

Makes sense because it's done in one standard way, possible change in future 
will be easy.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns


D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

2018-12-17 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments.

INLINE COMMENTS

> copyjob.cpp:419
> +// TODO: this is done only for local files, but we could use the 
> UDSEntry to do this portably
> +// ... assuming all kioslaves set permissions correctly
> +if (fileInfo.exists() && !fileInfo.isWritable()) {

For file permissions, 'file:' and 'trash:' use the result of QT_LSTAT, 
'archive:' makes use of stat, 'sftp:' uses sftp_lstat, and smb sets UDS_ACCESS 
to 0500. These are the kioslaves(I found) which KDE ships and set UDS_ACCESS 
entry. I think using UDSEntry can be considered here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17632

To: dfaure, shubham, broulik, bruns
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns


D17617: Display error instead of silently failing when asked to create folder that already exists

2018-12-17 Thread Nathaniel Graham
ngraham added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in knewfilemenu.cpp:916
> I still think it's better to emit errorMessage instead. Can you check it will 
> be more difficult ?

I don't see how that makes sense. What's wrong with the current approach of 
expecting the jobs themselves to emit errors?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns


D17617: Display error instead of silently failing when asked to create folder that already exists

2018-12-17 Thread Anthony Fieroni
anthonyfieroni added inline comments.

INLINE COMMENTS

> ngraham wrote in knewfilemenu.cpp:916
> It displays on the current tab, as expected.

I still think it's better to emit errorMessage instead. Can you check it will 
be more difficult ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns


D17617: Display error instead of silently failing when asked to create folder that already exists

2018-12-17 Thread Nathaniel Graham
ngraham marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns


D17617: Display error instead of silently failing when asked to create folder that already exists

2018-12-17 Thread Nathaniel Graham
ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in knewfilemenu.cpp:916
> Can you verify that if it has tabs it will display on current tab not in all.

It displays on the current tab, as expected.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns


D17617: Display error instead of silently failing when asked to create folder that already exists

2018-12-17 Thread Anthony Fieroni
anthonyfieroni added inline comments.

INLINE COMMENTS

> knewfilemenu.cpp:916
>  job->uiDelegate()->setAutoErrorHandlingEnabled(true);
> -KIO::FileUndoManager::self()->recordJob(KIO::FileUndoManager::Mkpath, 
> QList(), url, job);
> +KJobWidgets::setWindow(job, m_parentWidget);
>  

Can you verify that if it has tabs it will display on current tab not in all.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns


D17617: Display error instead of silently failing when asked to create folder that already exists

2018-12-17 Thread David Faure
dfaure accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: dfaure, emateli, elvisangelaccio, Codezela, kde-frameworks-devel, michaelh, 
ngraham, bruns