D17245: Add string formatting function to property info

astippich marked 3 inline comments as done. astippich added a comment. Thanks for the review! INLINE COMMENTS > bruns wrote in formatstrings.cpp:50 > Why is midnight an invalid time? Same with the previous discussing around the orientation values, I simply copied the code. My plan was to

D17245: Add string formatting function to property info

astippich updated this revision to Diff 47816. astippich added a comment. - remove static kformat - always show time - change default display function handling REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=47660=47816 BRANCH

D17178: Don't ask for confimation when reloading

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with this, thanks! REPOSITORY R39 KTextEditor BRANCH arcpatch-D17178 REVISION DETAIL https://phabricator.kde.org/D17178 To: nicolasfella, #kate, ngraham, cullmann Cc:

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann added a comment. I am at the moment a bit busy, if nobody else has time, I will try to take a closer look after x-mas. REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel,

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

dhaumann added a comment. Hm, these shortcuts exist for 15+ years... The extended shortcuts are not used widely in kde at all. Do we really address issues here? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: dhaumann, ngraham,

D16643: Correct the accept flag of the event object on DragMove

trmdi updated this revision to Diff 47815. trmdi edited reviewers, added: bruns; removed: davidedmundson. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16643?vs=44860=47815 REVISION DETAIL https://phabricator.kde.org/D16643 AFFECTED FILES

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. Is it better if I change the line 91 to `event->setAccepted(m_enabled && !m_temporaryInhibition)` @bruns ? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni,

T3689: Add abi compliance checker to CI

knauss added a comment. In T3689#170284 , @bcooksley wrote: > In regards to `akonadi-mime` I have now re-run it, and it seems to work fine. > As long as you're relying only on the master manifest.yaml, then it should be impossible for any

T3689: Add abi compliance checker to CI

knauss added a revision: D17672: Move settings for abi-complience-checker to own yaml file.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 23:35:30 + Build duration: 8 min 52 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/61/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Dec 2018 23:35:30 + Build duration: 8 min 24 sec and counting JUnit Tests Name: (root)

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever marked 2 inline comments as done. vandenoever added a comment. I pushed two encore commits fixing the two raised issues. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: apol, kde-frameworks-devel,

D10446: Add KLanguageName

aacid added inline comments. INLINE COMMENTS > sitter wrote in kf5_entry.desktop:1 > Really good point. I've had a look and we only extract src/*. In fact, we > only have Messages.sh in src :) > > This is in line with other frameworks where we have desktop file fixtures. > They all only

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.11 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.11/3/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 22:36:10 + Build duration: 5 min 36 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.9 - Build # 59 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.9/59/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Dec 2018 22:36:10 + Build duration: 5 min 10 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.11 - Build # 23 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.11/23/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 18 Dec 2018 22:36:10 + Build duration: 4 min 22 sec and counting JUnit Tests

D17495: [KMessageBox] Fix minimum dialog size when details are requested

This revision was automatically updated to reflect the committed changes. Closed by commit R236:032c783b990e: [KMessageBox] Fix minimum dialog size when details are requested (authored by cfeck). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D17651: Escape bytes that are larger than or equal to 127 in config files

dfaure added a comment. Thanks! INLINE COMMENTS > kconfigtest.cpp:1726 > +QVERIFY(file.open()); > +qWarning() << file.fileName(); > +KConfig config(file.fileName(), KConfig::SimpleConfig); Remove (or at least degrade to qDebug, this is not a warning) > kconfigtest.cpp:1739 > +

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 175 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/175/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Dec 2018 20:43:14 + Build duration: 5 min 40 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.11 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 20:43:14 + Build duration: 4 min 52 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 92 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/92/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 18 Dec 2018 20:43:14 + Build duration: 2 min 31 sec and counting

D15960: Don't check if file is directory based on mime-type

poboiko added a comment. In D15960#379043 , @aacid wrote: > @poboiko You broke the build, please fix it. Sorry! Apparently, I've messed up while did `git rebase` on current master. Should be fixed by c7416a41

D17651: Escape bytes that are larger than or equal to 127 in config files

This revision was automatically updated to reflect the committed changes. Closed by commit R237:6a185285ae44: Escape bytes that are larger than or equal to 127 in config files (authored by vandenoever). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/10/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 20:10:29 + Build duration: 7 min 29 sec and counting JUnit Tests Name: (root)

D17631: class Message: Use inclass member initialization

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ca0f9e3cc011: class Message: Use inclass member initialization (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17631?vs=47686=47795

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 60 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/60/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Dec 2018 19:57:19 + Build duration: 8 min 55 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.11 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 19:57:19 + Build duration: 1 min 54 sec and counting JUnit Tests Name: (root)

D17651: Escape bytes that are larger than or equal to 127 in config files

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R237 KConfig BRANCH utf8 (branched from master) REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: apol,

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever updated this revision to Diff 47790. vandenoever added a comment. Add a check for reading in the unit test. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17651?vs=47788=47790 BRANCH utf8 (branched from master) REVISION DETAIL

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

loh.tar added a comment. - No sure if there must be something at other places considered - This is my second version where the wrap is done ether at the static setting or the view width, whatever is smaller. At first is was always wrapped at the static setting. Then I thought it may this

D15960: Don't check if file is directory based on mime-type

aacid added a comment. @poboiko You broke the build, please fix it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns, astippich Cc: aacid, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch is in "Dynamic Wrap Mode" the text

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever retitled this revision from "Escape bytes that are larger than 127 in config files" to "Escape bytes that are larger than or equal to 127 in config files". vandenoever edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL

D17651: Escape bytes that are larger than 127 in config files

vandenoever updated this revision to Diff 47788. vandenoever edited the summary of this revision. vandenoever added a comment. Added a unit test and changed the code so that 0x7f (DEL) is also escaped. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D17629: Add method to BackgroundChecker to add word to session

ahmadsamir added a reviewer: sandsmark. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17629 To: ahmadsamir, davidedmundson, cullmann, sandsmark Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

ngraham added a comment. In D17623#378783 , @ndavis wrote: > 2. It's supposed to be a newspaper. I tried to make it look similar to `message-news`: F6486579: Screenshot_20181218_073508.png > - An

D17528: Refactor SlaveInterface::calcSpeed

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. endless refactoring, for the better :-) INLINE COMMENTS > slaveinterface.cpp:119 > +d->transfer_details.clear(); > +

D17647: Fix KGlobalAccel build with Qt 5.13 prerelease

This revision was automatically updated to reflect the committed changes. Closed by commit R268:c96d012b6d47: Fix KGlobalAccel build with Qt 5.13 prerelease. (authored by mpyne). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17647?vs=47743=47775

D17651: Escape bytes that are larger than 127 in config files

dfaure added a comment. +1 from me, although a unittest would be good. Especially in order to check that this then gets decoded properly when reading back from the kconfig file... REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure,

D17651: Escape bytes that are larger than 127 in config files

vandenoever retitled this revision from "Escape bytes that larger than 127" to "Escape bytes that are larger than 127 in config files". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson Cc: kde-frameworks-devel, michaelh,

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 14:34:36 + Build duration: 6 min 1 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/75/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Dec 2018 14:34:36 + Build duration: 1 min 49 sec and counting JUnit Tests Name: (root)

D16966: Fix typo in i18n message (cmdline option description)

This revision was automatically updated to reflect the committed changes. Closed by commit R290:49a674d3bdb0: Fix typo in i18n message (cmdline option description) (authored by aspotashev). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16966?vs=47770=47771

D16966: Fix typo in i18n message (cmdline option description)

aspotashev updated this revision to Diff 47770. aspotashev added a comment. fix another typo REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16966?vs=45698=47770 BRANCH arcpatch-D16966 REVISION DETAIL https://phabricator.kde.org/D16966 AFFECTED

D17650: Install kioslave as kioslave5 on Windows

ngraham added a comment. In D17650#378760 , @lbeltrame wrote: > > umbrello from binary factory is far from been production ready. Windows releases are made from the KDE4 branch. See for example https://phabricator.kde.org/T7659 > > I would

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 174 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/174/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 18 Dec 2018 14:06:35 + Build duration: 4 min 49 sec and counting CONSOLE OUTPUT [...truncated 645

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 91 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/91/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 18 Dec 2018 14:06:36 + Build duration: 3 min 28 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 14:06:36 + Build duration: 1 min 43 sec and counting CONSOLE OUTPUT [...truncated 640

D15960: Don't check if file is directory based on mime-type

poboiko added a comment. In D15960#375517 , @bruns wrote: > Sorry, fell through the cracks - give a ping next time something is blocked for no apparent reason ... Nevermind, I also didn't have much spare time for KDE lately :(

D15960: Don't check if file is directory based on mime-type

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns, astippich Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D17651: Escape bytes that larger than 127

vandenoever added reviewers: dfaure, arichardson. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

broulik added a comment. I'm not blaming anyone, I'm merely stating that there is a potential issue with this patch that might not have been addressed and needs @bruns further input. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart,

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. In D16643#378823 , @broulik wrote: > Only if that potential issue with inhibition has been addressed You mean @bruns is right and I'm wrong? REPOSITORY R296 KDeclarative REVISION DETAIL

D16643: Correct the accept flag of the event object on DragMove

broulik added a comment. Only if that potential issue with inhibition has been addressed REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham,

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. !ping @hein Could you land this patch? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17651: Escape bytes that larger than 127

vandenoever edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that larger than 127

vandenoever edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that larger than 127

vandenoever created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vandenoever requested review of this revision. REVISION SUMMARY UserBase tells me that KDE configuration files are encoded in UTF-8.

D17623: Add YaST icons

ndavis added a comment. In D17623#378670 , @ngraham wrote: > Also, here are my only aesthetic suggestions: > > - Messages icon: how about making this look more like the utilities-log-viewer icon? Maybe a 32px version of that? > - Release

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. The conflict is still presence on opensuse and relates to the packages mingw32-cross-kde4-tools mingw32-cross-kf5-tools REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame, vonreth Cc: lbeltrame,

D17650: Install kioslave as kioslave5 on Windows

vonreth added a comment. In D17650#378765 , @habacker wrote: > On a recent opensuse Leap 42.3 or 15.x system there is > > > /usr/lib64/kde4/libexec/kioslave > > /usr/lib64/libexec/kf5/kioslave > > because the distribution provides

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. In D17650#378765 , @habacker wrote: > On a recent opensuse Leap 42.3 or 15.x system there is > > > /usr/lib64/kde4/libexec/kioslave > > /usr/lib64/libexec/kf5/kioslave As a packager of KDE software for

D17647: Fix KGlobalAccel build with Qt 5.13 prerelease

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. As a rule of thumb, I'd say it's just fine to remove moc includes if there's no Q_OBJECT or Q_GADGET on the cpp file. REPOSITORY R268 KGlobalAccel REVISION DETAIL

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. On opensuse there are the cross compile helper packages mingw32-cross-kde4-tools mingw32-cross-kf5-tools both containing docbookl10nhelper and nothing prevents them from been installed in parallel REPOSITORY R241 KIO REVISION DETAIL

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. On a recent opensuse Leap 42.3 or 15.x system there is > /usr/lib64/kde4/libexec/kioslave > /usr/lib64/libexec/kf5/kioslave because the distribution provides kdelibs4 and kio packages. it only does not conflict because the executables are located in

D17650: Install kioslave as kioslave5 on Windows

vonreth added a comment. I see no reason for this. Having a KF5 and kde 4 in the path sounds like a bad idea in general. Is this for cygwin or something like that? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame, vonreth Cc:

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a reviewer: vonreth. lbeltrame added a comment. That said, let's hear the opinion of someone else as well. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame, vonreth Cc: lbeltrame, kde-frameworks-devel, michaelh,

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. > umbrello from binary factory is far from been production ready. Windows releases are made from the KDE4 branch. See for example https://phabricator.kde.org/T7659 I would argue this is more of umbrello's problem to keep on supporting kdelibs 4.x and KF5 at

D10446: Add KLanguageName

sitter added inline comments. INLINE COMMENTS > aacid wrote in kf5_entry.desktop:1 > This is going to be a problem, scripty is going to come and whipe these > .desktop files out and then make the translators translate them again. > > Wonder if we could rename them to .desktop.untransltable or

D10446: Add KLanguageName

sitter updated this revision to Diff 47758. sitter added a comment. move env setup to qcorestartup to prevent the env from not getting set up in time and the tests failing as a result REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D17650: Install kioslave as kioslave5 on Windows

habacker added a comment. In D17650#378747 , @lbeltrame wrote: > At this point, I'd rather give my -1 to this. The 4.x kdelibs stack is *long* unmaintained, as well as Qt. What are real, **compelling** reasons to do this? > > EDIT: I know

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

habacker added a comment. In D17649#378737 , @ltoscano wrote: > The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is exported), and in general it should not exist in the same build root of its kdelibs 4.x counterpart.

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a reviewer: Frameworks. lbeltrame requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame Cc: lbeltrame, kde-frameworks-devel, michaelh,

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. At this point, I'd rather give my -1 to this. The 4.x kdelibs stack is *long* unmaintained, as well as Qt. What are real, **compelling** reasons to do this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker Cc: lbeltrame,

D17650: Install kioslave as kioslave5 on Windows

habacker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY FIXED-IN:5.54.0 BUG:377687 REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

ltoscano added a comment. The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is exported), and in general it should not exist in the same build root of its kdelibs 4.x counterpart. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D17649 To:

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

habacker created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY FIXED-IN:5.54 BUG:373928 REPOSITORY R238 KDocTools BRANCH master REVISION