D17726: Add helper function to disable redirections (useful for kde-open)

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> krun.h:158
> +/**
> + * Sets wether KRun should follow URLs redirections.
> + * This is enabled by default

Typo: wether -> whether

> krun.h:160
> + * This is enabled by default
> + * @param b wether to follow redirections or not.
> + */

Typo: wether -> whether

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17726

To: achauvel, dfaure, #frameworks, cfeck
Cc: yurchor, kde-frameworks-devel, michaelh, ngraham, bruns

D17727: Get default web browser from xdg-settings if it’s not set in KDE

[Mélanie Chauvel]

achauvel created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
achauvel requested review of this revision.

REVISION SUMMARY
  This greatly speed up opening URLs from kde-open (avoid ~1 second of wait)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17727

AFFECTED FILES
  src/widgets/krun.cpp

To: achauvel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[Mélanie Chauvel]

achauvel updated this revision to Diff 47987.
achauvel added a comment.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.


  Uses new function added in https://phabricator.kde.org/D17726

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15189?vs=40897=47987

REVISION DETAIL
  https://phabricator.kde.org/D15189

AFFECTED FILES
  kioclient/kioclient.cpp

To: achauvel, #frameworks, dfaure, cfeck
Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D17726: Add helper function to disable redirections (useful for kde-open)

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added reviewers: dfaure, Frameworks, cfeck.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17726

To: achauvel, dfaure, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17726: Add helper function to disable redirections (useful for kde-open)

[Mélanie Chauvel]

achauvel created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
achauvel requested review of this revision.

REVISION SUMMARY
  See https://phabricator.kde.org/D15189

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17726

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: achauvel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  In D17623#380549 , @fvogt wrote:
  
  > In D17623#380511 , @ndavis wrote:
  >
  > > @fvogt @hellcp For some reason YaST Control Center only works with 32px 
icons from Breeze but it can work with seemingly any size icon from hicolor. If 
either of you could help me figure out why that is, I would appreciate it.
  >
  >
  > AFAICT YaST just uses `QIcon::fromTheme("foo").pixmap(32, 32)` which should 
work just fine. Did you refresh the icon cache? What's the issue exactly? Do 
you see the wrong icon, wrong size or no icon at all?
  
  
  Actually, it works with 32px and 48px Breeze icons, but not 64px. If the 
Breeze icon is 64px, yast-c-c shows the hicolor icon. If there is no hicolor 
icon for a module (i.e., I delete all `yast-printer` icons from hicolor), 
yast-c-c shows the `yast` icon, even if there is a Breeze icon at 64px. I'm 
pretty sure it's not an icon cache issue because there are no issues with 
changing icons to 48px versions, only 64px has issues.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Fabian Vogt]

fvogt added a comment.


  In D17623#380511 , @ndavis wrote:
  
  > @fvogt @hellcp For some reason YaST Control Center only works with 32px 
icons from Breeze but it can work with seemingly any size icon from hicolor. If 
either of you could help me figure out why that is, I would appreciate it.
  
  
  AFAICT YaST just uses `QIcon::fromTheme("foo").pixmap(32, 32)` which should 
work just fine. Did you refresh the icon cache? What's the issue exactly? Do 
you see the wrong icon, wrong size or no icon at all?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST icons

[Noah Davis]

ndavis added a comment.


  @fvogt @hellcp For some reason YaST Control Center only works with 32px icons 
from Breeze but it can work with seemingly any size icon from hicolor. If 
either of you could help me figure out why that is, I would appreciate it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar updated this revision to Diff 47966.
loh.tar added a comment.


  Improve the readability and prevent unwanted lookup by caching d(this) as dd

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47963=47966

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in katesearchbar.cpp:860-865
> Maybe not an issue, but you can try to cache value preventing unwanted lookup
> 
>   auto dd = d(this);
>   dd->...

Only here or everywhere?
At this particular place may that optimized by the compiler(?)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  This doesn't seem to actually work; after applying the patch; the new icon is 
not actually used with dark themes nor visible in Cuttlefish. Also the `dupe` 
test is now failing:
  
The following tests FAILED:
  4 - dupe (Failed)
Errors while running CTest
  
  Please make sure to run the unit tests with `ctest`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17459: SearchBar: Add Cancel button to stop long running tasks

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katesearchbar.cpp:860-865
> +d(this)->m_inputRange = inputRange;
> +d(this)->m_workingRange = 
> m_view->doc()->newMovingRange(d(this)->m_inputRange);
> +d(this)->m_replacement = replacement;
> +d(this)->m_replaceMode = replaceMode;
> +d(this)->m_matchCounter = 0;
> +d(this)->m_cancelFindOrReplace = false; // Ensure we have a GO!

Maybe not an issue, but you can try to cache value preventing unwanted lookup

  auto dd = d(this);
  dd->...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar added a comment.


  I have tried to run two S jobs at the same time on the same document, seems 
to works nicely
  
  - view 1 -> S "tab" -> "-"
  - view 2 -> S "0" -> "+"
  
  I had canceled both jobs and then resume, that's why at the pic are already 
replacents to see while the job is still running. Job is almost finished, had 
taken a couple of minutes and ~2GB RAM
  F6496970: still-running-near-finish.png 
  After finish, scrolled down
  F6496972: finished-scrolled-down.png 
  
  My current status is: No crashes I'm aware of and everything seems to work.
  
  - "m_cancelFindOrReplace" may better renamed to "m_jobIsRuning" or similar
  - Is the "Cancel" perhaps better named "Stop"?
  - The new added, and now  "d->m_foo" variables by better renamed to "d->foo", 
but perhaps will never a true d-pointer added but the new variables moved back 
as member again (?)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar updated this revision to Diff 47963.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Fix crash when the document will closed while a S job is running
  - Fix crash when the view will closed while a S job is running
  
  These fixes seems to work so far but they do not block the user action which 
is somehow an unusual behaviour.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=47907=47963

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17015: Fix the Qt doc creation with Qt 5.12.

[Christophe Giboudeaux]

cgiboudeaux updated this revision to Diff 47962.
cgiboudeaux added a comment.


  Try to find qmake if qmake-qt5 is not found

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17015?vs=46780=47962

BRANCH
  arcpatch-D17015

REVISION DETAIL
  https://phabricator.kde.org/D17015

AFFECTED FILES
  cmake/FindQHelpGenerator.cmake
  docs/CMakeLists.txt
  modules/ECMQueryQmake.cmake

To: cgiboudeaux, kossebau
Cc: tcberner, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D17173: Add error value for job owner dying

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ec31566e4cc7: Add error value for job owner dying 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17173?vs=47464=47958#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17173?vs=47464=47958

REVISION DETAIL
  https://phabricator.kde.org/D17173

AFFECTED FILES
  src/core/global.h

To: davidedmundson, dfaure, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/96/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 21 Dec 2018 13:22:22 +
 Build duration:
4 min 39 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5Wayland_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26637/31313)53%
(10626/20059)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12198/12366)50%
(6390/12849)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6258/7368)64%
(1800/2791)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7745/8948)66%
(2267/3446)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/5/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 21 Dec 2018 13:19:03 +
 Build duration:
4 min 38 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5Wayland_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26634/31312)53%
(10626/20059)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12195/12365)50%
(6390/12849)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6258/7368)64%
(1800/2791)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7745/8948)66%
(2267/3446)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/95/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 21 Dec 2018 13:08:18 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Wayland_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26636/31315)53%
(10623/20059)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12185/12366)50%
(6380/12849)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6269/7370)65%
(1806/2791)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7746/8948)66%
(2268/3446)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 21 Dec 2018 13:08:18 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Wayland_compat_report.html
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26636/31312)53%
(10628/20059)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12194/12365)50%
(6389/12849)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6261/7368)65%
(1803/2791)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7745/8948)66%
(2267/3446)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D17498: Xdg Decoration Support

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:46390781daad: Xdg Decoration Support (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17498?vs=47468=47955#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17498?vs=47468=47955

REVISION DETAIL
  https://phabricator.kde.org/D17498

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_decoration.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgdecoration.cpp
  src/client/xdgdecoration.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgdecoration_interface.cpp
  src/server/xdgdecoration_interface.h
  src/server/xdgshell_interface.h
  src/tools/mapping.txt

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 47950.
chinmoyr added a comment.


  update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17528?vs=47726=47950

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17528

AFFECTED FILES
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h

To: chinmoyr, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D17650: Install kioslave.exe as kioslave5.exe under Windows

[Hannah von Reth]

vonreth added a comment.


  In D17650#380329 , @habacker wrote:
  
  > In D17650#380309 , @habacker 
wrote:
  >
  > > See this https://bugs.kde.org/show_bug.cgi?id=380139 as example. The 
different Qt installation layout depending on the platform is a nightmare for 
cross-platform support and ties up resources that are no longer available for 
more important things.
  >
  >
  > Here you can an actual example - https://phabricator.kde.org/T10207
  
  
  This issue is related to your configuration of the blacklist.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave.exe as kioslave5.exe under Windows

[Ralf Habacker]

habacker added a comment.


  In D17650#380309 , @habacker wrote:
  
  > See this https://bugs.kde.org/show_bug.cgi?id=380139 as example. The 
different Qt installation layout depending on the platform is a nightmare for 
cross-platform support and ties up resources that are no longer available for 
more important things.
  
  
  Here you can an actual example - https://phabricator.kde.org/T10207

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave.exe as kioslave5.exe under Windows

[Luca Beltrame]

lbeltrame added a comment.


  I would still suggest you get your stuff done with the binary factory and not 
on the OBS simply because then KDE as a whole can benefit from it. Not doing so 
will make sure that Windows and other platform-specific issues will never be 
found.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave.exe as kioslave5.exe under Windows

[Ralf Habacker]

habacker updated this revision to Diff 47944.
habacker retitled this revision from "Install kioslave as kioslave5 on Windows" 
to "Install kioslave.exe as kioslave5.exe under Windows".
habacker edited the summary of this revision.
habacker removed subscribers: bcooksley, heikobecker, ngraham, lbeltrame.
habacker added a comment.


  - fix clients of kioslave

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17650?vs=47757=47944

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17650

AFFECTED FILES
  src/core/slave.cpp
  src/kioslave/CMakeLists.txt

To: habacker, #frameworks, lbeltrame, vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, bcooksley, heikobecker

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  In D17650#380277 , @habacker wrote:
  
  > and try to fix the related issue or check if some else has fixed it.
  
  
  See this https://bugs.kde.org/show_bug.cgi?id=380139 as example. The 
different Qt installation layout depending on the platform is a nightmare for 
cross-platform support and ties up resources that are no longer available for 
more important things. Making cross compiled packaged on obs for example is 
mostly a simple copy and replace of specific variables (for example that shared 
files are located in bin dir, not in lib). Converting to the complete different 
Qt 5 path layout results into much more work without any benefit.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: bcooksley, heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, 
bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Reverted and the version was fixed.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D17718

To: cgiboudeaux, cfeck, #build_system
Cc: pino, alexeymin, kde-frameworks-devel, michaelh, ngraham, bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

[Christophe Giboudeaux]

cgiboudeaux removed a reviewer: alexeymin.
cgiboudeaux added a comment.


  In D17718#380267 , @pino wrote:
  
  > In D17718#380261 , @alexeymin 
wrote:
  >
  > > I tested this, it indeed fixes 390225
  > >  Withoug this patch, generated pkgconfig file was:
  > >
  > >   prefix=/usr
  > >   exec_prefix=bin
  > >   libdir=lib/x86_64-linux-gnu
  > >   includedir=include
  > >  
  > >   Name: libKActivities
  > >   Description: libKActivities is a C++ library for using KDE activities
  > >   URL: http://www.kde.org
  > >   Requires: Qt5Core
  > >   Version: 
  > >   Libs: -Llib/x86_64-linux-gnu -lKF5Activities
  > >   Cflags: -Iinclude
  > >
  > >
  > > With this, version field is filled in and full paths are specified:
  > >
  > >   Name: libKActivities
  > >   Description: libKActivities is a C++ library for using KDE activities
  > >   Version: 5.54.0
  > >   Libs: -L/usr/lib/x86_64-linux-gnu -llibKActivities
  >
  >
  > This seems wrong to me, the library is called `KF5Activities` and not 
`libKActivities`.
  >
  > > Cflags: -I/usr/include/libKActivities
  >
  > Ditto.
  
  
  mmh, right, and ECMGeneratePkgConfigFile doesn't understand why the Name: and 
the library name should be different. I'm reverting and just fixing the version 
in the .pc.cmake file.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D17718

To: cgiboudeaux, cfeck, #build_system
Cc: pino, alexeymin, kde-frameworks-devel, michaelh, ngraham, bruns

D17719: Fix executable name for kioslave on Windows

[Ralf Habacker]

habacker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  FIXED-IN:5.54.0
  BUG:377687
  also see https://phabricator.kde.org/D17650

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17719

AFFECTED FILES
  src/klauncher/klauncher.cpp

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  In D17650#380272 , @vonreth wrote:
  
  > In kde4 we had 104 unmaintained untested applications.
  >  The 6 now are much better supported, in general we only add applications 
to binary factory if a project asks for it and maintains it for some degree.
  
  
  
  
  In D17650#380266 , @heikobecker 
wrote:
  
  > > no, it is only used in kio internally by klauncher to start io slaves.
  >
  > at least kinit disagrees:
  >
  >   src/klauncher/klauncher.cpp:1021
arg_list.prepend(QLatin1String("kioslave"));
  >
  
  
  Thanks for this pointer, which is one of the major differences to KDE4 and 
makes it sometime hard to follow. In KDE4 kinit  is also located in the same 
repo.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: bcooksley, heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, 
bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  > Why not joining the effort of the people that are working to get those 
applications on Windows,
  
  You did not get the point. If there is anything left over besides the time I 
have to maintain the KDE applications and libraries, I go through this list 
(https://bugs.kde.org/showdependencytree.cgi?id=373932_resolved=1) and try 
to fix the related issue.
  The list has already been reduced from 66 to 28.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: bcooksley, heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, 
bruns

D17650: Install kioslave as kioslave5 on Windows

[Hannah von Reth]

vonreth added a comment.


  In kde4 we had 104 unmaintained untested applications.
  The 6 now are much better supported, in general we only add applications to 
binary factory if a project asks for it and maintain it for some degree.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: bcooksley, heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, 
bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

[Pino Toscano]

pino added a comment.


  In D17718#380261 , @alexeymin 
wrote:
  
  > I tested this, it indeed fixes 390225
  >  Withoug this patch, generated pkgconfig file was:
  >
  >   prefix=/usr
  >   exec_prefix=bin
  >   libdir=lib/x86_64-linux-gnu
  >   includedir=include
  >  
  >   Name: libKActivities
  >   Description: libKActivities is a C++ library for using KDE activities
  >   URL: http://www.kde.org
  >   Requires: Qt5Core
  >   Version: 
  >   Libs: -Llib/x86_64-linux-gnu -lKF5Activities
  >   Cflags: -Iinclude
  >
  >
  > With this, version field is filled in and full paths are specified:
  >
  >   Name: libKActivities
  >   Description: libKActivities is a C++ library for using KDE activities
  >   Version: 5.54.0
  >   Libs: -L/usr/lib/x86_64-linux-gnu -llibKActivities
  
  
  This seems wrong to me, the library is called `KF5Activities` and not 
`libKActivities`.
  
  > Cflags: -I/usr/include/libKActivities
  
  Ditto.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D17718

To: cgiboudeaux, cfeck, #build_system, alexeymin
Cc: pino, alexeymin, kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Heiko Becker]

heikobecker added a comment.


  > no, it is only used in kio internally by klauncher to start io slaves.
  
  at least kinit disagrees:
  
src/klauncher/klauncher.cpp:1021
arg_list.prepend(QLatin1String("kioslave"));

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: bcooksley, heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, 
bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R6:52267908a1e4: Use ECMGeneratePkgConfigFile to create the 
pkgconfig file. (authored by cgiboudeaux).

REPOSITORY
  R6 KActivities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17718?vs=47934=47935

REVISION DETAIL
  https://phabricator.kde.org/D17718

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/libKActivities.pc.cmake

To: cgiboudeaux, cfeck, #build_system, alexeymin
Cc: alexeymin, kde-frameworks-devel, michaelh, ngraham, bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

[Alexey Min]

alexeymin accepted this revision.
alexeymin added a comment.
This revision is now accepted and ready to land.


  I tested this, it indeed fixes 390225
  Withoug this patch, generated pkgconfig file was:
  
prefix=/usr
exec_prefix=bin
libdir=lib/x86_64-linux-gnu
includedir=include

Name: libKActivities
Description: libKActivities is a C++ library for using KDE activities
URL: http://www.kde.org
Requires: Qt5Core
Version: 
Libs: -Llib/x86_64-linux-gnu -lKF5Activities
Cflags: -Iinclude
  
  With this, version field is filled in and full paths are specified:
  
Name: libKActivities
Description: libKActivities is a C++ library for using KDE activities
Version: 5.54.0
Libs: -L/usr/lib/x86_64-linux-gnu -llibKActivities
Cflags: -I/usr/include/libKActivities 
Requires: Qt5Core
  
  So, +1

REPOSITORY
  R6 KActivities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17718

To: cgiboudeaux, cfeck, #build_system, alexeymin
Cc: alexeymin, kde-frameworks-devel, michaelh, ngraham, bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

[Christophe Giboudeaux]

cgiboudeaux added reviewers: cfeck, Build System.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D17718

To: cgiboudeaux, cfeck, #build_system
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

[Christophe Giboudeaux]

cgiboudeaux created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cgiboudeaux requested review of this revision.

REVISION SUMMARY
  This also fixes the version in the .pc file.
  
  BUG 390225
  FIXED-IN: 5.55

REPOSITORY
  R6 KActivities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17718

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/libKActivities.pc.cmake

To: cgiboudeaux
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  Yes there are more 'nightly' releases, which is a good thing :-),
  
  but there are only about  6 'release' versions
  
  https://binary-factory.kde.org/view/Windows%2064-bit/ : 5 
  https://binary-factory.kde.org/view/Windows%2032-bit/ : 6
  
  and KMyMoney 'release' version is marked as 'Preview Release' (see 
https://kmymoney.org/)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: bcooksley, heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, 
bruns

D17650: Install kioslave as kioslave5 on Windows

[Ben Cooksley]

bcooksley added a comment.


  It is much more than 7 - at least on the Binary Factory.
  See https://binary-factory.kde.org/view/Windows%2032-bit/ and 
https://binary-factory.kde.org/view/Windows%2064-bit/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: bcooksley, heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, 
bruns

D17650: Install kioslave as kioslave5 on Windows

[Luca Beltrame]

lbeltrame added a comment.


  In D17650#380243 , @habacker wrote:
  
  >
  
  
  
  
  >   $ rpm -q -f /usr/i686-w64-mingw32/sys-root/mingw/bin/kioslave.exe 
  >   mingw32-kdelibs4-4.14.60-30.27.noarch
  >   $ rpm -q -f /usr/i686-w64-mingw32/sys-root/mingw/bin/kioslave.exe 
  >   mingw32-kio-5.47.0-11.28.noarch
  
  For the record, those packages aren't shipped officially by the distribution 
you are using.
  
  >> seeing that it's not possible to upstream patches (and there are quite a 
few needed to keep it building) as the git repo is locked down.
  > 
  > It needs someone to take over maintenance of kdelibs.
  
  No. You need to get over the fact that kdelibs4 development is *done* and 
deal, period. Qt4 is EOL, kdelibs4 is EOL. It is time to move on.
  
  > In recent years, of the 104 KDE4 applications for Windows 
(https://community.kde.org/Windows/Releases/4.10.2), only 7 are available for 
KF5 (https://community.kde.org/Windows, minus the stable versions of Umbrello 
and KMymoney that are still on KDE4).  KDE4 will probably stay as a base for a 
while.
  
  Why not joining the effort of the people that are working to get those 
applications on Windows, rather than relying on unmaintained software? By 
distributing Qt 4.x based software we are exposing users to risks, given it is 
completely unmaintained.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

D17650: Install kioslave as kioslave5 on Windows

[Ralf Habacker]

habacker added a comment.


  > I'd argue that the problem is with your distribution.
  
  It is designed in ECM to install mentioned helpers on windows (which are 
cross compiled packages on obs) in main executable install dir.
  
$ rpm -q -f /usr/i686-w64-mingw32/sys-root/mingw/bin/kioslave.exe 
mingw32-kdelibs4-4.14.60-30.27.noarch
$ rpm -q -f /usr/i686-w64-mingw32/sys-root/mingw/bin/kioslave.exe 
mingw32-kio-5.47.0-11.28.noarch
  
  > Everybody still shipping qt4 is on its own anyway,
  
  Unfortunally yes, for example 
https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4,
 but this is unrelated, we are about talking about a patch for KF5, not qt4.
  
  > seeing that it's not possible to upstream patches (and there are quite a 
few needed to keep it building) as the git repo is locked down.
  
  It needs someone to take over maintenance of kdelibs.
  
  > And I'm pretty sure this patch breaks at least one other framework.
  
  no, it is only used in kio internally by klauncher to start io slaves.
  
  > Additionally there might be future maintenance costs,
  
  no, it simply follows the name style other kio executables installed in 
normal 'bin' dir already have e.g kcookiejar5, ktelnetservices5, ktrash5.
  
  > so I see no reason to flog a dead horse and penalize everybody else for it.
  
  In recent years, of the 104 KDE4 applications for Windows 
(https://community.kde.org/Windows/Releases/4.10.2), only 7 are available for 
KF5 (https://community.kde.org/Windows, minus the stable versions of Umbrello 
and KMymoney that are still on KDE4).  KDE4 will probably stay as a base for a 
while.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17650

To: habacker, #frameworks, lbeltrame, vonreth
Cc: heikobecker, ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  In D17649#380233 , @habacker wrote:
  
  > On opensuse there are the cross compile helper packages
  >
  > mingw32-cross-kde4-tools
  > mingw32-cross-kf5-tools
  >
  > both containing docbookl10nhelper and nothing prevents them from been 
installed in parallel
  
  
  Nothing says that both must be installed at the same time. Just add conflicts 
to these packages against each other, so it is clearly marked that they are not 
coinstallable.
  Furthermore, as already mentioned in D17650: Install kioslave as kioslave5 on 
Windows , just focus the efforts on KF5 
stuff, instead of wasting work to make umbrello & alkimia dual Qt4/Qt5, and 
adding more features to a stable Qt4 branch (4.8) of kmymoney.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker, pino
Cc: pino, ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, 
bruns, skadinna