D17806: Add Itinerary plugin

2018-12-25 Thread Nicolas Fella 
nicolasfella edited the summary of this revision.
nicolasfella added a dependency: D17805: Allow specifying multiple mimetypes as 
constraints.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17806

To: nicolasfella, apol, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17805: Allow specifying multiple mimetypes as constraints

2018-12-25 Thread Nicolas Fella 
nicolasfella added a dependent revision: D17806: Add Itinerary plugin.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17805

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17806: Add Itinerary plugin

2018-12-25 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: apol, vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Useful for importing reservation from PDF, Apple Wallet or JSON-LD files that 
are not automatically extracted in KMail.

TEST PLAN
  Select pkpass, pdf, jsonld file in Dolphin, import into Itinerary

REPOSITORY
  R495 Purpose Library

BRANCH
  itinerary

REVISION DETAIL
  https://phabricator.kde.org/D17806

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/itinerary/CMakeLists.txt
  src/plugins/itinerary/Messages.sh
  src/plugins/itinerary/itineraryplugin.cpp
  src/plugins/itinerary/itineraryplugin.json

To: nicolasfella, apol, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17805: Allow specifying multiple mimetypes as constraints

2018-12-25 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Allow specifying multiple mimetypes separated by ';'. When one of them 
matches the match is accepted.

TEST PLAN
  Add plugin with two mimetypes. Check that it is listed as available for both 
types and not for any other.

REPOSITORY
  R495 Purpose Library

BRANCH
  multimime

REVISION DETAIL
  https://phabricator.kde.org/D17805

AFFECTED FILES
  src/alternativesmodel.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17797: Include applets/22

2018-12-25 Thread Noah Davis 
ndavis added a comment.


  What is questionable is the purpose for keeping those specific icons in 
there. All of them can be categorized as device icons, with the car being 
arguably a device.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17797

To: nicolasfella, #breeze
Cc: ndavis, kde-frameworks-devel, trickyricky26, michaelh, ngraham, bruns

D17797: Include applets/22

2018-12-25 Thread Noah Davis 
ndavis added a comment.


  In D17797#382232 , @nicolasfella 
wrote:
  
  > Thinking about it, is there a particular reason why those icons are in the 
22 folder in the first place? They are all svgs after all
  
  
  While we do use SVGs for scalability, SVGs still need to be designed for 
different sizes, otherwise they will look ugly and blurry at sizes they weren't 
designed for. A 22px icon scaled down to 16px or a 16px icon scaled up to 22px 
will be blurry. This looks especially bad with line art.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17797

To: nicolasfella, #breeze
Cc: ndavis, kde-frameworks-devel, trickyricky26, michaelh, ngraham, bruns

D17802: Hide API documentation of internal classes

2018-12-25 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17802

AFFECTED FILES
  docs/Doxyfile.local

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

2018-12-25 Thread Sandro Knauß 
knauss added a revision: D17798: publish acc build logs as artifacts..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17797: Include applets/22

2018-12-25 Thread Nicolas Fella 
nicolasfella added a comment.


  Thinking about it, is there a particular reason why those icons are in the 22 
folder in the first place? They are all svgs after all

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17797

To: nicolasfella, #breeze
Cc: kde-frameworks-devel, trickyricky26, michaelh, ngraham, bruns

D17797: Include applets/22

2018-12-25 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added a reviewer: Breeze.
nicolasfella added a project: Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  I noticed that plasma-pa doesn't show an icon for my connected speakers. 
Turns out the icon (hifi) exists in applets/22 but Cuttlefish doesn't show it.

TEST PLAN
  Cuttlefish and plasma-pa now show the hifi icon

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17797

AFFECTED FILES
  icons/index.theme

To: nicolasfella, #breeze
Cc: kde-frameworks-devel, trickyricky26, michaelh, ngraham, bruns