D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY **Changes:** TypeScript

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.11 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 31 Dec 2018 07:24:22 + Build duration: 6 min 32 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 118 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/118/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 31 Dec 2018 07:24:22 + Build duration: 5 min 44 sec and counting BUILD ARTIFACTS abi-compa

D17863: Add ecm_check_linker_flags function

tcberner added a comment. In D17863#384145 , @cgiboudeaux wrote: > Why not fixing kstars instead? include(ECMCheckLinkerFlags) [...] # Check for nodump support SET(NODUMP_FLAGS "-Wl,-z,nodump") ecm_check_linker_fla

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham added a comment. I don't have access to a webdav server to test with. Do you know of a public one? Also, this feels like an issue with the webdav ioslave, so we might want to fix that issue in another patch REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.9 - Build # 124 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.9/124/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 31 Dec 2018 04:16:01 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatibility-resu

D17617: Display error instead of silently failing when asked to create folder that already exists

elvisangelaccio added a comment. Much better now, but I noticed that with `webdavs://` the errore message does not show the name of the new folder: A folder named already exists. (while it works fine with `file://`, `ftp://` and `sftp://`). REPOSITORY R241 KIO REVISION DETAIL

T3689: Add abi compliance checker to CI

knauss added a revision: D17880: check-abi: Fix error logging for non compatible builds.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17863: Add ecm_check_linker_flags function

cgiboudeaux added a comment. Why not fixing kstars instead? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17623: Add YaST and new preference icons

ndavis added a comment. The patch now passes the scalable test, but I don't think it's organized in a great way. I supposed I can always reorganize things if I make 48px versions of each YaST icon later. I can't do that now because it would take way too much time and I'm starting to get sick

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48418. ndavis added a comment. Move all YaST icons that don't have a 48px version to `preferences/32/`, undo all changes to `index.theme`, remove the new `preferences-system` icon, change `yast-system` to a symlink to `systemsettings` REPOSITORY R266 Br

D17816: Initial support for xattrs on kio copy/move

cochise added a comment. In D17816#384056 , @pino wrote: > - NULL -> nullptr > - there is not just glibc I'm following the pattern in Baloo, that keeps NULL on Mac and *BSD. I don't have any of these systems to test, so I didn't touch i

D17816: Initial support for xattrs on kio copy/move

pino added a comment. general notes: - NULL -> nullptr - there is not just glibc - the changes to `file_unix.cpp` seem unrelated to you patch now, so better split them in an own patch - use `constData()` instead of `data()` every time the data needed is read-only INLINE COMMENTS

D17816: Initial support for xattrs on kio copy/move

cochise updated this revision to Diff 48410. cochise marked an inline comment as done. cochise added a comment. Bug resolved in a proper way with help of Tomaz Canabrava Some other small fixes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=48384&

D17730: Review KateStatusBar

loh.tar added a comment. Harr, one more issue :-/ F6516314: 1546186710.png Idea how to fix this? I had in the past often such trouble, but so far I remember no solution. So my fix would be to remove the emphasis. Is it OK to update this diff here

D17730: Review KateStatusBar

loh.tar added a comment. One idea: Now you have only to click once to change some setting, not twice (double-click). So if these test simulate a clicks... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: zetazeta, cull

D17730: Review KateStatusBar

loh.tar added a comment. I'm pretty baffled. What does the status bar which may break some input (mode) ? These report says nothing to me. Well, ok, the vi-mode can enabled/disabled :-/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexted

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.9 - Build # 168 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.9/168/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 30 Dec 2018 13:49:20 + Build duration: 18 min and counting BUILD ARTIFACTS abi-compatibility-

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/19/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 30 Dec 2018 13:49:21 + Build duration: 6 min 55 sec and counting BUILD ARTIFACTS abi-compat

D17730: Review KateStatusBar

cullmann added a comment. I reverted it ATM, to see if the tests pass then again. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, n

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 30 Dec 2018 13:43:35 + Build duration: 4 min 52 sec and counting BUILD ARTIFACTS abi-compatibi

D17730: Review KateStatusBar

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, this seems to break the unit tests :/ see https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.9/167/testReport/junit/projectroot.autotests.src/vimode/vim

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.9 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.9/60/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 30 Dec 2018 13:43:35 + Build duration: 1 min 36 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.9 - Build # 167 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.9/167/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 30 Dec 2018 13:17:40 + Build duration: 13 min and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/18/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 30 Dec 2018 13:17:40 + Build duration: 6 min 24 sec and counting BUILD ARTIFACTS abi-compat

D17730: Review KateStatusBar

This revision was automatically updated to reflect the committed changes. Closed by commit R39:3b874e56b8dc: Review KateStatusBar (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17730?vs=48387&id=48395 REVISION

D17730: Review KateStatusBar

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yep, fine with this. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: zetazeta, cullmann, kwrite-deve

D17817: Build without D-Bus on Android

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Given the discussion I think this should go in. REPOSITORY R289 KNotifications BRANCH arcpatch-D17817 REVISION DETAIL https://phabricator.kde.org/D17817 To: vkrause, dhaumann Cc

D17459: SearchBar: Add Cancel button to stop long running tasks

dhaumann added inline comments. INLINE COMMENTS > cullmann wrote in katesearchbar.h:221-227 > This is a purely internal class. > It is only exported for the unit tests, no header files are installed, > therefore any change of the layout is ok ;=) Yes: as rule of thumb: only classes in the KText

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.11 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/7/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 30 Dec 2018 12:18:10 + Build duration: 7 min 42 sec and counting BUILD ARTIFACTS compat_reports/K

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 63 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/63/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 30 Dec 2018 12:18:10 + Build duration: 7 min 26 sec and counting BUILD ARTIFACTS compat_reports/KF

D17856: Fix a regression introduced in 6a1852

This revision was automatically updated to reflect the committed changes. Closed by commit R237:f403d09d0b49: Fix a regression introduced in 6a1852 (authored by vandenoever). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17856?vs=48363&id=48393 REVISION DETA

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 48391. loh.tar added a comment. - Revert d-stuff - Remove BCI stuff I'm still looking for a better name for "m_cancelFindOrReplace", suggestions? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47966&id=48391 REVISION DETAIL htt

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. In D17857#383865 , @dhaumann wrote: > Is this related to bug https://bugs.kde.org/show_bug.cgi?id=306745 ? I don't think so. Here is it auto-bracket stuff, there general "is visible" stuff :-) (Yeah, my English ro

D17851: Add Android notification backend

vkrause added a comment. In D17851#383718 , @nicolasfella wrote: > By using AndroidX (formerly known as the support library) we could enable it for Android version older than 23 (which is about 29% of all active devices). That would require add

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

dhaumann added a comment. Is this related to bug https://bugs.kde.org/show_bug.cgi?id=306745 ? I once tried to fix 306745 but had to revert due to a regression, see D10054 . REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857

D17817: Build without D-Bus on Android

vkrause added a comment. D17868 adds kwindowsystem to the Android CI, which is (still) a dependency for knotifications, I'll add knotifications itself too once the necessary patches have landed. REPOSITORY R289 KNotifications REVISION DETAIL https://

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann added a comment. The d-stuff should go out again, beside that i still need to test this more. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kde-

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. Do I have to revert this d-stuff? If so, some other tweak, or just as it was? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kd

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. As always poor tested and only in "normal mode", not vi INLINE COMMENTS > katedocument.cpp:3073 > const auto insertedAt(view->cursorPosition()); > -view->setCursorPosition(cursorPos); > m_currentAutobraceRange.reset(ne

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar retitled this revision from "DocumentPrivate: Don't scroll view when add auto-bracket at aned of file" to "DocumentPrivate: Don't scroll view when add auto-bracket at end of file". loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://pha

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48387. loh.tar retitled this revision from "[WIP] Review KateStatusBar " to "Review KateStatusBar ". loh.tar edited the summary of this revision. loh.tar added a comment. - Remove seemingly unneeded spacing. Well, there is a change but tiny and perhaps to

D17863: Add ecm_check_linker_flags function

lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns