D17911: Fix failing knewfilemenu test and underlying reason for its failure

2019-01-02 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks! Does the code change in `src/filewidgets/knewfilemenu.cpp` make sense 
to you? I tested a bunch but I know you're the expert here. :)

REPOSITORY
  R241 KIO

BRANCH
  fix-test-and-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17911

To: ngraham, #frameworks, dfaure, elvisangelaccio, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17911: Fix failing knewfilemenu test and underlying reason for its failure

2019-01-02 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Tests are good :-)

REPOSITORY
  R241 KIO

BRANCH
  fix-test-and-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17911

To: ngraham, #frameworks, dfaure, elvisangelaccio, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

2019-01-02 Thread Nathaniel Graham 
ngraham planned changes to this revision.
ngraham added a comment.


  Still doesn't actually work right; need to hack on it more.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10305

To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi
Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

2019-01-02 Thread Nathaniel Graham 
ngraham updated this revision to Diff 48569.
ngraham marked an inline comment as done.
ngraham added a comment.


  Rebase on current master, address review comments, fix bugs

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10305?vs=26574&id=48569

BRANCH
  arcpatch-D10305

REVISION DETAIL
  https://phabricator.kde.org/D10305

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/declarativeimports/core/tooltip.h
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/core/tooltipdialog.h

To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi
Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 106 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/106/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 02 Jan 2019 19:33:30 +
 Build duration:
4 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 19 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/19/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 02 Jan 2019 19:33:30 +
 Build duration:
1 min 30 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 02 Jan 2019 19:33:30 +
 Build duration:
1 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D17927: Fix gradient positions (Breeze Dark)

2019-01-02 Thread Noah Davis 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:742801be4a7a: Fix gradient positions (Breeze Dark) 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17927?vs=48562&id=48563

REVISION DETAIL
  https://phabricator.kde.org/D17927

AFFECTED FILES
  icons-dark/apps/48/blender.svg
  icons-dark/apps/48/calamares.svg
  icons-dark/apps/48/ubiquity-kde.svg
  icons-dark/apps/48/ubiquity.svg
  icons-dark/preferences/32/preferences-system-network-nis.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17927: Fix gradient positions (Breeze Dark)

2019-01-02 Thread Noah Davis 
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Forgot to do Breeze Dark when I fixed them in my previous diff

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-gradients (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17927

AFFECTED FILES
  icons-dark/apps/48/blender.svg
  icons-dark/apps/48/calamares.svg
  icons-dark/apps/48/ubiquity-kde.svg
  icons-dark/apps/48/ubiquity.svg
  icons-dark/preferences/32/preferences-system-network-nis.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 105 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/105/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 02 Jan 2019 19:01:20 +
 Build duration:
1 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/5/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 02 Jan 2019 19:01:20 +
 Build duration:
1 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 18 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/18/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 02 Jan 2019 19:01:20 +
 Build duration:
1 min 33 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D17912: Fix shadow gradients

2019-01-02 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:9a4e5d509535: Fix shadow gradients (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17912?vs=48509&id=48561

REVISION DETAIL
  https://phabricator.kde.org/D17912

AFFECTED FILES
  icons/apps/48/blender.svg
  icons/apps/48/calamares.svg
  icons/apps/48/ubiquity-kde.svg
  icons/apps/48/ubiquity.svg
  icons/preferences/32/preferences-system-network-nis.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 104 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/104/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 02 Jan 2019 18:54:40 +
 Build duration:
1 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 17 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/17/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 02 Jan 2019 18:54:40 +
 Build duration:
1 min 35 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/4/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 02 Jan 2019 18:54:40 +
 Build duration:
1 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D17923: Better desktop icon colors

2019-01-02 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7c81d01ed673: Better desktop icon colors (authored by 
GB_2, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17923?vs=48554&id=48560

REVISION DETAIL
  https://phabricator.kde.org/D17923

AFFECTED FILES
  icons/applets/256/org.kde.plasma.frame.svg
  icons/applets/64/preferences-system-windows-effect-desktopgrid.svg
  icons/applets/64/preferences-system-windows-effect-fadedesktop.svg
  icons/applets/64/preferences-system-windows-effect-highlightwindow.svg
  icons/applets/64/preferences-system-windows-effect-login.svg
  icons/applets/64/preferences-system-windows-effect-logout.svg
  icons/applets/64/preferences-system-windows-effect-scale-in.svg
  icons/applets/64/preferences-system-windows-effect-screenedge.svg
  icons/applets/64/preferences-system-windows-effect-screenshot.svg
  icons/applets/64/preferences-system-windows-effect-thumbnailaside.svg
  icons/applets/64/preferences-system-windows-effect-translucency.svg
  icons/applets/64/preferences-system-windows-effect-windowaperture.svg
  icons/apps/48/breeze-settings.svg
  icons/apps/48/kmag.svg
  icons/apps/48/ksnapshot.svg
  icons/places/32/user-desktop.svg
  icons/places/64/user-desktop.svg
  icons/preferences/32/plasma-search.svg
  icons/preferences/32/preferences-desktop-plasma.svg
  icons/preferences/32/preferences-desktop-screensaver.svg
  icons/preferences/32/preferences-desktop-user-password.svg
  icons/preferences/32/preferences-desktop-wallpaper.svg
  icons/preferences/32/preferences-desktop.svg
  icons/preferences/32/preferences-system-session-services.svg

To: GB_2, #vdg, #breeze, ngraham
Cc: ngraham, #breeze, kde-frameworks-devel, #vdg, michaelh, bruns

D17924: Better plasma-media-center icon

2019-01-02 Thread Nathaniel Graham 
ngraham added a comment.


  The gradient you used for the icons in D17924 
 looks different from the one you used 
here. This one has a darker one that almost looks radial instead of linear. Is 
that intentional?
  
  F6521196: Screenshot_20190102_115236.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17924

To: GB_2, #breeze, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17923: Better desktop icon colors

2019-01-02 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Wow, the aesthetic improvement here is really dramatic. That purple is such a 
more pleasant color than the old orange in these icons! All relevant icons seem 
changed, tests pass, etc.

REPOSITORY
  R266 Breeze Icons

BRANCH
  better-desktop-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17923

To: GB_2, #vdg, #breeze, ngraham
Cc: ngraham, #breeze, kde-frameworks-devel, #vdg, michaelh, bruns

D17924: Better plasma-media-center icon

2019-01-02 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Breeze, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Forgot to change plasma-media-center in D17919 
, this fixes it.

TEST PLAN
  Open cuttlefish and search for plasma-media-center

REPOSITORY
  R266 Breeze Icons

BRANCH
  better-plasma-media-center-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17924

AFFECTED FILES
  icons/apps/48/plasma-media-center.svg

To: GB_2, #breeze, #vdg
Cc: #vdg, kde-frameworks-devel, #breeze, michaelh, ngraham, bruns

D17923: Better desktop icon colors

2019-01-02 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17923

To: GB_2, #vdg, #breeze
Cc: #breeze, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17923: Better desktop icon colors

2019-01-02 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: VDG, Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The current icons with an abstract desktop wallpaper in the background have a 
very hard to see white icon, so this improves the colors and contrast of the 
abstract desktop wallpaper.
  F6521149: Plasma Desktop Preferences Icon.png 


TEST PLAN
  Open cuttlefish and see if every icon of this type has different colors now

REPOSITORY
  R266 Breeze Icons

BRANCH
  better-desktop-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17923

AFFECTED FILES
  icons/applets/256/org.kde.plasma.frame.svg
  icons/applets/64/preferences-system-windows-effect-desktopgrid.svg
  icons/applets/64/preferences-system-windows-effect-fadedesktop.svg
  icons/applets/64/preferences-system-windows-effect-highlightwindow.svg
  icons/applets/64/preferences-system-windows-effect-login.svg
  icons/applets/64/preferences-system-windows-effect-logout.svg
  icons/applets/64/preferences-system-windows-effect-scale-in.svg
  icons/applets/64/preferences-system-windows-effect-screenedge.svg
  icons/applets/64/preferences-system-windows-effect-screenshot.svg
  icons/applets/64/preferences-system-windows-effect-thumbnailaside.svg
  icons/applets/64/preferences-system-windows-effect-translucency.svg
  icons/applets/64/preferences-system-windows-effect-windowaperture.svg
  icons/apps/48/breeze-settings.svg
  icons/apps/48/kmag.svg
  icons/apps/48/ksnapshot.svg
  icons/places/32/user-desktop.svg
  icons/places/64/user-desktop.svg
  icons/preferences/32/plasma-search.svg
  icons/preferences/32/preferences-desktop-plasma.svg
  icons/preferences/32/preferences-desktop-screensaver.svg
  icons/preferences/32/preferences-desktop-user-password.svg
  icons/preferences/32/preferences-desktop-wallpaper.svg
  icons/preferences/32/preferences-desktop.svg
  icons/preferences/32/preferences-system-session-services.svg

To: GB_2, #vdg, #breeze
Cc: #breeze, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17851: Add Android notification backend

2019-01-02 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  These changes only will apply to Android, so let's get this in. The status 
quo is broken there anyway.
  
  As for the application, it could be in a separate repository too, no need to 
bloat the repository. For Kirigami we had to split it already because it was a 
bad idea.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17851

To: vkrause, apol
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 16 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/16/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 02 Jan 2019 15:59:14 +
 Build duration:
4 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 103 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/103/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 02 Jan 2019 15:59:14 +
 Build duration:
1 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 3 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/3/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 02 Jan 2019 15:59:15 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D17919: Better multimedia related icons

2019-01-02 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:98e5d1a3bd63: Better multimedia related icons (authored 
by GB_2, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17919?vs=48538&id=48544

REVISION DETAIL
  https://phabricator.kde.org/D17919

AFFECTED FILES
  icons/categories/32/applications-multimedia.svg
  icons/devices/64/multimedia-player.svg
  icons/devices/64/video-television.svg
  icons/preferences/32/preferences-desktop-multimedia.svg

To: GB_2, #breeze, #vdg, ngraham
Cc: ngraham, rooty, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17919: Better multimedia related icons

2019-01-02 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  better-multimedia-category-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17919

To: GB_2, #breeze, #vdg, ngraham
Cc: ngraham, rooty, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17919: Better multimedia related icons

2019-01-02 Thread Nathaniel Graham 
ngraham added a comment.


  lol you're too fast for me

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17919

To: GB_2, #breeze, #vdg
Cc: ngraham, rooty, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17919: Better multimedia related icons

2019-01-02 Thread Nathaniel Graham 
ngraham added a comment.


  Great!
  
  This ugly gradient is also present in:
  
  - `preferences-desktop-multimedia`
  - `multimedia-player`.
  - `video-television`
  
  Can you fix it in those too?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17919

To: GB_2, #breeze, #vdg
Cc: ngraham, rooty, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17919: Better multimedia related icons

2019-01-02 Thread Root 
rooty added a comment.


  +1 love the new background color

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17919

To: GB_2, #breeze, #vdg
Cc: rooty, #vdg, kde-frameworks-devel, #breeze, michaelh, ngraham, bruns

D17919: Better multimedia related icons

2019-01-02 Thread Björn Feber 
GB_2 updated this revision to Diff 48538.
GB_2 added a comment.


  Update other multimedia related icons too

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17919?vs=48537&id=48538

BRANCH
  better-multimedia-category-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17919

AFFECTED FILES
  icons/categories/32/applications-multimedia.svg
  icons/devices/64/multimedia-player.svg
  icons/devices/64/video-television.svg
  icons/preferences/32/preferences-desktop-multimedia.svg

To: GB_2, #breeze, #vdg
Cc: #vdg, kde-frameworks-devel, #breeze, michaelh, ngraham, bruns

D17919: Better multimedia related icons

2019-01-02 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Breeze, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Improves the screen background gradient in the multimedia related icons to 
make them look better.
  F6520979: Multimedia Category Icon.png 

TEST PLAN
  Open cuttlefish and search for applications-multimedia

REPOSITORY
  R266 Breeze Icons

BRANCH
  better-multimedia-category-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17919

AFFECTED FILES
  icons/categories/32/applications-multimedia.svg

To: GB_2, #breeze, #vdg
Cc: #vdg, kde-frameworks-devel, #breeze, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-02 Thread Nathaniel Graham 
ngraham removed a dependent revision: D17916: [Login and lock screens] Do not 
use light font styles for the sddm clock.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: cfeck, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-02 Thread Nathaniel Graham 
ngraham removed a dependent revision: D17916: [Login and lock screens] Do not 
use light font styles for the sddm clock.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17905: [frameworks] Do not use light font styles for headings (1/3)

2019-01-02 Thread Nathaniel Graham 
ngraham removed a dependent revision: D17916: [Login and lock screens] Do not 
use light font styles for the sddm clock.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17912: Fix shadow gradients

2019-01-02 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-gradients (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17912

To: ndavis, #vdg, #breeze, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17310: Improve Kile icon with LaTeX font

2019-01-02 Thread TrickyRicky 
trickyricky26 added a comment.


  Some designs that are more faithful to the original:
  
  F6520878: kile-faithful.svg.png 
  This has almost the same letter design as the original. I adjusted it a bit 
to fit onto the notepad.
  
  F6520887: kile-faithful-alternative.svg.png 

  This one has the letters arranged differently to make better use of the 
available space. 
  However, I think this looks less appealing and it is even less clear that the 
letters make the coherent word "Kile" than the original.
  
  @mludwig 
  What do you think of these designs? Are they close enough to the original to 
be recognizable?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: loh.tar, mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-02 Thread Filip Fila 
filipf edited the test plan for this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17905: [frameworks] Do not use light font styles for headings (1/3)

2019-01-02 Thread Filip Fila 
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

2019-01-02 Thread Root 
rooty added a dependent revision: D17916: [Login and lock screens] Do not use 
light font styles for the sddm clock.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: cfeck, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-02 Thread Root 
rooty added a dependent revision: D17916: [Login and lock screens] Do not use 
light font styles for the sddm clock.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17905: [frameworks] Do not use light font styles for headings (1/3)

2019-01-02 Thread Root 
rooty added a dependent revision: D17916: [Login and lock screens] Do not use 
light font styles for the sddm clock.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17310: Improve Kile icon with LaTeX font

2019-01-02 Thread TrickyRicky 
trickyricky26 planned changes to this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: loh.tar, mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/2/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 02 Jan 2019 11:01:26 +
 Build duration:
56 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/2/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 02 Jan 2019 06:19:31 +
 Build duration:
5 hr 26 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

2019-01-02 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/2/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 02 Jan 2019 02:50:15 +
 Build duration:
8 hr 54 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D17310: Improve Kile icon with LaTeX font

2019-01-02 Thread TrickyRicky 
trickyricky26 added a comment.


  In D17310#384720 , @mludwig wrote:
  
  > Moreover, as you pointed out in https://phabricator.kde.org/T10243, the 
"Don't destroy the app's existing branding" recommendation in the HIG has 
actually been violated by the previous version of this icon already.
  
  
  I have to agree with you here. Do you think a version of the icon with 
identical Text as the original Kile icon (big, horizontal "K", smaller, 
vertical "ile") with the notepad as the background would be enough to not 
differ from the existing branding too much?
  I would like for some of the aspects of the current proposal (notepad, pen) 
to stay as the plain blue circle from the original icon does not integrate too 
well with the Breeze style.
  
  I will update the revision with a version described above (original letters, 
notepad background)

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: loh.tar, mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17904: Highlight CUDA .cu and .cuh files as C++

2019-01-02 Thread Thomas Schöps 
thomassc updated this revision to Diff 48519.
thomassc added a comment.


  Thanks for having a look. I assume that the "version" attribute needs to be 
increased and the "kateversion" does not. I updated the diff accordingly. I 
don't think that I have any commit rights, can you commit?

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17904?vs=48493&id=48519

REVISION DETAIL
  https://phabricator.kde.org/D17904

AFFECTED FILES
  data/syntax/cpp.xml

To: thomassc, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D17910: [UDisks2] Use MediaRemovable to determine if media can be ejected

2019-01-02 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:6d260195cf75: [UDisks2] Use MediaRemovable to determine 
if media can be ejected (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17910?vs=48504&id=48516

REVISION DETAIL
  https://phabricator.kde.org/D17910

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: bruns, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2019-01-02 Thread Roman Gilg 
romangg updated this revision to Diff 48515.
romangg added a comment.


  - Fix typo
  - Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15421?vs=41497&id=48515

BRANCH
  0proxyDataSurface

REVISION DETAIL
  https://phabricator.kde.org/D15421

AFFECTED FILES
  src/server/datadevice_interface.cpp
  src/server/datadevice_interface.h
  src/server/pointer_interface.cpp
  src/server/seat_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h
  src/server/surface_interface_p.h

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2019-01-02 Thread Roman Gilg 
romangg marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15023: [server] Add selectionChanged signal

2019-01-02 Thread Roman Gilg 
romangg updated this revision to Diff 48513.
romangg added a comment.


  Rebase on master.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15023?vs=41424&id=48513

BRANCH
  0selectionChangeXwl

REVISION DETAIL
  https://phabricator.kde.org/D15023

AFFECTED FILES
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns