D17956: DocumentPrivate: Fix broken doc links in qCWarning

sars added a comment. Adding as a warning message in the view could be another review and needs comments from others first REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956 To: loh.tar, #ktexteditor, sars Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor,

D17956: DocumentPrivate: Fix broken doc links in qCWarning

sars accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956 To: loh.tar, #ktexteditor, sars Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking,

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 04 Jan 2019 06:56:34 + Build duration: 1 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/108/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 Jan 2019 06:56:33 + Build duration: 1 min 34 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/21/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 04 Jan 2019 06:56:34 + Build duration: 1 min 28 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/107/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 04 Jan 2019 06:09:13 + Build duration: 1 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/20/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 04 Jan 2019 06:09:13 + Build duration: 1 min 35 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 04 Jan 2019 06:09:13 + Build duration: 1 min 32 sec and counting JUnit Tests Name:

D17924: Better plasma-media-center icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b66a65bac264: Better plasma-media-center icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17924?vs=48596=48657 REVISION DETAIL

D17957: WML: fix embedded Lua code & use new default styles

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In the previous diff of WML (D17891

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar added a comment. How about to change this logging into a warning message in the view? Or will it displayed(?) I have noticed these while investigating https://bugs.kde.org/show_bug.cgi?id=397956 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D15573: replace custom backtracing in SlaveBase with KCrash

cfeck added a comment. This seems to pull in QtGui dependency, but that's also dragged in by KService (which also links to KF5::Crash) and KF5DBusAddons (which only needs QtX11Extras, which unfortunately also needs QtGui). Can the KCrash dependency be added to the slaves instead of to

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/3/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 03 Jan 2019 22:04:06 + Build duration: 32 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/9/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 03 Jan 2019 22:04:06 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 211 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/211/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 03 Jan 2019 22:04:06 + Build duration: 9 min 8 sec and counting BUILD ARTIFACTS

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e5949866bb8f: [Calendar] Expose firstDayOfWeek in MonthView (authored by Zren). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D17939: Haskell: Highlight empty comments after 'import'

xialiyao added a comment. Thanks a lot for the tip! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17939 To: xialiyao, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars

D17951: Haskell: Make = a special symbol

xialiyao created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. xialiyao requested review of this revision. REVISION SUMMARY It was previously parsed as an operator, but it's much less of one than even `=>` or `->`.

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 03 Jan 2019 20:42:55 + Build duration: 39 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 210 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/210/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 03 Jan 2019 20:42:55 + Build duration: 4 min 6 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/2/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 03 Jan 2019 20:42:55 + Build duration: 1 min 48 sec and counting JUnit Tests

D17730: Review KateStatusBar

loh.tar added a comment. > Do we loose this property by using real buttons instead of labels as this patch proposes? I don't think so. The buttons are not entire new, only some labels are now ALSO buttons. REPOSITORY R39 KTextEditor REVISION DETAIL

D17911: Fix failing knewfilemenu test and underlying reason for its failure

ngraham added a comment. Tagging is on January 5th, so I'd like to get this in before then. Any objections from anyone if I commit this? REPOSITORY R241 KIO BRANCH fix-test-and-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D17911 To: ngraham, #frameworks,

D17816: Support for xattrs on kio copy/move

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, bruns

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Don't wrap entire document when nothing is selected but wrap

D17730: Review KateStatusBar

dhaumann added a comment. @cullmann I remember that you fiddled around with the status bar quite a lot to make it pixel perfect in height, i.e. that the height of the statusbar matches the hight of e.g. the search bar. Do we loose this property by using real buttons instead of labels as

D17938: Add support for passing cursor information to KRun.

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17938 To: arrowd, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17430: highlight token strings and delimited strings

dhaumann added a comment. Also committed, hope everything merged nicely and is correct. I had to update the folding unit test data again, but I guess that is fine. If you find any issues, please provide another patch :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D17430: highlight token strings and delimited strings

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2a928919366d: highlight token strings and delimited strings (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17430?vs=48636=48638#toc REPOSITORY R216 Syntax

D17430: highlight token strings and delimited strings

aG0aep6G added a comment. In D17430#386026 , @dhaumann wrote: > Unfortunately, this patch also has an issue: > > XSDError in data/syntax/d.xml, at line 413, column 53: Element context is missing required attribute lineEndContext. >

D17430: highlight token strings and delimited strings

aG0aep6G updated this revision to Diff 48636. aG0aep6G added a comment. - add missing lineEndContext attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17430?vs=47371=48636 BRANCH tokenstring-delimitedstring REVISION DETAIL

D17460: fixups for `extern` and `pragma`

This revision was automatically updated to reflect the committed changes. Closed by commit R216:dc79692de359: fixups for `extern` and `pragma` (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17460?vs=48634=48635#toc REPOSITORY R216 Syntax Highlighting CHANGES

D17924: Better plasma-media-center icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good! Shipit! REPOSITORY R266 Breeze Icons BRANCH better-plasma-media-center-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17924 To: GB_2,

D17460: fixups for `extern` and `pragma`

aG0aep6G added a comment. In D17460#386002 , @dhaumann wrote: > Can you provide an updated patch to fix this? Or at least tell me what lineEndContext should be used here? Fixed, I hope. REPOSITORY R216 Syntax Highlighting BRANCH

D17430: highlight token strings and delimited strings

dhaumann added a comment. Unfortunately, this patch also has an issue: XSDError in data/syntax/d.xml, at line 413, column 53: Element context is missing required attribute lineEndContext. Can you provide an update to fix it? REPOSITORY R216 Syntax Highlighting BRANCH

D17460: fixups for `extern` and `pragma`

aG0aep6G updated this revision to Diff 48634. aG0aep6G added a comment. - add missing lineEndContext attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17460?vs=47369=48634 BRANCH extern-and-pragma REVISION DETAIL

D17904: Highlight CUDA .cu and .cuh files as C++

dhaumann added a comment. Thanks! More patches welcome :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17904 To: thomassc, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh,

D17904: Highlight CUDA .cu and .cuh files as C++

This revision was automatically updated to reflect the committed changes. Closed by commit R216:47ca116c74d2: Highlight CUDA .cu and .cuh files as C++ (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17904?vs=48519=48633

D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Ok, will integrate now as well. REPOSITORY R216 Syntax Highlighting BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D17883 To: nibags,

D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:f8d8a2fbc0f5: TypeScript TS/JS React: improve types detection, fix float-points other… (authored by nibags, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17460: fixups for `extern` and `pragma`

dhaumann added a comment. @aG0aep6G I just tried to commit this, but it does not work due to the following issue: XSDError in data/syntax/d.xml, at line 613, column 60: Element context is missing required attribute lineEndContext. Can you provide an updated patch to fix this? Or

D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17883 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann,

D17883: TypeScript & TS/JS React: improve types detection, fix float-points & other improvements/fixes

nibags updated this revision to Diff 48628. nibags added a comment. - Small modification in comments REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17883?vs=48433=48628 BRANCH update-typescript REVISION DETAIL

D17939: Haskell: Highlight empty comments after 'import'

dhaumann added a comment. Committed, I also used some default styles, see patch below. You can find more of the available default styles since KF5 here: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/ If you want, you can use these and post

D17939: Haskell: Highlight empty comments after 'import'

This revision was automatically updated to reflect the committed changes. Closed by commit R216:d173b27c4d37: Haskell: Highlight empty comments after import (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17939?vs=48605=48627#toc REPOSITORY R216 Syntax

D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c276c7003d35: WML: fix infinite loop in contexts switch only highlight tags with valid names (authored by nibags, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D17905: [frameworks] Do not use light font styles for headings (1/3)

ngraham added a comment. In D17905#385834 , @abetts wrote: > I don't have a problem with the font as much as I have a problem with the spacing for the title labels. They seem to be super close to checkboxes, other labels and controls. There

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a subscriber: rooty. ngraham added a comment. Aesthetics are admittedly subjective, though I must note that pretty much all of VDG is in favor of moving away from light header text for aesthetic reasons. However there are other important technical arguments as well, which I

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

kkofler added a comment. Herald added a subscriber: kde-frameworks-devel. Ping? This has been stuck for over a year now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8810 To: kkofler, #frameworks, kfunk, cullmann Cc: kde-frameworks-devel, dfaure, ngraham, broulik,

D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names

nibags updated this revision to Diff 48617. nibags added a comment. - Update test file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17891?vs=48510=48617 BRANCH fix-wml REVISION DETAIL https://phabricator.kde.org/D17891 AFFECTED FILES

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.11/1/ Project: kf5-qt5 AndroidQt5.11 Date of build: Thu, 03 Jan 2019 16:57:49 + Build duration: 3 min 47 sec and counting

D17851: Add Android notification backend

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a54c7b17045a: Add Android notification backend (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17851?vs=48339=48609 REVISION DETAIL

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a subscriber: Frameworks. REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel,

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added subscribers: VDG, Plasma, ngraham. REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: ngraham, #plasma, #vdg, abetts, mart, plasma-devel, dkardarakos,

D17905: [frameworks] Do not use light font styles for headings (1/3)

filipf added subscribers: ngraham, VDG, Plasma, Frameworks. REPOSITORY R242 Plasma Framework (Library) BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: #frameworks, #plasma, #vdg,

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. In D17906#385682 , @mart wrote: > I'm very much against this, I think it looks very bad :/ I think the idea to have a light style for big titles is nice and could theoretically work, but in our case unfortunately

D17905: [frameworks] Do not use light font styles for headings (1/3)

abetts added a comment. I don't have a problem with the font as much as I have a problem with the spacing for the title labels. They seem to be super close to checkboxes, other labels and controls. There should be a clear separation. Adding a heavier font to the title label helps a lot but

D17939: Haskell: Highlight empty comments after 'import'

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH import-comment REVISION DETAIL https://phabricator.kde.org/D17939 To: xialiyao, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham,

D17939: Haskell: Highlight empty comments after 'import'

xialiyao updated this revision to Diff 48605. xialiyao added a comment. Added tests and bumped haskell.xml version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17939?vs=48594=48605 BRANCH import-comment REVISION DETAIL

D17906: [kirigami] Do not use light font styles for headings (2/3)

abetts added a comment. Goodness, I think this is all about taste. I am more on the side that it looks good. It visually prioritizes hierarchy with labels. @mart Does it just look bad for you or do you think this will cause issues somewhere else? REPOSITORY R169 Kirigami BRANCH

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/2/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 03 Jan 2019 14:32:33 + Build duration: 1 min 46 sec and counting JUnit Tests Name:

D17924: Better plasma-media-center icon

rooty added a comment. +1 loving the new icon REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17924 To: GB_2, #breeze, #vdg Cc: rooty, ngraham, #vdg, kde-frameworks-devel, #breeze, michaelh, bruns

D17939: Haskell: Highlight empty comments after 'import'

dhaumann added a comment. Yes, please add a test line in the autotest folder: https://github.com/KDE/syntax-highlighting/blob/master/autotests/input/highlight.hs And please also increase the version number in the language xml element. REPOSITORY R216 Syntax Highlighting REVISION

D17924: Better plasma-media-center icon

GB_2 updated this revision to Diff 48596. GB_2 added a comment. Remove dark radial gradient REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17924?vs=48555=48596 BRANCH better-plasma-media-center-icon (branched from master) REVISION DETAIL

D17816: Support for xattrs on kio copy/move

pino added a comment. Nice progresses, thanks for the fixes. I added few more notes, just mentioning the first occurrence of each. One more thing is to print errno (and possibly its string representation using `strerror`/`strerror_r`) on failure, so that the debugging is easier. INLINE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/34/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 03 Jan 2019 12:29:48 + Build duration: 34 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 395 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/395/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 03 Jan 2019 12:29:48 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/2/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 03 Jan 2019 12:29:48 + Build duration: 12 min and counting JUnit Tests Name: projectroot

D17939: Haskell: Highlight empty comments after 'import'

xialiyao added a comment. Should I add a test for it? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17939 To: xialiyao Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17939: Haskell: Highlight empty comments after 'import'

xialiyao created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. xialiyao requested review of this revision. REVISION SUMMARY In the following snippet, import Bar () -- the trailing, empty comment did

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. I'm very much against this, I think it looks very bad :/ REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: mart, plasma-devel,

D17241: WIP:Disable highlighting after 512 characters on a line.

sars added a comment. @dhaumann OK the limit is too low for Kile that is clear. Visual Studio Code is limiting the highlighting on a line to 1 characters. I tried to set the limit to 1, but that was very noticeably slow. Selecting a whole line took multiple seconds, which is

D17905: [frameworks] Do not use light font styles for headings (1/3)

filipf updated this revision to Diff 48579. filipf added a comment. Found another case of the FontLight variable being set REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17905?vs=48495=48579 BRANCH no-light-headings (branched from

D17816: Support for xattrs on kio copy/move

cochise edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, bruns

D17816: Initial support for xattrs on kio copy/move

cochise updated this revision to Diff 48586. cochise added a comment. Tests added, includes and ifdefs reworked Initial tests. Not crossplatform of extensive yet. The includes and ifdefs were reworked, and I think they are more concise and simple, but some feedback is needed, as they

D17932: Improvements to completion

thomassc created this revision. thomassc added a reviewer: KTextEditor. thomassc added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. thomassc requested review of this revision. REVISION SUMMARY My goal is to fix

D17938: Add support for passing cursor information to KRun.

arrowd created this revision. arrowd added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arrowd requested review of this revision. REVISION SUMMARY This is the KIO part of https://bugs.kde.org/show_bug.cgi?id=398998 TEST PLAN

D17816: Support for xattrs on kio copy/move

cochise retitled this revision from "Initial support for xattrs on kio copy/move" to "Support for xattrs on kio copy/move". cochise edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: abika, pino,