D17911: Fix failing knewfilemenu test and underlying reason for its failure

ngraham updated this revision to Diff 48783. ngraham added a comment. Test for failure too REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17911?vs=48508=48783 BRANCH fix-test-and-code (branched from master) REVISION DETAIL

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.9 - Build # 126 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.9/126/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 Jan 2019 04:32:45 + Build duration: 2 hr 20 min and counting CONSOLE OUTPUT [...truncated 38

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 398 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/398/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 Jan 2019 04:31:55 + Build duration: 2 hr 21 min and counting CONSOLE OUTPUT [...truncated 38

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 213 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/213/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 Jan 2019 04:32:35 + Build duration: 2 hr 20 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » frameworkintegration » kf5-qt5 SUSEQt5.9 - Build # 53 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20SUSEQt5.9/53/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 Jan 2019 04:31:08 + Build duration: 2 hr 19 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 110 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/110/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 Jan 2019 04:32:05 + Build duration: 2 hr 19 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/57/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 Jan 2019 04:31:28 + Build duration: 2 hr 19 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/11/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 06 Jan 2019 04:32:35 + Build duration: 2 hr 4 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/37/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 06 Jan 2019 04:31:56 + Build duration: 1 hr 57 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 06 Jan 2019 04:31:28 + Build duration: 1 hr 57 min and counting BUILD ARTIFACTS

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48781. loh.tar added a comment. Allow StatusBarButton to shrink Ah! Strange! :-/ But somehow the more usual behavior, these "crunching" is unlikely. Couldn't find a hint where it is done in Kate, but after some digging around I have some solution

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 04:31:55 + Build duration: 1 hr 13 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 04:32:35 + Build duration: 1 hr 9 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/3/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 04:31:28 + Build duration: 1 hr 4 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/36/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 06 Jan 2019 02:55:00 + Build duration: 28 min and counting BUILD ARTIFACTS

D17730: Review KateStatusBar

zetazeta added a comment. The problem I talk about happens on kwrite, no kate. I get the crunch as well on kate. Cheers :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, zetazeta, cullmann, kwrite-devel,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 397 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/397/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 06 Jan 2019 02:55:00 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 02:55:00 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D17999: ViewConfig: Add option to paste at cursor position by mouse

ngraham added a comment. I would change the string to "Paste clipboard contents at mouse cursor location". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel,

D17816: Support for xattrs on kio copy/move

bruns added inline comments. INLINE COMMENTS > copyjob.cpp:2199 > +#if HAVE_SYS_XATTR_H && !defined(__stub_getxattr) > +ssize_t listlen = listxattr(xattrsrc, nullptr, 0); > +#elif defined(Q_OS_MAC) you can (typically) avoid the double (syscall, i.e. expensive) by preallocating the array

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Please provide also a tooltip/whats-this text, if useful. My QtDesigner did not show the needed widget stuff, so the text is not set. A look at that bug report may give more hints/ideas REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: Review KateStatusBar

loh.tar added a comment. @zetazeta wrote > I find it annoying that the status bar imposes a limit on the minimum width of the window @dhaumann wrote > Maybe with this patch, the status bar grows and forces a different width me wrote > The bar can shrink almost endless

D17999: ViewConfig: Add option to paste at cursor position by mouse

dhaumann added subscribers: ngraham, dhaumann. dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Good patch, I think this can go in. @ngraham: You as native English speaker, is the wording in the dialog ok? REPOSITORY R39

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this option is the cursor not moved to the mouse position

D17730: Review KateStatusBar

zetazeta added a comment. In D17730#382676 , @cullmann wrote: > > - Your comment to @zetazeta request ? I have tried to add a QScrollArea but without success :-/ Ideas? Perhaps is a second level of layout/widget needed(?) > > I would not

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

Hi, > ;=( > > 5.12 breaks more scripting tests than just templatehandler_test, > have ATM no fix for the indentation stuff, thought. I spend a bit time debugging this, somehow some regex .exec's are regressed from 5.11 to 5.12: https://phabricator.kde.org/D17998 If somebody has insight if

D17998: test to fix cpp indenter

cullmann added reviewers: carewolf, Frameworks. cullmann added a comment. Hi ;=) I have some dumb javascript / QJSEngine question: With Qt 5.12, the regex above var r = /^(\s*)(([\)\]}]?\s*)*([\)\]]\s*))?;/.exec(prevString); executes successfully on a "prevString"

D17998: test to fix cpp indenter

cullmann created this revision. cullmann added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY cppstyle indenter is broken with Qt 5.12 this commit

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

;=( 5.12 breaks more scripting tests than just templatehandler_test, have ATM no fix for the indentation stuff, thought. Greetings Christoph - Am 5. Jan 2019 um 20:02 schrieb CI System nore...@kde.org: > BUILD UNSTABLE > Build URL [ >

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/23/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 05 Jan 2019 18:57:34 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 05 Jan 2019 18:57:34 + Build duration: 5 min 4 sec and counting JUnit Tests Name:

D17816: Support for xattrs on kio copy/move

dfaure added a comment. I'll be happy to review a patch for QSaveFile to preserve ACLs and xattrs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun,

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.9 - Build # 62 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.9/62/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 05 Jan 2019 17:53:39 + Build duration: 4 min 48 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kholidays » kf5-qt5 SUSEQt5.11 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 05 Jan 2019 17:53:39 + Build duration: 4 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.11 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.11/26/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 05 Jan 2019 17:53:39 + Build duration: 2 min 7 sec and counting JUnit Tests

KDE CI: Frameworks » kholidays » kf5-qt5 FreeBSDQt5.12 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20FreeBSDQt5.12/3/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 05 Jan 2019 17:53:39 + Build duration: 41 sec and counting JUnit Tests Name: projectroot

D17816: Support for xattrs on kio copy/move

cochise added a comment. In D17816#386810 , @funkybomber wrote: > On a related note, is it possible that the "QSaveFile" is also responsible for a similar behaviour in Ark? Probably yes:

D17938: Add support for passing cursor information to KRun.

elvisangelaccio added a comment. In D17938#386999 , @arrowd wrote: > In D17938#386985 , @elvisangelaccio wrote: > > > I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm

D17938: Add support for passing cursor information to KRun.

aacid added a comment. Encode the information in the url? Also this change is binary incompatible, please see the wiki https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17938 To: arrowd,

D17938: Add support for passing cursor information to KRun.

arrowd added a comment. In D17938#386985 , @elvisangelaccio wrote: > I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API. I'd say they are both filetype-specific and

D17938: Add support for passing cursor information to KRun.

elvisangelaccio added a comment. I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17938 To: arrowd, #frameworks Cc: elvisangelaccio,

D17990: Update php syntax support

This revision was automatically updated to reflect the committed changes. Closed by commit R216:d85160a96653: Update php syntax support (authored by pprkut, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17990: Update php syntax support

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, will integrate. REPOSITORY R216 Syntax Highlighting BRANCH php-merged REVISION DETAIL https://phabricator.kde.org/D17990 To: pprkut, dhaumann Cc: dhaumann,

D17991: Refactor the way device backends are built and registered

pino added a comment. This is tested so far only on Linux, where the cmake output for the device backends is: -- The following features have been enabled: * fakehw, Solid device 'fakehw' backend. * udev, Solid device 'udev' backend. * udisks2, Solid device 'udisks2'

D17991: Refactor the way device backends are built and registered

pino created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY Currently, the bits of information of each device backend (e.g. udev, upower, etc) are spread in different files: -

D17990: Update php syntax support

pprkut created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. pprkut requested review of this revision. REVISION SUMMARY This is now mostly based on the official php documentation, with some minor exceptions. This should

D17973: [Android] Fail more gracefully when building with API < 23

This revision was automatically updated to reflect the committed changes. Closed by commit R289:0430c577f963: [Android] Fail more gracefully when building with API 23 (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D17970: Fix broken Emmet

loh.tar added a comment. May I ask a stupid question? Is the entire function needed? That's looks to me somehow like image/picture stuff but I don't find picture stuff in the Tool->Emmet menu. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17970 To: loh.tar,

D17730: Review KateStatusBar

loh.tar added a comment. That can I not really imagine :-/ Wouldn't that not somehow to be notice in normal use? Let's try this. Shot without bar, Now choose "Show bar", The window didn't change. (Sorry, no tool at hand to paste pics together) The bar can shrink almost endless.

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 48733. cochise added a comment. small cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=48731=48733 BRANCH xattr-copy-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D17816

D17816: Support for xattrs on kio copy/move

cochise edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, bruns

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 48731. cochise added a comment. Tests refactored, but no multiplatform. Other small fixes. The tests aren't a big mess anymore, and some groundwork for multiplatform tests are in place, but as I don't have a non linux system, I can't finish this

D17986: Build the Java side with Gradle, as AAR instead of JAR

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Most importantly this allows us to use the AndroidX support library, to properly support a wide range of different

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/22/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 05 Jan 2019 10:51:18 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 05 Jan 2019 10:51:18 + Build duration: 5 min 23 sec and counting JUnit Tests Name:

D17970: Fix broken Emmet

dhaumann added inline comments. INLINE COMMENTS > dhaumann wrote in lib.js:5434 > Being a js-noob, I did some searchin the net and it seems to me that \211 is > supposed to be octal sequence. On > https://stackoverflow.com/questions/21071921 it is said that octal sequences > are optional in

D17984: Fix emmet script by using HEX instead of OCT numbers in strings

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2f467b46ac6f: Fix emmet script by using HEX instead of OCT numbers in strings (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17984: Fix emmet script by using HEX instead of OCT numbers in strings

carewolf accepted this revision. carewolf added a comment. This revision is now accepted and ready to land. Looks good to me REPOSITORY R39 KTextEditor BRANCH fix-emmet REVISION DETAIL https://phabricator.kde.org/D17984 To: dhaumann, carewolf, loh.tar Cc: kwrite-devel,

D17984: Fix emmet script by using HEX instead of OCT numbers in strings

dhaumann created this revision. dhaumann added reviewers: carewolf, loh.tar. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This is a follow-up commit to D17970

D17816: Support for xattrs on kio copy/move

funkybomber added a comment. @dhaumann: I just tested it on KDE Neon. You are right, it is fixed! :) On a related note, is it possible that the "QSaveFile" is also responsible for a similar behaviour in Ark? If I add tags to a "test.zip" file and then I open it with Ark and

D17973: [Android] Fail more gracefully when building with API < 23

vkrause accepted this revision. REPOSITORY R289 KNotifications BRANCH grace REVISION DETAIL https://phabricator.kde.org/D17973 To: nicolasfella, vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17911: Fix failing knewfilemenu test and underlying reason for its failure

dfaure added a comment. That makes sense. You could set expectedFileName to empty, and change the test code to interpret this as "nothing got created (and possibly: check that we got an error signal, if there's one)" REPOSITORY R241 KIO BRANCH fix-test-and-code (branched from master)

D17970: Fix broken Emmet

dhaumann added inline comments. INLINE COMMENTS > carewolf wrote in lib.js:5434 > Is that even valid JS? Shouldn\t it be \xHH with hexidecimal? Being a js-noob, I did some searchin the net and it seems to me that \211 is supposed to be octal sequence. On

D17730: Review KateStatusBar

dhaumann added a comment. @loh.tar I think this test uses dynamic word wrap, and therefore requires a specific width of the view. Maybe with this patch, the status bar grows and forces a different width, so that the dynamic word wrap changes and the test fails? REPOSITORY R39 KTextEditor

D17970: Fix broken Emmet

carewolf added inline comments. INLINE COMMENTS > lib.js:5434 > getImageSize: function(stream) { > - var pngMagicNum = "\211PNG\r\n\032\n", > - jpgMagicNum = "\377\330", Is that even valid JS? Shouldn\t it be \xHH with hexidecimal?

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/21/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 05 Jan 2019 09:31:57 + Build duration: 6 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/3/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 05 Jan 2019 09:31:57 + Build duration: 5 min 1 sec and counting JUnit Tests Name:

D17970: Fix broken Emmet

dhaumann added a comment. Btw, I committed this, but now the length of the string is 14 characters instead of 8, so this patch is certainly wrong. But better this than a completely broken emmet. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17970 To: loh.tar,

D17970: Fix broken Emmet

This revision was automatically updated to reflect the committed changes. Closed by commit R39:120e8400cad6: Fix broken Emmet (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17970?vs=48698=48719 REVISION DETAIL

D17970: Fix broken Emmet

dhaumann added subscribers: carewolf, dhaumann. dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. @carewolf This issue was caused by the QtScript to QML migration in KTextEditor. Could you have a look or pass this on the relevant V4