KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 74 - Still unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/74/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 07 Jan 2019 18:13:53 + Build duration: 9 hr 34 min and counting JUnit Tests

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Nathaniel Graham
ngraham added a comment. F6531451: Screenshot_20190107_145258.png In this one, the fact that it's a header is connoted by its much larger font size and wider character width and spacing. It feels "bigger" in every way than the text beneath it. It

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kio-searchellipsis (branched from master) REVISION DETAIL https://phabricator.kde.org/D18045 To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham Cc: kde-frameworks-devel,

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This has the effect of //removing// the search fields for all the shortcut chooser views. That doesn't seem like the intent here. REPOSITORY R276 KItemViews REVISION DETAIL

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think this is fine. The search field doesn't have to specify what it's going to be searching in if it's totally obvious, as it is here. This also makes it consistent with other similar

D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH skipautomoxforgperf REVISION DETAIL https://phabricator.kde.org/D18088 To: kossebau, #frameworks, pino, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh,

D18081: Make translations work

2019-01-07 Thread Aleix Pol Gonzalez
apol added a comment. LGTM otherwise INLINE COMMENTS > CMakeLists.txt:4 > set(KF5_VERSION "5.54.0") # handled by release scripts > -set(KF5_DEP_VERSION "5.54.0") # handled by release scripts > +set(KF5_DEP_VERSION "5.53.0") # handled by release scripts > project(KPackage VERSION

D18079: Use (and suggest using) the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18079 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D18076 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17986: Build the Java side with Gradle, as AAR instead of JAR

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17986 To: vkrause, apol Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham,

D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

2019-01-07 Thread Friedrich W. H. Kossebau
kossebau added a comment. Not sure if there ever s a chance somebody would inject QObject code into such a generated file? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18088 To: kossebau, #frameworks, pino Cc: kde-frameworks-devel, kde-buildsystem,

D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

2019-01-07 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, pino. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Avoids to have manually set the property on

D18010: Allow zero altitude/longitude/latitude exiv gps data

2019-01-07 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18010 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D10446: Add KLanguageName

2019-01-07 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > klanguagename.cpp:30 > +const QStringList parts = QLocale().name().split(QChar('_')); > +return nameForCodeInLocale(code, parts.at(0)); > +} should the second param be code too? I mean if we read the docs we say both are code (ISO 639-1),

D18081: Make translations work

2019-01-07 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Do not call i18n from global static variables since qcoreapplication is still not around yet and that makes it fail

D17999: ViewConfig: Add option to paste at cursor position by mouse

2019-01-07 Thread loh tar
loh.tar added a comment. I agree, it's on the first sight pretty clear. But then can you force this "style" for every bool option. In the above linked pic is this obviously only used for Normal vs Vi-Mode [1] A drawback of that "style" may that you can't say for sure "which is what" in

D18079: Use (and suggest using) the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18079 AFFECTED FILES

D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It's simpler to understand than K_PLUGIN_FACTORY_WITH_JSON that asks you for a factory name but you never know which name

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added inline comments. INLINE COMMENTS > pino wrote in kpluginselector.cpp:261 > a) explicit is better than implicit > b) "shorter" makes sense only when thinking for English, not for other > languages a) not always - there's very little nuance here, and there's nothing to be gained by

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 07 Jan 2019 20:54:16 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2019-01-07 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R241:a3fce6e0b7f2: avoid blocking kio_http_cache_cleaner and ensure exit with session (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17741?vs=48084=48924#toc REPOSITORY

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.11/12/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 07 Jan 2019 20:41:21 + Build duration: 5 min 17 sec and counting BUILD ARTIFACTS

D17391: add support for more mimetypes to taglibwriter

2019-01-07 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:b6fa5f7245fb: add support for more mimetypes to taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17391?vs=46994=48918

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/3/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 07 Jan 2019 20:41:21 + Build duration: 2 min 9 sec and counting BUILD ARTIFACTS

D17999: ViewConfig: Add option to paste at cursor position by mouse

2019-01-07 Thread Christoph Cullmann
cullmann added a comment. In D17999#387760 , @ngraham wrote: > Hmm, maybe I misunderstood the feature then, sorry! > > In cases where there are two binary options but both are semi-confusing, or when one option does not necessarily imply its

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 19 - Still unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/19/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 06 Jan 2019 23:17:33 + Build duration: 20 hr and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 4 - Fixed!

2019-01-07 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 07 Jan 2019 18:40:42 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.11 - Build # 17 - Fixed!

2019-01-07 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.11/17/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 07 Jan 2019 18:40:42 + Build duration: 9 min 47 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 3 - Failure!

2019-01-07 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/3/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 07 Jan 2019 18:34:31 + Build duration: 2 min 52 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.11 - Build # 16 - Failure!

2019-01-07 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.11/16/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 07 Jan 2019 18:34:32 + Build duration: 2 min 53 sec and counting CONSOLE OUTPUT [...truncated

D18030: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D18030 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18029: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18029 To: aacid, apol Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 07 Jan 2019 18:13:36 + Build duration: 5 min 31 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 73 - Aborted!

2019-01-07 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown":

D18028: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18028 To: aacid, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Filip Fila
filipf added a comment. Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. F6531867: image.png For me this represented a massive regression, and there's bound to be more people in a similar situation. We can't

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > rooty wrote in kpluginselector.cpp:261 > i think it's because it's self-evident (and shorter) a) explicit is better than implicit b) "shorter" makes sense only when thinking for English, not for other languages REPOSITORY R295 KCMUtils REVISION

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root
rooty added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D18046 To: rooty, #vdg, #plasma, kde-frameworks-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added inline comments. INLINE COMMENTS > pino wrote in kpluginselector.cpp:261 > why not "Search plugins..."? i think it's because it's self-evident (and shorter) REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty, #vdg, #plasma,

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty, #vdg, #plasma, kde-frameworks-devel Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham,

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root
rooty added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18045 To: rooty, #vdg, #plasma, kde-frameworks-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root
rooty added reviewers: VDG, Plasma, kde-frameworks-devel. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D18046 To: rooty, #vdg, #plasma, kde-frameworks-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root
rooty added reviewers: VDG, Plasma, kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18045 To: rooty, #vdg, #plasma, kde-frameworks-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added reviewers: VDG, Plasma, kde-frameworks-devel. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty, #vdg, #plasma, kde-frameworks-devel Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D17986: Build the Java side with Gradle, as AAR instead of JAR

2019-01-07 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in FindGradle.cmake:5 > Sounds like it should be in ECM, no? Right, that's the obvious final location for this, once it has proven itself as the right approach here. REPOSITORY R289 KNotifications REVISION DETAIL

D17986: Build the Java side with Gradle, as AAR instead of JAR

2019-01-07 Thread Volker Krause
vkrause updated this revision to Diff 48881. vkrause added a comment. Move Android specifc stuff into a subdir. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17986?vs=48727=48881 BRANCH master REVISION DETAIL

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > kpluginselector.cpp:261 > d->lineEdit->setClearButtonEnabled(true); > -d->lineEdit->setPlaceholderText(i18n("Search Plugins")); > +d->lineEdit->setPlaceholderText(i18n("Search...")); > d->listView = new KCategorizedView(this); why

D17855: Don't rely on the Plasma workspace integration on Android

2019-01-07 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:7e5cf84798cd: Dont rely on the Plasma workspace integration on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17855?vs=48355=48877#toc REPOSITORY R289

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root
rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REVISION SUMMARY This patch removes the "Search:" portion of Activities (in System Settings, Desktop Behavior --> Workspace) and adds

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root
rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds the ellipsis to the search label of the Cookies section of Network --> Settings. REPOSITORY R241 KIO

D17854: Search for notfication event configuration in qrc resources

2019-01-07 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:aec9d7a29c80: Search for notfication event configuration in qrc resources (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Shubham
shubham added a comment. I don't think so, next time when you can push this type of change (ellipsis) directly, there is a task about it if you know. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty Cc: shubham, kde-frameworks-devel, michaelh,

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added a comment. In D18043#388194 , @shubham wrote: > I don't think so, next time when you can push this type of change (ellipsis) directly, there is a task about it if you know. Cool! REPOSITORY R295 KCMUtils REVISION DETAIL

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added a comment. In D18043#388191 , @shubham wrote: > +1 hey i ... accidentally ran arc diff without arc feature? is that a problem? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty Cc:

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Shubham
shubham added a comment. +1 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18043 To: rooty Cc: shubham, kde-frameworks-devel, michaelh, ngraham, bruns

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds an ellipsis to the search labels in KPluginSelector (and the elements that call for it, e.g. KWin

D18030: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D18030 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18029: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18029 To: aacid, apol Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

2019-01-07 Thread Dr.-Ing. Christoph Cullmann
Hi, this is very likely an evil Qt JS regression in 5.12.x, see https://bugreports.qt.io/browse/QTBUG-72879 Greetings Christoph - Am 7. Jan 2019 um 1:32 schrieb CI System nore...@kde.org: > BUILD UNSTABLE > Build URL [ >

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Filip Fila
filipf added a comment. In D17906#388104 , @rooty wrote: > In D17906#388052 , @mart wrote: > > > can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Root
rooty added a comment. In D17906#388052 , @mart wrote: > can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? nope, very much

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Filip Fila
filipf added a comment. I was actually just going to reply that light titles could work theoretically well with level 1 headings before I saw your last comment. For this to work right, for me it would mean: - certain adjustments for visual hierarchy; big headings must still retain

D18010: Allow zero altitude/longitude/latitude exiv gps data

2019-01-07 Thread Stefan Brüns
bruns added a comment. Can you create two test files, one with e.g. altitude == 0, and one without altitude? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18010 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin
mart added a comment. can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin
mart added a comment. in the end i *may* accept non light titles, even tough i still very much don't like the idea, but what i don't want to never, ever see in any circumstance is bold titles, anything of that will just be reverted. REPOSITORY R169 Kirigami BRANCH no-light-headings

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin
mart added a comment. In D17906#385968 , @ngraham wrote: > - **Implementation inconsistency:** Many fonts don't have a dedicated light style, many distros don't ship them if they do, and Qt < 5.12 doesn't use them even if nope, with

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin
mart added a comment. In D17906#385857 , @filipf wrote: > With the exception of the case of the Windows Store (which does nonetheless manage to achieve some visual hierarchy with different font sizes and colors), others mostly actually have an

D18038: Fix semantics for ghns_exclude

2019-01-07 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added reviewers: ronaldv, KDE Store. leinir added projects: KNewStuff, KDE Store. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY After much discussion on the

D10446: Add KLanguageName

2019-01-07 Thread Harald Sitter
sitter updated this revision to Diff 48853. sitter added a comment. configure_file the fixtures lest they get mangled by scripty on account of being desktop files lookup still goes through qfindtestdata, so we need the output relative to the binary now REPOSITORY R265 KConfigWidgets

D15573: replace custom backtracing in SlaveBase with KCrash

2019-01-07 Thread Harald Sitter
sitter added a comment. I am somewhat indifferent. It certainly has caused some grief for various reasons in various places, so it stands to reason that it should go. Also since auto-init of kcrash is essentially not a thing for application code (what with link-as-needed being a common

D17998: test to fix cpp indenter

2019-01-07 Thread Christoph Cullmann
cullmann added a comment. I c reated a Qt bug, I still think this is some regression. https://bugreports.qt.io/browse/QTBUG-72879 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17998 To: cullmann, dhaumann, carewolf, #frameworks Cc: kwrite-devel,

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2019-01-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17741 To: mkoller, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns