KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 74 - Still unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/74/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 07 Jan 2019 18:13:53 +
 Build duration:
9 hr 34 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.externalextractortestFailed: projectroot.autotests.externalwritertest

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Nathaniel Graham
ngraham added a comment.


  F6531451: Screenshot_20190107_145258.png 

  In this one, the fact that it's a header is connoted by its much larger font 
size and wider character width and spacing. It feels "bigger" in every way than 
the text beneath it. It looks good.
  
  F6531453: Screenshot_20190107_145312.png 

  
  This photo is quite different. Here the header text is no larger or barely 
larger than the text beneath it, and its line weight is lighter. Also, it's 
very visually disconnected from the thing it's a header for, since it's stuck 
up in the top-right corner of a visually superfluous stock photo. Nothing about 
the header text tells my eye "I'm a header!"

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  kio-searchellipsis (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18045

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This has the effect of //removing// the search fields for all the shortcut 
chooser views. That doesn't seem like the intent here.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I think this is fine. The search field doesn't have to specify what it's 
going to be searching in if it's totally obvious, as it is here. This also 
makes it consistent with other similar instances of 
list-with-search-field-on-top, as in the Effects KCM.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, pino, shubham, kde-frameworks-devel, michaelh, bruns


D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  skipautomoxforgperf

REVISION DETAIL
  https://phabricator.kde.org/D18088

To: kossebau, #frameworks, pino, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D18081: Make translations work

2019-01-07 Thread Aleix Pol Gonzalez
apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> CMakeLists.txt:4
>  set(KF5_VERSION "5.54.0") # handled by release scripts
> -set(KF5_DEP_VERSION "5.54.0") # handled by release scripts
> +set(KF5_DEP_VERSION "5.53.0") # handled by release scripts
>  project(KPackage VERSION ${KF5_VERSION})

Wrong?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D18081

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D18079: Use (and suggest using) the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18079

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18076

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17986: Build the Java side with Gradle, as AAR instead of JAR

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17986

To: vkrause, apol
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns


D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

2019-01-07 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  Not sure if there ever s a chance somebody would inject QObject code into 
such a generated file?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18088

To: kossebau, #frameworks, pino
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

2019-01-07 Thread Friedrich W. H. Kossebau
kossebau created this revision.
kossebau added reviewers: Frameworks, pino.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Avoids to have manually set the property on the generated source file to
  deal with changed CMake policy CMP0071.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  skipautomoxforgperf

REVISION DETAIL
  https://phabricator.kde.org/D18088

AFFECTED FILES
  find-modules/FindGperf.cmake

To: kossebau, #frameworks, pino
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns


D18010: Allow zero altitude/longitude/latitude exiv gps data

2019-01-07 Thread Stefan Brüns
bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18010

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D10446: Add KLanguageName

2019-01-07 Thread Albert Astals Cid
aacid added inline comments.

INLINE COMMENTS

> klanguagename.cpp:30
> +const QStringList parts = QLocale().name().split(QChar('_'));
> +return nameForCodeInLocale(code, parts.at(0));
> +}

should the second param be code too?

I mean if we read the docs we say both are code (ISO 639-1), so both should be 
the same and not only the first part?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns


D18081: Make translations work

2019-01-07 Thread Albert Astals Cid
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Do not call i18n from global static variables since qcoreapplication is
  still not around yet and that makes it fail

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18081

AFFECTED FILES
  CMakeLists.txt
  src/kpackagetool/kpackagetool.cpp
  src/kpackagetool/main.cpp
  src/kpackagetool/options.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17999: ViewConfig: Add option to paste at cursor position by mouse

2019-01-07 Thread loh tar
loh.tar added a comment.


  I agree, it's on the first sight pretty clear. But then can you force this 
"style" for every bool option. In the above linked pic is this obviously only 
used for Normal vs Vi-Mode [1]
  
  A drawback of that "style" may that you can't say for sure "which is what" in 
sense of true/false. When you like to change an option by some config file or 
command, what is to give? [2]
  
  Or what if you like to add an short cut and menu option for this? 
  With that in mind looks a checkbox not so bad.
  
  [1] Should it be a string setting, too bad, sorry
  [2] Well, you have then the key(word) which is typically a short version of 
the text shown at the checkbox.

REVISION DETAIL
  https://phabricator.kde.org/D17999

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars


D18079: Use (and suggest using) the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18079

AFFECTED FILES
  src/ioslaves/http/kcookiejar/kcookieserver.cpp
  src/ioslaves/remote/kdedmodule/remotedirnotifymodule.cpp
  src/kioexec/kioexecd.cpp
  src/kpac/proxyscout.cpp
  src/kpasswdserver/kiod_kpasswdserver.cpp
  src/kssld/kssld.cpp
  src/urifilters/fixhost/fixhosturifilter.cpp
  src/urifilters/ikws/kuriikwsfilter.cpp
  src/urifilters/ikws/kurisearchfilter.cpp
  src/urifilters/localdomain/localdomainurifilter.cpp
  src/urifilters/shorturi/kshorturifilter.cpp
  src/widgets/kabstractfileitemactionplugin.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  It's simpler to understand than K_PLUGIN_FACTORY_WITH_JSON that asks
  you for a factory name but you never know which name to use, until you
  realize the name doesn't matter at all.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18076

AFFECTED FILES
  src/services/kplugininfo.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added inline comments.

INLINE COMMENTS

> pino wrote in kpluginselector.cpp:261
> a) explicit is better than implicit
> b) "shorter" makes sense only when thinking for English, not for other 
> languages

a) not always - there's very little nuance here, and there's nothing to be 
gained by adding the word plugins (except for reinforcing that the word is a 
verb and that it's transitive), that's why we don't use "Type to"... besides, 
if we did make it explicit, we'd have to use "Search applications, places, 
actions etc." in kicker, "Search clipboard contents" in clipboard etc.

b) "search" is a simpler and far less restrictive idea than "search plugins" in 
whatever language we're talking about or in, it's a single idea that doesn't 
call for a direct object and doubles as a noun (検索, Suche, Busca etc.)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 07 Jan 2019 20:54:16 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2019-01-07 Thread Martin Koller
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a3fce6e0b7f2: avoid blocking kio_http_cache_cleaner and 
ensure exit with session (authored by mkoller).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17741?vs=48084=48924#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17741?vs=48084=48924

REVISION DETAIL
  https://phabricator.kde.org/D17741

AFFECTED FILES
  src/ioslaves/http/http_cache_cleaner.cpp

To: mkoller, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.11/12/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Mon, 07 Jan 2019 20:41:21 +
 Build duration:
5 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3122/3826)48%
(4572/9597)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(835/854)49%
(1800/3659)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1168/1558)47%
(2223/4717)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D17391: add support for more mimetypes to taglibwriter

2019-01-07 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:b6fa5f7245fb: add support for more mimetypes to 
taglibwriter (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17391?vs=46994=48918

REVISION DETAIL
  https://phabricator.kde.org/D17391

AFFECTED FILES
  autotests/taglibwritertest.cpp
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/3/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 07 Jan 2019 20:41:21 +
 Build duration:
2 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3122/3826)48%
(4572/9597)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(835/854)49%
(1800/3659)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1168/1558)47%
(2223/4717)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D17999: ViewConfig: Add option to paste at cursor position by mouse

2019-01-07 Thread Christoph Cullmann
cullmann added a comment.


  In D17999#387760 , @ngraham wrote:
  
  > Hmm, maybe I misunderstood the feature then, sorry!
  >
  > In cases where there are two binary options but both are semi-confusing, or 
when one option does not necessarily imply its inverse, radio buttons or a 
combobox are ideal because then you can make both choices very clear. For 
example:
  >
  >   Paste using mouse inserts text: (0) At insertion point
  >   ( ) At mouse cursor's location
  >
  
  
  I think that would make sense.

REVISION DETAIL
  https://phabricator.kde.org/D17999

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, bruns, demsking, sars


KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 19 - Still unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/19/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 06 Jan 2019 23:17:33 +
 Build duration:
20 hr and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kcrashtest

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 4 - Fixed!

2019-01-07 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/4/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 07 Jan 2019 18:40:42 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)21%
(454/2204)18%
(202/1118)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(150/155)60%
(64/106)src100%
(8/8)100%
(8/8)67%
(220/327)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
  

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.11 - Build # 17 - Fixed!

2019-01-07 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.11/17/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Mon, 07 Jan 2019 18:40:42 +
 Build duration:
9 min 47 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)21%
(454/2204)18%
(202/1118)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(150/155)60%
(64/106)src100%
(8/8)100%
(8/8)67%
(220/327)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 3 - Failure!

2019-01-07 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/3/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 07 Jan 2019 18:34:31 +
 Build duration:
2 min 52 sec and counting
   CONSOLE OUTPUT
  [...truncated 488 lines...][ 41%] Built target KF5PurposeWidgetsScanning dependencies of target alternativesmodeltest[ 42%] Building CXX object autotests/CMakeFiles/alternativesmodeltest.dir/alternativesmodeltest.cpp.o[ 43%] Building CXX object autotests/CMakeFiles/alternativesmodeltest.dir/alternativesmodeltest_autogen/mocs_compilation.cpp.o[ 43%] Linking CXX executable ../bin/alternativesmodeltest[ 43%] Built target alternativesmodeltest[ 43%] Generating qrc_sharetool-resources.cppScanning dependencies of target sharetool[ 44%] Building CXX object tests/tool/CMakeFiles/sharetool.dir/main.cpp.o[ 45%] Building CXX object tests/tool/CMakeFiles/sharetool.dir/qrc_sharetool-resources.cpp.o[ 46%] Building CXX object tests/tool/CMakeFiles/sharetool.dir/sharetool_autogen/mocs_compilation.cpp.o[ 46%] Linking CXX executable ../../bin/sharetool[ 46%] Built target sharetoolScanning dependencies of target testphabricator[ 47%] Building CXX object src/plugins/phabricator/CMakeFiles/testphabricator.dir/tests/testphabricator.cpp.o[ 48%] Building CXX object src/plugins/phabricator/CMakeFiles/testphabricator.dir/testphabricator_autogen/mocs_compilation.cpp.o[ 48%] Linking CXX executable ../../../bin/testphabricator[ 48%] Built target testphabricatorScanning dependencies of target phabricatorplugin[ 49%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorplugin.dir/phabricatorplugin.cpp.o[ 49%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorplugin.dir/phabricatorplugin_autogen/mocs_compilation.cpp.o[ 50%] Linking CXX shared module ../../../bin/kf5/purpose/phabricatorplugin.so[ 50%] Built target phabricatorpluginScanning dependencies of target phabricatorquickplugin[ 51%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorquickplugin.dir/quick/phabricatorquickplugin.cpp.o[ 51%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorquickplugin.dir/quick/difflistmodel.cpp.o/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.10/src/plugins/phabricator/quick/difflistmodel.cpp: In member function ���virtual QVariant DiffListModel::data(const QModelIndex&, int) const���:/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.10/src/plugins/phabricator/quick/difflistmodel.cpp:143:27: warning: this statement may fall through [-Wimplicit-fallthrough=] ret = QBrush(Qt::green);   ^/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.10/src/plugins/phabricator/quick/difflistmodel.cpp:144:17: note: here case Phabricator::DiffRevList::NeedsReview: ^~~~/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.10/src/plugins/phabricator/quick/difflistmodel.cpp:146:27: warning: this statement may fall through [-Wimplicit-fallthrough=] ret = QBrush(Qt::magenta);   ^~~/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.10/src/plugins/phabricator/quick/difflistmodel.cpp:147:17: note: here case Phabricator::DiffRevList::NeedsRevision: ^~~~[ 52%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorquickplugin.dir/quick/phabricatorrc.cpp.o[ 53%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorquickplugin.dir/phabricatorquickplugin_autogen/mocs_compilation.cpp.o[ 54%] Linking CXX shared library ../../../bin/libphabricatorquickplugin.so[ 54%] Built target phabricatorquickpluginScanning dependencies of target sharefileitemaction_autogen[ 55%] Automatic MOC for target sharefileitemaction[ 55%] Built target sharefileitemaction_autogenScanning dependencies of target menutest_autogen[ 56%] Automatic MOC for target menutest[ 56%] Built target menutest_autogenScanning dependencies of target menudemo_autogen[ 57%] Automatic MOC for target menudemo[ 57%] Built target menudemo_autogenScanning dependencies of target sharefileitemaction[ 58%] Building CXX object src/fileitemactionplugin/CMakeFiles/sharefileitemaction.dir/sharefileitemaction.cpp.o[ 58%] Building CXX object src/fileitemactionplugin/CMakeFiles/sharefileitemaction.dir/purpose_fileitemaction_plugin_debug.cpp.o[ 59%] Building CXX object src/fileitemactionplugin/CMakeFiles/sharefileitemaction.dir/sharefileitemaction_autogen/mocs_compilation.cpp.o[ 60%] Linking CXX shared module ../../bin/kf5/kfileitemaction/sharefileitemaction.so[ 60%] Built target sharefileitemactionScanning dependencies of target menutest[ 61%] Building CXX object autotests/CMakeFiles/menutest.dir/menutest.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/menutest.dir/menutest_autogen/mocs_compilation.cpp.o[ 62%] Linking CXX executable ../bin/menutest[ 62%] 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.11 - Build # 16 - Failure!

2019-01-07 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.11/16/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Mon, 07 Jan 2019 18:34:32 +
 Build duration:
2 min 53 sec and counting
   CONSOLE OUTPUT
  [...truncated 488 lines...][ 41%] Built target KF5PurposeWidgetsScanning dependencies of target alternativesmodeltest[ 42%] Building CXX object autotests/CMakeFiles/alternativesmodeltest.dir/alternativesmodeltest.cpp.o[ 43%] Building CXX object autotests/CMakeFiles/alternativesmodeltest.dir/alternativesmodeltest_autogen/mocs_compilation.cpp.o[ 43%] Linking CXX executable ../bin/alternativesmodeltest[ 43%] Built target alternativesmodeltest[ 43%] Generating qrc_sharetool-resources.cppScanning dependencies of target sharetool[ 44%] Building CXX object tests/tool/CMakeFiles/sharetool.dir/main.cpp.o[ 45%] Building CXX object tests/tool/CMakeFiles/sharetool.dir/qrc_sharetool-resources.cpp.o[ 46%] Building CXX object tests/tool/CMakeFiles/sharetool.dir/sharetool_autogen/mocs_compilation.cpp.o[ 46%] Linking CXX executable ../../bin/sharetool[ 46%] Built target sharetoolScanning dependencies of target testphabricator[ 47%] Building CXX object src/plugins/phabricator/CMakeFiles/testphabricator.dir/tests/testphabricator.cpp.o[ 48%] Building CXX object src/plugins/phabricator/CMakeFiles/testphabricator.dir/testphabricator_autogen/mocs_compilation.cpp.o[ 48%] Linking CXX executable ../../../bin/testphabricator[ 48%] Built target testphabricatorScanning dependencies of target phabricatorplugin[ 49%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorplugin.dir/phabricatorplugin.cpp.o[ 49%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorplugin.dir/phabricatorplugin_autogen/mocs_compilation.cpp.o[ 50%] Linking CXX shared module ../../../bin/kf5/purpose/phabricatorplugin.so[ 50%] Built target phabricatorpluginScanning dependencies of target phabricatorquickplugin[ 51%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorquickplugin.dir/quick/phabricatorquickplugin.cpp.o[ 51%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorquickplugin.dir/quick/difflistmodel.cpp.o/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.11/src/plugins/phabricator/quick/difflistmodel.cpp: In member function ���virtual QVariant DiffListModel::data(const QModelIndex&, int) const���:/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.11/src/plugins/phabricator/quick/difflistmodel.cpp:143:27: warning: this statement may fall through [-Wimplicit-fallthrough=] ret = QBrush(Qt::green);   ^/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.11/src/plugins/phabricator/quick/difflistmodel.cpp:144:17: note: here case Phabricator::DiffRevList::NeedsReview: ^~~~/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.11/src/plugins/phabricator/quick/difflistmodel.cpp:146:27: warning: this statement may fall through [-Wimplicit-fallthrough=] ret = QBrush(Qt::magenta);   ^~~/home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.11/src/plugins/phabricator/quick/difflistmodel.cpp:147:17: note: here case Phabricator::DiffRevList::NeedsRevision: ^~~~[ 52%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorquickplugin.dir/quick/phabricatorrc.cpp.o[ 53%] Building CXX object src/plugins/phabricator/CMakeFiles/phabricatorquickplugin.dir/phabricatorquickplugin_autogen/mocs_compilation.cpp.o[ 54%] Linking CXX shared library ../../../bin/libphabricatorquickplugin.so[ 54%] Built target phabricatorquickpluginScanning dependencies of target sharefileitemaction_autogen[ 55%] Automatic MOC for target sharefileitemaction[ 55%] Built target sharefileitemaction_autogenScanning dependencies of target menutest_autogen[ 56%] Automatic MOC for target menutest[ 56%] Built target menutest_autogenScanning dependencies of target menudemo_autogen[ 57%] Automatic MOC for target menudemo[ 57%] Built target menudemo_autogenScanning dependencies of target sharefileitemaction[ 58%] Building CXX object src/fileitemactionplugin/CMakeFiles/sharefileitemaction.dir/sharefileitemaction.cpp.o[ 58%] Building CXX object src/fileitemactionplugin/CMakeFiles/sharefileitemaction.dir/purpose_fileitemaction_plugin_debug.cpp.o[ 59%] Building CXX object src/fileitemactionplugin/CMakeFiles/sharefileitemaction.dir/sharefileitemaction_autogen/mocs_compilation.cpp.o[ 60%] Linking CXX shared module ../../bin/kf5/kfileitemaction/sharefileitemaction.so[ 60%] Built target sharefileitemactionScanning dependencies of target menutest[ 61%] Building CXX object autotests/CMakeFiles/menutest.dir/menutest.cpp.o[ 62%] Building CXX object autotests/CMakeFiles/menutest.dir/menutest_autogen/mocs_compilation.cpp.o[ 62%] Linking CXX executable ../bin/menutest[ 

D18030: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid closed this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D18030

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18029: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18029

To: aacid, apol
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

2019-01-07 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 07 Jan 2019 18:13:36 +
 Build duration:
5 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 73 - Aborted!

2019-01-07 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
 ^

hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:52413 failed. The channel is closing down or has closed down

D18028: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Albert Astals Cid
aacid closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18028

To: aacid, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars


D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Filip Fila
filipf added a comment.


  Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same 
problem.
  
  F6531867: image.png 
  
  For me this represented a massive regression, and there's bound to be more 
people in a similar situation. We can't have this happening.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Pino Toscano
pino added inline comments.

INLINE COMMENTS

> rooty wrote in kpluginselector.cpp:261
> i think it's because it's self-evident (and shorter)

a) explicit is better than implicit
b) "shorter" makes sense only when thinking for English, not for other languages

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root
rooty added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added inline comments.

INLINE COMMENTS

> pino wrote in kpluginselector.cpp:261
> why not "Search plugins..."?

i think it's because it's self-evident (and shorter)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root
rooty added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18045

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root
rooty added reviewers: VDG, Plasma, kde-frameworks-devel.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root
rooty added reviewers: VDG, Plasma, kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18045

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added reviewers: VDG, Plasma, kde-frameworks-devel.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty, #vdg, #plasma, kde-frameworks-devel
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D17986: Build the Java side with Gradle, as AAR instead of JAR

2019-01-07 Thread Volker Krause
vkrause added inline comments.

INLINE COMMENTS

> apol wrote in FindGradle.cmake:5
> Sounds like it should be in ECM, no?

Right, that's the obvious final location for this, once it has proven itself as 
the right approach here.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17986

To: vkrause
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns


D17986: Build the Java side with Gradle, as AAR instead of JAR

2019-01-07 Thread Volker Krause
vkrause updated this revision to Diff 48881.
vkrause added a comment.


  Move Android specifc stuff into a subdir.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17986?vs=48727=48881

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17986

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGradle.cmake
  cmake/modules/local.properties.in
  cmake/modules/settings.gradle.in
  src/CMakeLists.txt
  src/KF5Notifications-android-dependencies.xml
  src/android/AndroidManifest.xml
  src/android/CMakeLists.txt
  src/android/build.gradle
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/org/kde/knotifications/KNotification.java
  src/org/kde/knotifications/NotifyByAndroid.java

To: vkrause
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Pino Toscano
pino added inline comments.

INLINE COMMENTS

> kpluginselector.cpp:261
>  d->lineEdit->setClearButtonEnabled(true);
> -d->lineEdit->setPlaceholderText(i18n("Search Plugins"));
> +d->lineEdit->setPlaceholderText(i18n("Search..."));
>  d->listView = new KCategorizedView(this);

why not "Search plugins..."?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty
Cc: pino, shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D17855: Don't rely on the Plasma workspace integration on Android

2019-01-07 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:7e5cf84798cd: Dont rely on the Plasma workspace 
integration on Android (authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17855?vs=48355=48877#toc

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17855?vs=48355=48877

REVISION DETAIL
  https://phabricator.kde.org/D17855

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/android_defaults.notifyrc
  src/knotification.cpp
  src/knotifications.qrc

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-07 Thread Root
rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch removes the "Search:" portion of Activities (in System Settings, 
Desktop Behavior --> Workspace) and adds "Search..." to the search field.

REPOSITORY
  R276 KItemViews

BRANCH
  kitemviews-searchellipsis (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18046

AFFECTED FILES
  src/ktreewidgetsearchline.cpp
  src/ktreewidgetsearchlinewidget.cpp

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-07 Thread Root
rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch adds the ellipsis to the search label of the Cookies section of 
Network --> Settings.

REPOSITORY
  R241 KIO

BRANCH
  kio-searchellipsis (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18045

AFFECTED FILES
  src/kcms/kio/kcookiespolicies.ui

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D17854: Search for notfication event configuration in qrc resources

2019-01-07 Thread Volker Krause
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:aec9d7a29c80: Search for notfication event configuration 
in qrc resources (authored by vkrause).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17854?vs=48353=48874

REVISION DETAIL
  https://phabricator.kde.org/D17854

AFFECTED FILES
  src/knotifyconfig.cpp

To: vkrause, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Shubham
shubham added a comment.


  I don't think so, next time when you can push this type of change (ellipsis) 
directly, there is a task about it if you know.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty
Cc: shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added a comment.


  In D18043#388194 , @shubham wrote:
  
  > I don't think so, next time when you can push this type of change 
(ellipsis) directly, there is a task about it if you know.
  
  
  Cool!

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty
Cc: shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty added a comment.


  In D18043#388191 , @shubham wrote:
  
  > +1
  
  
  hey i ... accidentally ran arc diff without arc feature? is that a problem?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty
Cc: shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Shubham
shubham added a comment.


  +1

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18043

To: rooty
Cc: shubham, kde-frameworks-devel, michaelh, ngraham, bruns


D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-07 Thread Root
rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch adds an ellipsis to the search labels in KPluginSelector (and the 
elements that call for it, e.g. KWin Scripts).

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18043

AFFECTED FILES
  src/kpluginselector.cpp

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18030: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18030

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18029: Use the nicer K_PLUGIN_CLASS_WITH_JSON

2019-01-07 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18029

To: aacid, apol
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

2019-01-07 Thread Dr.-Ing. Christoph Cullmann
Hi,

this is very likely an evil Qt JS regression in 5.12.x, see

https://bugreports.qt.io/browse/QTBUG-72879

Greetings
Christoph

- Am 7. Jan 2019 um 1:32 schrieb CI System nore...@kde.org:

> BUILD UNSTABLE
> Build URL [
> https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/9/
> |
> https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/9/
> ]
> Project:  kf5-qt5 FreeBSDQt5.12
> Date of build:Sun, 06 Jan 2019 23:55:27 +
> Build duration:   37 min and counting
> JUnit Tests
> Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s),
> Total: 61 test(s)
> * Failed: projectroot.autotests.kateindenttest_testCppstyle
> 
> Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), 
> Skipped: 0
> test(s), Total: 5 test(s)

-- 
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
Science Park 1 Tel:   +49-681-38360-22
66123 Saarbrücken  Fax:   +49-681-38360-20
GERMANYWWW:   http://www.AbsInt.com

Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234


D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Filip Fila
filipf added a comment.


  In D17906#388104 , @rooty wrote:
  
  > In D17906#388052 , @mart wrote:
  >
  > > can we still keep as light the first level of heading, which is huge (and 
use that sparsingly) and go to levels from 2 onwards where needed smaller and 
bigger?
  >
  >
  > nope, very much against this idea... it //might// work if we used segoe ui, 
but that's about the only instance in which it would
  
  
  Not true, it might work with Noto Sans and with adjustments, but the problem 
is we dont lock people into using the same font. They have an easier job in 
Windows and co.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Root
rooty added a comment.


  In D17906#388052 , @mart wrote:
  
  > can we still keep as light the first level of heading, which is huge (and 
use that sparsingly) and go to levels from 2 onwards where needed smaller and 
bigger?
  
  
  nope, very much against this idea... it //might// work if we used segoe ui, 
but that's about the only instance in which it would

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Filip Fila
filipf added a comment.


  I was actually just going to reply that light titles could work theoretically 
well with level 1 headings before I saw your last comment. For this to work 
right, for me it would mean:
  
  - certain adjustments for visual hierarchy; big headings must still retain 
visual priority-> e.g. the application's description in Discover would need to 
have some opacity
  - Qt using **only** the "light" font style and not falling back to styles 
such as "hairline" or "ultrathin"
  
  Although you then still have the problem of potentially too thin "light" 
styles with some fonts + not being able to guarantee your effect if the font 
doesn't have the light style. So the latter also means if you fix point no. 1 I 
mentioned, you get super //in your face// titles because the font is now 
regular.
  
  Have you managed to test the current solution with some other fonts maybe? 
With more testing we could see for how many it works in the first place and how 
many are troublesome (e.g. Deja VuSans).

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D18010: Allow zero altitude/longitude/latitude exiv gps data

2019-01-07 Thread Stefan Brüns
bruns added a comment.


  Can you create two test files, one with e.g. altitude == 0, and one without 
altitude?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18010

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin
mart added a comment.


  can we still keep as light the first level of heading, which is huge (and use 
that sparsingly) and go to levels from 2 onwards where needed smaller and 
bigger?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin
mart added a comment.


  in the end i *may* accept non light titles, even tough i still very much 
don't like the idea, but what i don't want to never, ever see in any 
circumstance is bold titles, anything of that will just be reverted.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin
mart added a comment.


  In D17906#385968 , @ngraham wrote:
  
  > - **Implementation inconsistency:** Many  fonts don't have a dedicated 
light style, many distros don't ship them if they do, and Qt < 5.12 doesn't use 
them even if
  
  
  nope, with the workaround used it works even with old versions

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin
mart added a comment.


  In D17906#385857 , @filipf wrote:
  
  > With the exception of the case of the Windows Store (which does nonetheless 
manage to achieve some visual hierarchy with different font sizes and colors), 
others mostly actually have an opposite approach and go the bold/semi-bold 
route for the more prominent titles, which makes sense - you want to highlight 
the information contained in them. But the point of this patch is to just make 
sure the most important information is not made less important or even 
illegible, which is guaranteed if the labels are "regular" style.
  
  
  of all of those the one i prefer by a long shot is indeed windows store which 
actually looks exactly like our graphics,
  F6531451: Screenshot_20190107_145258.png 
 is not conceptually different from 
F6531453: Screenshot_20190107_145312.png  
in any way really.
  
  the reason that in many places the visual hierarchy has been broken, like in 
plasma tooltips or calendar, is because the title text has been changed to be 
stupidly small, but the fact that it has been ruined, is not a good excuse to 
ruin it even more.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein


D18038: Fix semantics for ghns_exclude

2019-01-07 Thread Dan Leinir Turthra Jensen
leinir created this revision.
leinir added reviewers: ronaldv, KDE Store.
leinir added projects: KNewStuff, KDE Store.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  After much discussion on the topic, it came to light that the specific 
grammar used for the default tag in KNSCore was incorrect, as it was an action 
verb (rather than an adjective the way the metadata tags are supposed to be). 
While this does mean that previous versions of Frameworks will not have the 
filtering functionality by default, it is otherwise non-invasive and causes no 
side effects apart from the server-suggested filtering working.
  
  CCBUG: https://bugs.kde.org/show_bug.cgi?id=402888

TEST PLAN
  Run the test tool without this patch: Items which are supposed to be excluded 
are not excluded
  Run the test tool with this patch: Items which are supposed to be excluded 
from listings are excluded.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18038

AFFECTED FILES
  autotests/knewstuffentrytest.cpp
  src/core/engine.cpp
  src/core/engine.h
  src/core/tagsfilterchecker.cpp
  src/core/tagsfilterchecker.h
  tests/testdata/entry.xml

To: leinir, ronaldv, #kde_store
Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, 
alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck


D10446: Add KLanguageName

2019-01-07 Thread Harald Sitter
sitter updated this revision to Diff 48853.
sitter added a comment.


  configure_file the fixtures lest they get mangled by scripty on account of 
being desktop files
  
  lookup still goes through qfindtestdata, so we need the output relative to
  the binary now

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10446?vs=47758=48853

BRANCH
  arcpatch-D10446

REVISION DETAIL
  https://phabricator.kde.org/D10446

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kf5_entry_data.cmake/locale/ca/kf5_entry.cmake
  autotests/kf5_entry_data.cmake/locale/de/kf5_entry.cmake
  autotests/kf5_entry_data.cmake/locale/en_US/kf5_entry.cmake
  autotests/kf5_entry_data.cmake/locale/fr/kf5_entry.cmake
  autotests/kf5_entry_data.cmake/locale/pt/kf5_entry.cmake
  autotests/klanguagenametest.cpp
  src/CMakeLists.txt
  src/klanguagename.cpp
  src/klanguagename.h

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns


D15573: replace custom backtracing in SlaveBase with KCrash

2019-01-07 Thread Harald Sitter
sitter added a comment.


  I am somewhat indifferent. It certainly has caused some grief for various 
reasons in various places, so it stands to reason that it should go. Also since 
auto-init of kcrash is essentially not a thing for application code (what with 
link-as-needed being a common distro flag) it's possibly more consistent to 
move it's enabling to the individual slaves.
  
  OTOH the forced kcrashing did reveal a whole bunch of problems with the 
existing slaves. It's not all bad. Perhaps the way to go is to detangle kcrash 
from qtgui as a hard dep. As I recall it's only used for reinit-tech anyway, so 
hardly useful for the slave use-case. kcrashcore if you will ;) (I doubt we'd 
actually need a separate lib to accomplish it though)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15573

To: sitter, dfaure
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns


D17998: test to fix cpp indenter

2019-01-07 Thread Christoph Cullmann
cullmann added a comment.


  I c reated a Qt bug, I still think this is some regression.
  
  https://bugreports.qt.io/browse/QTBUG-72879

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17998

To: cullmann, dhaumann, carewolf, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D17741: avoid blocking kio_http_cache_cleaner and ensure exit with session

2019-01-07 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17741

To: mkoller, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns