D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

2019-01-11 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > kcheckaccelerators.cpp:97 > + > +if (!app->eventDispatcher()) { > +// We are called with event dispatcher being null when KXmlGui is > being loaded That's static member, you don't need instance. BTW can we check only for null

D18204: Make KCheckAccelerators less invasive for apps that don't directly link to KXmlGui

2019-01-11 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY BUGS: 337491 TEST PLAN Ran qtcreator and it no longer has the & in Details Added some debug and checked that okular

D18201: Consistently fill the lock in the encrypted icon

2019-01-11 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:27a6c17638c9: Consistently fill the lock in the encrypted icon (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D18201: Consistently fill the lock in the encrypted icon

2019-01-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops! Nice catch. REPOSITORY R266 Breeze Icons BRANCH fix-encrypted-22 (branched from master) REVISION DETAIL https://phabricator.kde.org/D18201 To: trickyricky26, #vdg,

D18199: Add Kotlin (.kt) mimetype icons

2019-01-11 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

2019-01-11 Thread TrickyRicky
trickyricky26 updated this revision to Diff 49301. trickyricky26 edited the summary of this revision. trickyricky26 added a comment. - Use a lighter color for 16px and 22px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18199?vs=49293=49301 BRANCH

D18201: Consistently fill the lock in the encrypted icon

2019-01-11 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18201 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18201: Consistently fill the lock in the encrypted icon

2019-01-11 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18201 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D18201: Consistently fill the lock in the encrypted icon

2019-01-11 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH fix-encrypted-22 (branched from master) REVISION DETAIL

D18038: Fix semantics for ghns_exclude

2019-01-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, in addition to the testing tool working, this patch seems to actually fix the issue in production (e.g. "Tree on Island" is no longer visible in the wallpaper downloader), and as

D18199: Add Kotlin (.kt) mimetype icons

2019-01-11 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

2019-01-11 Thread Nathaniel Graham
ngraham added a reviewer: VDG. ngraham added a comment. Pretty pictures? :) As discussed in chat, you'll need to submit a merge request to add support in `shared-mime-info` too. Here is a commit where someone else added a new mimetype:

D18192: Remove unused forward declaration

2019-01-11 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18192 To: vkrause, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

2019-01-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 11 Jan 2019 21:00:32 + Build duration: 6 min 11 sec and counting JUnit Tests Name:

D17797: Include applets/22

2019-01-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 49294. nicolasfella added a comment. - Rebase - add to Breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17797?vs=48191=49294 BRANCH fix REVISION DETAIL https://phabricator.kde.org/D17797

D18199: Add Kotlin (.kt) mimetype icons

2019-01-11 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-kotlin-icons (branched from master) REVISION DETAIL

D10716: handle wrong password when using sudo which asks for another password

2019-01-11 Thread Fabian Vogt
fvogt added a comment. In D10716#391331 , @jriddell wrote: > > Is it necessary to write the mock su/sudo in python? That introduces a big and mostly unnecessary dependency on python. > > Nope but that's what was easiest for me and I'm out of

D18192: Remove unused forward declaration

2019-01-11 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Technically SIC, but this is "leaking" D-Bus related classes into user code which doesn't exist on Android.

D18191: Rebuild AAR when Java sources change

2019-01-11 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is a fairly aggressive heuristic, but that's fine as Gradle wont do much if nothing relevant changed, so it's

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

2019-01-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 11 Jan 2019 16:47:30 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D18043: [kcmutils] Add ellipsis to search labels in KPluginSelector

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R295:24ba84914a84: [kcmutils] Add ellipsis to search labels in KPluginSelector (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread David Faure
dfaure added a comment. A unittest for this fix would have been even better ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18187 To: chinmoyr, ngraham, hein Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R276:649157422e4e: [kitemviews] Change the search in Desktop Behavior/Activities to more in line… (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R276 KItemViews CHANGES

D18045: [kio] Add ellipsis to search label in Cookies section

2019-01-11 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e4679f600075: [kio] Add ellipsis to search label in Cookies section (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

2019-01-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 11 Jan 2019 16:37:30 + Build duration: 7 min 16 sec and counting JUnit Tests Name:

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread Chinmoy Ranjan Pradhan
This revision was automatically updated to reflect the committed changes. Closed by commit R241:28dacfe07375: [KNewFileMenu] Dont emit fileCreated when creating a directory (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Test still passes, creating new files and directories still works, conceptually makes sense, fixes 403100. Thanks for doing this @chinmoyr! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18187

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18187 To: chinmoyr, ngraham, hein Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY BUG: 403100 TEST PLAN unit tests pass. REPOSITORY R241 KIO BRANCH master

D18158: Fix elapsed time check

2019-01-11 Thread Chinmoy Ranjan Pradhan
chinmoyr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18158 To: davidedmundson, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2019-01-11 Thread Jonathan Riddell
jriddell added inline comments. INLINE COMMENTS > fvogt wrote in su:28 > That won't work anywhere else and requires that the binary is installed when > running tests. Not sure what you mean by won't work anywhere else, it'll work using the kdesu_stub which is built by the local compile. It

D10716: handle wrong password when using sudo which asks for another password

2019-01-11 Thread Jonathan Riddell
jriddell marked 3 inline comments as done. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2019-01-11 Thread Jonathan Riddell
jriddell marked an inline comment as done. jriddell added a comment. > Is it necessary to write the mock su/sudo in python? That introduces a big and mostly unnecessary dependency on python. Nope but that's what was easiest for me and I'm out of energy for this > By adding a new

D10716: handle wrong password when using sudo which asks for another password

2019-01-11 Thread Jonathan Riddell
jriddell updated this revision to Diff 49244. jriddell added a comment. - remove unused variable - remove unused include - use QStandardPaths::setTestModeEnabled - tidy up includes and defines - refactor out config setting to remove duplication REPOSITORY R299 KDESu CHANGES SINCE

D18164: Review KateGotoBar

2019-01-11 Thread loh tar
loh.tar updated this revision to Diff 49243. loh.tar added a comment. - Use 120 as wheel-delta threshold - Use member instead of static local > If not do it right you can end up in partial value when it used finer-resolution wheels and mishmash. I have problems to see that hazard,

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 21 - Unstable!

2019-01-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/21/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 11 Jan 2019 12:27:51 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 4 - Still Failing!

2019-01-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/4/ Project: kf5-qt5 AndroidQt5.11 Date of build: Fri, 11 Jan 2019 12:27:15 + Build duration: 3 min 46 sec and counting CONSOLE OUTPUT

D17691: Add rows info to the plasma virtual desktop protocol

2019-01-11 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > test_plasma_virtual_desktop.cpp:280 > +m_plasmaVirtualDesktopManagementInterface->setRows(3); > +rowsChangedSpy.wait(); > +QCOMPARE(m_plasmaVirtualDesktopManagement->rows(), 3); QVERIFY > plasmavirtualdesktop.h:168 > > +void

D17691: Add rows info to the plasma virtual desktop protocol

2019-01-11 Thread Eike Hein
hein added a comment. > The desktop cube shows everything flat, desktop grid is configurable (and hardcoded). The desktop grid effect uses the rows setting from the KCM for me. I don't think it's easy for users to understand that the KCM is configuring KWin only, instead of all of

D17691: Add rows info to the plasma virtual desktop protocol

2019-01-11 Thread David Edmundson
davidedmundson added a comment. I thought we had a whole conversation in the first set of reviews that views (layout) was independent of data. The desktop cube shows everything flat, desktop grid is configurable (and hardcoded). The pager is just another view, there's no need to sync

D18178: fix environment setup of klanguagename test

2019-01-11 Thread Rik Mills
rikmills accepted this revision. rikmills added a comment. This revision is now accepted and ready to land. Build and passes on Kubuntu CI now. https://launchpadlibrarian.net/405807438/buildlog_ubuntu-disco-amd64.kconfigwidgets_5.54.0+p19.04+git20190111.1036-0_BUILDING.txt.gz REPOSITORY

D18178: fix environment setup of klanguagename test

2019-01-11 Thread Harald Sitter
sitter created this revision. sitter added reviewers: aacid, rikmills. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - use correct env vars LANG and LANGUAGE - as an additional safety-net

D10446: Add KLanguageName

2019-01-11 Thread Harald Sitter
sitter added a comment. Oh actually. I have a theory. My environment vars were wrong. Try with s/LANG/LANGUAGE and s/LOCALE/LANG please. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid, apol Cc: rikmills, vkrause, dhaumann, hein,

D10446: Add KLanguageName

2019-01-11 Thread Harald Sitter
sitter added a comment. You'll have to debug this for us. It passes on build.kde.org  REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid, apol Cc: rikmills, vkrause, dhaumann, hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham,

D10446: Add KLanguageName

2019-01-11 Thread Rik Mills
rikmills added a comment. Kubuntu CI builds 2/4 Test #3: klanguagenametest ***Failed0.03 sec - Start testing of KLanguageNameTest * Config: Using QtTest library 5.11.3, Qt 5.11.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC

D18038: Fix semantics for ghns_exclude

2019-01-11 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D18038#390748 , @ngraham wrote: > What is the test tool? Can you help a total n00b like me learn how to test KNewStuff patches like these? The test tool is khotnewstuff_test in tests/. It's not installed, but