KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 13 Jan 2019 23:43:40 + Build duration: 5 min 8 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 13 Jan 2019 23:32:30 + Build duration: 1 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 13 Jan 2019 22:42:15 + Build duration: 11 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 13 Jan 2019 22:21:35 + Build duration: 21 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 13 Jan 2019 22:21:35 + Build duration: 1 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 13 Jan 2019 22:21:35 + Build duration: 1 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 13 Jan 2019 21:40:29 + Build duration: 48 sec and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/3/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 13 Jan 2019 21:31:24 + Build duration: 1 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 13 Jan 2019 21:31:24 + Build duration: 1 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 13 Jan 2019 21:31:24 + Build duration: 41 sec and counting JUnit Tests Name:

D18205: Test empty and zero gps data

bruns added inline comments. INLINE COMMENTS > astippich wrote in exiv2extractortest.cpp:65 > That's not possible, qFuzzyCompare does not handle this correctly with a too > small epsilon. It's probably because of the float->double conversion in the > extractor see comment in the other review

D18010: Allow zero altitude/longitude/latitude exiv gps data

bruns added inline comments. INLINE COMMENTS > exiv2extractor.cpp:298 > } > } > return alt; when you rewrite this as if (it != data.end()) { auto ratio = it->value().toRational(); it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef")); if

D17932: Improvements to completion

thomassc updated this revision to Diff 49397. thomassc added a comment. Change to a single setter for match_cs and exact_match_cs to avoid restriction on call order of functions REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17932?vs=49343=49397

D18199: Add Kotlin (.kt) mimetype icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:33ca64ca5c0d: Add Kotlin (.kt) mimetype icons (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D18215: Improve the preferences-desktop-cryptography icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:a7154ef3053c: Improve the preferences-desktop-cryptography icon (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D18215: Improve the preferences-desktop-cryptography icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. There we go! REPOSITORY R266 Breeze Icons BRANCH improve-preferences-cryptography (branched from master) REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26,

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 updated this revision to Diff 49390. trickyricky26 added a comment. - Actually change the icon to match preferences-system-network-iscsi REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18215?vs=49381=49390 BRANCH

D18215: Improve the preferences-desktop-cryptography icon

ngraham added a comment. Hmm, I don't actually see any changes compares to the previous version. There are still subtle visual differences between the two icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg, ngraham Cc:

D18199: Add Kotlin (.kt) mimetype icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH add-kotlin-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg, ngraham, ndavis Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH add-kotlin-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg, ngraham Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D17932: Improvements to completion

mwolff added subscribers: brauch, kfunk, apol. mwolff added a comment. In D17932#392060 , @thomassc wrote: > Thanks for reviewing. Regarding the question about which models would have an insensitive exact match, and which ones have sensitive

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18215 To: trickyricky26, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

trickyricky26 updated this revision to Diff 49381. trickyricky26 added a comment. - Match the preferences-system-network-iscsi style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18215?vs=49360=49381 BRANCH improve-preferences-cryptography

D18199: Add Kotlin (.kt) mimetype icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH add-kotlin-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18199 To: trickyricky26, #vdg, ngraham Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

trickyricky26 updated this revision to Diff 49379. trickyricky26 added a comment. This revision is now accepted and ready to land. - Use the gradient on the 32px version as well REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18199?vs=49353=49379

D17245: Add string formatting function to property info

astippich added a comment. @broulik since you've made the feature request, do you mind giving this a quick look? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel,

D18205: Test empty and zero gps data

astippich retitled this revision from "test empty and zero gps data" to "Test empty and zero gps data". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D18205: test empty and zero gps data

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractortest.cpp:65 > although only copied, I think it should be written like the other two: > `QCOMPARE(result.properties().value(PhotoGpsAltiitude).toDouble(), 12.2);` That's

D18205: test empty and zero gps data

astippich updated this revision to Diff 49377. astippich added a comment. - move namespace REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49316=49377 BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 AFFECTED FILES

D18222: Install dbus configuration files under DATADIR by default

arojas created this revision. arojas added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Packages should install their configuration files under DATADIR, SYSCONFDIR should

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/30/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 09 Jan 2019 04:32:58 + Build duration: 4 days 3 hr and counting JUnit Tests