KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/14/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 13 Jan 2019 23:43:40 +
 Build duration:
5 min 8 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/5/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 13 Jan 2019 23:32:30 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/14/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 13 Jan 2019 22:42:15 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/5/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 13 Jan 2019 22:21:35 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/8/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sun, 13 Jan 2019 22:21:35 +
 Build duration:
1 min 52 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/4/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 13 Jan 2019 22:21:35 +
 Build duration:
1 min 51 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/4/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 13 Jan 2019 21:40:29 +
 Build duration:
48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/3/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 13 Jan 2019 21:31:24 +
 Build duration:
1 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1493/3602)33%
(663/2021)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)40%
(1226/3095)32%
(589/1819)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.11/4/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sun, 13 Jan 2019 21:31:24 +
 Build duration:
1 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1493/3602)33%
(663/2021)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)40%
(1226/3095)32%
(589/1819)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/4/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 13 Jan 2019 21:31:24 +
 Build duration:
41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga

D18205: Test empty and zero gps data

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in exiv2extractortest.cpp:65
> That's not possible, qFuzzyCompare does not handle this correctly with a too 
> small epsilon. It's probably because of the float->double conversion in the 
> extractor

see comment in the other review

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18205

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18010: Allow zero altitude/longitude/latitude exiv gps data

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> exiv2extractor.cpp:298
>  }
>  }
>  return alt;

when you rewrite this as

  if (it != data.end()) {
  auto ratio = it->value().toRational();
  it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef"));
  if ((ratio.second != 0) && (it != data.end())) {
  auto altRef = it->value().toLong();
  if (altRef) {
  alt = -1.0 * ratio.first / ratio.second;
  } else {
  alt = 1.0 * ratio.first / ratio.second;
  }
  }
  }

does the unit test pass without special handling of the altitude fuzz?

REPOSITORY
  R286 KFileMetaData

BRANCH
  fix_zero_gps

REVISION DETAIL
  https://phabricator.kde.org/D18010

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17932: Improvements to completion

[Thomas Schöps]

thomassc updated this revision to Diff 49397.
thomassc added a comment.


  Change to a single setter for match_cs and exact_match_cs to avoid 
restriction on call order of functions

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17932?vs=49343=49397

BRANCH
  improvements_to_completion (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17932

AFFECTED FILES
  autotests/src/completion_test.cpp
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletionmodel.h

To: thomassc, #ktexteditor, #kdevelop, mwolff
Cc: apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde-frameworks-devel, 
hase, michaelh, ngraham, bruns, demsking, head7, sars, dhaumann

D18199: Add Kotlin (.kt) mimetype icons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:33ca64ca5c0d: Add Kotlin (.kt) mimetype icons (authored 
by trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18199?vs=49379=49396

REVISION DETAIL
  https://phabricator.kde.org/D18199

AFFECTED FILES
  icons-dark/mimetypes/16/text-x-kotlin.svg
  icons-dark/mimetypes/22/text-x-kotlin.svg
  icons-dark/mimetypes/32/text-x-kotlin.svg
  icons-dark/mimetypes/64/text-x-kotlin.svg
  icons/mimetypes/16/text-x-kotlin.svg
  icons/mimetypes/22/text-x-kotlin.svg
  icons/mimetypes/32/text-x-kotlin.svg
  icons/mimetypes/64/text-x-kotlin.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a7154ef3053c: Improve the 
preferences-desktop-cryptography icon (authored by trickyricky26, committed by 
ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49390=49392

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/mimetypes/32/preferences-desktop-cryptography.svg
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/mimetypes/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  There we go!

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

[TrickyRicky]

trickyricky26 updated this revision to Diff 49390.
trickyricky26 added a comment.


  - Actually change the icon to match preferences-system-network-iscsi

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49381=49390

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/mimetypes/32/preferences-desktop-cryptography.svg
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/mimetypes/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I don't actually see any changes compares to the previous version. There 
are still subtle visual differences between the two icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-kotlin-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18199

To: trickyricky26, #vdg, ngraham, ndavis
Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-kotlin-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18199

To: trickyricky26, #vdg, ngraham
Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D17932: Improvements to completion

[Milian Wolff]

mwolff added subscribers: brauch, kfunk, apol.
mwolff added a comment.


  In D17932#392060 , @thomassc wrote:
  
  > Thanks for reviewing. Regarding the question about which models would have 
an insensitive exact match, and which ones have sensitive exact matches:
  >
  > - An example for case-insensitive exact matches might be plain text, or a 
hypothetical case-insensitive programming language. For example for plain text, 
one might want to treat words like "Question" and "question" as exact matches, 
which will make the completion widget close itself when it shows one of them 
and the user types the other. This is the current behavior for the word 
completion in KWrite / Kate.
  > - An example for case-sensitive exact matches would be a case-sensitive 
programming language like C++. If the user typed "m_var" but the variable is 
actually called "m_Var", then the completion widget should not hide itself, 
since it might still be useful to replace the typed text with the completion 
item that has different case.
  
  
  please put that information into the commit message - I think it's valuable 
to have
  
  overall, I think I'm in favor of getting this in - but I'd like to get input 
from others. @brauch , @kfunk, @apol what do you have to say to this?

INLINE COMMENTS

> thomassc wrote in katecompletionmodel.h:394
> I added asserts to the setters. One should be aware then though that it 
> restricts the order in which these must be called. For example, if both 
> settings are case-insensitive at first and both should be changed to 
> case-sensitive, then the exact-match-sensitivity must be changed before the 
> match-sensitivity. Alternatively, one could make a single setter function 
> that changes both properties.

either that, or handle it gracefully (with a warning?) wherever it's used?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17932

To: thomassc, #ktexteditor, #kdevelop, mwolff
Cc: apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde-frameworks-devel, 
hase, michaelh, ngraham, bruns, demsking, head7, sars, dhaumann

D18215: Improve the preferences-desktop-cryptography icon

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18215

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18215: Improve the preferences-desktop-cryptography icon

[TrickyRicky]

trickyricky26 updated this revision to Diff 49381.
trickyricky26 added a comment.


  - Match the preferences-system-network-iscsi style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18215?vs=49360=49381

BRANCH
  improve-preferences-cryptography (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18215

AFFECTED FILES
  icons-dark/mimetypes/32/preferences-desktop-cryptography.svg
  icons-dark/preferences/32/preferences-desktop-cryptography.svg
  icons/mimetypes/32/preferences-desktop-cryptography.svg
  icons/preferences/32/preferences-desktop-cryptography.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-kotlin-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18199

To: trickyricky26, #vdg, ngraham
Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D18199: Add Kotlin (.kt) mimetype icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 49379.
trickyricky26 added a comment.
This revision is now accepted and ready to land.


  - Use the gradient on the 32px version as well

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18199?vs=49353=49379

BRANCH
  add-kotlin-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18199

AFFECTED FILES
  icons-dark/mimetypes/16/text-x-kotlin.svg
  icons-dark/mimetypes/22/text-x-kotlin.svg
  icons-dark/mimetypes/32/text-x-kotlin.svg
  icons-dark/mimetypes/64/text-x-kotlin.svg
  icons/mimetypes/16/text-x-kotlin.svg
  icons/mimetypes/22/text-x-kotlin.svg
  icons/mimetypes/32/text-x-kotlin.svg
  icons/mimetypes/64/text-x-kotlin.svg

To: trickyricky26, #vdg, ngraham
Cc: alex-l, ngraham, kde-frameworks-devel, michaelh, bruns

D17245: Add string formatting function to property info

[Alexander Stippich]

astippich added a comment.


  @broulik since you've made the feature request, do you mind giving this a 
quick look?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D18205: Test empty and zero gps data

[Alexander Stippich]

astippich retitled this revision from "test empty and zero gps data" to "Test 
empty and zero gps data".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18205

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18205: test empty and zero gps data

[Alexander Stippich]

astippich marked an inline comment as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in exiv2extractortest.cpp:65
> although only copied, I think it should be written like the other two:
> `QCOMPARE(result.properties().value(PhotoGpsAltiitude).toDouble(), 12.2);`

That's not possible, qFuzzyCompare does not handle this correctly with a too 
small epsilon. It's probably because of the float->double conversion in the 
extractor

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18205

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18205: test empty and zero gps data

[Alexander Stippich]

astippich updated this revision to Diff 49377.
astippich added a comment.


  - move namespace

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18205?vs=49316=49377

BRANCH
  gps_tests

REVISION DETAIL
  https://phabricator.kde.org/D18205

AFFECTED FILES
  autotests/exiv2extractortest.cpp
  autotests/exiv2extractortest.h
  autotests/samplefiles/test_no_gps.jpg
  autotests/samplefiles/test_zero_gps.jpg

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18222: Install dbus configuration files under DATADIR by default

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Packages should install their configuration files under DATADIR, SYSCONFDIR 
should be reserved for system administrators overrides.

TEST PLAN
  Built powerdevil with patched kauth, dbus conf files were installed under 
/usr/share/dbus-1/system.d

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18222

AFFECTED FILES
  cmake/KF5AuthMacros.cmake
  src/ConfigureChecks.cmake

To: arojas, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/30/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 09 Jan 2019 04:32:58 +
 Build duration:
4 days 3 hr and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)