D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-15 Thread loh tar
loh.tar added a comment. Interesting. Didn't know that such function exist. Well, it may help to read the handbook... Is there no GUI way to access such stuff? "Read the handbook" lala... Well, word/text wrapping is a field which has many room for improvements. - Adjust as block

D18288: Make the clock svg's shadows more logically correct and visually appropriate

2019-01-15 Thread Nathaniel Graham
ngraham retitled this revision from "Give the clock svg's hour hand a shadow for the spindle" to "Make the clock svg's shadows more logically correct and visually appropriate". ngraham edited the summary of this revision. ngraham added a reviewer: Plasma. REPOSITORY R242 Plasma Framework

D18288: Give the clock svg's hour hand a shadow for the spindle

2019-01-15 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18288 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18288: Give the clock svg's hour hand a shadow for the spindle

2019-01-15 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18288 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18288: Give the clock svg's hour hand a shadow for the spindle

2019-01-15 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Give the clock's hour hand a shadow for the spindle too, since the shadow model we're

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

2019-01-15 Thread Nerdopolis Turfwalker
nerdopolist added a comment. I tried with my script that tried to reproduce that "kio skips files" issue https://raw.githubusercontent.com/n3rdopolis/otherstuff/master/kiocopy (changing the TEST_INVALID_UNICODE_CHARS=0 line to TEST_INVALID_UNICODE_CHARS=1 ) and then letting it run.

D18282: document-new icon follow ColorScheme-Text

2019-01-15 Thread Andreas Kainz
This revision was automatically updated to reflect the committed changes. Closed by commit R266:e3804e633e67: document-new icon follow ColorScheme-Text (authored by andreask). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18282?vs=49583=49585 REVISION

D18282: document-new icon follow ColorScheme-Text

2019-01-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, looks like this fixes it! REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D18282 To: andreask, #vdg, ngraham Cc: ngraham,

D18282: document-new icon follow ColorScheme-Text

2019-01-15 Thread Andreas Kainz
andreask created this revision. andreask added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. andreask requested review of this revision. REVISION SUMMARY icon follow now ColorScheme-Text color TEST PLAN change to breeze-dark and open

D18164: Review KateGotoBar

2019-01-15 Thread Dominik Haumann
dhaumann added a comment. Indeed I misread the screenshot - sorry for that :-) In that case, I have no objections. @cullmann your take? REVISION DETAIL https://phabricator.kde.org/D18164 To: loh.tar, #ktexteditor Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel,

D18277: Add a new preferences-desktop-theme-global icon

2019-01-15 Thread TrickyRicky
trickyricky26 planned changes to this revision. trickyricky26 added a comment. I will make a variant with a titlebar that is split between a light and dark variant (like `preferences-desktop-theme`) as well as the bottom panel in the same style. REPOSITORY R266 Breeze Icons REVISION

D18163: KateRenderer: when printing initially set the color scheme to Printing

2019-01-15 Thread Ahmad Samir
ahmadsamir added a comment. @dhaumann: in the screenshot that's "file -> print"; the issue here is with "file -> print preview", where the extra options tabs (including "Layout") aren't added by ktexteditor. :) REPOSITORY R39 KTextEditor REVISION DETAIL

D18277: Add a new preferences-desktop-theme-global icon

2019-01-15 Thread TrickyRicky
trickyricky26 retitled this revision from "Add a new preferences-desktop-theme icon, rename the old one" to "Add a new preferences-desktop-theme-global icon". trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons

D18277: Add a new preferences-desktop-theme icon, rename the old one

2019-01-15 Thread TrickyRicky
trickyricky26 updated this revision to Diff 49573. trickyricky26 added a comment. - Change name to preferences-desktop-theme-global REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18277?vs=49565=49573 BRANCH new-pref-theme-icon (branched from

D18278: Add a preferences-system-splash icon for the Splash Screen KCM

2019-01-15 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:fe8f60030d00: Add a preferences-system-splash icon for the Splash Screen KCM (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D18278: Add a preferences-system-splash icon for the Splash Screen KCM

2019-01-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Love it REPOSITORY R266 Breeze Icons BRANCH preferences-splash-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18278 To: trickyricky26, #vdg, ngraham Cc:

D18278: Add a preferences-system-splash icon for the Splash Screen KCM

2019-01-15 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18278 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D18277: Add a new preferences-desktop-theme icon, rename the old one

2019-01-15 Thread Nathaniel Graham
ngraham added a comment. Actually now that I think about it, the name `preferences-desktop-theme-global` might be better because then if the icon doesn't exist, it will fall back to `preferences-desktop-theme` (which does exist) instead of `preferences-desktop-global` (which doesn't).

D18278: Add a preferences-system-splash icon for the Splash Screen KCM

2019-01-15 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-splash-icon (branched from master) REVISION DETAIL

D18277: Add a new preferences-desktop-theme icon, rename the old one

2019-01-15 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18277 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18277: Add a new preferences-desktop-theme icon, rename the old one

2019-01-15 Thread TrickyRicky
trickyricky26 updated this revision to Diff 49565. trickyricky26 added a comment. - Revert renaming of old icon; name the new icon preferences-desktop-global-theme REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18277?vs=49561=49565 BRANCH

D18164: Review KateGotoBar

2019-01-15 Thread loh tar
loh.tar added a comment. > I have the feeling it adds more clutter than it helps by default: Code clutter or what? The functionality is lovely and I can't see in which way It may someone jar > I thinkis quite fast. For a keyboard-virtuoso for sure. I'm one of those who use

D18163: KateRenderer: when printing initially set the color scheme to Printing

2019-01-15 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Looking at the printing pages, I can find the following, see screenshot. Please note the ComboBox where you can select a printing schema. In other words, this should not be

D18277: Add a new preferences-desktop-theme icon, rename the old one

2019-01-15 Thread TrickyRicky
trickyricky26 planned changes to this revision. trickyricky26 added a comment. In D18277#393868 , @ngraham wrote: > Recommendation: > > - In this patch, just create a new LnF/Global theme icon with a new name. Maybe

D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-15 Thread Dominik Haumann
dhaumann added a comment. @loh.tar Slightly related: You may want to also have a look at this: https://phabricator.kde.org/source/ktexteditor/browse/master/src/script/data/commands/utils.js$271 In short, there is a command line command (F7) called 'rewrap' that rewraps the selection in a

D18277: Add a new preferences-desktop-theme icon, rename the old one

2019-01-15 Thread Nathaniel Graham
ngraham added a comment. Recommendation: - In this patch, just create a new LnF/Global theme icon with a new name. Maybe `preferences-desktop-global-theme`? - I rename `preferences-desktop-theme` to `preferences-desktop-application-theme` and put a compatibility symlink in place -

D18277: Add a new preferences-desktop-theme icon, rename the old one

2019-01-15 Thread Nathaniel Graham
ngraham added a comment. Just so you know, there are a lot of users for `preferences-desktop-theme`: https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-theme It's always good to do a search like this before you change the meaning of existing icons--even ones that are

D18277: Add a new preferences-desktop-theme icon, rename the old one

2019-01-15 Thread Nathaniel Graham
ngraham retitled this revision from "Add a new preference-desktop-theme icon, rename the old one" to "Add a new preferences-desktop-theme icon, rename the old one". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons

D18277: Add a new preference-desktop-theme icon, rename the old one

2019-01-15 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18277 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D18277: Add a new preference-desktop-theme icon, rename the old one

2019-01-15 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH new-pref-theme-icon (branched from master) REVISION DETAIL

D17932: Improvements to completion

2019-01-15 Thread Milian Wolff
mwolff accepted this revision as: mwolff. mwolff added a comment. @brauch, @kfunk what do you say? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop, mwolff Cc: apol, kfunk, brauch, mwolff, cullmann, kwrite-devel,

D11236: [KCrash] Establish socket to allow change of ptrace scope

2019-01-15 Thread Oswald Buddenhagen
ossi added a comment. In D11236#393789 , @ossi wrote: > detaching via double fork() "protects" the child process, > but does *not* break the permission inheritance. ok, i take that back and claim the opposite - i misinterpreted

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-01-15 Thread Emirald Mateli
emateli planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D18164: Review KateGotoBar

2019-01-15 Thread Dominik Haumann
dhaumann added a comment. I like the idea to go to next modified line up / down. I am undecided about the goto line in clipboard, since I have the feeling it adds more clutter than it helps by default: I thinkis quite fast. In addition, this leads to having "Gehe zu" twice in the ui,

D11236: [KCrash] Establish socket to allow change of ptrace scope

2019-01-15 Thread Oswald Buddenhagen
ossi added a comment. In D11236#393720 , @croick wrote: > Actually it's only the internal process that creates the backtraces, that is a descendant of DrKonqi. All debuggers that are launched via the "Debug" button are processes on their own

D18274: Make notifications work on Android with API level < 23

2019-01-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY At API level < 23 we cannot set a custom icon but have to use a static one from the Android resource system, so let's

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

2019-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 15 Jan 2019 18:08:14 + Build duration: 6 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 11 - Failure!

2019-01-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/11/ Project: kf5-qt5 AndroidQt5.11 Date of build: Tue, 15 Jan 2019 18:03:34 + Build duration: 46 sec and counting CONSOLE OUTPUT

D18253: Move the Android API level checks to runtime

2019-01-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:e9a35ccb2a60: Move the Android API level checks to runtime (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18253?vs=49486=49550

D18253: Move the Android API level checks to runtime

2019-01-15 Thread Volker Krause
vkrause added a comment. In D18253#393283 , @apol wrote: > Maybe we could print something for adb logcat that says that notifications won't be working? Android itself is already doing that. And support for older API levels is hopefully

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

2019-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 15 Jan 2019 17:28:23 + Build duration: 4 min 56 sec and counting JUnit Tests Name:

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

2019-01-15 Thread Dominik Haumann
dhaumann closed this revision. dhaumann added a comment. Closed, see commit 1e0ace28c795cbe5e88bc1f31ea37a250cd110b0 REVISION DETAIL https://phabricator.kde.org/D17852 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

2019-01-15 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Good patch, and works for me. REVISION DETAIL https://phabricator.kde.org/D17852 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor,

D11236: [KCrash] Establish socket to allow change of ptrace scope

2019-01-15 Thread Christoph Roick
croick added a comment. In D11236#393063 , @ossi wrote: > yay, i finally have "some" time for this. ^^ Great! :) And thanks for your input. > it took me a while to get a coherent picture of the problem and solution, because your

D17938: Add support for passing cursor information to KRun.

2019-01-15 Thread Gleb Popov
arrowd abandoned this revision. arrowd added a comment. Right. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17938 To: arrowd, #frameworks Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

2019-01-15 Thread Elvis Angelaccio
elvisangelaccio added a comment. @arrowd I see you landed D18099 , so this can be discarded, right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17938 To: arrowd, #frameworks Cc: aacid, elvisangelaccio, kde-frameworks-devel,

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

2019-01-15 Thread loh tar
loh.tar added a comment. > can you please rephrase the title of this review to make it understandable? Of course, if I could, I would have done it :-) "Remove all what is not nice text" ? It may help you to read all posts to get a hint of my intention. It turned out that this here ist

D18149: Share Plasma::Theme instances between multiple ColorScope

2019-01-15 Thread Kai Uwe Broulik
broulik updated this revision to Diff 49537. broulik retitled this revision from "Share Plasma::Theme instances between multiple Svg and ColorScope" to "Share Plasma::Theme instances between multiple ColorScope". broulik edited the test plan for this revision. broulik added a comment. Focus

D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-15 Thread loh tar
loh.tar added subscribers: cullmann, dhaumann. loh.tar added a comment. > please add proper tests for this functionality No idea how Because there are a couple of bug reports where often the response was like "No, can't be done" need this a closer look from @dhaumann and @cullmann

D18263: [CopyJob] Provide more descriptive notification header

2019-01-15 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. They emit a generic message. A descriptive message can only generated from within job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18263 To: chinmoyr, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

2019-01-15 Thread Alexander Volkov
volkov added a comment. Looks like the bug is caused by removing the line "updateBackend(udi);" REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham, apol Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh,

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

2019-01-15 Thread Kai Uwe Broulik
broulik added a comment. > And QSharedDataPointer? For that `Theme` would need to be `QSharedData`, no? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18149 To: broulik, #plasma Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh,

D14661: Force reevaluation of Predicates if interfaces are removed

2019-01-15 Thread Kai Uwe Broulik
broulik added a comment. So, looks like adding the device causes us to probe it and that prompts UDisks to close the tray for examination? I lack a CD drive, so I cannot try this. Can you perhaps investigate this issue? :) Easiest could be to check for device type and then in doubt just

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

2019-01-15 Thread loh tar
loh.tar updated this revision to Diff 49530. loh.tar added a comment. Add autotest CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17852?vs=48340=49530 REVISION DETAIL https://phabricator.kde.org/D17852 AFFECTED FILES autotests/src/kateview_test.cpp

D14661: Force reevaluation of Predicates if interfaces are removed

2019-01-15 Thread Alexander Volkov
volkov added a comment. This change causes a bug: when you eject a mounted CD from the applet, then CD-ROM tray closes immediately after ejecting. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham, apol Cc: volkov, apol,

D18163: KateRenderer: when printing initially set the color scheme to Printing

2019-01-15 Thread Milian Wolff
mwolff accepted this revision as: mwolff. mwolff added a comment. This revision is now accepted and ready to land. lgtm, @cullmann @dhaumann? could the schema name be translated (I hope not)? REPOSITORY R39 KTextEditor BRANCH print-preview-text-color REVISION DETAIL

D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-15 Thread Milian Wolff
mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. I like what I'm seeing in the screenshot, but please add proper tests for this functionality INLINE COMMENTS > kateview.cpp:2355 > +// Because we shrink and expand lines, we

D18263: [CopyJob] Provide more descriptive notification header

2019-01-15 Thread Kai Uwe Broulik
broulik added a comment. Isn't that done by `emitCopying` et al? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18263 To: chinmoyr, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18263: [CopyJob] Provide more descriptive notification header

2019-01-15 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: dfaure, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY A job can internally set a more descriptive title or a generic title will

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

2019-01-15 Thread Milian Wolff
mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. can you please rephrase the title of this review to make it understandable? "Remove all" - what do you remove? All what? Also, can you please add tests for the feature you

D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

2019-01-15 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I am no Ruby expert, but your screenshots show a clear improvement, please push ;=) Thanks for the improvement + tests! REPOSITORY R216 Syntax Highlighting BRANCH fix-ruby

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Unstable!

2019-01-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/32/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 15 Jan 2019 09:31:54 + Build duration: 43 min and counting JUnit Tests