D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files

nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18509 To: jwilbee, #framework_syntax_highlighting, cullmann, dhaumann Cc: nibags, shubham, kwrite-devel, kde-frameworks-devel, hase, mi

D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files

nibags added a comment. The bug is identical to D17891 ! Please, also put `#pop!error` in `fallthroughContext="error"`, on lines 238 and 363. And increase the file version REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.k

D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files

jwilbee retitled this revision from "Fixed bug where typing menu or menuconfig while editng a kconfig file would cause the loop at abstracthighlighter.cpp:299 to get stuck in an inite loop. This would occur because the config_entry_start and menu_entry contexts would push an error..." to "Fixed

D18509: Fixed bug where typing menu or menuconfig while editng a kconfig file would cause the loop at abstracthighlighter.cpp:299 to get stuck in an inite loop. This would occur because the config_ent

shubham added a comment. Thanks jwilbe for the patch, but please don't make the title , a summary, keep it short to the point. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18509 To: jwilbee Cc: shubham, kwrite-devel, kde-frameworks-devel, hase, michae

D18509: Fixed bug where typing menu or menuconfig while editng a kconfig file would cause the loop at abstracthighlighter.cpp:299 to get stuck in an inite loop. This would occur because the config_ent

jwilbee created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. jwilbee requested review of this revision. REVISION SUMMARY ...line end context and the error line end context would pop back to the config_entry or menu_entry c

D18434: exiv2extractor: add support for bmp, gif, webp, tga

kossebau added a reviewer: Dolphin. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18434 To: kossebau, #baloo, #dolphin Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18507: Add Activities KCM icon

ndavis added a comment. The icon the KCM currently uses is `preferences-activities`. It's kind of odd that it isn't `preferences-desktop-activities`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18507 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngra

D18507: Add Activities KCM icon

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18507 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18507: Add Activities KCM icon

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-desktop (branched from master) REVISION DETAIL https://

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb updated this revision to Diff 50205. rjvbb added a comment. Use qobject_cast. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18380?vs=50084&id=50205 REVISION DETAIL https://phabricator.kde.org/D18380 AFFECTED FILES src/filewidgets/kdiroperatordetailview.cpp To: rjvbb, ng

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz Cc: cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar added a comment. > If you want to get this behavior for Markdown Even I had mentioned Markdown as example, I would prefer to have this as general behavior. Not only because I don't know anything about that highlight stuff and can't implement it this way. I often write some

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. please look at the existing tests and expand that. There's e.g. `KateDocumentTest::testWordWrap` in `ktexteditor/autotests/src/katedocument_test.cpp` also don't change the be

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. Ok, that behavior you describe is bad. I would get annoyed by that, esp. since the list of chars that you use are totally language specific. If you want to get this behavior f

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > As far as I know, using qobject_cast is faster than comparing class names, because it only compares metaclass pointers. Additionally, it allows subclasses. Purely academic: that would be true for an ObjC-like construct like `isKindOfClass` but doesn't it qobj

D18380: KIO: make file dialog columns resizable again (and movable)

cfeck added a comment. As far as I know, using qobject_cast is faster than comparing class names, because it only compares metaclass pointers. Additionally, it allows subclasses. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham, #frameworks, #dol

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

cullmann added a comment. Either one would need to expose more info from the xml highlighting definitions or as poor mans fix provide some config entry to allow people themself to specify which () "" pairs the want to have handled globall with minimal defaults. REPOSITORY R39 KTextEd

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar added a comment. There is an `enum KSyntaxHighlighting::Theme::TextStyle::Operator` but I can't find a function to test for that. Beside that I guess it would not work anyway. If it's an operator or not need a call to some "update highlight" to investigate the context. Ideas?

D18499: [KCM Controls GridView] Add remove animation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:d8505b807d55: [KCM Controls GridView] Add remove animation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18499?vs=50188&id=50190 REVIS

D18499: [KCM Controls GridView] Add remove animation

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18499 To: broulik, #plasma, mart, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18499: [KCM Controls GridView] Add remove animation

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is what all the grid KCMs have been doing, so it makes sense to put it into

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb marked an inline comment as done. rjvbb added inline comments. INLINE COMMENTS > cfeck wrote in kdiroperatordetailview.cpp:54 > Can we use qobject_cast here? Doh, of course. It's probably more expensive (which shouldn't matter here) but also means we have to include `kfilewidget.h`. Is t

D11236: [KCrash] Establish socket to allow change of ptracer

ossi accepted this revision. ossi added a comment. This revision is now accepted and ready to land. here too, it should be "ancestor" not "parent" for extra correctness. amending the code comment is optional, too. INLINE COMMENTS > kcrash.cpp:662 > +// For now that will be DrKonqi,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi accepted this revision. ossi added a comment. This revision is now accepted and ready to land. note that for extra correctness it should be "ancestor" not "parent". REPOSITORY R871 DrKonqi BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_works

D18380: KIO: make file dialog columns resizable again (and movable)

cfeck added inline comments. INLINE COMMENTS > kdiroperatordetailview.cpp:54 > +} > +m_isFileWidget = pw ? strcmp(pw->metaObject()->className(), > "KFileWidget") == 0 : false; > +// install the section resize handler Can we use qobject_cast here? REPOSITORY R241 KIO

D18380: KIO: make file dialog columns resizable again (and movable)

dhaumann added a comment. I'm not against this change, but have the feeling another +2 from someone who know this stuff is a good idea. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz Cc: dhaumann,

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. David, Andreas, any idea why the name column all of a sudden jumps to a larger width when the widget is used in a side-bar and you're making the view narrower and approach the minimum width? It works in our favour here because the end result is that the name column bec

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added reviewers: dfaure, ahartmetz. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns