KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 29 Jan 2019 04:33:13 + Build duration: 19 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Jan 2019 04:33:14 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 29 Jan 2019 04:32:56 + Build duration: 16 min and counting JUnit Tests Name: projectr

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 Jan 2019 04:33:14 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Jan 2019 04:32:56 + Build duration: 8 min 15 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 29 Jan 2019 04:32:26 + Build duration: 7 min 50 sec and counting JUnit Tests Name: projectroo

D18516: Fix end of folding region in rules with lookAhead=true

2019-01-28 Thread Dominik Haumann
dhaumann added a comment. Ok I see: this kind of reverts Christophs changes in the lookahead case. What I wonder is whether we need a // TODO KF6: add a bool lookAhead in applyFolding() such that we know whether a folding end region should end at 0 or at length. @cullmann Your take

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/6/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 Jan 2019 02:08:25 + Build duration: 8 min 6 sec and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Jan 2019 02:08:25 + Build duration: 3 min 58 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 29 Jan 2019 02:08:25 + Build duration: 2 min 39 sec and counting JUnit Tests Name: pro

D17737: [CopyJob] Create clones in btrf/xfs mount

2019-01-28 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. @bruns ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, davidedmundson Cc: bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/5/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 Jan 2019 23:55:34 + Build duration: 5 min 50 sec and counting BUILD ARTIFACTS abi-com

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 23:55:34 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS abi-com

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 28 Jan 2019 23:55:34 + Build duration: 3 min 15 sec and counting JUnit Tests Name:

D18475: Add AsciiDoc support

2019-01-28 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:de5fc35624d2: Add AsciiDoc support (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18475?vs=50391&id=50453#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST U

D18475: Add AsciiDoc support

2019-01-28 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. 1. I apply your patch: arc patch D18475 2. Since there is a new syntax highlighting file, I do: touch data/syntax-data.qrc.in 3. I switch to the

D16894: [ECM] use a macro to add compiler flags conditionally

2019-01-28 Thread René J . V . Bertin
rjvbb updated this revision to Diff 50451. rjvbb added a comment. This follows David's suggestion, but using `QUERY_IF` instead of the suggested `TRY_IF` to make it clear that this parameter controls the querying of the compiler. I haven't yet tested the new logic exhaustively but the as fa

D16894: [ECM] use a macro to add compiler flags conditionally

2019-01-28 Thread René J . V . Bertin
rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16894 To: rjvbb, #build_system, kfunk Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, br

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Fixed!

2019-01-28 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 28 Jan 2019 19:12:47 + Build duration: 1 hr 36 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 12 - Fixed!

2019-01-28 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 20:29:13 + Build duration: 3 min 38 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 27 - Fixed!

2019-01-28 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/27/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 28 Jan 2019 20:29:13 + Build duration: 2 min 2 sec and counting JUnit Tests

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 14 - Fixed!

2019-01-28 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/14/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 Jan 2019 20:29:13 + Build duration: 1 min 17 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 20:15:47 + Build duration: 4 min 10 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/13/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 Jan 2019 20:15:47 + Build duration: 1 min 19 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 19:32:02 + Build duration: 4 min 14 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/12/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 Jan 2019 19:32:02 + Build duration: 1 min 15 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/11/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 Jan 2019 19:12:47 + Build duration: 1 min 25 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/9/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 19:12:47 + Build duration: 1 min 22 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 18:18:32 + Build duration: 3 min 43 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 23 - Still unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/23/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 28 Jan 2019 18:18:32 + Build duration: 2 min 8 sec and counting JUnit Tests

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 Jan 2019 18:18:32 + Build duration: 1 min 19 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 28 Jan 2019 18:18:32 + Build duration: 46 sec and counting JUnit Tests Name: projec

D18582: Add explicit SurfaceInterface::commited signal

2019-01-28 Thread Vlad Zagorodniy
zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > surface_interface.h:347 > + * @since 5.54 > + */ > +void committed(); **/ REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kd

D18582: Add explicit SurfaceInterface::commited signal

2019-01-28 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Whilst some interfaces that are double-buffered against the wl_surf

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 28 Jan 2019 13:21:51 + Build duration: 37 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 13:21:51 + Build duration: 3 min 53 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/9/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 Jan 2019 13:21:51 + Build duration: 1 min 49 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 22 - Failure!

2019-01-28 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/22/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 28 Jan 2019 13:21:50 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

2019-01-28 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R287:51d710adda14: Fix various OOB reads and writes in kimg_tga and kimg_xcf (authored by fvogt). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18574?vs=50416&id=

D18475: Add AsciiDoc support

2019-01-28 Thread Andreas Gratzer
andreasgr added a comment. In D18475#400238 , @nibags wrote: > Hi!! > Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use `make test` and `autotests/update-reference-data.sh`.

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 Jan 2019 12:11:25 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatibility-re

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 28 Jan 2019 12:11:25 + Build duration: 10 min and counting JUnit Tests Name: projectroot.

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

2019-01-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 12:11:25 + Build duration: 7 min 22 sec and counting BUILD ARTIFACTS abi-compatibil

D18475: Add AsciiDoc support

2019-01-28 Thread Andreas Gratzer
andreasgr added a comment. In D18475#400989 , @nibags wrote: > If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal).

D18577: Make XdgTest spec compliant

2019-01-28 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:818e0d1fcb65: Make XdgTest spec compliant (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18577?vs=50422&id=50425 REVISION DETAIL h

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

2019-01-28 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Thanks :) REPOSITORY R287 KImageFormats BRANCH sec REVISION DETAIL https://phabricator.kde.org/D18574 To: fvogt, aacid Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D18237: Fix ResultIterator

2019-01-28 Thread Albert Astals Cid
aacid added a comment. ping REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18577: Make XdgTest spec compliant

2019-01-28 Thread David Edmundson
davidedmundson updated this revision to Diff 50422. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18577?vs=50420&id=50422 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18577 AFFECTED FILES tests

D18577: Make XdgTest spec compliant

2019-01-28 Thread Vlad Zagorodniy
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D18577 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18577: Make XdgTest spec compliant

2019-01-28 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > xdgtest.cpp:124 > Q_ASSERT(m_xdgShellSurface); > -connect(m_xdgShellSurface, &XdgShellSurface::sizeChanged, this, > &XdgTest::render); > -render(); > +connect(m_xdgShellSurface, &XdgShellSurface::confi

D18577: Make XdgTest spec compliant

2019-01-28 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Right now it worked in kwin, but was in fact breaking the spec send

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.12 - Build # 3 - Fixed!

2019-01-28 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 28 Jan 2019 09:32:13 + Build duration: 1 hr 18 min and counting BUILD ARTIFACTS abi-co

D16894: [ECM] use a macro to add compiler flags conditionally

2019-01-28 Thread René J . V . Bertin
rjvbb added a comment. Usually if you have a conditional behaviour the associated condition specifies when to trigger it, no? You're right that the names don't suggest exactly how the condition is being evaluated (with extra checks or not), but that was also a bit the idea. Don't bother t

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

2019-01-28 Thread Fabian Vogt
fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D18574 To: fvogt, aacid Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

2019-01-28 Thread Fabian Vogt
fvogt updated this revision to Diff 50416. fvogt added a comment. Also bail out early if image data known broken. (Unrelated to the overflow fixes, but nice to have) REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18574?vs=50414&id=50416 BRANCH se

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

2019-01-28 Thread Luca Beltrame
lbeltrame added a comment. Can you expand a bit the description? I understand you are fixing problems, but why the problems are there and what you are doing exactly. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D18574 To: fvogt, aacid Cc: lbeltrame, kde-fram

D16894: [ECM] use a macro to add compiler flags conditionally

2019-01-28 Thread David Faure
dfaure added a comment. Ah. You meant an "OR", I thought it was an "AND". (as in `our known selection of compilers OR/AND appleclang supports it`) But things are certainly not clearer now with the name CONDITION, which doesn't imply either one. Aside from the AppleClang issue, I've h

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

2019-01-28 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. TEST PLAN No crash anymore. REPOSITORY R287 KImageFormats BRANCH sec REVISION DETAIL https://phabrica