D19075: Fix FindEGL

2019-02-15 Thread Tobias C. Berner
tcberner added a comment. Possibly the returend `EGL_INCLUDE_DIR` should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner,

D19075: Fix FindEGL

2019-02-15 Thread Tobias C. Berner
tcberner added a reviewer: FreeBSD. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

2019-02-15 Thread Tobias C. Berner
tcberner created this revision. tcberner added reviewers: Automotive, hausmann. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY ${EGL_INCLUDE_DIR} is the path up to

D19075: Fix FindEGL

2019-02-15 Thread Tobias C. Berner
tcberner added a dependency: D18960: Add compile check to FindEGL. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

2019-02-15 Thread Tobias C. Berner
tcberner added a dependent revision: D19075: Fix FindEGL. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: bcooksley, tcberner, kossebau, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

2019-02-15 Thread Ben Cooksley
bcooksley added a comment. /usr/local/bin/gmake -f CMakeFiles/cmTC_fd24d.dir/build.make CMakeFiles/cmTC_fd24d.dir/build gmake[1]: Entering directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp' Building CXX object CMakeFiles/cmTC_fd24d.dir/src.cxx.o /usr/bin/c++

D19060: Use AuthCore instead of Auth

2019-02-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D19060 To: aacid, apol Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars,

D19059: Use AuthCore instead of Auth

2019-02-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D19059 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19058: Add a note for KF6 to use the core version of KF5::Auth

2019-02-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D19058 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19054: Port cross-compilation support to KF5_HOST_TOOLING

2019-02-15 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19054 To: vkrause, apol Cc: apol, ltoscano, habacker, kde-frameworks-devel,

D19057: Compile our own helper against AuthCore and not Auth

2019-02-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D19057 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19048: Namespace find_file result

2019-02-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D19048 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

2019-02-15 Thread Krešimir Čohar
rooty added a dependency: D19020: [breeze-icons] Revamp system.svgz. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty added a dependent revision: D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik,

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

2019-02-15 Thread Krešimir Čohar
rooty edited the summary of this revision. rooty edited the test plan for this revision. rooty added reviewers: VDG, ngraham. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19074 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

2019-02-15 Thread Krešimir Čohar
rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REVISION SUMMARY This patch replaces the suspend and hibernate icons in the Breeze icon theme with the ones from system.svgz in patch

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty updated this revision to Diff 51821. rooty added a comment. Fix suspend icon height REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51793=51821 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19065: Cleanup idempotent entries from mimetype mapper table

2019-02-15 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The OpenDocument and OfficeXML mime types are

D18883: Add PDF thumbnailer

2019-02-15 Thread Albert Astals Cid
aacid added a comment. The code can't be much simpler than this, there's not much places it can go wrong, i guess the only other thing to mention is, poppler will crash with some bad data, so i don't know if this is on it's own process or not, but if it's not it may bring down whatever app

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

2019-02-15 Thread Noah Davis
ndavis added a comment. In D19030#412778 , @ngraham wrote: > Now we don't need `input-gaming` anymore. :) What happens if an application asks for a 22px `input-gaming` icon and not `input-gaming-symbolic`? REPOSITORY R266 Breeze Icons

D19060: Use AuthCore instead of Auth

2019-02-15 Thread Albert Astals Cid
aacid created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aacid requested review of this revision. REVISION SUMMARY we don't need KAuth::ObjectDecorator nor the widget dependency it brings TEST PLAN Compiles

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Feb 2019 18:53:24 + Build duration: 2 min 59 sec and counting BUILD ARTIFACTS

D19059: Use AuthCore instead of Auth

2019-02-15 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY we don't need KAuth::ObjectDecorator nor the widget dependency it brings TEST PLAN Compiles REPOSITORY R241 KIO

D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Filip Fila
filipf edited the summary of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D19047 To: filipf, #frameworks, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19054: Port cross-compilation support to KF5_HOST_TOOLING

2019-02-15 Thread Luigi Toscano
ltoscano added subscribers: habacker, ltoscano. ltoscano added a comment. I trust @vkrause that this complicated part works, but I need to ask @habacker too, as he contributed part of the cross-compiling code. If anyone else from the #windows

D19058: Add a note for KF6 to use the core version of KF5::Auth

2019-02-15 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D19058 AFFECTED FILES src/CMakeLists.txt

D19053: [kio-extras] Use "storage media" instead of "storages"

2019-02-15 Thread Krešimir Čohar
This revision was automatically updated to reflect the committed changes. Closed by commit R320:9f79f84d0800: [kio-extras] Use storage media instead of storages (authored by rooty). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19053?vs=51796=51798

D19054: Port cross-compilation support to KF5_HOST_TOOLING

2019-02-15 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is more consistent with this is done in other frameworks, and more importantly it

D19053: [kio-extras] Use "storage media" instead of "storages"

2019-02-15 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH typo (branched from master) REVISION DETAIL https://phabricator.kde.org/D19053 To: rooty, #vdg, ngraham Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh,

D19057: Compile our own helper against AuthCore and not Auth

2019-02-15 Thread Albert Astals Cid
aacid updated this revision to Diff 51802. aacid added a comment. Link our own examples against AuthCore REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19057?vs=51801=51802 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19057 AFFECTED

D19057: Compile our own helper against AuthCore and not Auth

2019-02-15 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D19057 AFFECTED FILES src/ConfigureChecks.cmake

D19056: Tell people they should mostly be using KF5::AuthCore

2019-02-15 Thread Christoph Feck
cfeck retitled this revision from "Tell people they should mostly be using KF5::Auth" to "Tell people they should mostly be using KF5::AuthCore". REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D19056 To: aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19056: Tell people they should mostly be using KF5::Auth

2019-02-15 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D19056 AFFECTED FILES README.md To: aacid Cc:

D19053: [kio-extras] Use "storage media" instead of "storages"

2019-02-15 Thread Krešimir Čohar
rooty updated this revision to Diff 51796. rooty added a comment. Fix my own error (ironic?) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19053?vs=51795=51796 BRANCH typo (branched from master) REVISION DETAIL https://phabricator.kde.org/D19053

D19053: [kio-extras] Use "storage media" instead of "storages"

2019-02-15 Thread Krešimir Čohar
rooty edited the summary of this revision. rooty added a reviewer: VDG. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19053 To: rooty, #vdg Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros,

D19053: [kio-extras] Use "storage media" instead of "storages"

2019-02-15 Thread Krešimir Čohar
rooty created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. rooty requested review of this revision. REPOSITORY R320 KIO Extras BRANCH typo (branched from master) REVISION DETAIL https://phabricator.kde.org/D19053

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty updated this revision to Diff 51793. rooty added a comment. Use Zs instead of stars REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51727=51793 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Failing!

2019-02-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 19:47:58 + Build duration: 27 sec and counting CONSOLE OUTPUT [...truncated

D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19047 To: filipf, #frameworks, ngraham, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 18:53:24 + Build duration: 19 min and counting JUnit Tests Name:

D19051: [RFC]DocumentPrivate: Auto unwrap line when text is removed

2019-02-15 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Such patch seems to be missing to achieve the desired

D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R296:23942e570831: [GridDelegate] Fix long labels blending into each other (authored by filipf, committed by ngraham). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/18/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Feb 2019 18:53:24 + Build duration: 3 min 15 sec and counting BUILD ARTIFACTS

D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Filip Fila
filipf added a comment. In D19047#413025 , @ngraham wrote: > +1, definitely the correct fix. > > Let's land this now and then we can work on the UI improvement of enabling multi-line strings in another patch. Okay! :) REPOSITORY

D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, definitely the correct fix. Let's land this now and then we can work on the UI improvement of enabling multi-line strings in another patch. REPOSITORY R296 KDeclarative

D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Filip Fila
filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY This patch anchors the GridDelegate's label width and height to the thumbnail, as opposed to the parent. NOTE: I'm

D19049: Namespace find_file call

2019-02-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY KAuth uses the same name, getting our cached result then. REPOSITORY R244 KCoreAddons BRANCH master REVISION

D19048: Namespace find_file result

2019-02-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY KCoreAddons uses the same name, which causes this to use the cached result for the KCoreAddons find_file call, making

D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Filip Fila
filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added reviewers: Frameworks, ngraham, VDG. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19047 To: filipf, #frameworks, ngraham, #vdg Cc: kde-frameworks-devel,

D18734: Update octave.xml to Octave 4.2.0

2019-02-15 Thread Nikita Sirgienko
sirgienko added a comment. Could I specify, what dot is also word delimiter? Because, for example, "p.poly" has a wrong highlighting: "poly" highlighted as function, but it is not a function, it is a part of object "p". REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D18527: List Android as officially supported

2019-02-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:aa18d0749f5c: List Android as officially supported (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18527?vs=50264=51771 REVISION

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

2019-02-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a reviewer: Frameworks. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me, but please wait for approval by @dfaure or another #frameworks person before landing.

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Nathaniel Graham
ngraham added a comment. Yeah in and of itself, the snowflake is good. I think it just needs something added to it so it doesn't look like it turns on the air conditioning as Kai alluded to. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Feb 2019 16:07:07 + Build duration: 3 min 32 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/11/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Feb 2019 16:07:07 + Build duration: 3 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 16:07:07 + Build duration: 2 min 47 sec and counting JUnit Tests Name:

D18369: Create tel: links for phone numbers

2019-02-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R244:5b5e87d699c5: Create tel: links for phone numbers (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18369?vs=50315=51764#toc REPOSITORY R244 KCoreAddons CHANGES SINCE

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:07 + Build duration: 2 min 50 sec and counting

KDE CI: Frameworks » kcompletion » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:07 + Build duration: 3 min 53 sec and counting

KDE CI: Frameworks » attica » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:07 + Build duration: 3 min 50 sec and counting

KDE CI: Frameworks » kimageformats » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:06 + Build duration: 3 min 5 sec and counting

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:06 + Build duration: 3 min 1 sec and counting

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:06 + Build duration: 3 min 8 sec and counting

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:06 + Build duration: 3 min 3 sec and counting

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 4 - Fixed!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/4/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:06 + Build duration: 1 min 55 sec and counting

KDE CI: Frameworks » ki18n » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:07 + Build duration: 2 min 39 sec and counting

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:06 + Build duration: 1 min 19 sec and counting

KDE CI: Frameworks » threadweaver » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:07 + Build duration: 1 min 20 sec and counting

KDE CI: Frameworks » kguiaddons » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kguiaddons/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 16:00:06 + Build duration: 1 min 14 sec and counting

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty added a comment. In D19020#412775 , @ngraham wrote: > +1 on the List Users icon. Perfect. > > For the Type User icon, I'm not sure it needs to be in a circle. With the new moon-style suspend icon on the left side, it might be better to

KDE CI: Frameworks » karchive » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 15:52:28 + Build duration: 1 min 5 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Feb 2019 15:42:27 + Build duration: 10 min and counting BUILD ARTIFACTS

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

2019-02-15 Thread Krešimir Čohar
rooty added a comment. In D19030#412778 , @ngraham wrote: > Now we don't need `input-gaming` anymore. :) @hein put the "too" in parentheses :D, I was erring on the side of caution But what do I do to the 64 px version? Rename it to

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 15:51:43 + Build duration: 55 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Feb 2019 15:42:27 + Build duration: 5 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 3 - Still Failing!

2019-02-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/3/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 15:47:59 + Build duration: 33 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcodecs » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 15:44:50 + Build duration: 58 sec and counting

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 2 - Still Failing!

2019-02-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/2/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 15:42:14 + Build duration: 38 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 15:43:45 + Build duration: 50 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

2019-02-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 15:42:27 + Build duration: 2 min 11 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.12 - Build # 2 - Fixed!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/2/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 15:41:11 + Build duration: 51 sec and counting

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

2019-02-15 Thread Igor Poboiko
poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks, ngraham, bruns Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

2019-02-15 Thread Igor Poboiko
poboiko updated this revision to Diff 51762. poboiko added a comment. Forgot to define `fname` inside `EventMoveTo` REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18698?vs=51739=51762 BRANCH add-watch-moved (branched from master) REVISION DETAIL

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.12 - Build # 2 - Fixed!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.12/2/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 15:39:12 + Build duration: 1 min 6 sec and counting

D18965: Guard KCompressionDevice::open being called with no backend available

2019-02-15 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R243:3d5713ba3760: Guard KCompressionDevice::open being called with no backend available (authored by davidedmundson). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE

D19007: Wait for DBus Reply Before Performing Computations

2019-02-15 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > narvaez wrote in monitor.cpp:90 > The batch size is **hardcoded** at 40 so querying it at at any interval is > pointless, for that matter. Instead of hardcoding more magic numbers I would > just #define BATCH_SIZE 40 inside the Engine lib and set

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. +1 on the List Users icon. Perfect. For the Type User icon, I'm not sure it needs to be in a circle. With the new moon-style suspend icon on the left side, it might be

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

2019-02-15 Thread Nathaniel Graham
ngraham added a comment. Now we don't need `input-gaming` anymore. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.12 - Build # 1 - Failure!

2019-02-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 14:51:04 + Build duration: 48 sec and counting CONSOLE OUTPUT

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

2019-02-15 Thread Krešimir Čohar
rooty updated this revision to Diff 51759. rooty added a comment. Add input-games and input-games-symbolic REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19030?vs=51732=51759 BRANCH gamepad-icon-16-22-px (branched from master) REVISION DETAIL

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.12 - Build # 1 - Failure!

2019-02-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 14:45:44 + Build duration: 43 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.12 - Build # 5 - Fixed!

2019-02-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/5/ Project: kf5-qt5 AndroidQt5.12 Date of build: Fri, 15 Feb 2019 14:43:57 + Build duration: 40 sec and counting

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

2019-02-15 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R293 Baloo BRANCH add-watch-moved (branched from master) REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks, ngraham, bruns Cc:

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

2019-02-15 Thread Nathaniel Graham
ngraham added a comment. +1 on `input games` and `input-games-symbolic` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18845: authority: add support for passing details to polkit

2019-02-15 Thread Matthias Gerstner
mgerstner added inline comments. INLINE COMMENTS > bruns wrote in polkitqt1-authority.cpp:328 > nullptr I didn't want to mix styles in the source files. It's adjusted now. REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc:

D18845: authority: add support for passing details to polkit

2019-02-15 Thread Matthias Gerstner
mgerstner updated this revision to Diff 51753. mgerstner added a comment. Incorporated review comments: replaced `NULL` by `nullptr`, removed some extra whitespace within parantheses, added KF6 TODO. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18845?vs=51161=51753 REVISION

D19016: Update Android toolchain files to reality

2019-02-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:81374904954b: Update Android toolchain files to reality (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19016?vs=51701=51749

  1   2   >