D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

loh.tar added a comment.


  > Just to be on the safe side: Does this also work, if you have two views 
visible showing the same document, and then the message appears?
  
  As said, poor tested., but what needs to be taken care? Normally these 
messages works well, so no idea why now not.
  
  > Does it also work, if you have two main windows showing the same document 
(View > New Window)?
  
  Do you mean something else than this hint?
  
  > One issue may/is that in case of multible views/windows the actions only 
get synced after an reload event :-/
  
  A tip how to solve this may helpful.

INLINE COMMENTS

> dhaumann wrote in kateview.cpp:238-239
> Could you use new-style signal/slot syntax for new code? :)

Yeah, normally I do. Here I was not sure if it will keeped/accepted and only 
did lazy copy old code :-)

BTW I'm surprised that such function (slot) didn't alrady exist. Instead will 
in the doc all views at some points directly called to update some things. See 
e.g. DocumentPrivate::documentReload:4310

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D16579: Remove support for non-standard APE tag field names from the test files

[Nathaniel Graham]

ngraham added a comment.


  In D16579#428807 , @smithjd wrote:
  
  > In D16579#428790 , @ngraham 
wrote:
  >
  > > Two reviewers had open "Changes Requested" statuses on this patch when 
you committed it, and from the latest comments, it's not clear that their 
concerns were addressed first. Can you explain your thought process regarding 
why you felt it was appropriate to ignore your reviewers as well as KDE 
community norms and commit this anyway?
  >
  >
  > The scope has shrunk to just the test files since D18826 
 made the original code changes and the 
requested changes obsolete, and the test file changes were ack'ed.
  
  
  If that's the case, you should have asked the reviewers who had requested 
changes whether the current state of the patch was merge-able so they they 
could turn their Changes Requested statuses into Accepted statuses. We have a 
review process for a reason, and you are expected to follow the rules.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, abrahams

D16579: Remove support for non-standard APE tag field names from the test files

[James Smith]

smithjd added a comment.


  In D16579#428790 , @ngraham wrote:
  
  > Two reviewers had open "Changes Requested" statuses on this patch when you 
committed it, and from the latest comments, it's not clear that their concerns 
were addressed first. Can you explain your thought process regarding why you 
felt it was appropriate to ignore your reviewers as well as KDE community norms 
and commit this anyway?
  
  
  The scope has shrunk to just the test files since D18826 
 made the original code changes and the 
requested changes obsolete, and the test file changes were ack'ed.
  
  Your comment is unfounded.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, abrahams

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/21/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Mar 2019 04:40:03 +
 Build duration:
9 min 7 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.57.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(456/2236)18%
(203/1134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(150/155)60%
(64/106)src100%
(8/8)100%
(8/8)68%
(222/327)50%
(105/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/8)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%

D19621: ViewPrivate: Make deselection by arrow keys more handy

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:5c94789d28ea: ViewPrivate: Make deselection by arrow keys 
more handy (authored by loh.tar, committed by ngraham).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19621?vs=53574=53631

REVISION DETAIL
  https://phabricator.kde.org/D19621

AFFECTED FILES
  autotests/src/kateview_test.cpp
  autotests/src/kateview_test.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

D16579: Remove support for non-standard APE tag field names from the test files

[Nathaniel Graham]

ngraham added a comment.


  Two reviewers had open "Changes Requested" statuses on this patch when you 
committed it, and from the latest comments, it's not clear that their concerns 
were addressed first. Can you explain your thought process regarding why you 
felt it was appropriate to ignore your reviewers as well as KDE community norms 
and commit this anyway?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D19667: Add Q_EMIT to emit signal call

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19667

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19668: Convert two old-style connects to new-style

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19668

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19666: Remove reference from const KConfigIniBackend::BufferFragment

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  If clazy says so... ¯\_(ツ)_/¯

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19666

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19665: Add Q_OBJECT to KFilterDev

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19665

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19646: Redesign KDE Connect and bluetooth config pages

[Aleix Pol Gonzalez]

apol added a comment.


  This adds a dependency to Kirigami. We are already tier2 so that's okay, but 
reflect it on CMake at least.

INLINE COMMENTS

> kdeconnectplugin_config.qml:41
>  text: model.display
> +icon: model.iconName
>  onClicked: root.device = deviceId

Use icon.name.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: abetts, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D19668: Convert two old-style connects to new-style

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19668

AFFECTED FILES
  src/kdbusinterprocesslock.cpp
  src/kdbusservice.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19652: Add cross-compilation support for kpackagetool5

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Danke!

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19652

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19667: Add Q_EMIT to emit signal call

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19667

AFFECTED FILES
  src/lib/plugin/kpluginfactory.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19666: Remove reference from const KConfigIniBackend::BufferFragment

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  According to clazy since KConfigIniBackend::BufferFragment is very small it's 
faster to just copy it

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19666

AFFECTED FILES
  src/core/bufferfragment_p.h
  src/core/kconfigini.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19665: Add Q_OBJECT to KFilterDev

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  It's a good thing to have

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19665

AFFECTED FILES
  src/kfilterdev.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18601: Rewrite taglib writer to use property interface

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibwriter.cpp:70
> > Taglib does not "handle this nicely". For APE and Xiph, it just accepts 
> > *any* unknown key and uses it verbatim, while for MP4 and ASF it rejects 
> > any unknown key.
> 
> And so do APE::Tag::setItem and OGG::XiphComment::addField ...? btw, also 
> perfectly legal, APE and Xiph allow writing arbitrary tags, while the others 
> do not.
> 
> > The setProperties() is also quite inconsistent, for APE and ASF it only 
> > removes items which have an empty value, while for Xiph, the properties are 
> > completely replaced.
> 
> Xiph explicitly allows multiple entries per key, which need to be removed 
> when writing.
> 
> > As soon as you add support for a property where APE and Xiph key naming 
> > differs, or is only supported by one, you will require two functions anyway.
> 
> TagLib automatically translates different keys from APE to "common names", 
> e.g. DISC->DISCNUMBER etc.
> 
> I would really like to hand off manual tag handling to TagLib as much as 
> possible. The library solely responsible for reading tags usually knows 
> better how to handle the tags than we do (with a few exceptions to the rule 
> of course).

By using the type specific function you signal you are aware of the differences 
between the two, and supply the appropriate data.

RATING is **not handled** by the properties interface, it just works by 
coincidence, not by design.

In case Taglib properly handles a tag, I am not against using it, as said 
several times. This is the case for DISC, but not for RATING.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[Dominik Haumann]

dhaumann added a comment.


  Just to be on the safe side: Does this also work, if you have two views 
visible showing the same document, and then the message appears? Does it also 
work, if you have two main windows showing the same document (View > New 
Window)?

INLINE COMMENTS

> kateview.cpp:238-239
>  
> +connect(m_doc, SIGNAL(reloaded(KTextEditor::Document*)), 
> SLOT(slotDocumentReloaded()));
> +connect(m_doc, SIGNAL(aboutToReload(KTextEditor::Document*)), 
> SLOT(slotDocumentAboutToReload()));
> +

Could you use new-style signal/slot syntax for new code? :)

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D19557: Update design to look more similar to kde.org

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:a67daca8199c: Update design to look more similar to 
kde.org (authored by ognarb).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53616=53617

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.jpg

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Carl Schwan]

ognarb added a comment.


  In D19557#428634 , @ltoscano wrote:
  
  > Thank you! And sorry for the ping-pong.
  
  
  No problems ;) Thanks for the review.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Luigi Toscano]

ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Thank you! And sorry for the ping-pong.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Carl Schwan]

ognarb updated this revision to Diff 53616.
ognarb added a comment.


  Don't change image link and remove kde.png

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53603=53616

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.jpg

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Carl Schwan]

ognarb retitled this revision from "Update css" to "Update design to look more 
similar to kde.org".
ognarb edited the summary of this revision.
ognarb edited the test plan for this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano added a comment.


  In D19557#428619 , @ognarb wrote:
  
  > In D19557#428618 , @ltoscano 
wrote:
  >
  > > In D19557#428617 , @ognarb 
wrote:
  > >
  > > > They use the old link for the image, also the jpg version instead of 
the png. I tested with new page and old page and the result is visually the 
same.
  > >
  > >
  > > But do the existing pages use the old link for the image with the new CSS?
  >
  >
  > Yes the link to the css didn't change, only the content. So even the old 
page links to the new CSS.
  
  
  Ok, so let's back one minute, and maybe it was the case in the original 
review, despite what myself and other people suggested, what if:
  
  - the changes to the XSL files are reverted
  - top-kde.jpg is rewritten using the same size of the original, and of course 
same format. No need to add the new kde.png. You may want to add it, but same 
format, so that we can switch in KF6.
  
  This should ensure no unexpected changes if any user expect the image to be 
that size, and both newly-generated pages and the old ones will have the same 
aspect.
  
  Sorry if it was the case in the first review.
  
  The point about the commit message is still valid.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> kossebau wrote in textcreator.cpp:169
> For the thumbnail the code is rendering on a paper-like canvas, which is 
> hard-coded as well (see lines above with `QColor ( 245, 245, 245 ); // 
> light-grey background`). To simulate a print-out, for what I guess or would 
> have done myself.
> So with that using also a hard-coded theme should be fine, or?

Ah, I thought in a dark color theme the preview is also dark - which does not 
seem to be the case...

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik, cfeck
Cc: dhaumann, vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#428618 , @ltoscano wrote:
  
  > In D19557#428617 , @ognarb wrote:
  >
  > > They use the old link for the image, also the jpg version instead of the 
png. I tested with new page and old page and the result is visually the same.
  >
  >
  > But do the existing pages use the old link for the image with the new CSS?
  
  
  Yes the link to the css didn't change, only the content. So even the old page 
links to the new CSS.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano added a comment.


  In any case, please change the commit message. When this is committed and 
rechecked in one year from now, the aspect of the linked website may not be 
relevant anymore and the images are not visible when you run git log.
  Please describe what the change is about. 
https://chris.beams.io/posts/git-commit/

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano added a comment.


  In D19557#428617 , @ognarb wrote:
  
  > They use the old link for the image, also the jpg version instead of the 
png. I tested with new page and old page and the result is visually the same.
  
  
  But do the existing pages use the old link for the image with the new CSS?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#428614 , @ltoscano wrote:
  
  > No, wait a minute. What happens with pages which are not regenerated?
  
  
  They use the old link for the image, also the jpg version instead of the png. 
I tested with new page and old page and the result is visually the same.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  No, wait a minute. What happens with pages which are not regenerated?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dhaumann wrote in textcreator.cpp:169
> I saw this review request just now: Using a hardcoded theme is not a good 
> idea. I suggest to use a solution based on the background color. We have the 
> following in our example codeeditor:
> 
>   setTheme((palette().color(QPalette::Base).lightness() < 128)
>   ? m_repository.defaultTheme(KSyntaxHighlighting::Repository::DarkTheme)
>   : 
> m_repository.defaultTheme(KSyntaxHighlighting::Repository::LightTheme));
> 
> Could a similar approach be used here as well?

For the thumbnail the code is rendering on a paper-like canvas, which is 
hard-coded as well (see lines above with `QColor ( 245, 245, 245 ); // 
light-grey background`). To simulate a print-out, for what I guess or would 
have done myself.
So with that using also a hard-coded theme should be fine, or?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik, cfeck
Cc: dhaumann, vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 55 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/55/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Mar 2019 19:22:43 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> textcreator.cpp:169
> +
> syntaxHighlighter.setDefinition(m_highlightingRepository.definitionForFileName(path));
> +const auto highlightingTheme = 
> m_highlightingRepository.defaultTheme(KSyntaxHighlighting::Repository::LightTheme);
> +syntaxHighlighter.setTheme(highlightingTheme);

I saw this review request just now: Using a hardcoded theme is not a good idea. 
I suggest to use a solution based on the background color. We have the 
following in our example codeeditor:

  setTheme((palette().color(QPalette::Base).lightness() < 128)
  ? m_repository.defaultTheme(KSyntaxHighlighting::Repository::DarkTheme)
  : m_repository.defaultTheme(KSyntaxHighlighting::Repository::LightTheme));

Could a similar approach be used here as well?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik, cfeck
Cc: dhaumann, vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D19621: ViewPrivate: Make deselection by arrow keys more handy

[loh tar]

loh.tar added a comment.


  > Ok with me.
  
  Thanks.
  
  > I still think that the unit test can be improved, like mixed rtl + ltr 
text, but ok :)
  
  That could be more difficult as you may expect. I think the current tests are 
OK, thisway has it to work always. The current behaviour in mixed text is 
strange and should not be verified by tests.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19621

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 54 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/54/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 09 Mar 2019 11:30:12 +
 Build duration:
1 day 7 hr and counting

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

loh.tar updated this revision to Diff 53613.
loh.tar added a comment.


  - Add actions to View menu
  - Contains some garbage lines
  - Still poor tested
  - One issue may/is that in case of multible views/windows the actions only 
get synced after an reload event :-/

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19517?vs=53548=53613

REVISION DETAIL
  https://phabricator.kde.org/D19517

AFFECTED FILES
  src/data/katepart5ui.rc
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/view/kateview.cpp
  src/view/kateview.h

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/37/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 18:57:15 +
 Build duration:
6 min 55 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(51/58)88%
(51/58)83%
(3190/3829)47%
(4345/9337)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(992/1020)49%
(2185/4505)src77%
(20/26)77%
(20/26)79%
(1193/1505)42%
(483/1150)src.extractors100%
(13/13)100%
(13/13)78%
(947/1219)46%
(1606/3521)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

loh.tar added inline comments.

INLINE COMMENTS

> dhaumann wrote in katedocument.h:1086
> What about this: make this a QAction with setCheckable(true). Then, you could 
> reuse this action in the KTextEditor::Message. You can put this action then 
> into the menu as well.
> 
> ...then again, this could also be in tbe DocumentConfig just like many other 
> settings we have.

- That would be the first action member in katedocument
- How that can add to the KTextEditor::Message didn't light me(?) Or why that 
would make sense

I'm working on a toggle action added to the View menu, so you can then enable 
that in advance. Surprising much effort :-/ but maybe I'm too stupid to do it 
in a simple way

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/42/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 18:57:15 +
 Build duration:
2 min 23 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(51/58)88%
(51/58)83%
(3190/3829)47%
(4345/9337)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(992/1020)49%
(2185/4505)src77%
(20/26)77%
(20/26)79%
(1193/1505)42%
(483/1150)src.extractors100%
(13/13)100%
(13/13)78%
(947/1219)46%
(1606/3521)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D16579: Remove support for non-standard APE tag field names from the test files

[James Smith]

smithjd retitled this revision from "Remove support for non-standard APE tag 
field names" to "Remove support for non-standard APE tag field names from the 
test files".
smithjd edited the summary of this revision.
smithjd edited the test plan for this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, ngraham, abrahams

D16579: Remove support for non-standard APE tag field names

[James Smith]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4c5c4f5b91ab: Use ALBUM ARTIST field name for 
APEv2 test files. (authored by smithjd).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16579?vs=52185=53610#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16579?vs=52185=53610

REVISION DETAIL
  https://phabricator.kde.org/D16579

AFFECTED FILES
  autotests/samplefiles/test.ape
  autotests/samplefiles/test.mpc

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, ngraham, abrahams

D19621: ViewPrivate: Make deselection by arrow keys more handy

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Ok with me.
  
  I still think that the unit test can be improved, like mixed rtl + ltr text, 
but ok :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19621

To: loh.tar, #ktexteditor, dhaumann
Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> katedocument.h:1086
>  bool m_modOnHd = false;
> +bool m_autoReloadMode = false;
> +QTimer m_autoReloadThrottle;

What about this: make this a QAction with setCheckable(true). Then, you could 
reuse this action in the KTextEditor::Message. You can put this action then 
into the menu as well.

...then again, this could also be in tbe DocumentConfig just like many other 
settings we have.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D19646: Redesign KDE Connect and bluetooth config pages

[Andres Betts]

abetts added a comment.


  Could there be a checkmark box or some way to indicate what selection has 
been made?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: abetts, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[James Smith]

smithjd added a comment.


  This test fails:
  
  FAIL!  : TagLibExtractorTest::testMp4(mp4) Compared values are not the same
  
Actual   (resultMp4.properties().value(Property::Rating).toInt()): 0
Expected (8) : 8
Loc: 
[/home/enderw/Code/kfilemetadata/autotests/taglibextractortest.cpp(381)]
  
  Is this a new failure?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19655: [kfilemetadata] Make it compile without foreach

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:928
> The changes in taglibextractor are no longer necessary after D18826 
>  has landed, you can omit these.

Ah ? so all was not commited when you wrote that it"s ok to regenerate patch ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19655

To: mlaurent, dfaure
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/72/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 17:17:55 +
 Build duration:
4 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/49/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 17:17:55 +
 Build duration:
2 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 80 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/80/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Mar 2019 17:17:55 +
 Build duration:
1 min 59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

valeriymalov updated this revision to Diff 53608.
valeriymalov marked 3 inline comments as done.
valeriymalov added a comment.


  - do not ignore results of PostingDB::iter in case of an error/end of db

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=52229=53608

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D19633: Improve consistency of window-* and add more

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:3bc4079c220e: Improve consistency of window-* and add 
more (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19633?vs=53571=53607

REVISION DETAIL
  https://phabricator.kde.org/D19633

AFFECTED FILES
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-pin.svg
  icons-dark/actions/16/window-restore.svg
  icons-dark/actions/16/window-unpin.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-pin.svg
  icons-dark/actions/22/window-restore.svg
  icons-dark/actions/22/window-unpin.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/actions/symbolic/window-close-symbolic.svg
  icons-dark/actions/symbolic/window-keep-above-symbolic.svg
  icons-dark/actions/symbolic/window-keep-below-symbolic.svg
  icons-dark/actions/symbolic/window-maximize-symbolic.svg
  icons-dark/actions/symbolic/window-pin-symbolic.svg
  icons-dark/actions/symbolic/window-restore-symbolic.svg
  icons-dark/actions/symbolic/window-unpin-symbolic.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-pin.svg
  icons/actions/16/window-restore.svg
  icons/actions/16/window-unpin.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-pin.svg
  icons/actions/22/window-restore.svg
  icons/actions/22/window-unpin.svg
  icons/actions/32/window-close.svg
  icons/actions/symbolic/window-close-symbolic.svg
  icons/actions/symbolic/window-keep-above-symbolic.svg
  icons/actions/symbolic/window-keep-below-symbolic.svg
  icons/actions/symbolic/window-maximize-symbolic.svg
  icons/actions/symbolic/window-pin-symbolic.svg
  icons/actions/symbolic/window-restore-symbolic.svg
  icons/actions/symbolic/window-unpin-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis added a comment.


  window-shade can be added in a later patch so that this one isn't 
unnecessarily held back

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/37/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 16:47:24 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32920/60431)39%
(17138/44401)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4373/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8436/14410)51%
(4759/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4350/7987)40%
(1914/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(558/1055)39%
(350/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/51/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 16:47:24 +
 Build duration:
7 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32880/60422)39%
(17113/44398)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4373/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8411/14401)51%
(4748/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4354/7987)40%
(1918/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

D18904: [FileCopyJob] Clean up after cancelation of file copy operation

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7a79f1531480: [FileCopyJob] Clean up after cancelation of 
file copy operation (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=53605=53606

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18904: [FileCopyJob] Clean up after cancelation of file copy operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53605.
chinmoyr retitled this revision from "[FileCopyJob] Clean up after file copy 
operation is cancelled" to "[FileCopyJob] Clean up after cancelation of file 
copy operation".
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Update summary

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=53604=53605

BRANCH
  arcpatch-D18904 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53604.
chinmoyr marked an inline comment as done.
chinmoyr added a comment.


  Changed m_bFileWriteInProgress -> m_bFileCopyInProgress

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=53297=53604

BRANCH
  arcpatch-D18904 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53603.
ognarb added a comment.


  Don't change image size

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53598=53603

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19633: Improve consistency of window-* and add more

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwriter.cpp:70
> Taglib does not "handle this nicely". For APE and Xiph, it just accepts *any* 
> unknown key and uses it verbatim, while for MP4 and ASF it rejects any 
> unknown key.
> 
> The setProperties() is also quite inconsistent, for APE and ASF it only 
> removes items which have an empty value, while for Xiph, the properties are 
> completely replaced.
> 
> As soon as you add support for a property where APE and Xiph key naming 
> differs, or is only supported by one, you will require two functions anyway.
> 
> Using `APE::Tag::setItem(...)` is as efficient as manipulating the key/value 
> in the Taglib::PropertyMap first and setting it by `setProperties(...)`. 
> Likewise for Xiph.
> 
> If you want to squeeze out the last bit of efficiency, you would skip the 
> `setProperties(...)` completely when no property is changed by 
> `writeGenericProperties()`. This happens e.g. if you only change the 
> rating.
> 
> If you want to avoid duplicate code, move the 
> `properties()`/`setProperties()` into `writeGenericProperties()`, that saves 
> 12*2 lines and adds 2.

> Taglib does not "handle this nicely". For APE and Xiph, it just accepts *any* 
> unknown key and uses it verbatim, while for MP4 and ASF it rejects any 
> unknown key.

And so do APE::Tag::setItem and OGG::XiphComment::addField ...? btw, also 
perfectly legal, APE and Xiph allow writing arbitrary tags, while the others do 
not.

> The setProperties() is also quite inconsistent, for APE and ASF it only 
> removes items which have an empty value, while for Xiph, the properties are 
> completely replaced.

Xiph explicitly allows multiple entries per key, which need to be removed when 
writing.

> As soon as you add support for a property where APE and Xiph key naming 
> differs, or is only supported by one, you will require two functions anyway.

TagLib automatically translates different keys from APE to "common names", e.g. 
DISC->DISCNUMBER etc.

I would really like to hand off manual tag handling to TagLib as much as 
possible. The library solely responsible for reading tags usually knows better 
how to handle the tags than we do (with a few exceptions to the rule of course).

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/36/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 15:03:05 +
 Build duration:
7 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(51/58)88%
(51/58)83%
(3190/3829)47%
(4345/9337)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(992/1020)49%
(2185/4505)src77%
(20/26)77%
(20/26)79%
(1193/1505)42%
(483/1150)src.extractors100%
(13/13)100%
(13/13)78%
(947/1219)46%
(1606/3521)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/41/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 15:03:04 +
 Build duration:
2 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(51/58)88%
(51/58)83%
(3190/3829)47%
(4345/9337)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(992/1020)49%
(2185/4505)src77%
(20/26)77%
(20/26)79%
(1193/1505)42%
(483/1150)src.extractors100%
(13/13)100%
(13/13)78%
(947/1219)46%
(1606/3521)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:649555ee3182: Rewrite the taglib extractor to use the 
generic PropertyMap interface (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18826?vs=53587=53599#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18826?vs=53587=53599

REVISION DETAIL
  https://phabricator.kde.org/D18826

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19655: [kfilemetadata] Make it compile without foreach

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> externalextractor.cpp:151
> +const auto lstKeys = propertiesObject.keys();
> +for (const auto  : lstKeys) {
>  if (key == QStringLiteral("typeInfo")) {

Can you change this to iterate over the entries, without intermediate list?

> externalwriter.cpp:112
>  
> -Q_FOREACH(const Property::Property , propertiesKeys) {
> +for (const Property::Property  : propertiesKeys) {
>  PropertyInfo propertyInfo(property);

dito, iteration without intermediate list.

> taglibextractor.cpp:928
>  result->add(Property::Location, loc);
>  }
>  

The changes in taglibextractor are no longer necessary after D18826 
 has landed, you can omit these.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19655

To: mlaurent, dfaure
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Thanks, looks good to me now.

REPOSITORY
  R286 KFileMetaData

BRANCH
  arcpatch-D18826

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19557: Update css

[Luigi Toscano]

ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  Can you please not overwrite top-kde.jpg too, or at least use the same size? 
Because the change of size may be a problem for existing users (if any, but I 
consider those files as part of the public interface of KDocTools

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19097: Add a test and document PropertyMap/VariantMap conversion

[Alexander Stippich]

astippich abandoned this revision.
astippich added a comment.




REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19097

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19098: Add PropertyMap to QVariantMap conversion function using names

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19098

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19557: Update css

[Yuri Chornoivan]

yurchor accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb updated this revision to Diff 53598.
ognarb added a comment.


  - Add deleted image
  - Rename top-kde.png to kde.png
  - Fix strange margin issues for some elements
  
  @rooty The font can be changed in the khelpcenter settings. But it's strange 
that it doesn't use Plasma settings per default.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53546=53598

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.jpg
  src/customization/kde-navig-online.xsl
  src/customization/kde-navig.xsl

To: ognarb, #vdg, #documentation
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19646: Redesign KDE Connect and bluetooth config pages

[Luigi Toscano]

ltoscano added a comment.


  Less technical note: I think that the commit message should not really about 
KDE Connect, as the change is reflected on all Purpose's users.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D19442: [Kfilemetada] Make it compile without foreach

[Laurent Montel]

mlaurent abandoned this revision.
mlaurent added a comment.


  I recreated it in "https://phabricator.kde.org/D19655;

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, ngraham, abrahams

D19655: [kfilemetadata] Make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R286 KFileMetaData

BRANCH
  compile_without_foreach

REVISION DETAIL
  https://phabricator.kde.org/D19655

AFFECTED FILES
  CMakeLists.txt
  src/externalextractor.cpp
  src/externalwriter.cpp
  src/extractorplugin.cpp
  src/extractors/office2007extractor.cpp
  src/extractors/taglibextractor.cpp
  src/writercollection.cpp
  tests/dump.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19557: Update css

[Yuri Chornoivan]

yurchor added a comment.


  In D19557#428394 , @ltoscano wrote:
  
  > Apart from the VDG, I'm sure that @yurchor can give some hints, as he 
manages the templates used to generate the PDFs.
  
  
  I have no objections. This part is not used for PDFs, btw. ;)

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Luigi Toscano]

ltoscano added a subscriber: yurchor.
ltoscano added a comment.


  On the graphical side I'm not the most qualified to talk :)
  Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages 
the templates used to generate the PDFs.
  
  From the technical point of view, I wouldn't remove any of the exiting files 
right now, at least not until KF6. I'd suggest using new names, just to avoid 
the possible confusion between the old top-kde.jpg and the new top-kde.png.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19652: Add cross-compilation support for kpackagetool5

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19652

AFFECTED FILES
  CMakeLists.txt
  KF5PackageConfig.cmake.in
  src/kpackagetool/CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19557: Update css

[Krešimir Čohar]

rooty added a comment.


  Can you make it use Noto Sans by any chance?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: rooty, ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, 
kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Albert Astals Cid]

aacid added a subscriber: ltoscano.
aacid added a comment.


  @ognarb i don't really have much to say here, my comment was just about a new 
file being introduced that seemed unnecessary.
  
  I'd say you want @ltoscano for someone that probably knows a bit about 
docs.kde.org code and maybe someone from VDG to say if it's prettier than 
before?

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: ltoscano, bruns, abetts, broulik, aacid, kde-frameworks-devel, 
kde-doc-english, gennad, michaelh, ngraham, skadinna

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

astippich updated this revision to Diff 53587.
astippich marked an inline comment as done.
astippich added a comment.


  - spelling fixes

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18826?vs=53585=53587

BRANCH
  arcpatch-D18826

REVISION DETAIL
  https://phabricator.kde.org/D18826

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

astippich marked 3 inline comments as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:364
> This intermediate list is not required, you can directly call result->add() 
> for each attribute in lstASF.

After further investigation there is no need to look for more than one entry, 
since there cannot be duplicated keys. This is also what TagLib does 
internally. So I changed it to be more inline with the generic extraction.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

astippich updated this revision to Diff 53585.
astippich added a comment.


  - update

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18826?vs=52890=53585

BRANCH
  arcpatch-D18826

REVISION DETAIL
  https://phabricator.kde.org/D18826

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19511: ViewPrivate: Disable read-only mode action when doc is modified

[loh tar]

loh.tar added a comment.


  So, then I assume you would be pro this patch.
  
  I notice one behavior that would be against this patch but not pro the 
meaning of "Read Only Mode". When you set this setting and issue a save request 
you get the "Save as" dialog. Such behavior is good in any case. But such 
option, working as the current one, should then be called like, "Don't 
Overwrite File".
  
  When you open as normal user a not writeable file, like /etc/fstab, I would 
somehow expect to see some warning and/or to enter the "Read Only Mode". But 
that's not the case. When you issue a save request you will be promted for 
admin rights, which is good in that example, no doubts.
  
  Then exist the case that an "dangerous/odd" file, e.g. with too long lines, 
will set to "Read Only Mode". So far I remember is that also only be done to 
protect the orig file to be overwritten, but not for some hard needs which 
couldn't be handled by KTextEditor, it's more some odd protection against bad 
edit performance. So here is also a "Don't Overwrite File" setting more needful 
at the long end.
  
  So, have have the feeling "Read Only Mode" should be renamed and this patch 
trashed, and the lock icon patch presumably too :-/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/14/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Mar 2019 09:40:06 +
 Build duration:
8 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 09:40:05 +
 Build duration:
5 min 29 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WindowSystem-5.57.0.xmlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7185/9550)55%
(3548/6397)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3049/3138)53%
(1294/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3342/4664)61%
(1949/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/18/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Mar 2019 09:35:31 +
 Build duration:
9 min 0 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6420/8540)43%
(10277/23672)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5865/12071)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(855/1267)36%
(988/2717)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/22/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Mar 2019 09:35:31 +
 Build duration:
8 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6420/8540)43%
(10277/23672)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5865/12071)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(855/1267)36%
(988/2717)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/19/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Mar 2019 09:38:45 +
 Build duration:
3 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/24/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Mar 2019 09:35:30 +
 Build duration:
3 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D19461: Logcat: fix dsError color with underline="0"

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1296052d48b3: Logcat: fix dsError color with 
underline=0 (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19461?vs=53426=53579

REVISION DETAIL
  https://phabricator.kde.org/D19461

AFFECTED FILES
  autotests/folding/test.logcat.fold
  autotests/html/test.logcat.html
  autotests/input/test.logcat
  autotests/reference/test.logcat.ref
  data/syntax/logcat.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19461: Logcat: fix dsError color with underline="0"

[Nibaldo González]

nibags added a comment.


  Yes, this corresponds to the bug you mention.
  In the "Vim (dark)" scheme, bold="0" doesn't work either, since all the text 
is bold.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  logcat-fix-error-color

REVISION DETAIL
  https://phabricator.kde.org/D19461

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann