D20148: Allow line end context switches in empty lines

cullmann added a comment. The change in the results look reasonable. For the loop itself: Should one not combine both loops? e.g. loop as long as either the emptycontext is stay and one does switch at line end or the emptycontext doesn't stay? Then one can handle intermixed things.

D20148: Allow line end context switches in empty lines

nibags retitled this revision from "Don't skip empty lines after matching a LineContinue rule" to "Allow line end context switches in empty lines". nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20148 To: nibags,

D20148: Don't skip empty lines after matching a LineContinue rule

nibags updated this revision to Diff 55161. nibags added a comment. - Don't store bool in StateData REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20148?vs=55150=55161 BRANCH fix-line-continue REVISION DETAIL

D19512: KateStatusBar: Show lock icon on modified label when in read-only mode

andreask added a comment. I had choose also an tooltip like most other apps do and there it work very well. F6740005: libreoffice-password-content.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19512 To: loh.tar,

D18604: Implement support for writing rating information for taglib writer

bruns added inline comments. INLINE COMMENTS > taglibwriter.cpp:45 > + > +#include > Remove ... > taglibwriter.cpp:71 > +int id3v2RatingTranslation[11] = { > +0,1,13,54,64,118,128,186,196,242,255 > +}; missing spaces > taglibwriter.cpp:131 > + > +} > + please add an end of anonymous

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added inline comments. INLINE COMMENTS > file.cpp:932 > +int64_t lowerBound = 256; > +int64_t higherBound = 1024; > +#else statx.stx_size is __u64, and readlink uses (unsigned) size_t for the buffer size. REPOSITORY R241 KIO REVISION DETAIL

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick added a comment. Would you accept now @apol? REVISION DETAIL https://phabricator.kde.org/D19420 To: croick, broulik, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 60 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/60/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 31 Mar 2019 20:18:38 + Build duration: 2 min 2 sec and counting JUnit Tests

KDE CI: Frameworks » kimageformats » kf5-qt5 AndroidQt5.12 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20AndroidQt5.12/11/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 31 Mar 2019 20:18:39 + Build duration: 46 sec and counting

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/44/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 20:18:39 + Build duration: 50 sec and counting JUnit Tests Name:

D20149: Fix compilation

aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D20149 To: aacid, svuorela Cc: svuorela, apol, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

cfoster added a comment. What needs to happen now for this to be accepted? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D20149: Fix compilation

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20149 To: aacid, svuorela Cc: svuorela, apol, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20149: Fix compilation

aacid added subscribers: pino, apol, svuorela. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D20149 To: aacid Cc: svuorela, apol, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20149: Fix compilation

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Seems only gcc can do a constexpr with strlen. This fixes the build with clang, hopefully to with MSVC? REPOSITORY

D20148: Don't skip empty lines after matching a LineContinue rule

nibags edited the summary of this revision. nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann, vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20148 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/78/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 19:36:03 + Build duration: 7 min 18 sec and counting JUnit Tests Name:

D20148: Don't skip empty lines after matching a LineContinue rule

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-line-continue REVISION DETAIL https://phabricator.kde.org/D20148

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/45/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 19:33:18 + Build duration: 7 min 31 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/44/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 19:33:18 + Build duration: 5 min 26 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/43/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 19:33:18 + Build duration: 2 min 3 sec and counting CONSOLE OUTPUT

D20147: Improve executable dialog buttons' icons

This revision was automatically updated to reflect the committed changes. Closed by commit R241:89557a218d7b: Improve executable dialog buttons icons (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20147?vs=55145=55149 REVISION DETAIL

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 59 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/59/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 31 Mar 2019 19:33:18 + Build duration: 1 min 7 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kimageformats » kf5-qt5 AndroidQt5.12 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20AndroidQt5.12/10/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 31 Mar 2019 19:33:18 + Build duration: 50 sec and counting CONSOLE OUTPUT

D20143: ora:kra: qstrcmp -> qstrncmp

This revision was automatically updated to reflect the committed changes. Closed by commit R287:fd4fb6f596e2: ora:kra: qstrcmp - memcmp (authored by aacid). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20143?vs=55138=55148 REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55147. meven added a comment. Use time_t instead of __time_t and fix higherBound REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55146=55147 BRANCH creation-date REVISION DETAIL

D20143: ora:kra: qstrcmp -> qstrncmp

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH arcpatch-D20143 REVISION DETAIL https://phabricator.kde.org/D20143 To: aacid, svuorela Cc: apol, pino, security-team, rempt, kde-frameworks-devel, michaelh, ngraham,

D19551: [knotifications] compile without foreach

dfaure added a comment. For the record, Laurent commented out the QT_NO_FOREACH define in commit cdfaff8ce6aa359555d0b611f9141d2012ec9dde , so the build should be fixed again. REPOSITORY R289 KNotifications

D20147: Improve executable dialog buttons' icons

ndavis accepted this revision. ndavis added a comment. Yes, this is much better. Wow, that `application-x-executable` icon is really blurry. REPOSITORY R241 KIO BRANCH improve-execute-dialog-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D20147 To: ngraham,

D14724: autotests: don't fail if an unrelated window shows up.

dfaure added a comment. That doesn't tell me much about the failure you mention -- what, how and why... I still think the patch is an improvement and should be pushed -- but now I regret putting it up for review, I almost completely forgot about it REPOSITORY R242 Plasma

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55146. meven added a comment. Handle properly respective types for stat and statx syscalls REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55132=55146 BRANCH creation-date REVISION DETAIL

D20143: ora:kra: qstrcmp -> qstrncmp

aacid marked 4 inline comments as done. aacid added inline comments. INLINE COMMENTS > apol wrote in kra.cpp:21 > how about calling it s_mimetype? ny. It happens to be the mimetype, but here we're using it as magic to detect if the file is a file we care about or not, i'd prefer to keep it

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/42/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 19:15:24 + Build duration: 5 min 33 sec and counting JUnit Tests Name:

D20147: Improve executable dialog buttons' icons

GB_2 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH improve-execute-dialog-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D20147 To: ngraham, #vdg, GB_2 Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 18:58:23 + Build duration: 16 min and counting JUnit Tests Name:

D20147: Improve executable dialog buttons' icons

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The buttons were using mimetype icons, which don't change their colors to reflect the

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/19/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 19:07:37 + Build duration: 5 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/43/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 19:04:30 + Build duration: 1 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/44/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 19:03:30 + Build duration: 1 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 42 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/42/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 18:58:23 + Build duration: 6 min 5 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 18:10:11 + Build duration: 53 min and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 43 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 18:58:23 + Build duration: 5 min 5 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 58 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/58/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 31 Mar 2019 19:00:34 + Build duration: 2 min 14 sec and counting JUnit Tests

D20145: Fix RGBHandler::canRead

This revision was automatically updated to reflect the committed changes. Closed by commit R287:9fc6967f4fe5: Fix RGBHandler::canRead (authored by aacid). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20145?vs=55141=55144 REVISION DETAIL

D20145: Fix RGBHandler::canRead

aacid added a comment. In D20145#441079 , @apol wrote: > Makes sense, maybe it would make sense to include a test case? if such a thing exists... We already have tests cases, it just does not use canRead, only read. I need this fixed so

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/23/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 18:10:10 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/28/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 18:10:10 + Build duration: 7 min 43 sec and counting BUILD ARTIFACTS

D20145: Fix RGBHandler::canRead

apol accepted this revision. apol added a comment. Makes sense, maybe it would make sense to include a test case? if such a thing exists... REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20145 To: aacid, svuorela, apol Cc: apol, svuorela,

D20143: ora:kra: qstrcmp -> qstrncmp

apol added a comment. +1 otherwise INLINE COMMENTS > kra.cpp:21 > > +static constexpr char s_magic[] = "application/x-krita"; > +static constexpr int s_magic_size = strlen(s_magic); how about calling it s_mimetype? REPOSITORY R287 KImageFormats REVISION DETAIL

D19784: Avoid calling QT_LSTAT and accessing recent documents

This revision was automatically updated to reflect the committed changes. Closed by commit R119:408f03ca989e: Avoid calling QT_LSTAT and accessing recent documents (authored by hoffmannrobert, committed by dfaure). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20145: Fix RGBHandler::canRead

svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. I'm not sure why it as such is needed, but it isn't wrong. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20145 To: aacid, svuorela

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH fix_recent_documents_kicker_hang REVISION DETAIL https://phabricator.kde.org/D19784 To: hoffmannrobert, #frameworks, dfaure, #dolphin Cc: apol, ngraham, plasma-devel,

D20145: Fix RGBHandler::canRead

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY As one can see in SGIImage::readImage the accepted images are _stream >> u16; if (u16 != 0x01da) {

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. Another alternative would be to turn the thumbnail outline into a real outline instead of a rounded rectangle behind the thumbnailArea. Then it could go on top of the thumbnailArea and the thumbnail highlight could fit perfectly inside of it. This would give previews

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. Here is how no radius for the thumbnailArea and thumbnail highlight looks: F6739553: Screenshot_20190331_131729.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg

D20063: Sublime Merge Icon.

This revision was automatically updated to reflect the committed changes. Closed by commit R266:69d7182daffc: Sublime Merge Icon. (authored by otavva, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20063?vs=54981=55140 REVISION

D20143: ora:kra: qstrcmp -> qstrncmp

aacid updated this revision to Diff 55138. aacid added a comment. use strlen instead of sizeof to not include the trailing \0 REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20143?vs=55137=55138 BRANCH arcpatch-D20143 REVISION DETAIL

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. In D20140#440989 , @ngraham wrote: > It's probably going to be more noticeable for High DPI users. It seems like there must be a way to fix this rather than just removing the thumbnail radius. I could remove the

D20143: ora:kra: qstrcmp -> qstrncmp

pino added inline comments. INLINE COMMENTS > kra.cpp:22 > +static constexpr char s_magic[] = "application/x-krita"; > +static constexpr int s_magic_size = sizeof(s_magic); > + this also counts the null terminator (as it is part of the static string) > kra.cpp:61 > if (device->peek(buff,

D20143: ora:kra: qstrcmp -> qstrncmp

aacid added subscribers: rempt, security-team. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D20143 To: aacid Cc: security-team, rempt, kde-frameworks-devel, michaelh, ngraham, bruns

D20143: ora:kra: qstrcmp -> qstrncmp

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Makes oss-fuzz happier REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL

D20032: Convert string formatting tests to be data driven

bruns added inline comments. INLINE COMMENTS > apol wrote in propertyinfotest.cpp:71 > Not really, but if @mgallien, who is the maintainer, is fine with it, I'm > fine too. > After all it's still better than what we used to have. @mgallien has not done any coding are reviews on kfilemetadata

D20063: Sublime Merge Icon.

otavva added a comment. kirill.otave...@gmail.com Kirill Otavva (or Otavenko if you wish). REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, cblack, arvidhansson,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/53/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 14:59:34 + Build duration: 2 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/52/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 14:52:28 + Build duration: 7 min 4 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/58/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 14:55:00 + Build duration: 2 min 27 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/57/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 14:52:28 + Build duration: 2 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/58/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 14:54:08 + Build duration: 1 min 1 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/57/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 14:52:29 + Build duration: 1 min 9 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.11 - Build # 132 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.11/132/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 31 Mar 2019 14:18:34 + Build duration: 35 min and counting JUnit Tests

D20139: [TagLibExtractor] Use the correct mimetype in case of inheritance

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e32763292366: [TagLibExtractor] Use the correct mimetype in case of inheritance (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20138: Add a helper to determine actual supported parent mime type

This revision was automatically updated to reflect the committed changes. Closed by commit R286:72d10bc06b97: Add a helper to determine actual supported parent mime type (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20138: Add a helper to determine actual supported parent mime type

bruns added a comment. In D20138#440972 , @astippich wrote: > Oh, another idea: Cannot this be used to determine that the extractor supports the inheriting mimetype as required in D20121 ? Would need to be

D18601: Rewrite taglib writer to use property interface

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH rewrite_taglib2 REVISION DETAIL https://phabricator.kde.org/D18601 To: astippich, bruns, mgallien, broulik, cfeck Cc: kde-frameworks-devel, #baloo, gennad, domson,

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 71 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/71/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 14:18:33 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 56 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/56/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 14:18:33 + Build duration: 14 min and counting BUILD ARTIFACTS

D20082: Safeguard against invalid files

bruns accepted this revision. REPOSITORY R286 KFileMetaData BRANCH taglib_invalid REVISION DETAIL https://phabricator.kde.org/D20082 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 75 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/75/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 14:18:33 + Build duration: 7 min 54 sec and counting JUnit Tests Name:

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ngraham added a comment. It's probably going to be more noticeable for High DPI users. It seems like there must be a way to fix this rather than just removing the thumbnail radius. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg

D20082: Safeguard against invalid files

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_invalid REVISION DETAIL https://phabricator.kde.org/D20082 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55132. meven added a comment. Avoid including twice errno.h REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55124=55132 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 74 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/74/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 13:04:38 + Build duration: 15 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 70 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/70/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 31 Mar 2019 13:04:38 + Build duration: 9 min 12 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.11 - Build # 131 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.11/131/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 31 Mar 2019 13:04:38 + Build duration: 6 min 50 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 55 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/55/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 13:04:38 + Build duration: 5 min 25 sec and counting CONSOLE OUTPUT

D20138: Add a helper to determine actual supported parent mime type

astippich added a comment. Oh, another idea: Cannot this be used to determine that the extractor supports the inheriting mimetype as required in D20121 ? Would need to be public for this, though, or the test needs to be made a friend class. REPOSITORY

D19425: DocumentPrivate: Support to set dictionary on block selection

This revision was automatically updated to reflect the committed changes. Closed by commit R39:eb90ca5231f4: DocumentPrivate: Support to set dictionary on block selection (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann added a comment. Hmm, if the follow_.. stuff is removed, I think the sub-menu should go away, too. The view_auto_reload should just be a top-level action, menus with single entries are strange ;) Feel free to commit this with such a change. REPOSITORY R39 KTextEditor

D20138: Add a helper to determine actual supported parent mime type

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Forget my comment, I thought it would be possible to share some code with the ExtractorCollection, but the implementation is too different REPOSITORY R286 KFileMetaData REVISION

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar added a comment. > Could the "view_auto_follow" be implemented in a second review after this is commited? I had remove this because it's somehow unhandy. When enabled you can't scroll up an look at some line without to be interrupted on next update. Now it works the smart way.

D18604: Implement support for writing rating information for taglib writer

astippich updated this revision to Diff 55127. astippich added a comment. - rebase - simplify id3 rating to array REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18604?vs=55056=55127 BRANCH rating_write2 REVISION DETAIL

D18603: Implement more tags for taglib writer

astippich updated this revision to Diff 55126. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=50705=55126 BRANCH enhance_taglibwriter2 REVISION DETAIL https://phabricator.kde.org/D18603 AFFECTED

D18603: Implement more tags for taglib writer

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter2 REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D18601: Rewrite taglib writer to use property interface

astippich updated this revision to Diff 55125. astippich added a comment. - check that file is valid - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18601?vs=50704=55125 BRANCH rewrite_taglib2 REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > fvogt wrote in file.cpp:71 > This won't work as expected, `USE_STATX` is unconditionally defined. Thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks,

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55124. meven added a comment. Conditionnaly define USE_STATX REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55123=55124 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20082: Safeguard against invalid files

astippich added a comment. ping. I would like to land this for KF 5.57 to fix crashes in the taglib extractors because of invalid files once and for all. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20082 To: astippich, bruns Cc: kde-frameworks-devel,

D19445: Handle variant list in formatting functions

astippich added a comment. ping. This will be beneficial for handling lists regardless of the discussion in D19087 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc:

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt added a comment. In D20096#440923 , @meven wrote: > In D20096#440921 , @fvogt wrote: > > > In D20096#440919 , @meven wrote: > > > > > So unless I

  1   2   >