KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 100 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/100/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 30 Apr 2019 03:45:14 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/97/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 30 Apr 2019 03:45:14 + Build duration: 9 min 52 sec and counting JUnit Tests Name:

D20907: Disable broken and no longer needed workaround code with msvc2019

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R314 KJs BRANCH master REVISION DETAIL https://phabricator.kde.org/D20907 To: vonreth, dfaure, arichardson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Binary files with .spx extension are detected as

D20913: [TagLibExtractor] Fix crash on invalid Speex files

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY TagLib::Ogg::Speex::File::isValid() returns true even

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

filipf added a comment. Which still leaves you with fixing the gaps when there's not thumbnail. I'd suggest to do: `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2` and call it a day :P REPOSITORY R296 KDeclarative REVISION DETAIL

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

filipf added a comment. You can fix the rounding bleeding into image previews by doing the following at line 116: `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing` F6800947: image.png REPOSITORY R296 KDeclarative REVISION

D20907: Disable broken and no longer needed workaround code with msvc2019

vonreth edited the summary of this revision. REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D20907 To: vonreth, dfaure, arichardson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20907: Disable broken and no longer needed workaround code with msvc2019

vonreth retitled this revision from "Disable boken and no longer needed workaround code" to " Disable broken and no longer needed workaround code with msvc2019". vonreth edited the summary of this revision. vonreth added reviewers: dfaure, arichardson. REPOSITORY R314 KJs REVISION DETAIL

D20907: Disable boken and no longer needed workaround code

vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REVISION SUMMARY See: int main() { const auto inf = std::numeric_limits::infinity(); print(_MSC_VER);

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/88/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 29 Apr 2019 19:06:25 + Build duration: 47 min and counting JUnit Tests Name:

D20877: Fix exivextractor crash with malformed files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e227a7ce4587: Fix exivextractor crash with malformed files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20877?vs=57157=57212

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/83/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 29 Apr 2019 19:06:25 + Build duration: 6 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/89/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Apr 2019 19:06:25 + Build duration: 3 min 11 sec and counting BUILD ARTIFACTS

D20903: Fix bookmark pixmap painting on icon bar

loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20903 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20877: Fix exivextractor crash with malformed files

ngraham accepted this revision. REPOSITORY R286 KFileMetaData BRANCH fix_exiv_crash REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a comment. In D20838#457395 , @meven wrote: > I have fixed those two issues : > > - the path are now translated from kde url to mostlocal urls (dropping from desktop:/ works fine) (not from trash:/ though, but it currently does

D20903: Fix bookmark pixmap painting on icon bar

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Hopefully this time really! TEST PLAN F6800396:

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 57192. loh.tar edited the test plan for this revision. loh.tar added a comment. - Remove special angle bracket check, will be back in a smarter may later (hopefully) - Move getter config functions into header CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 29 Apr 2019 13:58:30 + Build duration: 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 22 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 29 Apr 2019 13:58:30 + Build duration: 6 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 29 Apr 2019 13:58:30 + Build duration: 3 min 30 sec and counting JUnit Tests Name:

D19617: Support NET_WM_STATE_FOCUSED

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ab99c870d6ca: Support NET_WM_STATE_FOCUSED (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19617?vs=53460=57182#toc REPOSITORY R278 KWindowSystem CHANGES SINCE

D19617: Support NET_WM_STATE_FOCUSED

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in netwm_def.h:506 > It's 5.57; 5.56 has already been tagged. 5.58 at this point. REPOSITORY R278 KWindowSystem BRANCH state_focussed REVISION DETAIL https://phabricator.kde.org/D19617 To: davidedmundson, #kwin, broulik

D20897: Ensure the left border miss no change of the count of line number digits

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This check was accidentally removed by 57781f34

D19617: Support NET_WM_STATE_FOCUSED

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I think regardless of whether we end up using this in KWin or not, we should have the API for it in `KWindowSystem` REPOSITORY R278 KWindowSystem BRANCH state_focussed REVISION

D20877: Fix exivextractor crash with malformed files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fix_exiv_crash REVISION DETAIL https://phabricator.kde.org/D20877 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D19455: [knotification] compile without deprecated methods

mlaurent added a comment. "I'm fine with either fix, any objection to that being committed directly?" no problem for me REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19455 To: mlaurent, dfaure Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham,

D19455: [knotification] compile without deprecated methods

bcooksley added a comment. I'm fine with either fix, any objection to that being committed directly? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19455 To: mlaurent, dfaure Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/39/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 29 Apr 2019 00:47:15 + Build duration: 8 hr 12 min and counting JUnit Tests Name:

D20827: Reword some text, a couple clean ups, add a separator

meven added a comment. In D20827#457391 , @elvisangelaccio wrote: > @meven FYI this change broke the Frameworks string freeze: https://community.kde.org/Schedules/Frameworks Should I revert this then ? REPOSITORY R241 KIO REVISION

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 29 Apr 2019 07:32:17 + Build duration: 45 sec and counting JUnit Tests Name:

D20752: Add missing properties in kpackage-generic.desktop

dfaure closed this revision. REVISION DETAIL https://phabricator.kde.org/D20752 To: dfaure, mart, apol, sitter Cc: #frameworks