D20735: [KPropertiesDialog] Add octal permissions

shubham updated this revision to Diff 57355. shubham added a comment. No type casting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20735?vs=56979=57355 BRANCH octal REVISION DETAIL https://phabricator.kde.org/D20735 AFFECTED FILES

D20735: [KPropertiesDialog] Add octal permissions

shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino, #vdg Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20924: ViewConfig: Use new generic config interface

loh.tar updated this revision to Diff 57354. loh.tar retitled this revision from "[WIP] ViewConfig: Use new generic config interface " to "ViewConfig: Use new generic config interface ". loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a

D20940: [baloo_file] Wait for extractor process to start

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > extractorprocess.cpp:64 > { > Q_ASSERT(m_extractorProcess.state() == QProcess::Running); > Q_ASSERT(!fileIds.isEmpty()); This assert is just

D20938: Add Mounts Backend

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel,

D20938: Add Mounts Backend

bruns added a comment. Solid already has a working implementation for reading from /proc/mounts, the fstab backend. Contrary to this code, the fstab backend does not poll every second using a timer, but correctly uses /proc/mounts changes notification via blocking read. The only

D20924: [WIP] ViewConfig: Use new generic config interface

loh.tar updated this revision to Diff 57346. loh.tar edited the summary of this revision. loh.tar added a comment. - BookmarkSorting - AutoCenterLines - DefaultMarkType - PersistentSelection - InputMode - ViInputModeStealKeys - ViRelativeLineNumbers -

D20938: Add Mounts Backend

ivan added a comment. WRT implementation, I'd also add a link to KMountPoint (https://api.kde.org/frameworks/kio/html/classKMountPoint.html) which provides an interface to fstab/mtab so that Solid/FuseMounts plugin does not need to do any parsing by itself. It works with 'fuse.*'

D20938: Add Mounts Backend

svuorela added a comment. After reading the code a bit, I wonder - can't some of the parsing code be made testable (and tests added) - This likely also requires to get rid of the global static. - rather than poll /proc/mounts every second, I was wondering if one of the filesystem

D20939: Aztec: Fix padding if the last partial codeword is all one bits

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D20939 To: vkrause, svuorela, nicolasfella Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20938: Add Mounts Backend

ivan added a comment. @ngraham I guess that **is** the main point of this patch. I don't think that anyone is against that. :) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc:

D20938: Add Mounts Backend

ngraham added a comment. BTW I for one would really like FUSE mounts to show up in the Places panel. See for example https://bugs.kde.org/show_bug.cgi?id=404828 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio,

D20938: Add Mounts Backend

ivan added a comment. I'm torn between two approaches: - doing what you have done, maybe with a customization point - `fusermount -u` by default, something else for specific mount types; - disabling the teardown operation The rationale for the second one: - The users which

D20934: Rename file dialog "Filter" label text to "Type"

ngraham added a comment. Well, it's more complicated than that. It's a filter when it's a text field, but when saving, it can be a combobox for choosing a file type. So it should say "Filter:" when it's a text field, and "File Type:" when it's a combobox. REPOSITORY R241 KIO REVISION

D20942: Reorder includes

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH headers REVISION DETAIL https://phabricator.kde.org/D20942 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D20942: Reorder includes

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Reorder includes to make EBN happy REPOSITORY R286 KFileMetaData

D20938: Add Mounts Backend

hallas added a comment. In D20938#459076 , @ivan wrote: > Thanks for working on this. > > I'd probably call this `fusemounts` backend as it handles only FUSE mounts and nothing else. > > As for the //teardown// operation, some FUSE

D20827: Reword some text, a couple clean ups, add a separator

elvisangelaccio added a comment. In D20827#45 , @meven wrote: > In D20827#457391 , @elvisangelaccio wrote: > > > @meven FYI this change broke the Frameworks string freeze:

D20938: Add Mounts Backend

ivan added a comment. Thanks for working on this. I'd probably call this `fusemounts` backend as it handles only FUSE mounts and nothing else. As for the //teardown// operation, some FUSE backends (cryfs >0.10) have their own unmount commands instead of `fusermount -u`. REPOSITORY

D20934: Rename file dialog "Filter" label text to "Type"

GB_2 abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20934 To: GB_2, #frameworks, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio, #vdg, #plasma, kde-frameworks-devel, #frameworks, michaelh, ngraham, bruns

D20938: Add Mounts Backend

elvisangelaccio added reviewers: broulik, bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20940: [baloo_file] Wait for extractor process to start

apol added inline comments. INLINE COMMENTS > extractorprocess.cpp:47 > m_extractorProcess.start(); > +m_extractorProcess.waitForStarted(); > } Maybe this should be called in ::index then? This way we only block where it breaks. REPOSITORY R293 Baloo REVISION DETAIL

D20924: [WIP] ViewConfig: Use new generic config interface

loh.tar updated this revision to Diff 57323. loh.tar edited the summary of this revision. loh.tar added a comment. - Use the power of new the interface in DocumentPrivate::setViewVariable - ShowFoldingPreview - ShowLineModification - ShowFoldingBar CHANGES SINCE LAST UPDATE

D20934: Rename file dialog "Filter" label text to "Type"

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. "Filter" is the correct word, you can enter any string in the label (not necessarily a file type) and the view will be filtered accordingly. REPOSITORY R241

D20940: [baloo_file] Wait for extractor process to start

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When running baloo_file I hit the assert in

D20939: Aztec: Fix padding if the last partial codeword is all one bits

vkrause added reviewers: svuorela, nicolasfella. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D20939 To: vkrause, svuorela, nicolasfella Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20939: Aztec: Fix padding if the last partial codeword is all one bits

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Wikipedia says "after bit stuffing, the data string is padded to the next codeword boundary by appending 1 bits. If

D20938: Add Mounts Backend

hallas added a comment. This commit is still work-in-progress, but I would really like to get some feedback to the approach. Does it make sense to add a new backend? Or should this functionality be merged with one of the other backends (I was considering the fstab backend)? REPOSITORY

D20938: Add Mounts Backend

hallas created this revision. hallas added reviewers: Frameworks, ngraham, elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Adds a new devices backend providing information on Fuse

D20735: [KPropertiesDialog] Add octal permissions

pino requested changes to this revision. pino added a comment. Also, there was feedback it was still not taken care. Please do not ping on pathed when you are requested for changes, and still do not do them. INLINE COMMENTS > kpropertiesdialog.cpp:2111 > +mode_t itemPermission =

D20735: [KPropertiesDialog] Add octal permissions

shubham added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20735 To: shubham, ngraham, pino, #vdg Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20935: sonnet: provide override to force of a specific plugin

rjvbb created this revision. rjvbb added a reviewer: Frameworks. Herald added a project: Frameworks. rjvbb requested review of this revision. REVISION SUMMARY This provides an env.var-based mechanism to force the use of a specific spell checking plugin. A warning is printed when a plugin

D20924: [WIP] ViewConfig: Use new generic config interface

loh.tar updated this revision to Diff 57309. loh.tar edited the summary of this revision. loh.tar added a comment. - Use the power of new the interface in ViewPrivate::setConfigValue - Add missed finalizeConfigEntries() call - Add check to finalizeConfigEntries() for key to be unique -

D20934: Rename file dialog "Filter" label text to "Type"

GB_2 created this revision. GB_2 added reviewers: Frameworks, Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 79903 The term "Filter" is a bit strange for choosing a file type,

Deprecating KDEWebKit?

Hi, I have recently seen a several people in #kde-devel struggling with doing the recommended kdesrc-build based frameworks build due to kdewebkit failing. That's not really surprising as getting the necessary QtWebKit isn't actually trivial as it's no longer officially released, and

D20924: [WIP] ViewConfig: Use new generic config interface

loh.tar updated this revision to Diff 57300. loh.tar edited the summary of this revision. loh.tar added a comment. - Rebase on master - ShowScrollBarMiniMap - ShowScrollBarMiniMapAll - ScrollBarMiniMapWidth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20924?vs=57293=57300

D20924: [WIP] ViewConfig: Use new generic config interface

loh.tar added inline comments. INLINE COMMENTS > dhaumann wrote in kateconfig.h:964 > Are training commas allowed meanwhile? Yes. It's handy while still on work here, but can remove it when I'm done, if desired. Thanks for your look, pls do it again later. REVISION DETAIL

D20924: [WIP] ViewConfig: Use new generic config interface

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I read the diff carefully, please commit. INLINE COMMENTS > kateconfig.h:964 > +ShowScrollBarPreview, > +ShowWordCount, > }; Are training commas allowed