D15934: Add battery and bluetooth icons for other DE compatibility

2019-05-10 Thread Noah Davis
ndavis abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D21135: Allow to work with phone book and call history.

2019-05-10 Thread Stanislav Ageev
sageev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sageev requested review of this revision. REVISION SUMMARY This change allow to get contact and call history from phone. REPOSITORY R269 BluezQt REVISION DETAIL

D21133: Fix KAr::openArchive with older Qt

2019-05-10 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D21133 To: aacid, apol, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » karchive » kf5-qt5 SUSEQt5.10 - Build # 43 - Fixed!

2019-05-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 10 May 2019 20:04:21 + Build duration: 2 min 4 sec and counting BUILD ARTIFACTS

D21133: Fix KAr::openArchive with older Qt

2019-05-10 Thread David Faure
dfaure accepted this revision. dfaure added a comment. (if this was performance critical, the trimmed() shouldn't be done with recent Qt, but meh) REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21133 To: aacid, apol, dfaure Cc: dfaure,

D21133: Fix KAr::openArchive with older Qt

2019-05-10 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21133 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21133: Fix KAr::openArchive with older Qt

2019-05-10 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY It seems older Qt don't like converting QByteArray("33 ").toInt() so call trimmed before calling toInt REPOSITORY

D18933: Allow compositors to send discrete axis values

2019-05-10 Thread Vlad Zagorodniy
zzag updated this revision to Diff 57883. zzag added a comment. Small cleanup. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18933?vs=57882=57883 BRANCH pointer-axis-value-discrete REVISION DETAIL https://phabricator.kde.org/D18933 AFFECTED FILES

D18933: Allow compositors to send discrete axis values

2019-05-10 Thread Vlad Zagorodniy
zzag updated this revision to Diff 57882. zzag added a comment. @since 5.XX becomes @since 5.59 REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18933?vs=51659=57882 BRANCH pointer-axis-value-discrete REVISION DETAIL https://phabricator.kde.org/D18933

D21127: [KDynamicJobTracker] Ask kuiserver asynchronously

2019-05-10 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdynamicjobtracker.cpp:165 > if (kuiserverTracker) { > kuiserverTracker->unregisterJob(job); > } This would fail if the registerJob didn't

D18933: Allow compositors to send discrete axis values

2019-05-10 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH pointer-axis-value-discrete REVISION DETAIL https://phabricator.kde.org/D18933 To: zzag, #kwin, davidedmundson Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh,

D21126: [KUiServerJobTracker] Register jobs asynchronously

2019-05-10 Thread Kai Uwe Broulik
broulik updated this revision to Diff 57864. broulik added a comment. - When reply comes in after job already finished, call terminate on the jobview to end it gracefully REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21126?vs=57862=57864 REVISION

D21126: [KUiServerJobTracker] Register jobs asynchronously

2019-05-10 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. However now it obviously misses the first calls to set message and what not because the job view doesn't yet exist there... REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D21126 To: broulik,

D21127: [KDynamicJobTracker] Ask kuiserver asynchronously

2019-05-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is only a fallback option so it shouldn't jeopardize

D21126: [KUiServerJobTracker] Register jobs asynchronously

2019-05-10 Thread Kai Uwe Broulik
broulik edited the summary of this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D21126 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

2019-05-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Don't block waiting for the server to register the job,

D21119: [JobDialog] Also signal cancellation when window is closed by the user

2019-05-10 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D21119 To: broulik, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21119: [JobDialog] Also signal cancellation when window is closed by the user

2019-05-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This signal is emitted when the user tries to close the window manually, not

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

2019-05-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Now the notification KCM opens at a saner size The grid view kcms with a wider

D20958: New menu of syntax highlighting in the status bar

2019-05-10 Thread Nibaldo González
nibags updated this revision to Diff 57841. nibags added a comment. - Fixes the menu alignment of the previous update REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20958?vs=57819=57841 BRANCH new-mode-menu REVISION DETAIL

D20169: Add profile support interface for TerminalInterface

2019-05-10 Thread Maximilian Schiller
mschiller added a comment. Ping REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, michaelh, ngraham, bruns

KDE CI: Frameworks » karchive » kf5-qt5 SUSEQt5.10 - Build # 42 - Unstable!

2019-05-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.10/42/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 10 May 2019 07:03:12 + Build duration: 2 min 37 sec and counting BUILD ARTIFACTS

D21109: Fix KAr

2019-05-10 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R243:79446284aec2: Fix KAr (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21109?vs=57825=57838 REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

2019-05-10 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > meven wrote in renamefiledialog.h:5 > We can email Peter Penz to ask about doing a license change. > > I wish we would ask its contributors to allow the kde foundation to update > code distribution license on their behalf, provided the license