D21146: KProcessInfoList -- add proclist backend for FreeBSD

2019-05-11 Thread Pino Toscano 
pino added a comment.


  What about create a separate kprocesslist_libprocstat.cpp (or so) to 
implement `KProcessList::processInfoList()` using libprocstat, instead of 
overloading the existing kprocesslist_unix.cpp?
  
  Also, please adjust the coding style to the kdelibs coding style: 
https://community.kde.org/Policies/Kdelibs_Coding_Style
  In addition to that, IMHO you can simplify all the various statements like
  
type foo;
foo = ...;
  
  to
  
type foo = ...;

INLINE COMMENTS

> kprocesslist_unix.cpp:170-172
> +#ifdef HAVE_PROCSTAT
> +return unixProcessListKinfoProcStat();
> +#endif

this makes the rest of the function as unreachable code, and compilers might 
warn about that

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

2019-05-11 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> kprocesslist_unix.cpp:59
>  
> +KProcessInfoList unixProcessListKinfoProcStat()
> +{

doesn't that also need `#if HAVE_PROCSTAT`?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

2019-05-11 Thread Tobias C. Berner 
tcberner updated this revision to Diff 57915.
tcberner added a comment.


  Remove commented line.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21146?vs=57913&id=57915

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/config-kprocesslist.h.cmake
  src/lib/util/kprocesslist_unix.cpp

To: tcberner, #freebsd, adridg, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

2019-05-11 Thread Tobias C. Berner 
tcberner added inline comments.

INLINE COMMENTS

> FindProcstat.cmake:18
> +#documentation and/or other materials provided with the distribution.
> +# 3. Neither the name of the University nor the names of its contributors
> +#may be used to endorse or promote products derived from this software

^ that should probably be 2-clause...

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

2019-05-11 Thread Tobias C. Berner 
tcberner created this revision.
tcberner added reviewers: FreeBSD, adridg, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tcberner requested review of this revision.

REVISION SUMMARY
  This adds
  
  - unixProcessListKinfoProcStat() to KProcessInfoList to query process info 
via FreeBSD's procstat library
  - FindProcstat.cmake and config-kprocesslist.h.cmake to handle finding and 
using it
  
  - Additionally, the ps-argument in unixProcessListPS was changed to 
'commmand' form 'cmd' for FreeBSD.
  
  - Todo: make it nicer :)
  
  See D20007 

TEST PLAN
Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 198ms
* Finished testing of KProcessListTest *

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/config-kprocesslist.h.cmake
  src/lib/util/kprocesslist_unix.cpp

To: tcberner, #freebsd, adridg, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20958: New menu of syntax highlighting in the status bar

2019-05-11 Thread Nibaldo González 
nibags added a comment.


  Now it's OK

REPOSITORY
  R39 KTextEditor

BRANCH
  new-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D20958: New menu of syntax highlighting in the status bar

2019-05-11 Thread Nibaldo González 
nibags closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D20708: Change input-* device icon styles, add 16px icons

2019-05-11 Thread Noah Davis 
ndavis added a comment.


  In D20708#454298 , @ngraham wrote:
  
  > Even if only Inkscape currently uses the icon, as a rule we ignore that 
kind of information for code/content in Frameworks, because //in principle// 
any app could use it. It's more important for the icon to be semantically 
correct for any app that  wants to use it than it is for it to match its 
current sole user.
  >
  > For `dialog-input-devices`, I would accept an icon that //includes// a 
drawing tablet, but not one that has //only// a drawing tablet.
  
  
  How is this? 16px F6819133: Screenshot_20190511_114329.png 

  
  I tried making the mouse bigger, but it didn't work out very well since there 
was never quite enough room to make it feel balanced.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

2019-05-11 Thread Noah Davis 
ndavis added a comment.


  In D20140#458379 , @filipf wrote:
  
  > Which still leaves you with fixing the gaps when there's not thumbnail. I'd 
suggest to do:
  >
  > `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2`
  >
  > and call it a day :P
  >
  > F6800961: image.png 
  
  
  Unfortuantely, that still leaves small white corners on the thumbnails that 
don't take up the entire area. F6819109: Screenshot_20190511_13.png 

  
  I still don't t

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20958: New menu of syntax highlighting in the status bar

2019-05-11 Thread Nibaldo González 
nibags updated this revision to Diff 57905.
nibags added a comment.


  - Add delimiters « »

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20958?vs=57841&id=57905

BRANCH
  new-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D20958

AFFECTED FILES
  src/CMakeLists.txt
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp
  src/view/katestatusbar.cpp
  src/view/kateview.h

To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

2019-05-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/32/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 11 May 2019 10:12:00 +
 Build duration:
1 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

2019-05-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/31/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 11 May 2019 10:01:15 +
 Build duration:
1 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D17991: Refactor the way device backends are built and registered

2019-05-11 Thread Pino Toscano 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:97d95e3171c3: Refactor the way device backends are built 
and registered (authored by pino).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17991?vs=55373&id=57898#toc

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17991?vs=55373&id=57898

REVISION DETAIL
  https://phabricator.kde.org/D17991

AFFECTED FILES
  CMakeLists.txt
  cmake/SolidBackendsMacros.cmake
  src/solid/devices/CMakeLists.txt
  src/solid/devices/backends/fakehw/CMakeLists.txt
  src/solid/devices/backends/fstab/CMakeLists.txt
  src/solid/devices/backends/hal/CMakeLists.txt
  src/solid/devices/backends/iokit/CMakeLists.txt
  src/solid/devices/backends/udev/CMakeLists.txt
  src/solid/devices/backends/udisks2/CMakeLists.txt
  src/solid/devices/backends/upower/CMakeLists.txt
  src/solid/devices/backends/win/CMakeLists.txt
  src/solid/devices/managerbase.cpp

To: pino
Cc: #android, #windows, #freebsd, apol, kde-frameworks-devel, michaelh, 
ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-11 Thread Elvis Angelaccio 
elvisangelaccio added inline comments.

INLINE COMMENTS

> kfilewidgettest.cpp:38
> +#include 
> +#include 
> +

Unused?

> kfilewidgettest.cpp:407-413
> +QDir f(tempDir.filePath(dir));
> +
> +KFileWidget fw(QUrl::fromLocalFile(tempDir.path()));
> +fw.setOperationMode(KFileWidget::Opening);
> +fw.setMode(KFile::File);
> +fw.show();
> +fw.activateWindow();

Please use descriptive variable names instead of `f` and `fw`

> kfilewidgettest.cpp:415
> +
> +QList list_urls = {fileUrl};
> +QMimeData *mimeData = new QMimeData();

Missing camelCase

> kdiroperator.cpp:1404-1405
> +
> +QMimeDatabase md;
> +QMimeType mt = md.mimeTypeForUrl(url);
> +

Please use descriptive variable names also here.

> kdiroperator.cpp:1407
> +
> +QRegExp r;
> +r.setPatternSyntax(QRegExp::Wildcard);   // the "mimetype" 
> can be "image/*"

QRegExp should be avoid in new code, can you try to use QRegularExpression 
instead?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20838_1

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham, #frameworks
Cc: elvisangelaccio, apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 102 - Still Unstable!

2019-05-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/102/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 11 May 2019 07:50:30 +
 Build duration:
8 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

2019-05-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/30/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 11 May 2019 07:50:44 +
 Build duration:
2 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest