D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

2019-05-13 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 58040.
kossebau added a comment.


  Be verbose about behavioural adaption in API dox

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21174?vs=57963=58040

BRANCH
  makehaselementprefixmatchexpectation

REVISION DETAIL
  https://phabricator.kde.org/D21174

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/framesvg.h

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/101/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 13 May 2019 22:09:34 +
 Build duration:
4 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3505)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 94 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/94/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 13 May 2019 22:02:04 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13369)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3505)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%

D21201: FrameSvgItem: emit maskChanged also from geometryChanged()

2019-05-13 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Needed e.g. to fix the missing update of the mask on changing the size of
  the Plasma panel if only listening to mask changes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  emitmaskchangedalsoonsizechange

REVISION DETAIL
  https://phabricator.kde.org/D21201

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 100 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/100/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 13 May 2019 21:50:12 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3638/13370)18%
(1824/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3505)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(689/1579)29%
(304/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 93 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/93/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 13 May 2019 21:50:12 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3505)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 104 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/104/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 13 May 2019 21:52:47 +
 Build duration:
3 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21200: FrameSvg: prevent crash when calling mask() with no frame yet created

2019-05-13 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  donotcrashformask

REVISION DETAIL
  https://phabricator.kde.org/D21200

AFFECTED FILES
  src/plasma/framesvg.cpp

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

2019-05-13 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9142155b5a5b: API dox: note for 
FrameSvg::prefix()/actualPrefix() the trailing - (authored by 
kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21173?vs=58006=58036

REVISION DETAIL
  https://phabricator.kde.org/D21173

AFFECTED FILES
  src/plasma/framesvg.h

To: kossebau, #plasma, dhaumann
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21179: FrameSvgItem: emit maskChanged always from doUpdate()

2019-05-13 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:084ba0f886d1: FrameSvgItem: emit maskChanged always from 
doUpdate() (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21179?vs=57973=58037

REVISION DETAIL
  https://phabricator.kde.org/D21179

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 103 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/103/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 13 May 2019 21:50:13 +
 Build duration:
2 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21146: KProcessInfoList -- add proclist backend for FreeBSD

2019-05-13 Thread Pino Toscano 
pino added a comment.


  In D21146#463948 , @tcberner wrote:
  
  > Gargh, the code `kdelibs` code formatter changed a lot more in 
`kprocesslist_unix_proc.cpp` than wanted :/
  
  
  Then just rename kprocesslist_unix.cpp to kprocesslist_unix_proc.cpp, with no 
further changes.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

2019-05-13 Thread Adriaan de Groot 
adridg added inline comments.

INLINE COMMENTS

> kprocesslist_unix_proc.cpp:56
>  #else
> +#  ifdef Q_OS_FREEBSD
> +static const char formatC[] = "pid,state,user,command";

Are there situations where you would end up here? I mean, libprocstat is in 
base, since 9.0, so it is unlikely to be gone at any point.

> kprocesslist_unix_procstat.cpp:38
> +struct procstat *pstat;
> +pstat = procstat_open_sysctl();
> +

I absolutely have Opinions on C++ style that apply here, so I'm going to talk 
to Tobias elsewhere.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21197: [KCoreDirLister] Remove assert in reinsert method

2019-05-13 Thread Chinmoy Ranjan Pradhan 
chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Here I am trying to fix #405461. We reach this assertion in reinsert() after 
we create a new folder
  in kfilewidget. The code path is triggered by the signal KDirWatch::created 
which is then followed
  by itemsAddedInDirectory(), updateDirectory(), processPendingUpdates() and 
then reinsert().
  
  Now there are two issues with reinsert(). First it asserts that 
DirItem::lstItems (list of KItems)
  must contain a KItem whose url is lexicographically greater than the oldUrl 
we are trying to update.
  But when creating folders from kfilewidget it is almost always not true. In 
fact after creating a
  new folder it is empty.
  
  Other issue is with the behaviour of reinsert(). In case the exact KItem for 
oldUrl doesn't exist,
  it replaces the first greater KItem with the new one. From this method's 
description and from what I
  have observed so far this behaviours is incorrect. So removing the assertion 
seems to be an appropriate 
  way to fix the bug.
  
  PS: Following the code has been difficult so I might have missed a place where
  placing an extra updateDirectory() call would have fixed the issue or I might 
be talking nonsense here.
  Please correct me if this is the case.
  
  BUG: 405461

REPOSITORY
  R241 KIO

BRANCH
  kcoredirlister

REVISION DETAIL
  https://phabricator.kde.org/D21197

AFFECTED FILES
  src/core/kcoredirlister_p.h

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21155: Truncate long filname before creating a link

2019-05-13 Thread Nathaniel Graham 
ngraham accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21155

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

2019-05-13 Thread Nathaniel Graham 
ngraham added a comment.


  In D20140#463834 , @ndavis wrote:
  
  > In D20140#458379 , @filipf wrote:
  >
  > > Which still leaves you with fixing the gaps when there's not thumbnail. 
I'd suggest to do:
  > >
  > > `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2`
  > >
  > > and call it a day :P
  > >
  > > F6800961: image.png 
  >
  >
  > Unfortuantely, that still leaves small white corners on the thumbnails that 
don't take up the entire area.
  >
  > F6819113: Screenshot_20190511_111410.png 

  
  
  In practice, the thumbnail delegates are much smaller; is anyone gonna notice 
that (famous last words)?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

2019-05-13 Thread Nathaniel Graham 
ngraham added a comment.


  I think that looks good!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-13 Thread Nathaniel Graham 
ngraham added a comment.


  the icon theme can be considered to be VDG-maintained these days, andI think 
this passes the visual design test, but also the most important thing is that 
you as the app author like it!
  
  However if this is the actual icon you want to ship with the app, do we even 
need it to be in the breeze-icons framework? If it's the exact same icon, and 
you're going to ship it in your app's packaging/bundle anyway, I'm wondering 
what the value is.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, michaelh, bruns

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

2019-05-13 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D21149

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21149: KAr::openArchive: Protect against Heap-buffer-overflow in broken files

2019-05-13 Thread Albert Astals Cid 
aacid added a comment.


  it's not a hot path since no one is using this since this didn't work until i 
fixed it last week. So basically this is just for fun/sport

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21149

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-13 Thread Eike Hein 
hein added a comment.


  I'd say it's up to the Breeze maintainers. From my end I'm very interested in 
the app having a Breeze-compatible icon, because I'd like it to integrate well 
with KDE's workspaces and other apps. Review by the Breeze community is very 
appreciated to help with that. Application code needs to ship the icon anyway 
though for systems that don't have the theme and can't be reasonably expected 
to provide every app icon, so it's not vital to be included with the theme.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, michaelh, bruns

D21179: FrameSvgItem: emit maskChanged always from doUpdate()

2019-05-13 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  framesvgitemmoreemitmaskchanged

REVISION DETAIL
  https://phabricator.kde.org/D21179

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

2019-05-13 Thread Dominik Haumann 
dhaumann added a comment.


  Yes, please ask Peter Penz and CC a public mailing list and/or use the 
relicense check script. I am sure Peter would agree to a license change.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: ngraham, #frameworks, #dolphin, broulik
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, michaelh, 
ngraham

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

2019-05-13 Thread Dominik Haumann 
dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixdoxofprefix

REVISION DETAIL
  https://phabricator.kde.org/D21173

To: kossebau, #plasma, dhaumann
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-05-13 Thread Dominik Haumann 
dhaumann added a comment.


  @hindenburg: lgtm, could you comment?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

2019-05-13 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> kossebau wrote in framesvg.cpp:150
> But given the return, if the else needed? Actually some people recommend to 
> not use else after return. I might be Monday blind, sorry :)

I guess it doesn't matter. :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21174

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

2019-05-13 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 LGTM

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21174

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

2019-05-13 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 58006.
kossebau added a comment.


  appended -> at the end

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21173?vs=57961=58006

BRANCH
  fixdoxofprefix

REVISION DETAIL
  https://phabricator.kde.org/D21173

AFFECTED FILES
  src/plasma/framesvg.h

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

2019-05-13 Thread Friedrich W. H. Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> apol wrote in framesvg.cpp:150
>   if (prefix.endsWith(QLatin1Char('-'))) {
>   return hasElement(prefix % QLatin1String("center"));
>   } else
>   return hasElement(prefix % QLatin1String("-center"));

But given the return, if the else needed? Actually some people recommend to not 
use else after return. I might be Monday blind, sorry :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21174

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

2019-05-13 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> kossebau wrote in framesvg.cpp:150
> How would you use the `else`? Not yet with you what you mean here,

if (prefix.endsWith(QLatin1Char('-'))) {
  return hasElement(prefix % QLatin1String("center"));
  } else
  return hasElement(prefix % QLatin1String("-center"));

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21174

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-13 Thread Nathaniel Graham 
ngraham added a comment.


  In D21169#464291 , @apol wrote:
  
  > Let's add it when the application exists?
  
  
  We should do it beforehand so the app gets the proper Breeze icon on launch 
day.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ngraham, apol, kde-frameworks-devel, hein, michaelh, bruns

D21169: Add app icon for the Kirogi Drone control app

2019-05-13 Thread Eike Hein 
hein added a comment.


  @trickyricky26 It's great! What do you think about adding the detailed SVG as 
256 version?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: apol, kde-frameworks-devel, hein, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

2019-05-13 Thread Friedrich W. H. Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> apol wrote in framesvg.cpp:150
> else? or we want to test --center if -center fails?

How would you use the `else`? Not yet with you what you mean here,

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21174

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21183: search in the new location for knsrc files

2019-05-13 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R252:e0df1f28231c: search in the new location for knsrc files 
(authored by mart).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21183?vs=57997=58001

REVISION DETAIL
  https://phabricator.kde.org/D21183

AFFECTED FILES
  src/kpackage-install-handlers/kns/main.cpp

To: mart, #plasma, leinir
Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-13 Thread Méven Car 
meven updated this revision to Diff 58000.
meven added a comment.


  Review, removed a dead variable in test, use QRegularExpression

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57707=58000

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham, #frameworks
Cc: elvisangelaccio, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-13 Thread Méven Car 
meven marked 8 inline comments as done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham, #frameworks
Cc: elvisangelaccio, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21183: search in the new location for knsrc files

2019-05-13 Thread Dan Leinir Turthra Jensen 
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  In the words of the interwebs whenever someone days a certain number: nice :)

REPOSITORY
  R252 Framework Integration

BRANCH
  phab/newlocation

REVISION DETAIL
  https://phabricator.kde.org/D21183

To: mart, #plasma, leinir
Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns

D21183: search in the new location for knsrc files

2019-05-13 Thread Marco Martin 
mart updated this revision to Diff 57997.
mart added a comment.


  use configSearchLocations

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21183?vs=57993=57997

BRANCH
  phab/newlocation

REVISION DETAIL
  https://phabricator.kde.org/D21183

AFFECTED FILES
  src/kpackage-install-handlers/kns/main.cpp

To: mart, #plasma, leinir
Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns

D21183: search in the new location for knsrc files

2019-05-13 Thread Dan Leinir Turthra Jensen 
leinir requested changes to this revision.
leinir added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:49
>  
> -const auto knsname = 
> QStandardPaths::locate(QStandardPaths::GenericConfigLocation, url.host());
> +auto knsname = 
> QStandardPaths::locate(QStandardPaths::GenericDataLocation, 
> QStringLiteral("knsrcfiles/") + url.host());
> +if (knsname.isEmpty()) {

Since frameworkintegration requires KNewStuff (and Frameworks 5.58), i'd 
probably suggest using the static function in KNewStuffCore::Engine which gives 
you this information without having to do manual heuristic type stuff :)

static QStringList Engine::configSearchLocations(bool includeFallbackLocations 
= false):
https://api.kde.org/frameworks/knewstuff/html/classKNSCore_1_1Engine.html#a030b62a72c0c486939461983e225bb49

> main.cpp:116
>  // qDebug() << "checking..." << entry.status() << entry.providerId();
> -if (providerid != QUrl(entry.providerId()).host()) {
> +if (0& != QUrl(entry.providerId()).host()) {
>  qWarning() << "Wrong provider" << providerid << "instead of" << 
> QUrl(entry.providerId()).host();

Did you mean to leave this in?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D21183

To: mart, #plasma, leinir
Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

2019-05-13 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> framesvg.cpp:150
> +return hasElement(prefix % QLatin1String("center"));
> +}
> +

else? or we want to test --center if -center fails?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21174

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21173: API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'

2019-05-13 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> framesvg.h:230
>  /**
> - * Returns the prefix for SVG elements of the FrameSvg
> + * Returns the prefix for SVG elements of the FrameSvg (including the 
> appended '-' if not empty)
>   * @return the prefix

"appended" reads weird.

How about `including a '-' at the end if not empty`?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21173

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

2019-05-13 Thread Kai Uwe Broulik 
broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/kcmutils.git/commit/?id=0af14cfe4dc55c6dcc6680b367fd78d2cf79b37d

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D21115

To: broulik, #plasma, mart
Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham, bruns

D21183: search in the new location for knsrc files

2019-05-13 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  search in the new knsrc location, still fallback to the old one for
  compatibility

TEST PLAN
  tested with files in both locations

REPOSITORY
  R252 Framework Integration

BRANCH
  phab/newlocation

REVISION DETAIL
  https://phabricator.kde.org/D21183

AFFECTED FILES
  src/kpackage-install-handlers/kns/main.cpp

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

2019-05-13 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D21115

To: broulik, #plasma, mart
Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/99/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 13 May 2019 09:25:48 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3505)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 92 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/92/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 13 May 2019 09:25:48 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3505)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 102 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/102/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 13 May 2019 09:25:48 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 91 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/91/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 13 May 2019 08:55:32 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3505)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 98 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/98/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 13 May 2019 08:55:31 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3505)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 101 - Still Unstable!

2019-05-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/101/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 13 May 2019 08:55:31 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21172: FrameSvg: also clear mask cache on clearCache()

2019-05-13 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  clearalsomaskcache

REVISION DETAIL
  https://phabricator.kde.org/D21172

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20958: New menu of syntax highlighting in the status bar

2019-05-13 Thread Dominik Haumann 
dhaumann added a comment.


  Btw, I think this is a really nice improvement! Keep it coming :-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D21119: [JobDialog] Also signal cancellation when window is closed by the user

2019-05-13 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R495:b70018ee4b3e: [JobDialog] Also signal cancellation when 
window is closed by the user (authored by broulik).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21119?vs=57849=57980

REVISION DETAIL
  https://phabricator.kde.org/D21119

AFFECTED FILES
  src/widgets/JobDialog.qml

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21179: FrameSvgItem: emit maskChanged always from doUpdate()

2019-05-13 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  In that method we can assue a high chance that the mask is also affected.
  Instead of adding complicated additional code to track if the mask
  really changed, we rely on the cached value from FrameSvg.
  This method is not too often called in a Plasma session, so that
  further optimization work to avoid unneccesary emits seems not yet
  worth it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  framesvgitemmoreemitmaskchanged

REVISION DETAIL
  https://phabricator.kde.org/D21179

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns