anthonyfieroni added inline comments.
INLINE COMMENTS
> kioslave.cpp:132
> +const int newArgc = argc - 1;
> +char ** newArgv = new char*[newArgc];
> +newArgv[0] = argv[0];
Now has a leak, use vector instead.
REPOSITORY
R241 KIO
BRANCH
2019_freebsd_fixed
REVISION DETAIL
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LTGM
REPOSITORY
R241 KIO
BRANCH
2019_freebsd_fixed
REVISION DETAIL
https://phabricator.kde.org/D21280
To: dfaure, sitter, davidedmundson, apol, adridg
Cc: kde-frameworks-devel,
dfaure created this revision.
dfaure added reviewers: sitter, davidedmundson, apol, adridg.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
Linux has /proc so it doesn't matter there, but e.g. on
dfaure added inline comments.
INLINE COMMENTS
> org.kde.kded5.desktop:4
> +#it's here mostly so wayland can get an icon on popups
> +Type=SystemService
> +Icon=kde-frameworks
What does SystemService mean?
I'm seeing a warning from the kservice framework:
The desktop entry file
dhaumann added a comment.
I think this change introduces a regression: This code does not check for
"view->config()->autoBrackets()", so it's *ALWAYS* active, which I do not want.
Consider this:
if (bla |) { ... }
Now you type && foo(), the result is then:
if (bla && foo()
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/96/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Sat, 18 May 2019 16:13:26 +
Build duration:
22 min and counting
BUILD ARTIFACTS
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/109/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Sat, 18 May 2019 16:13:26 +
Build duration:
8 min 9 sec and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/106/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Sat, 18 May 2019 16:13:26 +
Build duration:
7 min 29 sec and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20WindowsMSVCQt5.11/75/
Project:
kf5-qt5 WindowsMSVCQt5.11
Date of build:
Sat, 18 May 2019 14:21:15 +
Build duration:
2 min 34 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.10/51/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Sat, 18 May 2019 12:15:30 +
Build duration:
2 min 52 sec and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.10/50/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Sat, 18 May 2019 11:51:20 +
Build duration:
2 min 10 sec and counting
BUILD ARTIFACTS
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20FreeBSDQt5.12/49/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Sat, 18 May 2019 11:51:20 +
Build duration:
49 sec and counting
JUnit Tests
Name: projectroot
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.10/49/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Sat, 18 May 2019 10:11:24 +
Build duration:
2 min 19 sec and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20FreeBSDQt5.12/48/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Sat, 18 May 2019 10:11:24 +
Build duration:
54 sec and counting
JUnit Tests
Name:
steffenh updated this revision to Diff 58241.
steffenh added a comment.
change name to KTouchGesture
add a private class for every exported class
remove unused code
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21028?vs=57584=58241
BRANCH
dfaure added a comment.
Can you look into adding a unittest for the case that hits the assert? As you
say, this code isn't easy... but the unittest is quite comprehensive (although
never enough, as proven by this).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D21197
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/108/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Sat, 18 May 2019 08:54:31 +
Build duration:
16 min and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/95/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Sat, 18 May 2019 08:54:31 +
Build duration:
10 min and counting
BUILD ARTIFACTS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/105/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Sat, 18 May 2019 08:54:31 +
Build duration:
7 min 43 sec and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
meven marked an inline comment as done.
Closed by commit R241:25eb17ffa666: Allow to drop one file or one folder on
KDirOperator (authored by meven).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/28/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Sat, 18 May 2019 07:32:01 +
Build duration:
2 min 54 sec and counting
JUnit Tests
meven marked 2 inline comments as done.
meven added inline comments.
INLINE COMMENTS
> ngraham wrote in fstabhandling.cpp:136
> So this situation could never happen with FUSE mounts? Or should that case be
> checked too.
Good point, I haven't thought much about this case.
> bruns wrote in
meven marked 2 inline comments as done.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, michaelh
meven updated this revision to Diff 58237.
meven added a comment.
Shorten comment line, ensure fuse mount do not end with / either
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21204?vs=58190=58237
BRANCH
arcpatch-D21204
REVISION DETAIL
24 matches
Mail list logo
