D21313: Create specific directory for kdebugsettings categories file

2019-05-20 Thread Luca Beltrame
lbeltrame removed a subscriber: cgiboudeaux. lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

2019-05-20 Thread Luca Beltrame
lbeltrame added a subscriber: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

2019-05-20 Thread Laurent Montel
mlaurent added a reviewer: dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

2019-05-20 Thread Laurent Montel
mlaurent created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY kdebugsettings categories files REPOSITORY R240 Extra CMake Modules BRANCH

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 113 - Still Unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/113/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 21 May 2019 04:04:16 + Build duration: 42 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 103 - Unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/103/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 May 2019 04:04:17 + Build duration: 39 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 112 - Still Unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/112/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 20 May 2019 21:57:35 + Build duration: 8 min 19 sec and counting JUnit Tests Name:

T8349: Improve Places panel usability and presentation

2019-05-20 Thread Nathaniel Graham
ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, cblack, arvidhansson, ian, jguidon, hannahk, Ghost6, jraleigh, squeakypancakes, alexde,

D16852: Add Documents to the default list of Places

2019-05-20 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1208a51e9abf: Add Documents to the default list of Places (authored by acrouthamel, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D16852: Add Documents to the default list of Places

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. With the addition of the Tags section, there's already a scrollbar, so there's no harm in doing this. REPOSITORY R241 KIO BRANCH add-documents (branched from master) REVISION DETAIL https://phabricator.kde.org/D16852 To: acrouthamel, #frameworks, #dolphin,

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. I was working on this myself last month by implementing new modes that are an amalgamation of existing settings, so nobody gets broken and backwards compatibility is ensured. I gotpretty far, but I hit a frustrating wall and forgot about it. :/ Your work here

D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Adriaan de Groot
adridg abandoned this revision. adridg added a comment. Thanks for looking at this, Harald. For various downstream packaging reasons, we're going to be stuck with patching, so I'm going to give up on this particular patch. REPOSITORY R244 KCoreAddons REVISION DETAIL

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven added a comment. This patch seems to me now inappropriate given the history of D12358 and D12326 . I only see a possibility in having Icons View and Compact view as Dolphin has without changing behavior and

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. Ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

T8349: Improve Places panel usability and presentation

2019-05-20 Thread Nathaniel Graham
ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, cblack, arvidhansson, ian, jguidon, hannahk, Ghost6, jraleigh, squeakypancakes, alexde,

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham
shubham updated this revision to Diff 58369. shubham added a comment. - REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20626?vs=58354=58369 BRANCH sysinfo REVISION DETAIL https://phabricator.kde.org/D20626 AFFECTED FILES src/kcms/kio/useragentinfo.cpp

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham
shubham added a comment. @dfaure Would you mind commiting it, I think I just messes up my ssh keys REPOSITORY R241 KIO BRANCH arcpatch-D20626 REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread David Faure
dfaure added a comment. Thanks. You can land the commit. REPOSITORY R241 KIO BRANCH arcpatch-D20626 REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19367: SearchBar: Don't block GUI when enter incremental pattern

2019-05-20 Thread Christoph Cullmann
cullmann added a comment. Simple tests with an 12 million lines document (COPYING.LIB concated "a lot") show compare to the current approach usable behavior. You start to type some word not in the document, it won't free for 10 seconds, it will just search in the background like it should.

D20959: Allow to change the Mode, after changing the Highlighting

2019-05-20 Thread Christoph Cullmann
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hi, could this lead to the following regression: https://bugs.kde.org/show_bug.cgi?id=407763 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20959

D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Harald Sitter
sitter added a comment. I do wonder if we couldn't just move the freebsd path to the end of the list and drop the ifdef. As far as linux is concerned we still obey the lookup order but simply have an additional path where we may look (and where the file should not ever exist on linux).

D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Adriaan de Groot
adridg edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21305 To: adridg, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Adriaan de Groot
adridg edited the test plan for this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21305 To: adridg, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Adriaan de Groot
adridg created this revision. adridg added a reviewer: sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. adridg requested review of this revision. REVISION SUMMARY - After much hemming and hawing we ended up with /usr/local/etc/os-release, which isn't

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham
shubham updated this revision to Diff 58354. shubham edited the summary of this revision. shubham added a comment. proper rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20626?vs=58351=58354 BRANCH arcpatch-D20626 REVISION DETAIL

D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham
shubham retitled this revision from "Refactor and cleanup" to "Rely upon QSysInfo to retrieve the system details". shubham edited the summary of this revision. shubham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20626 REVISION DETAIL

D20626: Refactor and cleanup

2019-05-20 Thread Shubham
shubham updated this revision to Diff 58351. shubham edited the summary of this revision. shubham edited the test plan for this revision. shubham added a comment. Rely upon QSysInfo to retrieve the system details REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D21299: examples: move codeeditor also in own subdir

2019-05-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e3a7922ae842: examples: move codeeditor also in own subdir (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21299?vs=58330=58349#toc REPOSITORY R216 Syntax

D21299: examples: move codeeditor also in own subdir

2019-05-20 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks! I was about to propose this for consistency as well, please go ahead. REPOSITORY R216 Syntax Highlighting BRANCH haveonesubdirperexample REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 114 - Fixed!

2019-05-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/114/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 20 May 2019 10:46:03 + Build duration: 24 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 282 - Fixed!

2019-05-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/282/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 20 May 2019 10:45:27 + Build duration: 10 min and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 101 - Fixed!

2019-05-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/101/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 20 May 2019 10:46:02 + Build duration: 8 min 38 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 111 - Still unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/111/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 20 May 2019 10:45:32 + Build duration: 7 min 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 113 - Failure!

2019-05-20 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/113/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 20 May 2019 10:36:01 + Build duration: 6 min 43 sec and counting CONSOLE OUTPUT Started by an SCM

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 100 - Failure!

2019-05-20 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/100/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 20 May 2019 10:36:01 + Build duration: 6 min 43 sec and counting CONSOLE OUTPUT Started by an SCM

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 110 - Failure!

2019-05-20 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown":

D21300: KIO: port away from QSslSocket+QFileInfo deprecated API

2019-05-20 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21300 To: dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 281 - Failure!

2019-05-20 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown":

D21300: KIO: port away from QSslSocket+QFileInfo deprecated API

2019-05-20 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 2019_deprecated_API REVISION DETAIL https://phabricator.kde.org/D21300 To: dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21249: Test current filter before setting a new one

2019-05-20 Thread Jan-Marek Glogowski
jglogowski updated this revision to Diff 58345. jglogowski added a comment. - Merge test/kfilewidgettest_filter.cpp into autotests/kfilewidgettest.cpp - Swap QCOMPARE parameters to match actual + expected output on failure - Always test filter and file name Technically the '*' filter

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58337. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58336=58337 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283 AFFECTED FILES

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21283 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58336. meven added a comment. Keep DetailTree as default file view REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58334=58336 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58334. meven added a comment. Extract KDirOperatorIconView to its own class REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58333=58334 BRANCH icon-compact-views REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 109 - Still Unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/109/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 20 May 2019 07:52:16 + Build duration: 1 hr 16 min and counting JUnit Tests Name:

D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

2019-05-20 Thread David Faure
dfaure added a comment. Good question. It seems to me that return would indeed be much better so that the stack gets unwinded... I'll make the change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21280 To: dfaure, sitter, davidedmundson, apol, adridg Cc: cullmann,

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58333. meven added a comment. Reword Icon View to Icons View REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58303=58333 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283 AFFECTED

D21300: KIO: port away from QSslSocket+QFileInfo deprecated API

2019-05-20 Thread David Faure
dfaure created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY I checked that those replacement APIs existed in 5.10 already. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH

D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

2019-05-20 Thread Christoph Cullmann
cullmann added a comment. Just out of curiosity: Does one need the exit(func(...)) call or wouldn't a return func...(); be enough? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21280 To: dfaure, sitter, davidedmundson, apol, adridg Cc: cullmann, anthonyfieroni,

D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

2019-05-20 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21280 To: dfaure, sitter, davidedmundson, apol, adridg Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21249: Test current filter before setting a new one

2019-05-20 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks! One minor issue: unittests (those based on QTEST_MAIN like yours) go into the autotests directory. tests/ is for interactive test programs. Can you move it there?

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

2019-05-20 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:2847d7c8716c: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip (authored by ndavis). REPOSITORY R266 Breeze

D20626: Refactor and cleanup

2019-05-20 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Please make sure to edit the commit log -- the phabricator description still says "Refactor and cleanup" ... REPOSITORY R241 KIO BRANCH cleanup REVISION DETAIL

D21299: examples: move codeeditor also in own subdir

2019-05-20 Thread Friedrich W. H. Kossebau
kossebau created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH haveonesubdirperexample REVISION DETAIL

D21298: Add example app for printing highlighted text to pdf

2019-05-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. kossebau marked 2 inline comments as done. Closed by commit R216:47e8ac891f91: Add example app for printing highlighted text to pdf (authored by kossebau). CHANGED PRIOR TO COMMIT

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

2019-05-20 Thread Christoph Cullmann
cullmann added a comment. :=) You are right, without that, it might be even faster as we only do it once. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21295 To: dhaumann, vkrause, cullmann, kossebau Cc: kwrite-devel, kde-frameworks-devel, domson,