D21313: Create specific directory for kdebugsettings categories file

2019-05-20 Thread Luca Beltrame
lbeltrame removed a subscriber: cgiboudeaux.
lbeltrame added a reviewer: cgiboudeaux.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns


D21313: Create specific directory for kdebugsettings categories file

2019-05-20 Thread Luca Beltrame
lbeltrame added a subscriber: cgiboudeaux.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns


D21313: Create specific directory for kdebugsettings categories file

2019-05-20 Thread Laurent Montel
mlaurent added a reviewer: dfaure.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns


D21313: Create specific directory for kdebugsettings categories file

2019-05-20 Thread Laurent Montel
mlaurent created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  kdebugsettings categories files

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 113 - Still Unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/113/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 21 May 2019 04:04:16 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 103 - Unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/103/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 May 2019 04:04:17 +
 Build duration:
39 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.59.0.xmllogs/KF5KIO/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)55%
(33176/60805)39%
(16967/43836)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4313/9045)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8481/14461)51%
(4707/9230)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4425/8115)41%
(1918/4729)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)54%
(579/1082)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 112 - Still Unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/112/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 20 May 2019 21:57:35 +
 Build duration:
8 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

T8349: Improve Places panel usability and presentation

2019-05-20 Thread Nathaniel Graham
ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, cblack, arvidhansson, ian, jguidon, hannahk, 
Ghost6, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, feverfew, 
trickyricky26, mglb, meven, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender


D16852: Add Documents to the default list of Places

2019-05-20 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1208a51e9abf: Add Documents to the default list of Places 
(authored by acrouthamel, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16852?vs=45388=58385

REVISION DETAIL
  https://phabricator.kde.org/D16852

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns


D16852: Add Documents to the default list of Places

2019-05-20 Thread Nathaniel Graham
ngraham added a comment.


  With the addition of the Tags section, there's already a scrollbar, so 
there's no harm in doing this.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns


D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Nathaniel Graham
ngraham added a comment.


  I was working on this myself last month by implementing new modes that are an 
amalgamation of existing settings, so nobody gets broken and backwards 
compatibility is ensured. I gotpretty far, but I hit a frustrating wall and 
forgot about it. :/ Your work here reminded me about it so I've re-based the 
patch, cleaned it up a bit, and fixed the problem I was having before 
(sometimes you just need to sleep on it for a month, eh?). I'll gladly hand off 
the work I've done so far to you if you want to finish it up. The `TODO` in the 
diff is accurate.
  
  P388 Dolphin-style view modes in the file dialog 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21283

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Adriaan de Groot
adridg abandoned this revision.
adridg added a comment.


  Thanks for looking at this, Harald. For various downstream packaging reasons, 
we're going to be stuck with patching, so I'm going to give up on this 
particular patch.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21305

To: adridg, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven added a comment.


  This patch seems to me now inappropriate given the history of D12358 
 and D12326 
.
  
  I only see a possibility in having Icons View and Compact view as Dolphin has 
without changing behavior and breaking things as adding more view types to 
KDirOperator (Icons and Compact), simply not using it in the KFileWidget.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21283

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2019-05-20 Thread Nathaniel Graham
ngraham added a comment.


  Ping!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns


T8349: Improve Places panel usability and presentation

2019-05-20 Thread Nathaniel Graham
ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, cblack, arvidhansson, ian, jguidon, hannahk, 
Ghost6, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, feverfew, 
trickyricky26, mglb, meven, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender


D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham
shubham updated this revision to Diff 58369.
shubham added a comment.


  -

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20626?vs=58354=58369

BRANCH
  sysinfo

REVISION DETAIL
  https://phabricator.kde.org/D20626

AFFECTED FILES
  src/kcms/kio/useragentinfo.cpp

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns


D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham
shubham added a comment.


  @dfaure Would you mind commiting it, I think I just messes up my ssh keys

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns


D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread David Faure
dfaure added a comment.


  Thanks. You can land the commit.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns


D19367: SearchBar: Don't block GUI when enter incremental pattern

2019-05-20 Thread Christoph Cullmann
cullmann added a comment.


  Simple tests with an 12 million lines document (COPYING.LIB concated "a lot") 
show compare to the current approach usable behavior.
  You start to type some word not in the document, it won't free for 10 
seconds, it will just search in the background like it should.
  I think the largest existing issue is IMHO the multi line stuff. Some more 
comments could help.
  
  Should the
  
  const int newChunkOverlap = pattern.count(QLatin1Char('\n'));
  
  
  actually disable it for multi line searches?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19367

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann


D20959: Allow to change the Mode, after changing the Highlighting

2019-05-20 Thread Christoph Cullmann
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hi,
  could this lead to the following regression:
  
  https://bugs.kde.org/show_bug.cgi?id=407763

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20959

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann


D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Harald Sitter
sitter added a comment.


  I do wonder if we couldn't just move the freebsd path to the end of the list 
and drop the ifdef. As far as linux is concerned we still obey the lookup order 
but simply have an additional path where we may look (and where the file should 
not ever exist on linux). Conversely on the freebsd side the file should never 
exist in the other two paths so it would simply fall through to usr/local.
  
  That said, the code is fine, ifdefs just trip me up when reading ^^

INLINE COMMENTS

> kosrelease.cpp:79
>  {
> -if (QFile::exists(QStringLiteral("/etc/os-release"))) {
> -return QStringLiteral("/etc/os-release");
> -} else if (QFile::exists(QStringLiteral("/usr/lib/os-release"))) {
> -return QStringLiteral("/usr/lib/os-release");
> -} else {
> -return QString();
> +for (const auto& path : { 
> +#ifdef Q_OS_FREEBSD

& goes on the left of the space please

> kosrelease.cpp:81
> +#ifdef Q_OS_FREEBSD
> +QStringLiteral("/usr/local/etc/os-release"),
> +#endif

The indentation is missing a space on every line. Currently it aligns with the 
bracket when it fact it should align with the arguments after the opening 
bracket.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21305

To: adridg, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Adriaan de Groot
adridg edited the test plan for this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21305

To: adridg, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Adriaan de Groot
adridg edited the test plan for this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21305

To: adridg, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21305: Add the FreeBSD default-path for os-release.

2019-05-20 Thread Adriaan de Groot
adridg created this revision.
adridg added a reviewer: sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
adridg requested review of this revision.

REVISION SUMMARY
  - After much hemming and hawing we ended up with /usr/local/etc/os-release, 
which isn't one of the standard paths (according to freedesktop.org) so in 
spite of us **having** the file, not all software that looks for it will find 
it. Patch in the correct path.
  - Patching in the correct path in the original code inserted #ifdefs that 
interact really badly with the existing code-layout.
  - Switch to iterating over a constant list; with Clang and -O3 this yields 
slightly smaller code compared to the original. This code is also much easier 
to #ifdef for specific needs (e.g. for NetBSD and OpenBSD).

TEST PLAN
  - Included in downstream packaging.
  - Test for functionality: ```
  
  #include 
  #include 
  
  static void derp(const QString& s)
  {
  
qDebug() << s;

KOSRelease r(s);
qDebug() << "  name" << r.name() 
<< "\n  version" << r.version();
  
  }
  
  int main(int argc, char **argv)
  {
  
derp(QString());
derp("/usr/local/etc/os-release");

return 0;
  
  }
  
- Test for code size:
  
  
  #include 
  #include 
  
  QString defaultFilePath()
  {
  #ifdef ONE
  
if (QFile::exists(QStringLiteral("/etc/os-release"))) {
return QStringLiteral("/etc/os-release");
} else if (QFile::exists(QStringLiteral("/usr/lib/os-release"))) {
return QStringLiteral("/usr/lib/os-release");
} else {
return QString();
}
  
  #endif
  #ifdef TWO
  
for (const auto& path : { 
QStringLiteral("/etc/os-release"),
QStringLiteral("/usr/lib/os-release")
}) {
if (QFile::exists(path)) {
return path;
}
}
return QString();
  
  #endif
  }

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21305

AFFECTED FILES
  src/lib/util/kosrelease.cpp

To: adridg, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham
shubham updated this revision to Diff 58354.
shubham edited the summary of this revision.
shubham added a comment.


  proper rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20626?vs=58351=58354

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

AFFECTED FILES
  src/kcms/kio/useragentinfo.cpp

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns


D20626: Rely upon QSysInfo to retrieve the system details

2019-05-20 Thread Shubham
shubham retitled this revision from "Refactor and cleanup" to "Rely upon 
QSysInfo to retrieve the system details".
shubham edited the summary of this revision.
shubham edited the test plan for this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns


D20626: Refactor and cleanup

2019-05-20 Thread Shubham
shubham updated this revision to Diff 58351.
shubham edited the summary of this revision.
shubham edited the test plan for this revision.
shubham added a comment.


  Rely upon QSysInfo to retrieve the system details

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20626?vs=56417=58351

BRANCH
  arcpatch-D20626

REVISION DETAIL
  https://phabricator.kde.org/D20626

AFFECTED FILES
  src/kcms/kio/useragentinfo.cpp

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns


D21299: examples: move codeeditor also in own subdir

2019-05-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e3a7922ae842: examples: move codeeditor also in own 
subdir (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21299?vs=58330=58349#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21299?vs=58330=58349

REVISION DETAIL
  https://phabricator.kde.org/D21299

AFFECTED FILES
  examples/CMakeLists.txt
  examples/codeeditor.cpp
  examples/codeeditor.h
  examples/codeeditor/CMakeLists.txt
  examples/codeeditor/codeeditor.cpp
  examples/codeeditor/codeeditor.h
  examples/codeeditor/main.cpp
  examples/main.cpp

To: kossebau, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars


D21299: examples: move codeeditor also in own subdir

2019-05-20 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Thanks! I was about to propose this for consistency as well, please go ahead.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  haveonesubdirperexample

REVISION DETAIL
  https://phabricator.kde.org/D21299

To: kossebau, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 114 - Fixed!

2019-05-20 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/114/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 20 May 2019 10:46:03 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.59.0.xmllogs/KF5KIO/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)55%
(33196/60794)39%
(16994/43831)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4310/9045)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8487/14454)51%
(4721/9227)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4427/8110)41%
(1919/4727)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)54%
(579/1082)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 282 - Fixed!

2019-05-20 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/282/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 20 May 2019 10:45:27 +
 Build duration:
10 min and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 101 - Fixed!

2019-05-20 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/101/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 20 May 2019 10:46:02 +
 Build duration:
8 min 38 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.59.0.xmllogs/KF5KIO/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)55%
(33168/60800)39%
(16957/43834)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9372/9820)48%
(4310/9045)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8468/14461)51%
(4711/9230)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4424/8110)41%
(1916/4727)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(578/1082)39%
(345/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 111 - Still unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/111/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 20 May 2019 10:45:32 +
 Build duration:
7 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 113 - Failure!

2019-05-20 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/113/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 20 May 2019 10:36:01 +
 Build duration:
6 min 43 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘Docker Swarm-d2a3cfbb6079’Ready to run at Mon May 20 10:42:28 UTC 2019Resuming build at Mon May 20 10:42:28 UTC 2019 after Jenkins restartRunning on Docker Swarm-fdb3c5f65867 in /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.10[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2019-05-20T10:42:33.653Z] No credentials specified[2019-05-20T10:42:33.658Z] Cloning the remote Git repository[2019-05-20T10:42:33.677Z] Cloning repository git://anongit.kde.org/kio[2019-05-20T10:42:33.700Z]  > git init /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.10 # timeout=10[2019-05-20T10:42:33.754Z] Fetching upstream changes from git://anongit.kde.org/kio[2019-05-20T10:42:33.754Z]  > git --version # timeout=10[2019-05-20T10:42:33.756Z]  > git fetch --tags --force --progress git://anongit.kde.org/kio +refs/heads/*:refs/remotes/origin/* # timeout=120[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-05-20T10:42:38.771Z] java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.onResume(SynchronousNonBlockingStepExecution.java:75)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:1011)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:989)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:907)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)[2019-05-20T10:42:38.771Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-05-20T10:42:38.772Z] 	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)[2019-05-20T10:42:38.772Z] 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)[2019-05-20T10:42:38.772Z] 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-05-20T10:42:38.772Z] 	at java.lang.Thread.run(Thread.java:748)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 100 - Failure!

2019-05-20 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/100/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 20 May 2019 10:36:01 +
 Build duration:
6 min 43 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskAll nodes of label ‘SUSEQt5.12’ are offlineReady to run at Mon May 20 10:42:28 UTC 2019Resuming build at Mon May 20 10:42:28 UTC 2019 after Jenkins restartRunning on Docker Swarm-8f6769c3bfa0 in /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2019-05-20T10:42:33.814Z] No credentials specified[2019-05-20T10:42:33.816Z] Cloning the remote Git repository[2019-05-20T10:42:33.841Z] Cloning repository git://anongit.kde.org/kio[2019-05-20T10:42:33.860Z]  > git init /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12 # timeout=10[2019-05-20T10:42:33.877Z] Fetching upstream changes from git://anongit.kde.org/kio[2019-05-20T10:42:33.877Z]  > git --version # timeout=10[2019-05-20T10:42:33.879Z]  > git fetch --tags --force --progress git://anongit.kde.org/kio +refs/heads/*:refs/remotes/origin/* # timeout=120[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-05-20T10:42:38.771Z] java.lang.Exception: Resume after a restart not supported for non-blocking synchronous steps[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.onResume(SynchronousNonBlockingStepExecution.java:75)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.Futures$6.run(Futures.java:975)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:134)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:170)[2019-05-20T10:42:38.771Z] 	at com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:1011)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$5.onSuccess(CpsFlowExecution.java:989)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:907)[2019-05-20T10:42:38.771Z] 	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)[2019-05-20T10:42:38.771Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-05-20T10:42:38.771Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-05-20T10:42:38.771Z] 	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)[2019-05-20T10:42:38.771Z] 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)[2019-05-20T10:42:38.772Z] 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-05-20T10:42:38.772Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-05-20T10:42:38.772Z] 	at java.lang.Thread.run(Thread.java:748)[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 110 - Failure!

2019-05-20 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
 ^

hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on FreeBSD Builder 2 failed. The channel is closing down or has closed down

D21300: KIO: port away from QSslSocket+QFileInfo deprecated API

2019-05-20 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21300

To: dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 281 - Failure!

2019-05-20 Thread CI System
Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
 ^

hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on JNLP4-connect connection from artonis.kde.org/195.201.167.115:62867 failed. The channel is closing down or has closed down

D21300: KIO: port away from QSslSocket+QFileInfo deprecated API

2019-05-20 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  2019_deprecated_API

REVISION DETAIL
  https://phabricator.kde.org/D21300

To: dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21249: Test current filter before setting a new one

2019-05-20 Thread Jan-Marek Glogowski
jglogowski updated this revision to Diff 58345.
jglogowski added a comment.


  - Merge test/kfilewidgettest_filter.cpp into autotests/kfilewidgettest.cpp
  - Swap QCOMPARE parameters to match actual + expected output on failure
  - Always test filter and file name
  
  Technically the '*' filter just makes sense as the last filter in the list 
and it's auto-selected if it's the first filter entry.
  That's out of scope here. Not sure if there should / could be a warning for a 
developer.
  
  Thanks for your patience.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21249?vs=58317=58345

REVISION DETAIL
  https://phabricator.kde.org/D21249

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kfilewidget.cpp

To: jglogowski, #frameworks, ngraham, dfaure
Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, 
bruns


D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58337.
meven added a comment.


  Clean up

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21283?vs=58336=58337

BRANCH
  icon-compact-views

REVISION DETAIL
  https://phabricator.kde.org/D21283

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp
  src/widgets/kfile.cpp
  src/widgets/kfile.h

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21283

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58336.
meven added a comment.


  Keep DetailTree as default file view

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21283?vs=58334=58336

BRANCH
  icon-compact-views

REVISION DETAIL
  https://phabricator.kde.org/D21283

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp
  src/widgets/kfile.cpp
  src/widgets/kfile.h

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58334.
meven added a comment.


  Extract KDirOperatorIconView to its own class

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21283?vs=58333=58334

BRANCH
  icon-compact-views

REVISION DETAIL
  https://phabricator.kde.org/D21283

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp
  src/widgets/kfile.cpp
  src/widgets/kfile.h

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 109 - Still Unstable!

2019-05-20 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/109/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 20 May 2019 07:52:16 +
 Build duration:
1 hr 16 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

2019-05-20 Thread David Faure
dfaure added a comment.


  Good question. It seems to me that return would indeed be much better so that 
the stack gets unwinded... I'll make the change.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21280

To: dfaure, sitter, davidedmundson, apol, adridg
Cc: cullmann, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns


D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58333.
meven added a comment.


  Reword Icon View to Icons View

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21283?vs=58303=58333

BRANCH
  icon-compact-views

REVISION DETAIL
  https://phabricator.kde.org/D21283

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kfilewidget.cpp
  src/widgets/kfile.cpp
  src/widgets/kfile.h

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21300: KIO: port away from QSslSocket+QFileInfo deprecated API

2019-05-20 Thread David Faure
dfaure created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  I checked that those replacement APIs existed in 5.10 already.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  2019_deprecated_API

REVISION DETAIL
  https://phabricator.kde.org/D21300

AFFECTED FILES
  src/core/ktcpsocket.cpp
  src/ioslaves/trash/tests/testtrash.cpp

To: dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

2019-05-20 Thread Christoph Cullmann
cullmann added a comment.


  Just out of curiosity: Does one need the exit(func(...)) call or wouldn't a 
return func...(); be enough?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21280

To: dfaure, sitter, davidedmundson, apol, adridg
Cc: cullmann, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns


D21280: kioslave: preserve argv[0], to fix applicationDirPath() on non-Linux

2019-05-20 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21280

To: dfaure, sitter, davidedmundson, apol, adridg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns


D21249: Test current filter before setting a new one

2019-05-20 Thread David Faure
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks!
  
  One minor issue: unittests (those based on QTEST_MAIN like yours) go into the 
autotests directory.
  tests/ is for interactive test programs.
  Can you move it there?
  It could even be just a new method in the existing 
autotests/kfilewidgettest.cpp
  [if you do keep it separate for some reason, add a copyright header, but my 
recommendation is to merge it anyway, to keep the usual structure of one test 
file per class being tested]

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21249

To: jglogowski, #frameworks, ngraham, dfaure
Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, 
bruns


D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

2019-05-20 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2847d7c8716c: Symlink arrow-*-double to go-*-skip, add 
24px go-*-skip (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21084?vs=57767=58331

REVISION DETAIL
  https://phabricator.kde.org/D21084

AFFECTED FILES
  icons-dark/actions/16/arrow-down-double.svg
  icons-dark/actions/16/arrow-left-double.svg
  icons-dark/actions/16/arrow-right-double.svg
  icons-dark/actions/16/arrow-up-double.svg
  icons-dark/actions/22/arrow-down-double.svg
  icons-dark/actions/22/arrow-left-double.svg
  icons-dark/actions/22/arrow-right-double.svg
  icons-dark/actions/22/arrow-up-double.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/24/go-down-skip.svg
  icons-dark/actions/24/go-next-skip.svg
  icons-dark/actions/24/go-previous-skip.svg
  icons-dark/actions/24/go-up-skip.svg
  icons-dark/actions/32/arrow-down-double.svg
  icons-dark/actions/32/arrow-left-double.svg
  icons-dark/actions/32/arrow-right-double.svg
  icons-dark/actions/32/arrow-up-double.svg
  icons/actions/16/arrow-down-double.svg
  icons/actions/16/arrow-left-double.svg
  icons/actions/16/arrow-right-double.svg
  icons/actions/16/arrow-up-double.svg
  icons/actions/22/arrow-down-double.svg
  icons/actions/22/arrow-left-double.svg
  icons/actions/22/arrow-right-double.svg
  icons/actions/22/arrow-up-double.svg
  icons/actions/24/arrow-down-double.svg
  icons/actions/24/arrow-left-double.svg
  icons/actions/24/arrow-right-double.svg
  icons/actions/24/arrow-up-double.svg
  icons/actions/24/go-down-skip.svg
  icons/actions/24/go-next-skip.svg
  icons/actions/24/go-previous-skip.svg
  icons/actions/24/go-up-skip.svg
  icons/actions/32/arrow-down-double.svg
  icons/actions/32/arrow-left-double.svg
  icons/actions/32/arrow-right-double.svg
  icons/actions/32/arrow-up-double.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20626: Refactor and cleanup

2019-05-20 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Please make sure to edit the commit log -- the phabricator description still 
says "Refactor and cleanup" ...

REPOSITORY
  R241 KIO

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns


D21299: examples: move codeeditor also in own subdir

2019-05-20 Thread Friedrich W. H. Kossebau
kossebau created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  haveonesubdirperexample

REVISION DETAIL
  https://phabricator.kde.org/D21299

AFFECTED FILES
  examples/CMakeLists.txt
  examples/codeeditor.cpp
  examples/codeeditor.h
  examples/codeeditor/CMakeLists.txt
  examples/codeeditor/codeeditor.cpp
  examples/codeeditor/codeeditor.h
  examples/codeeditor/main.cpp
  examples/main.cpp

To: kossebau
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D21298: Add example app for printing highlighted text to pdf

2019-05-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.
Closed by commit R216:47e8ac891f91: Add example app for printing highlighted 
text to pdf (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21298?vs=58327=58329#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21298?vs=58327=58329

REVISION DETAIL
  https://phabricator.kde.org/D21298

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/codepdfprinter/CMakeLists.txt
  examples/codepdfprinter/codepdfprinter.cpp
  examples/codepdfprinter/codepdfprinter.h
  examples/codepdfprinter/main.cpp

To: kossebau, vkrause, dhaumann
Cc: pino, dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars


D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

2019-05-20 Thread Christoph Cullmann
cullmann added a comment.


  :=) You are right, without that, it might be even faster as we only do it 
once.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21295

To: dhaumann, vkrause, cullmann, kossebau
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann