KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/29/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 25 May 2019 03:22:32 +
 Build duration:
1 hr 32 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D21388: KCompressionDevice: Remove bIgnoreData

[Aleix Pol Gonzalez]

apol added a comment.


  How hard would it be to test this?
  
  I like how the code ends up being much simpler.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D21388

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21388: KCompressionDevice: Remove bIgnoreData

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  bIgnoreData was used in ::seek to say, we don't really care much
  about the next readData call because we know it's coming from this read
  call we're wrapping in bIgnoreData and we will just going to throw
  away the data (see dummy variable).
  
  The problem is that it is not guaranteed that the readData call that the
  read() originates will be over dummy, in some cases it can be over the 
internal
  qiodevice ring buffer
  

https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/io/qiodevice.cpp?h=5.12#n1129
  
  so if we don't properly store the data we end up with wrong data in the ring 
buffer and bad things will happen

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21388

AFFECTED FILES
  src/kcompressiondevice.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

[Simon Redman]

sredman added a comment.


  In D21369#469389 , @apol wrote:
  
  > Seems like a clear layer break to spill KContacts over KPeople :P.
  >  Let's discuss it at the sprint? Or earlier. Let's discuss it? ^^'
  
  
  Sounds good

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D21369

To: sredman, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Peridot Lavender]

lavender added a comment.


  In D21378#469640 , @filipf wrote:
  
  > In D21378#469611 , @ndavis wrote:
  >
  > > In D21378#469607 , @filipf 
wrote:
  > >
  > > > So I have a light widget color scheme, but I want to be using a dark 
Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it 
doesn't respect my colors. So this is a good solution, +1 for the idea.
  > > >
  > > > I gave it a quick spin with Breeze Dark however and it's just not 
picking up some color schemes. It remains stuck on the colors of some previous 
scheme that worked. This seems to be random and may be a bug originating 
elsewhere so I'm hitting accept.
  > >
  > >
  > > After changing the system colorscheme, did you try restarting plasmashell 
or switching to a different desktop theme and switching back? I'll admit, it's 
a bit janky, but it should work if you do that. It definitely seems like a bug 
that originates from elsewhere.
  >
  >
  > Restarting plasmashell yes, switching to a different theme nope. But I did 
now and that seems to be working.
  
  
  It's very wonky but what worked for me was: change the desktop theme, not the 
look and feel, then change the color scheme to the one you want and finally 
change the desktop theme to Breeze Dark

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Filip Fila]

filipf added a comment.


  In D21378#469611 , @ndavis wrote:
  
  > In D21378#469607 , @filipf wrote:
  >
  > > So I have a light widget color scheme, but I want to be using a dark 
Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it 
doesn't respect my colors. So this is a good solution, +1 for the idea.
  > >
  > > I gave it a quick spin with Breeze Dark however and it's just not picking 
up some color schemes. It remains stuck on the colors of some previous scheme 
that worked. This seems to be random and may be a bug originating elsewhere so 
I'm hitting accept.
  >
  >
  > After changing the system colorscheme, did you try restarting plasmashell 
or switching to a different desktop theme and switching back? I'll admit, it's 
a bit janky, but it should work if you do that. It definitely seems like a bug 
that originates from elsewhere.
  
  
  Restarting plasmashell yes, switching to a different theme nope. But I did 
now and that seems to be working.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

[Ben Cooksley]

bcooksley added a comment.


  Aleix is correct, Flatpak commands are not possible within the CI environment 
(as Docker is heavily locked down, and the containerisation and other isolation 
measures that Flatpak tries to take are locked out as a consequence)
  Not to mention that Flatpak is Linux only as well, while Appstream data isn't 
applicable to multiple platforms.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21381

To: mgallien, aacid, yurchor, apol
Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  How about we test against both?
  
  And maybe it should be using `appstream-util validate` instead of forcing it 
through flatpak? 
  It will make it easier to be able to run it in build.kde.org.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21381

To: mgallien, aacid, yurchor, apol
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21317: Manipulate bytes instead of characters

[Thiago Macieira]

thiago added a comment.


  As for truncating UTF-8 multibyte sequences in the middle, when you convert 
back using QFile::decodeName, it'll be nonsensical. But I don't think it really 
matters since you're truncating and using the display string anyway, so you're 
already losing data. This wasn't a recoverable conversion anyway.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21317

To: chinmoyr, bruns, dfaure, thiago
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R296 KDeclarative

BRANCH
  porttoECMInstallQmlModules

REVISION DETAIL
  https://phabricator.kde.org/D21356

To: kossebau, #plasma, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis added a comment.


  In D21378#469607 , @filipf wrote:
  
  > So I have a light widget color scheme, but I want to be using a dark Plasma 
theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't 
respect my colors. So this is a good solution, +1 for the idea.
  >
  > I gave it a quick spin with Breeze Dark however and it's just not picking 
up some color schemes. It remains stuck on the colors of some previous scheme 
that worked. This seems to be random and may be a bug originating elsewhere so 
I'm hitting accept.
  
  
  After changing the system colorscheme, did you try restarting plasmashell or 
switching to a different desktop theme and switching back?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis added a comment.


  In D21378#469525 , @lavender wrote:
  
  > In D21378#469517 , @mart wrote:
  >
  > > the idea is kinda nice and with some schemes it will work just perfect...
  > >  however i think it risks a lot of having loss in contrast on certain 
color schems with your patch try for instance breezedark and the honeycomb 
system theme, the current task highlight would probably almost disappear
  >
  >
  > This is bringing it in line with Breeze Light which already has the color 
schemes influencing the taskbar color. I tested with honeycomb and it seemed to 
work fine.
  
  
  Actually, Breeze Light should have had the same problem as Breeze Dark. It's 
Breeze that should have already been adapting to the system colorscheme because 
it didn't have any colors defined.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  So I have a light widget color scheme, but I want to be using a dark Plasma 
theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't 
respect my colors. So this is a good solution, +1 for the idea.
  
  I gave it a quick spin with Breeze Dark however and it's just not picking up 
some color schemes. It remains stuck on the colors of some previous scheme that 
worked. This seems to be random and may be a bug originating elsewhere so I'm 
hitting accept.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21317: Manipulate bytes instead of characters

[Thiago Macieira]

thiago added a comment.


  I cringe a little when you apply QFile to a URL, but this is probably safe 
enough.
  
  LGTM

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21317

To: chinmoyr, bruns, dfaure, thiago
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21354: Port to new connect syntax

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R432:95df6fa38a45: Port to new connect syntax (authored by 
ngraham).

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21354?vs=58607&id=58610

REVISION DETAIL
  https://phabricator.kde.org/D21354

AFFECTED FILES
  samba/filepropertiesplugin/delegate.cpp
  samba/filepropertiesplugin/delegate.h
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21354: Port to new connect syntax

[Nathaniel Graham]

ngraham added a comment.


  In D21354#469531 , @bruns wrote:
  
  > LGTM
  >
  > currently, GCC thows some "0 for nullptr" and "missing override" warnings, 
are you going to address these (new SR)?
  >
  > Also, Qt recommends deriving from Q**Styled**ItemDelegate
  
  
  Yeah there are a lot of warnings and more code cleanup needed, this is just 
the first of many. :)

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21354: Port to new connect syntax

[Stefan Brüns]

bruns added a comment.


  LGTM
  
  currently, GCC thows some "0 for nullptr" and "missing override" warnings, 
are you going to address these (new SR)?
  
  Also, Qt recommends deriving from Q**Styled**ItemDelegate

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21354: Port to new connect syntax

[Nathaniel Graham]

ngraham updated this revision to Diff 58607.
ngraham added a comment.


  Rebase

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21354?vs=58605&id=58607

BRANCH
  port-to-new-connect-symtax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21354

AFFECTED FILES
  samba/filepropertiesplugin/delegate.cpp
  samba/filepropertiesplugin/delegate.h
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21378: Make Breeze Light/Dark use more system colors

[Peridot Lavender]

lavender added a comment.


  In D21378#469517 , @mart wrote:
  
  > the idea is kinda nice and with some schemes it will work just perfect...
  >  however i think it risks a lot of having loss in contrast on certain color 
schems with your patch try for instance breezedark and the honeycomb system 
theme, the current task highlight would probably almost disappear
  
  
  This is bringing it in line with Breeze Light which already has the color 
schemes influencing the taskbar color. When I tested I tested with honeycomb 
and it seemed to work fine.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21354: Port to new connect syntax

[Nathaniel Graham]

ngraham updated this revision to Diff 58605.
ngraham marked an inline comment as done.
ngraham added a comment.


  Don't double-connect

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21354?vs=58568&id=58605

BRANCH
  port-to-new-connect-symtax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21354

AFFECTED FILES
  samba/filepropertiesplugin/delegate.cpp
  samba/filepropertiesplugin/delegate.h
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21378: Make Breeze Light/Dark use more system colors

[Marco Martin]

mart added a comment.


  the idea is kinda nice and with some schemes it will work just perfect...
  however i think it risks a lot of having loss in contrast on certain color 
schems with your patch try for instance breezedark and the honeycomb system 
theme, the current task highlight would probably almost disappear

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a task: T8755: Use colors from the system colorscheme for the 
Task Manager's accent color in Breeze Light/Dark desktop themes.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Nathaniel Graham]

ngraham added a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

[Nathaniel Graham]

ngraham added a reviewer: apol.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21381

To: mgallien, aacid, yurchor, apol
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> KDEInstallDirs.cmake:131
>  # autostart files (``CONFDIR/autostart``) [``AUTOSTART_INSTALL_DIR``]
> +# ``DEBUGCATEGORIESDIR``
> +# kdebugsettings categories files directory 
> (``DATAROOTDIR/debug-categories5``) Since 5.59.0

Might `LOGGINGCATEGORIESDIR` or perhaps short `LOGCATDIR`  not be a better 
name, for one more following the naming pattern of Qt, but also more clearly 
pointing out what this is about? Debug categories could mean a lot, while this 
here is about logging only.

> KDEInstallDirs.cmake:132
> +# ``DEBUGCATEGORIESDIR``
> +# kdebugsettings categories files directory 
> (``DATAROOTDIR/debug-categories5``) Since 5.59.0
>  #

given this is adding a dir in the shared naming area, could this perhaps be 
more specific named, unless the plan is to make this a general-purpose dir 
shared among all kind of applications & toolkits?
For now this data is only for one program, kdebugsettings, so IMHO that should 
be reflected here.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Kai Uwe Broulik]

broulik added a comment.


  Okay, so we can just filter for "usb" then since we don't monitor "block" and 
"scsi_generic"
  
  > This definitely needs some documentation
  
  Agreed

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Stefan Brüns]

bruns added a comment.


  sd[a-z] is subsystem "block"
  sg[0-9] is susbsystem "scsi_generic"
  
  none of the ID_GPHOTO2==1 devices is a tty or dvb device

INLINE COMMENTS

> udevqtclient.h:53
>  DeviceList devicesBySubsystem(const QString &subsystem);
> +DeviceList devicesBySubsystemsAndProperties(const QStringList 
> &subsystems, const QVariantMap &properties);
>  Device deviceByDeviceFile(const QString &deviceFile);

This definitely needs some documentation

- values in subsystems form a union (ORed)
- key/values in properties form a union (ORed)

- both unions are intersected (ANDed)

i.e. in the camera case, (usb || dvb || tty) && (ID_GPHOTO2==1)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58604.
mlaurent added a comment.


  Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR
  
  Thanks for pointing me it :)

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58454&id=58604

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21368: Add syntax definition for the Common Intermediate Language

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:70a9e380e3b2: Add syntax definition for the Common 
Intermediate Language (authored by vkrause).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21368?vs=58550&id=58603

REVISION DETAIL
  https://phabricator.kde.org/D21368

AFFECTED FILES
  autotests/folding/test.il.fold
  autotests/html/test.il.html
  autotests/input/test.il
  autotests/reference/test.il.ref
  data/syntax/cil.xml

To: vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21380: show static word wrap marker always if requested

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:24fd3ca01d89: show static word wrap marker always if 
requested (authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21380?vs=58594&id=58602

REVISION DETAIL
  https://phabricator.kde.org/D21380

AFFECTED FILES
  src/dialogs/editconfigwidget.ui
  src/render/katerenderer.cpp

To: cullmann, #ktexteditor, #frameworks, arrowd
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21355: Fix qmldir files

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:d644659eed56: Fix qmldir files (authored by kossebau).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21355?vs=58520&id=58601

REVISION DETAIL
  https://phabricator.kde.org/D21355

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/qmldir
  src/qmlcontrols/kquickcontrols/private/qmldir
  src/qmlcontrols/kquickcontrols/qmldir
  src/qmlcontrols/kquickcontrolsaddons/qmldir

To: kossebau, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Kai Uwe Broulik]

broulik added a comment.


  Thanks, @bruns but what does this mean for this patch? :D

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21380: show static word wrap marker always if requested

[Gleb Popov]

arrowd accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21380

To: cullmann, #ktexteditor, #frameworks, arrowd
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21344: Port to ECMAddQmlModule

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 58597.
kossebau added a comment.


  udate to latest master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21344?vs=58492&id=58597

BRANCH
  porttoECMInstallQmlModules

REVISION DETAIL
  https://phabricator.kde.org/D21344

AFFECTED FILES
  CMakeLists.txt
  src/declarativeimports/calendar/CMakeLists.txt
  src/declarativeimports/calendar/qml/qmldir
  src/declarativeimports/core/CMakeLists.txt
  src/declarativeimports/core/qmldir
  src/declarativeimports/plasmacomponents/CMakeLists.txt
  src/declarativeimports/plasmacomponents/qml/qmldir
  src/declarativeimports/plasmaextracomponents/CMakeLists.txt
  src/declarativeimports/plasmaextracomponents/qml/qmldir
  src/declarativeimports/platformcomponents/CMakeLists.txt
  src/declarativeimports/platformcomponents/qmldir

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 58596.
kossebau added a comment.


  update to latest master

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21356?vs=58521&id=58596

BRANCH
  porttoECMInstallQmlModules

REVISION DETAIL
  https://phabricator.kde.org/D21356

AFFECTED FILES
  CMakeLists.txt
  src/qmlcontrols/draganddrop/CMakeLists.txt
  src/qmlcontrols/draganddrop/plugins.qmltypes
  src/qmlcontrols/draganddrop/qmldir
  src/qmlcontrols/kcmcontrols/CMakeLists.txt
  src/qmlcontrols/kcmcontrols/plugins.qmltypes
  src/qmlcontrols/kcmcontrols/qml/qmldir
  src/qmlcontrols/kconfig/CMakeLists.txt
  src/qmlcontrols/kconfig/plugins.qmltypes
  src/qmlcontrols/kconfig/qmldir
  src/qmlcontrols/kcoreaddons/CMakeLists.txt
  src/qmlcontrols/kcoreaddons/plugins.qmltypes
  src/qmlcontrols/kcoreaddons/qmldir
  src/qmlcontrols/kioplugin/CMakeLists.txt
  src/qmlcontrols/kioplugin/plugins.qmltypes
  src/qmlcontrols/kioplugin/qmldir
  src/qmlcontrols/kquickcontrols/CMakeLists.txt
  src/qmlcontrols/kquickcontrols/plugins.qmltypes
  src/qmlcontrols/kquickcontrols/private/CMakeLists.txt
  src/qmlcontrols/kquickcontrols/private/plugins.qmltypes
  src/qmlcontrols/kquickcontrols/private/qmldir
  src/qmlcontrols/kquickcontrols/qmldir
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt
  src/qmlcontrols/kquickcontrolsaddons/plugins.qmltypes
  src/qmlcontrols/kquickcontrolsaddons/qmldir
  src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt
  src/qmlcontrols/kwindowsystemplugin/plugins.qmltypes
  src/qmlcontrols/kwindowsystemplugin/qmldir

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

[Matthieu Gallien]

mgallien created this revision.
mgallien added reviewers: aacid, yurchor.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
mgallien requested review of this revision.

REVISION SUMMARY
  should help having the same validation than the one done by flathub
  
  related to D21242  and D21243 


TEST PLAN
  A test with Elisa allows validation tu succeed

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21381

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/appstreamtest.cmake

To: mgallien, aacid, yurchor
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21380: show static word wrap marker always if requested

[Christoph Cullmann]

cullmann added reviewers: KTextEditor, Frameworks.
cullmann added a comment.


  I think this is reasonable, if one enables this, it should be shown, people 
can disable it, if it doesn't look nice for their font (or alter the font).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21380

To: cullmann, #ktexteditor, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21380: show static word wrap marker always if requested

[Christoph Cullmann]

cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  don't check for fixed pitch font, as this seems to be not properly attributed
  to all kind of fonts
  
  see bug 344290

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21380

AFFECTED FILES
  src/dialogs/editconfigwidget.ui
  src/render/katerenderer.cpp

To: cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 103 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/103/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 24 May 2019 13:09:15 +
 Build duration:
8 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13377)18%
(1823/9883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/110/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 24 May 2019 13:09:15 +
 Build duration:
8 min 40 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13377)18%
(1822/9883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 113 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/113/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 24 May 2019 13:09:15 +
 Build duration:
3 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e99f653113ec: plasmacore: fix qmldir, ToolTip.qml no 
longer part of module (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21350?vs=58504&id=58593

REVISION DETAIL
  https://phabricator.kde.org/D21350

AFFECTED FILES
  src/declarativeimports/core/qmldir

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Stefan Brüns]

bruns added a comment.


  libgphoto2.rules lists the following devices (USB VID:PID):
  
  - 1403:0001  Sitronix Digital Photo Frame
  
  which apparently shows up as a generic mass storage (sd[a-z]), but actually 
is something completely different, see 
https://github.com/gphoto/libgphoto2/tree/master/camlibs/st2205
  
  - 1908:  Appotech based Photo frame
  
  https://github.com/gphoto/libgphoto2/tree/master/camlibs/ax203
  
  - 04b0: Nikon Coolpix, pre PTP era (~2002)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  cleancoreqmldir

REVISION DETAIL
  https://phabricator.kde.org/D21350

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21355: Fix qmldir files

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  improveqmldirs

REVISION DETAIL
  https://phabricator.kde.org/D21355

To: kossebau, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21328: Add qml import for KItemModels

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:12
> +
> +install(TARGETS itemmodelsplugin DESTINATION 
> ${KDE_INSTALL_QMLDIR}/org/kde/kitemmodels)
> +install(FILES qmldir DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/kitemmodels)

With the macros of ECMAddQmlModule proposed in D20984 
, the explicit qmldir file could be removed 
and the install lines replaced by

  ecm_add_qmlmodule(itemmodelsqml
  IDENTIFIER org.kde.kitemmodels
  DESTINATION ${KDE_INSTALL_QMLDIR}
  PLUGIN itemmodelsplugin
  TYPEINFO plugins.qmltypes
  VERSION 1.0
  )

getting rid of all the duplicated identifiers and having the build-system 
instead know about them and propagate as needed from this single source.
It would also add support for a plugins.qmltypes file, thus providing metadata 
about the module for tools e.g. in cross-compilation scenarios.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D21328

To: davidedmundson
Cc: kossebau, vkrause, apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 110 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/110/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 24 May 2019 11:30:25 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.59.0.xmllogs/KF5KIO/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/401)66%
(266/401)55%
(33325/61004)39%
(17051/43974)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9403/9853)48%
(4329/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8490/14466)51%
(4708/9230)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4448/8122)41%
(1945/4733)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1206)39%
(370/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 120 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/120/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 24 May 2019 11:30:25 +
 Build duration:
7 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Aleix Pol Gonzalez]

apol added a comment.


  +1 LGTM

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

[Aleix Pol Gonzalez]

apol added a comment.


  Seems like a clear layer break to spill KContacts over KPeople :P. Let's 
discuss it at the sprint?

INLINE COMMENTS

> persondata.h:123
> +
> +/** Returns an arbritrary phone number of the contact */
> +KContacts::PhoneNumber::List allPhoneNumbers() const;

wrong comment

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D21369

To: sredman, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21317: Manipulate bytes instead of characters

[David Faure]

dfaure added a comment.


  +1 from me, but if Thiago can take a look (about the issue of truncating in 
the middle of a multi-bytes utf8 characters) that'd be even better.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21317

To: chinmoyr, bruns, dfaure, thiago
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It currently scans all UDev devices, including processors, for that property.
  This limits the number of subsystems queried.

TEST PLAN
  I only found traces of "usb" and "tty" in gphoto code, not sure what other 
subsystems a camera could be. Definitely not cpu and processors, though.
  
  Previously hotplugengine took 46ms to initialize on plasmashell startup here, 
now it's down to 6ms.
  My phone still shows up as Camera when connected via PTP rather than MTP

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

AFFECTED FILES
  src/solid/devices/backends/shared/udevqtclient.cpp
  src/solid/devices/backends/shared/udevqtclient.h
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21354: Port to new connect syntax

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> sambausershareplugin.cpp:130
> +connect(propertiesUi.sambaNameEdit, &QLineEdit::textChanged,
> +this, &SambaUserSharePlugin::checkShareName);
> +connect(propertiesUi.sambaAllowGuestChk, &QCheckBox::toggled,

I meant - do `setDirty()` in e.g. `checkShareName()`, i.e. only one connection 
per signal.

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

D21378: Make Breeze Light/Dark use more system colors

[Peridot Lavender]

lavender added a comment.


  Tested and it looks good to me

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D21313#469311 , @mlaurent wrote:
  
  > Ping ?
  
  
  You didn't add "KXMLGUI_INSTALL_DIR)" back to where it belongs afaics.
  
  If noone has a better suggestion, we'll go for debug-categories5

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns