D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

ngraham added a comment. @cfeck @apol @aacid It's not clear to me what's being requested. Can someone clarify? REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop updated this revision to Diff 59308. JJRcop added a comment. Updated version number in comments to 5.59 since 5.58 came out earlier in May. REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20181?vs=55227&id=59308 REVISION DETAIL https://phab

D17595: Upstream Dolphin's file rename dialog

meven added inline comments. INLINE COMMENTS > bruns wrote in renamefiledialog.cpp:105 > The code assumes the "#" is the very last character ("Don't select the # > character"), so this requires a translation comment. Is that better line 105 ? REPOSITORY R241 KIO REVISION DETAIL https://ph

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 59292. meven marked an inline comment as done. meven added a comment. Improve localization context REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=59255&id=59292 BRANCH arcpatch-D17595_1 REVISION DETAIL https://

D14467: Auth Support: Drop privileges if target is not owned by root

chinmoyr updated this revision to Diff 59290. chinmoyr added a comment. - int -> ActionType - separated the logic in dropPrivileges() to two parts - accepting mode argument in mkdir - used *at() functions - minor cosmetic changes @mgerstner In case of rename, when owners are differ

D21632: Add edit-select-text, make 16px draw-text like 22px

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6227d63efa20: Add edit-select-text, make 16px draw-text like 22px (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21632?vs=59283&id=59287

D21632: Add edit-select-text, make 16px draw-text like 22px

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Perfect! REPOSITORY R266 Breeze Icons BRANCH edit-select-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D21632 To: ndavis, #vdg, ngraham Cc: ngraham, kde-

D21632: Add edit-select-text, make 16px draw-text like 22px

ndavis added a dependent revision: D21633: Change Text Selection icon to edit-select-text. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21632 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21632 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Okular uses draw-text for the text selection tool, but it has 2 different icons at differen

D21584: Add LE Advertising and GATT APIs

mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in gattapplication.h:66 > Should this be made private (preferrably in GattApplicationPrivate)? I override this in test class, so kept as protected. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D215

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/128/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 06 Jun 2019 17:41:33 + Build duration: 8 min 59 sec and counting JUnit Tests Name: projectro

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59277. mweichselbaumer added a comment. Fixed according to comments REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59238&id=59277 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584

D21459: Always save view settings when switching from one view mode to another

This revision was automatically updated to reflect the committed changes. Closed by commit R241:69754bfed154: Always save view settings when switching from one view mode to another (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=59058&

D21459: Always save view settings when switching from one view mode to another

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21607: Don't delay emission of matchesChanged indefinitely

ngraham added a comment. I think it's quite fine to have the entries jump around a little bit. To me it makes KRunner feel faster to have it start displaying results immediately and then refining them milliseconds later. +1 REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde

D21628: Avoid container detach in a few places

This revision was automatically updated to reflect the committed changes. Closed by commit R293:26e6e5fb46c4: Avoid container detach in a few places (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21628?vs=59269&id=59271 REVISION DETAIL ht

D17595: Upstream Dolphin's file rename dialog

bruns added inline comments. INLINE COMMENTS > renamefiledialog.cpp:105 > +} else { > +newName = i18nc("@info:status", "New name #"); > +editLabel = new QLabel(i18ncp("@label:textbox", The code assumes the "#" is the very last character ("Don't select the # character"), so t

D21628: Avoid container detach in a few places

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21628 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, ast

D21628: Avoid container detach in a few places

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN make REPOSITORY R293 Baloo BRANCH master REVISION DETAIL

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

ngraham added a comment. This fixes it for me: diff --git a/src/file/regexpcache.cpp b/src/file/regexpcache.cpp index f47757ff..dce5cdcb 100644 --- a/src/file/regexpcache.cpp +++ b/src/file/regexpcache.cpp @@ -78,9 +78,9 @@ void RegExpCache::rebuildCacheFromFilterList(con

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/86/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Jun 2019 13:35:56 + Build duration: 9 min 26 sec and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 89 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/89/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 06 Jun 2019 13:35:57 + Build duration: 6 min 14 sec and counting BUILD ARTIFACTS abi-compatibility

D21459: Always save view settings when switching from one view mode to another

ngraham added a comment. Your reasoning makes sense. Shipit! :) REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 179 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/179/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 06 Jun 2019 13:35:57 + Build duration: 4 min 35 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 92 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/92/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 06 Jun 2019 13:35:57 + Build duration: 3 min 4 sec and counting JUnit Tests Name: projectroo

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

bruns added a comment. In D21583#475086 , @bcooksley wrote: > This change unfortunately does not compile on any platform tracked by the CI system. > Please see https://build.kde.org/job/Frameworks/job/baloo/ > > This is something which ne

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Plasma applets when they were all C++ had a way for them to signa

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

broulik abandoned this revision. broulik added a comment. Pushed as part of D21379 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21425 To: broulik, #frameworks, davidedmundson, bruns Cc: kde-frameworks-devel, LeGast00n, michaelh,

D17595: Upstream Dolphin's file rename dialog

meven marked 7 inline comments as done. meven added inline comments. INLINE COMMENTS > bruns wrote in renamefiledialog.cpp:126 > better name - `m_extensionsAreUnique` The current name seems fine to me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #fram

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 59255. meven added a comment. Add a Private class to RenameFileDialog, code fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=47606&id=59255 BRANCH arcpatch-D17595 REVISION DETAIL https://phabricator.kde.o

D17595: Upstream Dolphin's file rename dialog

meven commandeered this revision. meven added a reviewer: ngraham. meven added inline comments. INLINE COMMENTS > pino wrote in renamefiledialog.cpp:50-51 > why a minimum size is enforced? For files whose name is short, I think the dialog would not look nice. This look fine in dolphin. Was added

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 06 Jun 2019 10:48:59 + Build duration: 1 min 32 sec and counting JUnit Tests Name: projectr

D21379: [UDev Backend] Narrow device queried for

This revision was automatically updated to reflect the committed changes. Closed by commit R245:fe1c9c02e09f: [UDev Backend] Narrow device queried for (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21379?vs=59052&id=59253 REVISION DETAIL

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

bcooksley added a comment. This change unfortunately does not compile on any platform tracked by the CI system. Please see https://build.kde.org/job/Frameworks/job/baloo/ This is something which needs correcting relatively urgently, as without it running any Dependency Build job is imp

D21379: [UDev Backend] Narrow device queried for

bruns accepted this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

bruns added a comment. In D21379#475032 , @broulik wrote: > Ping :) > > In D21379#472870 , @bruns wrote: > > > The question now is, should we also differnentiate here, i.e. map `QVariant()` to `n

D21607: Don't delay emission of matchesChanged indefinitely

fvogt updated this revision to Diff 59252. fvogt added a comment. New algorithm with no delay if not necessary. REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21607?vs=59203&id=59252 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21607 AF

D21607: Don't delay emission of matchesChanged indefinitely

fvogt added a comment. In D21607#474772 , @fvogt wrote: > So for the stable branches I'd like to keep the current version of the diff with a latency of [100,599] while for master something like the above with a latency of [0,500] can be tried.