D21661: add snoretoast backend for KNotifications on Windows

[Simon Redman]

sredman added a comment.


  In D21661#476571 , @pino wrote:
  
  > In D21661#476156 , @pino wrote:
  >
  > > how is snoretoast actually used here? you are requiring the library for 
building and linking, but then:
  > >
  > > - `snoretoastactions.h`, which is part of the headers of snoretoast, is 
copied here
  > > - the snoretoast library is never used, as the utilities of it are 
invoked instead If the library does all the work already, then I'd prefer to 
use it directly instead of spawning executables all the time...
  >
  >
  > Piyush, what about this? It seems the snoretoast library provides a 
`SnoreToasts` class to do this instead of spawning an helper tool, what about 
using it instead?
  
  
  @vonreth can probably explain better, but basically the situation as I 
understand it is on Windows you need to be installed in a special place and 
registered with the OS in order to show notifications. Since KNotifications is 
a library, an app using it can't (feasibly) be properly registered with the OS. 
It is possible we could come up with some complicated solution which would 
require every KNotification-using app to do some special and probably difficult 
to understand change to support Windows. Or we can have SnoreNotify.exe take 
care of all that nonsense for us. Note that, up to this point, there have been 
no special KNotifications changes to the generic KDE Connect codebase to make 
this work, just some tweaks to the Windows installer to pull in SnoreToast.
  
  Spawning the process of a small, helper .exe is what other big cross-platform 
apps, like say Chromium/Google Chrome, do.
  
  @pino Thank you very much for your reviews up to this point. It is very 
appreciated :). Supporting notifications on Windows is part of a GSoC project 
to release KDE Connect on Windows. We have a weekly VoIP meeting to talk about 
KDE Connect GSoC progress. If you would like to join those meetings, I can give 
you the information

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Pino Toscano]

pino added a comment.


  > This comment was removed by brute4s99.
  
  This comment was:
  
  > updated wrt review by toscanos
  
  Please do **NOT** remove your own comments. Other than being anti-social 
(imagine how easily you can twist conversations), in this case it's perfectly 
useless, as the default assignee for these reviews is a mailing list, so the 
original message is archived forever.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> CMakeLists.txt:112
> +if (TARGET SnoreToast::SnoreToastActions)
> +  target_link_libraries(KF5Notifications PRIVATE Qt5::Core Qt5::Network 
> SnoreToast::SnoreToastActions)
> +endif ()

`Qt5::Core` is not needed here; if we really want to be pedantic, it ought to 
be added unconditionally (however that would be a different patch than this one)

> brute4s99 wrote in CMakeLists.txt:48-49
> the interfacing plugin (notifybysnore) requires QLocalServer and 
> QLocalSocket, which are from Qt5Network.
> Qt5Core has QProcess, QDir, QTemporaryDir and a bunch of other headers, which 
> are required for the plugin as well.

Qt5Core is already pretty much required to build anything using Qt5, so looking 
for it in this place is a no-op (because it was already found)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Pino Toscano]

pino added a comment.


  In D21661#476156 , @pino wrote:
  
  > how is snoretoast actually used here? you are requiring the library for 
building and linking, but then:
  >
  > - `snoretoastactions.h`, which is part of the headers of snoretoast, is 
copied here
  > - the snoretoast library is never used, as the utilities of it are invoked 
instead If the library does all the work already, then I'd prefer to use it 
directly instead of spawning executables all the time...
  
  
  Piyush, what about this? It seems the snoretoast library provides a 
`SnoreToasts` class to do this instead of spawning an helper tool, what about 
using it instead?
  
  > Also: please format all the new code according to the kdelibs coding style 
-- for example `notifybysnore.cpp`.
  
  Still needs to be done.  Please make sure to indent by 4 spaces only, no 
tabs; also mind the spacing around conditions of `if`s, etc:
  https://community.kde.org/Policies/Kdelibs_Coding_Style
  
  Furthermore: there is a big switch on `snoreAction` that reacts only on 
buttons clicked; some of the other actions hint that the notification was 
closed, so most probably the KNotification object ought to be closed too. Check 
what the `NotifyByPopup` plugins does, for example, as there is something 
similar done.

INLINE COMMENTS

> knotificationmanager.cpp:45
> +#if defined(Q_OS_ANDROID)
> +#include "notifybyandroid.h"
> +#elif defined(Q_OS_WIN)

do not add spaces before the `#` of C preprocessor tokens, as it is 
undefined/nonstandard behaviour

> knotificationmanager.cpp:145
> +#else
> +if (d->inSandbox && d->portalDBusServiceExists) {
> +plugin = new NotifyByPortal(this);

this change is still unrelated -- are you really sure you rebased your work on 
top of the current master branch?

> notifybysnore.cpp:26
> +#include 
> +#include 
> +#include 

not needed (`debug_p.h` is already included)

> notifybysnore.cpp:30
> +#include 
> +#include 
> +

not needed

> notifybysnore.cpp:31-32
> +#include 
> +
> +
> +#include 

extra empty lines

> notifybysnore.cpp:34
> +#include 
> +
> +#include 

extra empty line

> notifybysnore.cpp:38
> +#include 
> +#include 
> +

`QCoreApplication` is enough (see below)

> notifybysnore.cpp:47
> +server = new QLocalServer();
> +server->listen(qApp->applicationName());
> +

`QCoreApplication::applicationName()` is static, so use it directly as static 
(this applies to all the uses)

> notifybysnore.cpp:50
> +QObject::connect(server, &QLocalServer::newConnection, server, [this]() {
> +auto sock = server->nextPendingConnection();
> +sock->waitForReadyRead();

sock is not closed and leaked

> notifybysnore.cpp:56
> +rawData.size() / sizeof(wchar_t));
> +QMap map;
> +for (const auto &str : data.split(QStringLiteral(";"))) {

QMap -> QHash

> notifybysnore.cpp:65
> +const auto snoreAction = 
> SnoreToastActions::getAction(action.toStdWString());
> +qCDebug(LOG_KNOTIFICATIONS) << "The notification ID is : " << 
> QString::number(id);
> +switch(snoreAction){

QDebug can print numbers directly, no need to convert it to string manually

> notifybysnore.cpp:119
> +QStringList arguments;
> +QString iconPath(QStringLiteral(""));
> +

no need to initialize it here -- it can go directly in the if block where it is 
used

> notifybysnore.cpp:120
> +QString iconPath(QStringLiteral(""));
> +
> +

extra empty line

> notifybysnore.cpp:133
> +if(!notification->pixmap().isNull()){
> +iconPath.append(iconDir->path() + QStringLiteral("/") 
> ++ QString::number(notification->id()) + 
> QStringLiteral(".png"));

no need to append, just assign directly (iconPath was empty before, anyway)

> notifybysnore.cpp:147
> +
> +qDebug() << arguments;
> +m_notifications.insert(notification->id(), notification);

either it uses the same debug category of the other message, or it is dropped

> notifybysnore.cpp:154-155
> +proc->close();
> +QFile file(iconPath);
> +file.remove();
> +});

There is a static `QFile::remove()`, so use it directly

> notifybysnore.cpp:154-155
> +proc->close();
> +QFile file(iconPath);
> +file.remove();
> +});

won't this remove the image too early? this will remove the image once the 
process ends, not when notification is closed; this fits better in `close()`

> notifybysnore.cpp:176
> +}
> +arguments.clear();
> +m_notifications.erase(it);

no need to clear this here, it will be deleted at the end of the function 
anyway...

> notifybysnore.cpp:190
> +}
> \ No newline at end of file


C/C++ source require an empty newline at the end

> pino wrote in notifybysnore.cpp:49
> `iconDir` is leaked

this is still not fixed

> pino wrote in notifybysnore.cpp:50
> `server` is leaked

this is still not fixed

> pino wrote in noti

D21681: ECMPackageConfigHelpers -> CMakePackageConfigHelpers

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  As suggested by the ecm package itself

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21681

AFFECTED FILES
  CMakeLists.txt

To: aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

[Stefan Brüns]

bruns added a dependent revision: D21680: [UnindexedFileIndexer] Pick up 
comment, tags and rating changes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21577

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  A folder should be reindexed (i.e. the terms should be updated) when
  the file xattrs are updated, which also updates the ctime.
  
  Depends on D21577 

TEST PLAN
  1. stop the indexer
  2. modify tags/rating/comment
  3. restart the indexer

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21680

AFFECTED FILES
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 marked 4 inline comments as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 59425.
brute4s99 marked 2 inline comments as done.
brute4s99 added a comment.


  updated acc to review by Hannah

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=59401&id=59425

BRANCH
  win32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21586: Add syntax definition for ninja build

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a72b6b5e53ec: Add syntax definition for ninja build 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21586?vs=59240&id=59421

REVISION DETAIL
  https://phabricator.kde.org/D21586

AFFECTED FILES
  autotests/folding/build.ninja.fold
  autotests/html/build.ninja.html
  autotests/input/build.ninja
  autotests/reference/build.ninja.ref
  data/syntax/ninja.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21661: add snoretoast backend for KNotifications on Windows

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> CMakeLists.txt:45
> +   set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED
> +  PURPOSE "Enable support for the snorenotify framework"
> +  DESCRIPTION "a cross-platform notification framework"

It's snoretoast not Snorenotify 😊 so you used the wrong description

> pino wrote in CMakeLists.txt:112
> this should be the `_FOUND` variable, just like done for the others

Hm I don't think the config sets a found variable. But

  if (TARGET Snoretoast::Snoretoast)

Actions should work.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21533: Format photo exposure time as rational when applicable

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Stefan Brüns]

bruns added reviewers: Baloo, ngraham, astippich, poboiko.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21674: [balooctl] Streamline indexer control commands

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Currently, there are 7 commands which start/stop the indexer in some way:
  
  - stop/start/restart: stops or/and starts the indexer process, effective for 
the current session (on next login, the indexer is started when enabled).
  - suspend/resume: the indexer process keeps running, but does not process any 
file events (files added/delete/modified ...).
  - disable/enable: sets the enable state in the config, stops the indexer 
process and deletes the database. On enable (even when already enabled) forces 
a full reindex via the 'firstRun' flag. The deletion of the DB file was done 
silently.
  
  The large number of similar commands is confusing by itself, and more
  so its side effects.
  
  The restart command was also racy, as it tried to start baloo_file even
  when the old instance still held the DBus interface, then the new instance
  would directly exit.
  
  This removes the stop/start/restart command alltogether, and removes the
  deletion of the DB from the disable command. Enable/disable still
  starts/stops the 'baloo_file' process.
  
  To allow deletion of the DB via CLI, a new "purge" command is added. In
  case the indexer was enabled/running, it is kept enabled.

REPOSITORY
  R293 Baloo

BRANCH
  balooctl_start_stop

REVISION DETAIL
  https://phabricator.kde.org/D21674

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21673: [FileIndexScheduler] Ensure indexer is not run in suspended state

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  After commit b13453360685 
 
("Use flag to track when a runner is going idle")
  the scheduler may be triggered from the finished content indexer thread,
  picking up any remaining work and overwriting the "Suspended" state.
  
  Use a flag variable for the suspend state, and determine the current
  state in the scheduler loop, like it is done for e.g. the onBattery
  state.

TEST PLAN
  feed some files into the content indexer
  suspend using `balooctl suspend`, content indexer stops and stays stopped

REPOSITORY
  R293 Baloo

BRANCH
  scheduler

REVISION DETAIL
  https://phabricator.kde.org/D21673

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21672: [PowerStateMonitor] Be conservative when determining power state

[Stefan Brüns]

bruns created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When the state defaults to AC-powered, the indexer may start some
  energy consuming tasks, only to stop these later when the pending
  DBus call finishes. Especially the content indexer can take a while
  to stop, until the current batch is finished.
  
  In case the DBus call fails AC-powered is assumed, to match the previous
  default.

TEST PLAN
  unplug AC power
  start baloo_file
  -> the content indexer no longer processes its first batch

REPOSITORY
  R293 Baloo

BRANCH
  scheduler

REVISION DETAIL
  https://phabricator.kde.org/D21672

AFFECTED FILES
  src/file/powerstatemonitor.cpp

To: bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The 'stop' flag was not set when the scheduler is quit, and the content
  indexer thread would keep running until it had processed all documents
  marked in the DB.

TEST PLAN
  feed some files into the content indexer
  try to stop the indexer, e.g. `balooctl stop` or using DBus
  -> the content indexer should stop after the current batch

REPOSITORY
  R293 Baloo

BRANCH
  scheduler

REVISION DETAIL
  https://phabricator.kde.org/D21671

AFFECTED FILES
  src/file/fileindexscheduler.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 added a comment.


  updating acc to review by pino

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 marked an inline comment as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 59401.
brute4s99 marked an inline comment as done.
brute4s99 added a comment.


  updated wrt review by toscanos

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=59379&id=59401

BRANCH
  win32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 marked 22 inline comments as done and an inline comment as not done.
brute4s99 added a comment.


  update incoming

INLINE COMMENTS

> pino wrote in CMakeLists.txt:48-49
> why are these two needed? if snoretoast require them, then its cmake config 
> file must require them, so that the above `find_package(LibSnoreToast)` is 
> enough

the interfacing plugin (notifybysnore) requires QLocalServer and QLocalSocket, 
which are from Qt5Network.
Qt5Core has QProcess, QDir, QTemporaryDir and a bunch of other headers, which 
are required for the plugin as well.

> pino wrote in knotificationmanager.cpp:76
> this does not seem related to snoretoast

yeah, looks like it picked up changes from commits on master. apologies for 
this.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21586: Add syntax definition for ninja build

[Christoph Cullmann]

cullmann added a comment.


  Perhaps we must go away from the implicit listing of the syntax files and 
really just add them all to the CMakeLists.txt,

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ninja (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21586

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21656: Create a breeze icon for kfourinline

[Nathaniel Graham]

ngraham added a comment.


  Also please add a one-pixel hard bottom shadow.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 119 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/119/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Jun 2019 09:39:36 +
 Build duration:
1 hr 38 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/402)66%
(266/402)55%
(33389/61077)39%
(17061/43994)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9403/9853)48%
(4329/9083)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8520/14470)51%
(4715/9230)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4487/8193)41%
(1953/4753)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1206)39%
(369/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 48 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/48/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Jun 2019 09:42:40 +
 Build duration:
1 hr 30 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.60.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(454/2243)17%
(171/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)54%
(54/100)src100%
(8/8)100%
(8/8)68%
(223/329)49%
(88/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 114 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/114/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Jun 2019 09:42:30 +
 Build duration:
1 hr 28 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13386)18%
(1823/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/28/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Jun 2019 09:41:56 +
 Build duration:
1 hr 22 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.60.0.xmllogs/KF5WindowSystem/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7202/9578)55%
(3551/6419)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3051/3144)52%
(1289/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3357/4686)60%
(1957/3239)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 58 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/58/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 08 Jun 2019 09:39:18 +
 Build duration:
1 hr 25 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 39 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/39/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Jun 2019 09:41:45 +
 Build duration:
1 hr 22 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.60.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/262)92%
(240/262)85%
(27114/31759)53%
(10908/20416)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12445/12520)50%
(6559/13039)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6335/7453)65%
(1825/2820)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7880/9129)66%
(2347/3566)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/40/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:42:52 +
 Build duration:
1 hr 9 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 124 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/124/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:42:30 +
 Build duration:
1 hr 7 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/94/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Jun 2019 09:38:53 +
 Build duration:
1 hr 8 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3683/4336)48%
(5117/10719)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1280/1310)49%
(2556/5237)src79%
(23/29)79%
(23/29)79%
(1230/1552)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/29/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Jun 2019 09:38:18 +
 Build duration:
1 hr 6 min and counting
   BUILD ARTIFACTS
  acc/KF5KDE4Support-5.60.0.xmlacc/KF5KDELibs4Support-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21577/45942)38%
(13024/34237)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11348/11739)50%
(7171/14363)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(743/9698)6%
(306/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1536)0%
(0/487)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/30/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:41:56 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/47/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:41:45 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/53/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Jun 2019 09:42:40 +
 Build duration:
51 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.60.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(447/2240)17%
(172/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)56%
(56/100)src100%
(8/8)100%
(8/8)66%
(216/326)48%
(87/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
   

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/29/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:41:15 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 121 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/121/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Jun 2019 09:42:30 +
 Build duration:
42 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13386)18%
(1822/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:40:57 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 43 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/43/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Jun 2019 09:41:45 +
 Build duration:
40 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.60.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/262)92%
(240/262)85%
(27112/31759)53%
(10905/20416)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12446/12520)50%
(6559/13039)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6332/7453)65%
(1822/2820)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7880/9129)66%
(2347/3566)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/32/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:40:35 +
 Build duration:
41 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 129 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/129/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:39:37 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21656: Create a breeze icon for kfourinline

[Noah Davis]

ndavis added a comment.


  We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen 
thing. How about adding some holes instead to make it look more like the real 
thing? 
https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg
  
  Just some ideas: Use light gray or white circles for the holes and black and 
red for the pieces (like in the actual program). Take a look at the `kiriki` 
icon. The way it does indentations can be inspiration for the holes.
  
  I think the icon is lacking gradients, especially the shadows, which are 
always supposed to be linear gradients.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/23/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:38:28 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/31/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:38:18 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 100 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/100/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 08 Jun 2019 09:38:53 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3683/4336)48%
(5117/10719)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1280/1310)49%
(2556/5237)src79%
(23/29)79%
(23/29)79%
(1230/1552)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/50/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 08 Jun 2019 09:37:52 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttest

D21661: add snoretoast backend for KNotifications on Windows

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> notifybysnore.cpp:115
> +{
> +if (m_notifications.find(notification->id()) != m_notifications.end()) {
> +qCDebug(LOG_KNOTIFICATIONS) << "Duplicate notification with ID: 
> " << notification->id() << " ignored.";

since this method is not const, prefer using constFind + constEnd for the hash 
lookup

> notifybysnore.cpp:119-121
> +if(notification->id() == -1){
> +qCDebug(LOG_KNOTIFICATIONS) << "Notification with ID : \"-1\" 
> ignored.";
> +}

none of the other plugins seem to check for id == -1 here, so I'd say this 
check can be dropped

> notifybysnore.cpp:132
> +arguments << QStringLiteral("-m") << notification->text();
> +arguments << QStringLiteral("-p") <<  file.fileName();
> +arguments << QStringLiteral("-appID") << app->applicationName();

if the notification has no pixmap (see `!notification->pixmap().isNull()` check 
above), then I guess you do not need to pass this argument, as the image will 
not exist

> notifybysnore.cpp:161-163
> +if (it.value()) {
> +finish(it.value());
> +}

`it` is used after erasing it from `m_notifications`, and that means that 
iterator points to nothing; you cannot use iterators after you remove them from 
their container

you already have `notification`, so just use it instead

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns