D21813: RFC: Consider adding more padding to the desktop theme

ndavis added a comment. Hmm. I don't think we should increase the padding on the desktop theme. That kind of approach seems like it would work best once we know the contents of notifications and OSDs are aligned how we want them to be in the code. REPOSITORY R242 Plasma Framework (Library)

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix_races REVISION DETAIL https://phabricator.kde.org/D21709 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

D21813: RFC: Consider adding more padding to the desktop theme

filipf added a comment. In D21813#479950 , @ndavis wrote: > Besides the notifications, where does this add padding? OSDs as far as I can tell, which are also actually not that roomy: F6890931: Screenshot_20190615_021457.png

D21813: RFC: Consider adding more padding to the desktop theme

ndavis added a comment. In D21813#479952 , @ngraham wrote: > I like the rounder corners! :) I don't, but those aren't meant to be discussed in this RFC anyway. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabri

D21813: RFC: Consider adding more padding to the desktop theme

ngraham added a comment. I like the rounder corners! :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

ndavis added a comment. Besides the notifications, where does this add padding? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

filipf edited the test plan for this revision. filipf added reviewers: Plasma, VDG, ngraham, broulik. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngrah

D21813: RFC: Consider adding more padding to the desktop theme

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY Instead of tweaking every plasmoid, add a bit more padding to the desktop theme. This would be an alternative soluti

D21788: Make Plasma::Svg::elementRect a bit leaner

apol marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21788 To: apol, #plasma, #frameworks Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21788: Make Plasma::Svg::elementRect a bit leaner

apol updated this revision to Diff 59837. apol added a comment. static const to be sure that QRegularExpression is only initialised once REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21788?vs=59772&id=59837 BRANCH master REVISION DET

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59835. brute4s99 added a comment. updated acc to workaround for MSVC2019 suggested by Hannah added inline comment for it at L92 -- notifybysnore.cpp REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=598

D21788: Make Plasma::Svg::elementRect a bit leaner

bruns added inline comments. INLINE COMMENTS > apol wrote in svg.cpp:123 > pcre2 does it, AFAIK. Benchmark tells `const static` is faster: F6890682: qre_bench.cpp REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/

D21807: [PendingFileQueueTest] Verify delete + create actually works

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix_races REVISION DETAIL https://phabricator.kde.org/D21807 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH create_delete REVISION DETAIL https://phabricator.kde.org/D21809 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michael

D21807: [PendingFileQueueTest] Verify delete + create actually works

bruns added a dependent revision: D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21807 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhniko

D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When a file has been deleted, a modified event should never

D21807: [PendingFileQueueTest] Verify delete + create actually works

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY A create event should not be merged with a immediately prec

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59826. brute4s99 added a comment. rebased on upstream/master REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59774&id=59826 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b2ebaf5293f1: [PendingFileQueueTest] Use synthetic timer events to speedup test (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21793?vs=59770&id=

D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a58296b2aa21: [XAttrIndexer] Update DocumentTime when XAttrs are updated (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21707?vs=59471&id=59821

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b359101424d8: [PendingFileQueue] Refactor for easier and faster unit testing (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21792?vs=59769&id=598

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

This revision was automatically updated to reflect the committed changes. Closed by commit R293:25ae93a560aa: [PendingFileQueueTest] Shorten timeouts, verify tracking time (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21791?vs=59768&id=5981

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bf100941db29: [PendingFileQueue] Use more accurate calculation of remaining time (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21790?vs=59767&id

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/107/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 14 Jun 2019 19:30:21 + Build duration: 4 min 23 sec and counting BUILD ARTIFACTS abi-com

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/101/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 14 Jun 2019 19:28:24 + Build duration: 3 min 51 sec and counting BUILD ARTIFACTS abi-com

D21707: [XAttrIndexer] Update DocumentTime when XAttrs are updated

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix_races REVISION DETAIL https://phabricator.kde.org/D21707 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/106/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 14 Jun 2019 19:24:18 + Build duration: 6 min 1 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/100/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 14 Jun 2019 19:24:18 + Build duration: 4 min 4 sec and counting BUILD ARTIFACTS abi-comp

D21772: Remove photo prefix from every exif property name

This revision was automatically updated to reflect the committed changes. Closed by commit R286:135fc25b6feb: Remove photo prefix from every exif property name (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21772?vs=59678&id=59817#toc REPOSITORY R286 KFileMetaD

D21519: Rename ImageMake and ImageModel properties

This revision was automatically updated to reflect the committed changes. Closed by commit R286:131947acb0b2: Rename ImageMake and ImageModel properties (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21519?vs=59676&id=59816 REVI

D19732: [KWidgetAddons] Fix build with Qt 5.13

apol closed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D19732 To: matthieugras, apol Cc: mlaurent, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D19732: [KWidgetAddons] Fix build with Qt 5.13

apol added a subscriber: mlaurent. apol added a comment. No, @mlaurent sent a similar patch and since he doesn't ask for review it went unnoticed. commit 57a1ac06fdd712bb39de30d2a0323c8c04d9d5e0 Author: Laurent

D19732: [KWidgetAddons] Fix build with Qt 5.13

ngraham added a comment. @apol @matthieugras is this still needed? If so we need to land it... REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19732 To: matthieugras, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH pendingfilequeue REVISION DETAIL https://phabricator.kde.org/D21793 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, mich

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH pendingfilequeue REVISION DETAIL https://phabricator.kde.org/D21792 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, mich

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

ngraham added a comment. Awesome, thanks! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21709 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21788: Make Plasma::Svg::elementRect a bit leaner

apol added inline comments. INLINE COMMENTS > bruns wrote in svg.cpp:123 > Are you sure about this? As far as I can see: > > `QRegularExpression::QRegularExpression(QString pattern)` default constructs > a `QRegularExpressionPrivate`, which sets `dirty(true)`. > > Calling `QRE::globalMatch()`

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH pendingfilequeue REVISION DETAIL https://phabricator.kde.org/D21791 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, mich

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, makes sense! REPOSITORY R293 Baloo BRANCH pendingfilequeue REVISION DETAIL https://phabricator.kde.org/D21790 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks

D21788: Make Plasma::Svg::elementRect a bit leaner

bruns added inline comments. INLINE COMMENTS > apol wrote in svg.cpp:123 > static isn't necessary, QRegularExpression already has internal regex > compilation optimisations we can leverage. > Does the assert bother you? Are you sure about this? As far as I can see: `QRegularExpression::QRegula

D21788: Make Plasma::Svg::elementRect a bit leaner

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > bruns wrote in svg.cpp:123 > Are you sure you uploaded the right diff? No const static, Q_ASSERT ... static isn't necessary, QRegularExpression already has internal regex compilation optimisations we can levera

D21788: Make Plasma::Svg::elementRect a bit leaner

bruns added inline comments. INLINE COMMENTS > svg.cpp:123 > +QRegularExpression > idExpr(QLatin1String("id\\s*?=\\s*?(['\"])(\\d+?-\\d+?-.*?)\\1")); > +Q_ASSERT(idExpr.isValid()); > Are you sure you uploaded the right diff? No const static, Q_ASSERT ... REPOSITORY R242 Plasma Fram