KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/103/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 16 Jun 2019 00:34:37 + Build duration: 17 min and counting BUILD ARTIFACTS acc/KF5FileMe

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/109/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 16 Jun 2019 00:34:37 + Build duration: 17 min and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 172 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/172/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 16 Jun 2019 00:34:37 + Build duration: 3 min 50 sec and counting JUnit Tests

D21313: Create specific directory for Qt logging categories file

kossebau added subscribers: vkrause, apol. kossebau added a comment. In D21313#480332 , @bcooksley wrote: > This change appears to be responsible for all Android builds being broken. > See https://build.kde.org/view/Failing/ > > Could some

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY All users of TermGenerator::termList do not use QStrings bu

KDE CI: Frameworks » kitemmodels » kf5-qt5 AndroidQt5.12 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20AndroidQt5.12/12/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:26 + Build duration: 6 min 14 sec and counting

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/32/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:25 + Build duration: 5 min 43 sec and counting

KDE CI: Frameworks » kcodecs » kf5-qt5 AndroidQt5.12 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20AndroidQt5.12/17/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:28 + Build duration: 5 min 2 sec and counting

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.12 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.12/18/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:25 + Build duration: 4 min 52 sec and counting

KDE CI: Frameworks » attica » kf5-qt5 AndroidQt5.12 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/22/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:29 + Build duration: 4 min 35 sec and counting

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.12 - Build # 40 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/40/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:27 + Build duration: 2 min 49 sec and counting

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.12 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.12/24/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:24 + Build duration: 2 min 5 sec and counting

KDE CI: Frameworks » syndication » kf5-qt5 AndroidQt5.12 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20AndroidQt5.12/10/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:22 + Build duration: 1 min 58 sec and counting

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.12 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.12/24/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:23 + Build duration: 1 min 56 sec and counting

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.12 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.12/15/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sun, 16 Jun 2019 00:03:22 + Build duration: 1 min 44 sec and counting

KDE CI: Frameworks » karchive » kf5-qt5 AndroidQt5.12 - Build # 53 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20AndroidQt5.12/53/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sat, 15 Jun 2019 23:43:09 + Build duration: 17 min and counting

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. In D20967#480338 , @bcooksley wrote: > Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability to

D19498: loadLibrary: Use enum values to define what type of plugin we load

aspotashev added a reviewer: Frameworks. REPOSITORY R317 Kross REVISION DETAIL https://phabricator.kde.org/D19498 To: aspotashev, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20967: [UserMetaData] Add method to query which attributes are set

bcooksley added a comment. Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability to respond to every review request. That is why the CI system monitors the state of

D17241: WIP:Disable highlighting after 512 characters on a line.

dhaumann accepted this revision. dhaumann added a comment. +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause, dhaumann, mwolff, sars Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraha

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. #windows - thanks for ignoring every review request! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: bcooksley, arrowd, #freebsd, #wi

D21313: Create specific directory for Qt logging categories file

bcooksley added a comment. This change appears to be responsible for all Android builds being broken. See https://build.kde.org/view/Failing/ Could someone take a look please? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfau

D20967: [UserMetaData] Add method to query which attributes are set

bcooksley added a comment. This change has unfortunately made MSVC unhappy - https://build.kde.org/view/Failing/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/lastFailedBuild/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann added a comment. I am not sure about the warning. The line length limit default should be increased it think, we could just try something like 1 for a start. I would propose we try this without a warning and see if we get negative feedback. Normally this should only kick in

D21661: add snoretoast backend for KNotifications on Windows

vonreth added inline comments. INLINE COMMENTS > shubham wrote in notifybysnore.h:44 > I doubt this compiles...You can't initialise variables inside the class Have you heard of this new c++ standard? C++11? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 171 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/171/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 15 Jun 2019 16:18:58 + Build duration: 3 hr 17 min and counting CONSOLE OUTPUT

D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The positions() method is only used inside the PhraseAndIte

D17241: WIP:Disable highlighting after 512 characters on a line.

sars added a comment. I tried the patch and it improved the performance really much! :) I was able to edit a line that contained over a million characters! Unfortunately I can't comment on the code too much, as I don't know the code enough. Some general stuff: 1. Should there b

D21661: add snoretoast backend for KNotifications on Windows

shubham added inline comments. INLINE COMMENTS > notifybysnore.h:44 > +QHash> m_notifications; > +QString program = QStringLiteral("SnoreToast.exe"); > +QLocalServer server; I doubt this compiles...You can't initialise variables inside the class REPOSITORY R289 KNotifications REV

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 170 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/170/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Jun 2019 18:16:47 + Build duration: 2 days 22 hr and counting CONSOLE OUTPUT

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 70 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/70/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 12 Jun 2019 05:23:56 + Build duration: 3 days 10 hr and counting

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/102/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 15 Jun 2019 14:24:54 + Build duration: 3 min 55 sec and counting BUILD ARTIFACTS abi-com

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/108/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 15 Jun 2019 14:24:54 + Build duration: 3 min 50 sec and counting BUILD ARTIFACTS acc/KF5

D21661: add snoretoast backend for KNotifications on Windows

vonreth added inline comments. INLINE COMMENTS > pino wrote in notifybysnore.cpp:92 > please document what is the issue, so in the future the workaround can be > dropped I can't put my finger on it I can only tell that https://github.com/KDE/snoretoast/blob/a53a6b733624ada78ef0f852407cad4be1c0

D21830: Format photo exposure bias value

astippich updated this revision to Diff 59875. astippich added a comment. - remove unnecessary else REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21830?vs=59874&id=59875 BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830 A

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

apol added a comment. In D21369#480148 , @albertvaka wrote: > If I understand correctly, the only reason to use KContacts here is so we can use its PhoneNumber type. We could change it to a QString? It is a string now, the advantage of u

D21830: Format photo exposure bias value

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:193 > +return i18nc("Exposure bias/compensation in exposure value (EV)", > "%1 EV", locale.toString(val, 'g', 3)); > +} else { > +int integral = roundedSixthParts / 6; no need for else here, you return. dito be

D21830: Format photo exposure bias value

astippich updated this revision to Diff 59874. astippich added a comment. - remove unneeded newline REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21830?vs=59873&id=59874 BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830 A

D21830: Format photo exposure bias value

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

astippich updated this revision to Diff 59873. astippich added a comment. - cover 1/2 case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21830?vs=59870&id=59873 BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830 AFFECTED F

D21830: Format photo exposure bias value

astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:183 > You obviously multiply here ... dividing by one third is multiplying by three :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde

D21830: Format photo exposure bias value

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:183 > +auto val = value.toDouble(); > +// exposure values are in steps of one third, divide by it > +auto thirds = val * 3; You obviously multiply here ... REPOSITORY R286 KFileMetaData REVISION DETAIL https://pha

D21830: Format photo exposure bias value

bruns added a comment. In D21830#480185 , @astippich wrote: > In D21830#480181 , @bruns wrote: > > > Many cameras can be switched to 1/2 EV steps. > > > Damn ;) do you know any other values? In

D21830: Format photo exposure bias value

astippich added a comment. In D21830#480181 , @bruns wrote: > Many cameras can be switched to 1/2 EV steps. Damn ;) do you know any other values? In case not, I would add this case in a loop and stupidly try everything REPOSITORY R286

D21830: Format photo exposure bias value

bruns added a comment. Many cameras can be switched to 1/2 EV steps. INLINE COMMENTS > formatstrings.cpp:189 > +int wholeNumber = roundedThirds / 3; > +if (wholeNumber > 0) { > +return i18nc("Exposure compensation given in thirds, with whole > number, in exposure

D17302: Add test for adding properties to result

astippich added a comment. ping! this now tests the resulting document and tests how the different data types are added to it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov

D21830: Format photo exposure bias value

astippich added a comment. exposure bias seems mostly to be in steps of 1/3 according to https://www.geofflawrence.com/exposure_compensation.html REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #bal

D21830: Format photo exposure bias value

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Format the photo exposure bias value in EV units and in ste

D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bb011d2fc034: [PendingFileQueueTest] Verify create + delete do not emit extra events (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21809?vs=5982

D21807: [PendingFileQueueTest] Verify delete + create actually works

This revision was automatically updated to reflect the committed changes. Closed by commit R293:309518239d77: [PendingFileQueueTest] Verify delete + create actually works (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21807?vs=59827&id=59868

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9b0ecc5d41b0: [PendingFileQueue] Avoid delete + create / create + delete race (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21709?vs=59473&id=59867#toc REPOSITORY R293

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

albertvaka added a comment. If I understand correctly, the only reason to use KContacts here is so we can use its PhoneNumber type. We could change it to a QString? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: albertvaka, kde-framework

D21661: add snoretoast backend for KNotifications on Windows

vonreth added inline comments. INLINE COMMENTS > notifybysnore.cpp:72 > +sock->deleteLater(); > +sock->close(); > +const QString data = deleteLater should also close the socket. Also don't use a pointer after you deleted it, even with a deleteLater. REPOSITORY R289 KNo

D21712: KateModeMenuList: move to QListView

nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21712 To: nibags, #ktexteditor, cullmann, dhaumann Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D21711: Julia: update syntax and add constants keywords

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c91c2554215d: Julia: update syntax and add constants keywords (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21711?vs=59476&id=598

D21661: add snoretoast backend for KNotifications on Windows

pino added a comment. Ah, one last thing I apparently forgot to mention so far: the names of class variables must start with `m_`. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pin

D21661: add snoretoast backend for KNotifications on Windows

pino added a comment. In D21661#479366 , @brute4s99 wrote: > I think I should make a new diff for further discussions, as this one is quite riddled with suggestions now. Are there any more issues with this patch or should I continue with a new

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr planned changes to this revision. chinmoyr added a comment. TODO - Change the UI of the warning dialog - We still need more details REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21783 To: chinmoyr, #vdg, #frameworks, dfaure Cc: ngraham, kde-frameworks-d

D21204: Ensure no trailing slash in mountpoint read from fstab file.

meven added a comment. How do you like this alternative @bruns ? The upside is that is fixes the bug and does not change stored data and keeps compatibility. The downside is that it is a little hackish. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: mev