KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 105 - Fixed!

2019-06-29 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/105/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 30 Jun 2019 06:45:35 +
 Build duration:
6 min 47 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3781/)48%
(5228/10937)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1307/1337)49%
(2613/5353)src79%
(23/29)79%
(23/29)80%
(1301/1633)45%
(547/1228)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3601)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/749)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 111 - Fixed!

2019-06-29 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/111/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 30 Jun 2019 06:45:35 +
 Build duration:
3 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3781/)48%
(5228/10937)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1307/1337)49%
(2613/5353)src79%
(23/29)79%
(23/29)80%
(1301/1633)45%
(547/1228)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3601)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/749)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D22157: Use debugging category in taglib extractor/writer

2019-06-29 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ce0b873f1888: Use debugging category in taglib 
extractor/writer (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22157?vs=60844&id=60850

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21586: Add syntax definition for ninja build

2019-06-29 Thread jonathan poelen 
jpoelen added a comment.


  After reflection (:D), I think the constraint is weak, the creation of new 
syntax is rare compared to the rest.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21586

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D22155: Add new activities and virtual desktops icons

2019-06-29 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I'm accepting this, but make sure you don't land this until you've submitted 
the other patches.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

D22155: Add new activities and virtual desktops icons

2019-06-29 Thread Björn Feber 
GB_2 added a comment.


  In D22155#488192 , @ndavis wrote:
  
  > Nice job!
  >
  > Are there other patches coming soon to fix the code where 
`preferences-activities` was used?
  
  
  Yeah, I'll make them soon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

D21563: Fix empty pages in print preview and lines printed twice

2019-06-29 Thread Dominik Haumann 
dhaumann closed this revision.
dhaumann added a comment.


  Fixed for KF 5.60 with commit 6bbbe6aa51c0a293a58dbca6223e37a73ce32122, 
thanks for the patch - keep it coming!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21563

To: hoffmannrobert, #kate, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, 
domson, michaelh, bruns, demsking, sars

D21563: Fix empty pages in print preview and lines printed twice

2019-06-29 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I just tested kwrite from master with Qt 5.12.0, and printing was completely 
broken. It even printed on Letter even though I specified A4 paper. A Qt update 
to Qt 5.12.3 fixed this - good so far.
  
  Indeed I can reproduce the following: If I have a line that wraps to the next 
page, the line is printed twice. With this patch, it works!

REPOSITORY
  R39 KTextEditor

BRANCH
  fix_preview_and_printing

REVISION DETAIL
  https://phabricator.kde.org/D21563

To: hoffmannrobert, #kate, #ktexteditor, dhaumann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, 
domson, michaelh, bruns, demsking, sars

D22156: RFC: Add wayland-protocols find module

2019-06-29 Thread Vlad Zagorodniy 
zzag abandoned this revision.
zzag added a comment.


  In D22156#488219 , @cgiboudeaux 
wrote:
  
  > how many users are there?
  
  
  Hmm, at this moment none. KWayland would be the primary user (and perhaps the 
only one). Perhaps ECM is not good place for this find module. Sorry for the 
noise.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22156

To: zzag, #kwin, #frameworks
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
bencreasy, michaelh, ngraham, bruns

D22157: Use debugging category in taglib extractor/writer

2019-06-29 Thread Stefan Brüns 
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_logging

REVISION DETAIL
  https://phabricator.kde.org/D22157

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22156: RFC: Add wayland-protocols find module

2019-06-29 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  how many users are there?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22156

To: zzag, #kwin, #frameworks
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
bencreasy, michaelh, ngraham, bruns

D22157: Use debugging category in taglib extractor/writer

2019-06-29 Thread Alexander Stippich 
astippich updated this revision to Diff 60844.
astippich added a comment.


  - adjust writer cmake

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22157?vs=60843&id=60844

BRANCH
  taglib_logging

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22157: Use debugging category in taglib extractor/writer

2019-06-29 Thread Alexander Stippich 
astippich updated this revision to Diff 60843.
astippich added a comment.


  - use separate debug src

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22157?vs=60838&id=60843

BRANCH
  taglib_logging

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

2019-06-29 Thread Alexander Stippich 
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:356
> is this always just one value, or a list as well?

as far as I know, asf only allows single entry tags, so just a single value

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

2019-06-29 Thread Alexander Stippich 
astippich updated this revision to Diff 60842.
astippich marked an inline comment as done.
astippich added a comment.


  - add trimmed(), adjust test
  - fileExtension

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20526?vs=60334&id=60842

BRANCH
  arcpatch-D20526

REVISION DETAIL
  https://phabricator.kde.org/D20526

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/extractors/taglibextractor.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22156: RFC: Add wayland-protocols find module

2019-06-29 Thread Aleix Pol Gonzalez 
apol added a comment.


  LGTM +1

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22156

To: zzag, #kwin, #frameworks
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, 
michaelh, ngraham, bruns

D22155: Add new activities and virtual desktops icons

2019-06-29 Thread Noah Davis 
ndavis added a comment.


  Nice job!
  
  Are there other patches coming soon to fix the code where 
`preferences-activities` was used?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

D22147: Better use of Qt APIs in Plasma::Theme

2019-06-29 Thread Aleix Pol Gonzalez 
apol marked 3 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> broulik wrote in theme.cpp:106
> Can we clean up all of this custom refcounting by using a `QSharedPointer`?

Implemented with QSharedData.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22147

To: apol, #plasma, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22147: Better use of Qt APIs in Plasma::Theme

2019-06-29 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 60840.
apol marked an inline comment as done.
apol added a comment.


  Address kai's comments

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22147?vs=60802&id=60840

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22147

AFFECTED FILES
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/svg.cpp
  src/plasma/theme.cpp

To: apol, #plasma, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22157: Use debugging category in taglib extractor/writer

2019-06-29 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> CMakeLists.txt:136
>  kde_enable_exceptions()
> -ecm_add_test(taglibextractortest.cpp 
> ../src/extractors/taglibextractor.cpp
> +ecm_add_test(taglibextractortest.cpp 
> ../src/extractors/taglibextractor.cpp ../src/kfilemetadata_debug.cpp
>  TEST_NAME "taglibextractortest"

use `${KfileMetaDataAutotest_SRCS}` instead ...

> CMakeLists.txt:153
>  
>  ecm_add_test(externalextractortest.cpp ../src/externalextractor.cpp 
> ${KfileMetaDataAutotest_SRCS}
>  TEST_NAME "externalextractortest"

... like done here

> CMakeLists.txt:19
>  if(TAGLIB_FOUND)
> -add_library(kfilemetadata_taglibextractor MODULE taglibextractor.cpp )
> +add_library(kfilemetadata_taglibextractor MODULE taglibextractor.cpp 
> ../kfilemetadata_debug.cpp)
>  target_include_directories(kfilemetadata_taglibextractor SYSTEM PRIVATE 
> ${TAGLIB_INCLUDES})

please change the `ecm_declare_logging_category` in `src/CMakeLists.txt` to a 
distinct variable for the debug source file, and use it here.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D22157

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

2019-06-29 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> taglibwritertest.cpp:556
> +
> +data.add(Property::Artist, QStringLiteral("Artist1 feat Artist2"));
> +data.add(Property::AlbumArtist, QStringLiteral("Artist1 feat. Artist2"));

const map properties = { {Artist, "Artist", ...};
  for (property : properties) {
data.add(...);
  }
  
  write(data);
  exxtractResult(...);
  
  for (property: properties) {
QCOMPARE(...);
  }

> taglibwritertest.cpp:578
> +{
> +QTest::addColumn("fileType");
> +QTest::addColumn("mimeType");

fileExtension

> taglibextractor.cpp:171
>  for (const auto& artist : artists) {
> -result->add(Property::Artist, artist);
> +result->add(Property::Artist, TStringToQString(artist));
>  }

There is a small mismatch between this one (and all others below) and e.g. 
"LYRICS" above - one uses `trimmed()`, the other does not.

IMHO, all properties should be trimmed (though we risk not being 
roundtrip-save).

> taglibextractor.cpp:356
>  lstASF = asfTags->attribute("Author");
>  if (!lstASF.isEmpty()) {
>  const auto attribute = lstASF.front();

is this always just one value, or a list as well?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22157: Use debugging category in taglib extractor/writer

2019-06-29 Thread Alexander Stippich 
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  taglib_logging

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20526: Fix extracting of some properties to match what was written

2019-06-29 Thread Alexander Stippich 
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20526

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22156: RFC: Add wayland-protocols find module

2019-06-29 Thread Vlad Zagorodniy 
zzag retitled this revision from "Add wayland-protocols find module" to "RFC: 
Add wayland-protocols find module".

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22156

To: zzag, #kwin, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, 
ngraham, bruns

D22156: Add wayland-protocols find module

2019-06-29 Thread Vlad Zagorodniy 
zzag created this revision.
zzag added reviewers: KWin, Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  This module can be used to retrieve path of a directory with all 
wayland-protocols'
  protocols, like xdg-shell, and so on.
  
  Example usage
  
find_package(WaylandProtocols REQUIRED)

ecm_add_wayland_client_protocol(CLIENT_LIB_SRCS
PROTOCOL ${WaylandProtocols_DATADIR}/stable/xdg-shell/xdg-shell.xml
BASENAME xdg-shell
)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  find-wayland-protocols

REVISION DETAIL
  https://phabricator.kde.org/D22156

AFFECTED FILES
  docs/find-module/FindWaylandProtocols.rst
  find-modules/FindWaylandProtocols.cmake

To: zzag, #kwin, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, 
ngraham, bruns

D22155: Add new activities and virtual desktops icons

2019-06-29 Thread Björn Feber 
GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  This adds new monochrome icons corresponding to the colorful ones. Also 
deletes the old monochrome `preferences-activies` icon and updates the symlinks 
that pointed to it.
  F6943845: activities Icon.png 
  F6943846: virtual-desktops Icon.png 

TEST PLAN
  Search for `activities` and `virtual-desktops` in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

AFFECTED FILES
  icons-dark/actions/16/activities.svg
  icons-dark/actions/16/diag_activity.svg
  icons-dark/actions/16/preferences-activities.svg
  icons-dark/actions/16/umbrello_diagram_activity.svg
  icons-dark/actions/16/virtual-desktops.svg
  icons-dark/actions/22/activities.svg
  icons-dark/actions/22/diag_activity.svg
  icons-dark/actions/22/preferences-activities.svg
  icons-dark/actions/22/umbrello_diagram_activity.svg
  icons-dark/actions/22/virtual-desktops.svg
  icons-dark/actions/24/activities.svg
  icons-dark/actions/24/preferences-activities.svg
  icons-dark/actions/24/virtual-desktops.svg
  icons/actions/16/activities.svg
  icons/actions/16/diag_activity.svg
  icons/actions/16/preferences-activities.svg
  icons/actions/16/umbrello_diagram_activity.svg
  icons/actions/16/virtual-desktops.svg
  icons/actions/22/activities.svg
  icons/actions/22/diag_activity.svg
  icons/actions/22/preferences-activities.svg
  icons/actions/22/umbrello_diagram_activity.svg
  icons/actions/22/virtual-desktops.svg
  icons/actions/24/activities.svg
  icons/actions/24/preferences-activities.svg
  icons/actions/24/virtual-desktops.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, bruns

D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-06-29 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:231
> +// it will match its eventual mounted device regardless whether or not 
> it ends with a slash
> +for (QString device : fstabDevices) {
> +QString deviceName = device;

get it by const ref.

> fstabhandling.cpp:236
> +} else {
> +deviceName = device + '/';
> +}

deviceName.append('/');

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, 
michaelh

D10747: Implement zwp_linux_dmabuf_v1

2019-06-29 Thread Vlad Zagorodniy 
zzag added a comment.


  > Update protocol xml to wayland-protocols master
  
  OT: there's a package called wayland-protocols. We could use it in order to 
avoid copying protocol specs.
  
  name=FindWaylandProtocols.cmake
#.rst:
# FindWaylandProtocols
# ---
#
# Try to find wayland-protocols on a Unix system.
#
# This will define the following variables:
#
# ``WaylandProtocols_FOUND``
# True if (the requested version of) wayland-protocols is available
# ``WaylandProtocols_VERSION``
# The version of wayland-protocols
# ``WaylandProtocols_DATADIR``
# The wayland protocols data directory

find_package(PkgConfig)
pkg_check_modules(PKG_wayland_protocols QUIET wayland-protocols)

set(WaylandProtocols_VERSION ${PKG_wayland_protocols_VERSION})
pkg_get_variable(WaylandProtocols_DATADIR wayland-protocols pkgdatadir)

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(WaylandProtocols
FOUND_VAR WaylandProtocols_FOUND
REQUIRED_VARS WaylandProtocols_DATADIR
VERSION_VAR WaylandProtocols_VERSION
)

include(FeatureSummary)
set_package_properties(WaylandProtocols PROPERTIES
URL "https://wayland.freedesktop.org/";
DESCRIPTION "Specifications of extended Wayland protocols"
)
  
  and then use it as follows
  
find_package(WaylandProtocols 1.8 REQUIRED)


${WaylandProtocols_DATADIR}/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: zzag, kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, 
jraleigh, sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, 
ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D20766: Use appropriate background color for text previews

2019-06-29 Thread Méven Car 
meven added a comment.


  For context :
  F6943088: Screenshot_20190629_110927.png 

  
  Given D21295 , can we move forward here ?

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: dhaumann, cullmann, vkrause, cfeck, meven, broulik, kde-frameworks-devel, 
kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-06-29 Thread Méven Car 
meven added a comment.


  ping @bruns

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

2019-06-29 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D13048

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik, meven, apol, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22144: - Add kio recentlyused:/ to access KactivitytStats data

2019-06-29 Thread Méven Car 
meven edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D22144: - Add kio recentlyused:/ to access KactivitytStats data

2019-06-29 Thread Méven Car 
meven edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D22143: Add proper logging using ECMQtDeclareLoggingCategory

2019-06-29 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> kossebau wrote in CMakeLists.txt:21
> Instead of relying on an undocumented  cpp file name generated by 
> ecm_qt_declare_logging_category, you rather want to have a separate SRC 
> variable which carries the source files generated by the macro, and add its 
> content here by instead adding this to the list:
> 
>   ${KActivitiesStats_LOG_SRCS}
> 
> That variable will also make it easier to track where this file is actually 
> coming from, instead having to guess it.

While it is true, the solution here is not ideal, it is quite commonly used in 
kde projects and anyone opening the CMakeLists.txt should come up pretty 
quickly that this file is being generated elsewhere.
I just lack a viable alternative. I had a hard time to uncover this solution in 
the first place.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks
Cc: kossebau, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns