D22102: Implement apply-on-double-click for all grid view KCM delegates

[Mariusz Glebocki]

mglb added a comment.


  In D22102#487806 , @ngraham wrote:
  
  >
  
  
  use its hidden Alt accelerator.
  
  Seems like already working solution for the problem. Whats wrong with alt 
accelerator?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22102

To: ngraham, #plasma, #vdg, mart, broulik
Cc: ndavis, anthonyfieroni, pino, davidedmundson, filipf, mglb, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/34/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 01 Jul 2019 02:55:30 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D21204: Ensure no trailing slash in mountpoint read from fstab file

[Nathaniel Graham]

ngraham retitled this revision from "Ensure no trailing slash in mountpoint 
read from fstab file." to "Ensure no trailing slash in mountpoint read from 
fstab file".

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, 
LeGast00n, michaelh

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Nathaniel Graham]

ngraham added a comment.


  In D21204#488719 , @dhaumann wrote:
  
  > Minor/general comment: given this is a KDE Frameworks change, could you 
improve the summary of the commit message for this and future commits? Here it 
just says bug, ccbug, fixedin. Imho a commit log should be self-explaining and 
self-contained: what is broken exactly, why is it broken, why is the suggested 
fix correct, what testing did you do, what possible risks does the change have?
  >
  > Everything is missing here. As consequence, you get poor or no reviews, and 
no one feels good enough giving a ship-it.
  
  
  +100; improving your title and description is often a key part of getting 
more reviewers.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, 
LeGast00n, michaelh

D22108: [TabBar] Remove exterior margins

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:97272465a8b4: [TabBar] Remove exterior margins (authored 
by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22108?vs=60704=60896

REVISION DETAIL
  https://phabricator.kde.org/D22108

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabBar.qml

To: filipf, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/128/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 30 Jun 2019 22:06:48 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13389)18%
(1823/9907)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3501)28%
(793/2847)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2020)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 121 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/121/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 30 Jun 2019 22:06:48 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3629/13389)18%
(1823/9907)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3501)28%
(793/2847)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2020)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/131/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 30 Jun 2019 22:06:48 +
 Build duration:
4 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Dominik Haumann]

dhaumann added a comment.


  Minor/general comment: given this is a KDE Frameworks change, could you 
improve the summary of the commit message for this and future commits? Here it 
just says bug, ccbug, fixedin. Imho a commit log should be self-explaining and 
self-contained: what is broken exactly, why is it broken, why is the suggested 
fix correct, what testing did you do, what possible risks does the change have?
  
  Everything is missing here. As consequence, you get poor or no reviews, and 
no one feels good enough giving a ship-it.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, 
LeGast00n, michaelh

D21813: RFC: Consider adding more padding to the desktop theme

[Filip Fila]

filipf added a comment.


  friendly ping
  
  @ndavis would you be willing to give it a go at making a proper patch for 
this (i.e. editing the Breeze svg)?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

Tipping the apple cart?

[Valorie Zimmerman]

Hello folks, as you know, I'm not a coder. However, I'm interested in our
code quality, and there has been some observation that "lots of patches get
missed, and submitters get confused due to a lack of auto-populated
reviewers" on Phabricator. Nate Graham has been adding groups to the
reviewers by hand, and would like to not do that any more.

However, many developers simply route all Phab emails to folders where they
sit unread, because Phab sends out an email for every event and comment!
This is far too spammy. In our move to Gitlab, we can do better. Right now,
the devel email lists get these emails -- but it is assumed that they are
often not read, because of the number of patches sitting unreviewed, and
unused. This is bad for our community, and very discouraging to newcomers.
One of our best recent initiatives has been the improve our onboarding
process, and this needs to be part of it.

Improving the workflow on Phabricator is almost pointless, since we're
leaving it. However, please give your ideas, thoughts and even opinions on
how best to improve this in Gitlab. I think if we engineer this well, we
can get more newbie contributors and more new *reviewers.*

I'm ok with starting Yet Another discussion which threatens to tip the
apple cart, because right now, the apples are already on the ground,
rotting.

Valorie

-- 
http://about.me/valoriez - pronouns: she/her

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil updated this revision to Diff 60891.
dvratil added a comment.


  Adapt to API changes in D21901 

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21902?vs=60066=60891

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21902

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h
  src/declarativeimports/calendar/eventdatadecorator.cpp
  src/declarativeimports/calendar/eventdatadecorator.h
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/calendar/eventpluginsmanager.h

To: dvratil, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

[Daniel Vrátil]

dvratil updated this revision to Diff 60890.
dvratil added a comment.


  Make the change truly API and ABI compatible

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21901?vs=60068=60890

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21901

AFFECTED FILES
  src/calendarevents/calendareventsplugin.cpp
  src/calendarevents/calendareventsplugin.h

To: dvratil, #frameworks, mart
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#486700 , @meven wrote:
  
  > I have started D22082  enrolling the 
plan set in the previous comment.
  >
  > Once this task has done enough progress and has landed some of its work, I 
will be able to revisit this diff.
  
  
  Work has moved to the kio-extras repo and is good enough for review D22144 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22144: - Add kio recentlyused:/ to access KactivitytStats data

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22144: - Add kio recentlyused:/ to access KactivitytStats data

[Méven Car]

meven added a comment.




REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22144: - Add kio recentlyused:/ to access KactivitytStats data

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22144: - Add kio recentlyused:/ to access KactivitytStats data

[Méven Car]

meven updated this revision to Diff 60886.
meven marked an inline comment as done.
meven added a comment.


  New json metadata file

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22144?vs=60789=60886

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22144

AFFECTED FILES
  CMakeLists.txt
  kio-extras.categories
  recentlyused/CMakeLists.txt
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h
  recentlyused/recentlyused.json

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik, meven, apol, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

[Méven Car]

meven added a comment.


  Nice work !

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik, meven, apol, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22144: - Add kio recentlyused:/ to access KactivitytStats data

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> recentlyused.protocol:1-14
> +[Protocol]
> +X-DocPath=kioslave5/recentlyused/index.html
> +exec=kf5/kio/recentlyused
> +protocol=recentlyused
> +Icon=document-open-recent
> +input=none
> +output=filesystem

We should use the JSON format for new ioslaves.

You can use the slaves in KIO as example.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

[Christoph Cullmann]

cullmann added a comment.


  I think I misunderstood the feature, sorry.
  
  I did now try the patch again (it didn't apply perfectly, but that was just a 
few lines of code to be moved in the katedocument.cpp patch. I tend to agree 
that until we have perhaps some proper config for that in syntax files, some 
presets and the ability for users to add own presets make sense.
  
  On can still later introduce some "syntax defined" enum value to query stuff 
from the syntax defintions.
  
  What I would change is the placement of the SetOfCharsToEncloseSelection 
enum, I think it is only needed in the dialog, or? I got partly confused by 
that as I thought it would be used to store the settings, but the settings are 
just stored as stringlist and the enum is only to make the UI aware of the 
presets, or?

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, LeGast00n, domson, michaelh, bruns, demsking, dhaumann

D22102: Implement apply-on-double-click for all grid view KCM delegates

[Nathaniel Graham]

ngraham added a comment.


  I don't really know what else to say. The current workflow is annoying and 
slow for me and I want to improve it. Maybe this isn't the best way, but it's 
rather frustrating to come up against a wall of opposition doubting whether 
it's a problem at all, or if it is, whether it's worth fixing.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22102

To: ngraham, #plasma, #vdg, mart, broulik
Cc: ndavis, anthonyfieroni, pino, davidedmundson, filipf, mglb, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22102: Implement apply-on-double-click for all grid view KCM delegates

[Noah Davis]

ndavis added a comment.


  In D22102#487806 , @ngraham wrote:
  
  > Maybe I should move back and examine the rationale for the proposal.
  >
  > Right now, I find it *extremely* annoying, slow, and frustrating to test 
new themes, colors, icons, wallpapers, etc. The workflow is to click on the 
delegate, and then click on the Apply button in the corner of the window, or 
use its hidden Alt accelerator. If I want to see 5 items, I do this five times. 
If I want to look through 20 items, I do this 20 times. Every time I do this, I 
get frustrated and feel like it should be doable in a faster way.
  >
  > This proposal is one way to resolve the issue. I don't personally see a 
problem with the hidden double-click accelerator (obviously, or else I wouldn't 
have submitted the patch :) ), but if people don't like this approach, I hope 
we can have a conversation about alternative approaches to resolve the 
underlying issue of the test-multiple-items-in-a-grid-view-KCM workflow being 
quite slow. I can think of a few:
  >
  > - Move to the instant apply paradigm
  > - Add Preview buttons to all delegates that "virtually" apply the item to 
everything visible on screen
  > - Do the above, but on hover or selection, with a visible message that says 
"this is just a preview", click Apply to apply these settings"
  > - Probably way more
  
  
  Exposing the options through a simple command line interface would be another 
option.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22102

To: ngraham, #plasma, #vdg, mart, broulik
Cc: ndavis, anthonyfieroni, pino, davidedmundson, filipf, mglb, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a comment.


  In D22155#488593 , @ngraham wrote:
  
  > In D22155#488485 , 
@anthonyfieroni wrote:
  >
  > > Renaming the icon is not quite good, if someone use newer framework and 
old applications / Plasma will not see an icon. That's pretty happen since 
framework incorporate new features + bugs fix and Plasma offers LTS.
  >
  >
  > Do you have any examples of distros that do this? To my knowledge, all 
"LTS" style distros freeze all versions of KDE software, not just Plasma and 
apps. Though I guess it would be a problem for rolling release distros that 
will offer  users Frameworks 5.60 months before Plasma 5.17.
  >
  > If it's a problem, we could wait a month and commit the Frameworks change 
for Frameworks 5.62, which is the release aligned with Plasma 5.17.
  
  
  I'd say we land this now for Frameworks 5.60 which releases July 6th and then 
backport the one small plasma-desktop patch to the stable branch, so it gets in 
5.16.3, which releases July 9th.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, 
michaelh, bruns

D22155: Add new activities and virtual desktops icons

[Nathaniel Graham]

ngraham added a comment.


  In D22155#488485 , @anthonyfieroni 
wrote:
  
  > Renaming the icon is not quite good, if someone use newer framework and old 
applications / Plasma will not see an icon. That's pretty happen since 
framework incorporate new features + bugs fix and Plasma offers LTS.
  
  
  Do you have any examples of distros that do this? To my knowledge, all "LTS" 
style distros freeze all versions of KDE software, not just Plasma and apps. 
Though I guess it would be a problem for rolling release distros that will 
offer  users Frameworks 5.60 months before Plasma 5.17.
  
  If it's a problem, we could wait a month and commit the Frameworks change for 
Frameworks 5.62, which is the release aligned with Plasma 5.17.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, 
michaelh, bruns

D10362: Change reveal password button logic

[Nathaniel Graham]

ngraham added a comment.


  In D10362#488571 , @ndavis wrote:
  
  > In D10362#488389 , @ngraham 
wrote:
  >
  > > I think the idea is that you're not supposed to be typing with the 
characters visible as you type because then anyone else who might be around 
could just see your password.
  >
  >
  > I understand this, but I think this is one of those cases where a marginal 
increase in security should take a backseat to usability. It's not like people 
can't quickly hide the password again if they already know about the button. If 
one is afraid of others looking over their shoulder, they shouldn't use the 
reveal password button in the first place, regardless of how it functions.
  
  
  Yeah, I guess that makes sense.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10362: Change reveal password button logic

[Noah Davis]

ndavis added a comment.


  In D10362#488389 , @ngraham wrote:
  
  > I think the idea is that you're not supposed to be typing with the 
characters visible as you type because then anyone else who might be around 
could just see your password.
  
  
  I understand this, but I think this is one of those cases where a marginal 
increase in security should take a backseat to usability. If one is afraid of 
others looking over their shoulder, they shouldn't use the reveal password 
button in the first place, regardless of how it functions. It's not like people 
can't quickly hide the password again if they already know about the button.
  
  > If you're in an environment where security concerns are sufficiently low as 
to permit this, it would probably make more sense to not even set a password, 
or use auto-login.
  
  I disagree. Just because you aren't likely to have someone looking over your 
shoulder, doesn't mean nobody will attempt to access your computer while you're 
not around.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22155: Add new activities and virtual desktops icons

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D22155#488497 , @GB_2 wrote:
  
  > We can backport the changes in Plasma to the LTS branch though.
  
  
  We can backport but you cannot increase depends on 5.60 to the LTS branch. So 
it should have a fallback code, if new icon isn't found to be used old one.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, 
michaelh, bruns

D22147: Better use of Qt APIs in Plasma::Theme

[Aleix Pol Gonzalez]

apol updated this revision to Diff 60875.
apol added a comment.


  address logic, no artifacts

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22147?vs=60840=60875

BRANCH
  arcpatch-D22147

REVISION DETAIL
  https://phabricator.kde.org/D22147

AFFECTED FILES
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/svg.cpp
  src/plasma/theme.cpp

To: apol, #plasma, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22172: [kio-extras] Use new activities icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  use-new-activities-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22172

To: GB_2, #plasma, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, kfm-devel, #plasma, fprice, LeGast00n, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22173: [kactivities] Use new activities icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R6 KActivities

BRANCH
  use-new-activities-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22173

To: GB_2, #plasma, #vdg, ndavis
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, michaelh, ngraham, bruns

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a comment.


  Phew, done!

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, 
michaelh, bruns

D22102: Implement apply-on-double-click for all grid view KCM delegates

[Pino Toscano]

pino added a comment.


  In D22102#488447 , @ngraham wrote:
  
  > In D22102#488388 , @pino wrote:
  >
  > > While I can understand that clicking can be "annoying", OTOH I consider 
all the KCMs you mentioned as "mostly once" configuration items: you generally 
configure the color/wallpaper/icons/etc when you start using Plasma, and then 
you almost never go back to change these configurations again. Maybe my 
perspective is limited, however I do not see e.g. an icon KCM used more than 
once per month (even stretching things a bit), so using them often is not a 
"common case".
  > >  Sure, I agree that 20 clicks for trying a wallpaper might be "slow", 
although most probably you have configured it within 10 minutes...
  >
  >
  > Sure, if your mental model of the Appearance configuration KCMs is "set it 
once and forget about it forever", then having a slightly slow workflow isn't a 
problem.
  
  
  I said something else than what you wrote above:
  
  - "mostly once", not "once and never forever"
  - even when you change, it might is not so often
  
  > Right now these KCMs are not catering very well to people with these 
workflows.
  
  I do not think it is worth to provide interface to adapt also to people with 
less common workflows without making it too messy.
  There are many applications that do not perfor greatly for less common (or 
even rare workflows) -- I do not see it problematic, as long as these workflows 
are still doable. After all, we are talking about one click for a wallpaper 
change (the same in any situation), not something else in addition to what is 
required already.
  
  > The people who use this configurability at all are probably likely to 
adjust the settings quite a bit and on a semi-regular basis.
  
  likely is [citation required].
  
  Again, how big is the demand for this?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22102

To: ngraham, #plasma, #vdg, mart, broulik
Cc: anthonyfieroni, pino, davidedmundson, filipf, mglb, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D22173: [kactivities] Use new activities icon

[Björn Feber]

GB_2 added a dependency: D22155: Add new activities and virtual desktops icons.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D22173

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, michaelh, ngraham, bruns

D22173: [kactivities] Use new activities icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the new icon added in D22155 .
  F6948432: kactivities Activities Icon.png 


TEST PLAN
  Open the activities overview.

REPOSITORY
  R6 KActivities

BRANCH
  use-new-activities-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22173

AFFECTED FILES
  src/imports/activitymodel.cpp
  src/lib/activitiesmodel.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, LeGast00n, michaelh, ngraham, bruns

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a dependent revision: D22173: [kactivities] Use new activities icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, 
michaelh, bruns

D22172: [kio-extras] Use new activities icon

[Björn Feber]

GB_2 added a dependency: D22155: Add new activities and virtual desktops icons.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22172

To: GB_2, #plasma, #vdg
Cc: kde-frameworks-devel, #vdg, kfm-devel, #plasma, fprice, LeGast00n, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a dependent revision: D22172: [kio-extras] Use new activities icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, 
michaelh, bruns

D22172: [kio-extras] Use new activities icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the new icon added in D22155 .
  F6948410: kio-extras Activities Icon.png 


TEST PLAN
  Open the Dolphin view context menu and visit "activities:".

REPOSITORY
  R320 KIO Extras

BRANCH
  use-new-activities-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22172

AFFECTED FILES
  activities/KioActivities.cpp
  activities/fileitemplugin/FileItemLinkingPlugin.cpp
  activities/fileitemplugin/FileItemLinkingPluginActionLoader.cpp
  activities/fileitemplugin/kactivitymanagerd_fileitem_linking_plugin.desktop

To: GB_2, #plasma, #vdg
Cc: kde-frameworks-devel, #vdg, kfm-devel, #plasma, fprice, LeGast00n, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a comment.


  In D22155#488485 , @anthonyfieroni 
wrote:
  
  > Renaming the icon is not quite good, if someone use newer framework and old 
applications / Plasma will not see an icon. That's pretty happen since 
framework incorporate new features + bugs fix and Plasma offers LTS.
  
  
  There is no other way, we need to solve T10165 
. We can backport the changes in Plasma to 
the LTS branch though.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, 
michaelh, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:074c91a58318: Move redundant logic in 
KIO::iconNameForUrl() into KFileItem::iconName() (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13048?vs=60801=60872

REVISION DETAIL
  https://phabricator.kde.org/D13048

AFFECTED FILES
  src/core/global.cpp

To: ngraham, #frameworks, broulik, meven, apol, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22155: Add new activities and virtual desktops icons

[Anthony Fieroni]

anthonyfieroni added a comment.


  Renaming the icon is not quite good, if someone use newer framework and old 
applications / Plasma will not see an icon. That's pretty happen since 
framework incorporate new features + bugs fix and Plasma offers LTS.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, 
michaelh, bruns

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a dependent revision: D22171: [colord-kde] Use more appropriate 
icon, because the activities icon changed.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, bruns

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a dependent revision: D22170: [latte-dock] Use new activities icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, bruns

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a dependent revision: D22167: [plasma-workspace] Use new activities 
icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, bruns

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a dependent revision: D22168: [plasma-desktop] Use new activities 
icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, bruns

D22155: Add new activities and virtual desktops icons

[Björn Feber]

GB_2 added a dependent revision: D22169: [plasma-active-window-control] Use new 
activities icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, bruns

D22102: Implement apply-on-double-click for all grid view KCM delegates

[Nathaniel Graham]

ngraham added a comment.


  In D22102#488388 , @pino wrote:
  
  > While I can understand that clicking can be "annoying", OTOH I consider all 
the KCMs you mentioned as "mostly once" configuration items: you generally 
configure the color/wallpaper/icons/etc when you start using Plasma, and then 
you almost never go back to change these configurations again. Maybe my 
perspective is limited, however I do not see e.g. an icon KCM used more than 
once per month (even stretching things a bit), so using them often is not a 
"common case".
  >  Sure, I agree that 20 clicks for trying a wallpaper might be "slow", 
although most probably you have configured it within 10 minutes...
  
  
  Sure, if your mental model of the Appearance configuration KCMs is "set it 
once and forget about it forever", then having a slightly slow workflow isn't a 
problem. But if your workflow is different, then it is a problem. Some people 
like trying out new things and change the appearance settings regularly. Some 
people like to manually change their wallpapers every few days. Some people are 
Plasma developers and need to test patches with multiple color schemes/widget 
themes/wallpapers/etc on a regular basis. Etc.
  
  Right now these KCMs are not catering very well to people with these 
workflows. These people may not be the common case, but the common case is a 
person who never looks in these KCMs at all because they are satisfied with the 
defaults. The people who use this configurability at all are probably likely to 
adjust the settings quite a bit and on a semi-regular basis.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22102

To: ngraham, #plasma, #vdg, mart, broulik
Cc: anthonyfieroni, pino, davidedmundson, filipf, mglb, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D22166: [AdvancedQueryParser] Introduce support for phrase queries

[Igor Poboiko]

poboiko added a comment.


  Note that it somewhat duplicates work done inside `QueryParser`. Which is 
//almost// not used anywhere - most of the parsing is done by 
`AdvancedQueryParser`.
  
  I feel somewhat weird having two separate parsers, as well as two different 
entities which store parsed query - i.e. `EngineQuery` and `Term`. 
  Do we really need them both?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D22166

To: poboiko, #baloo, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22102: Implement apply-on-double-click for all grid view KCM delegates

[Anthony Fieroni]

anthonyfieroni added a comment.


  Alternatively you can add message widget that explore double click 
functionality, when double click is applied it can change its message that save 
is applied. But rater OK/Apply became a bit pointless.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22102

To: ngraham, #plasma, #vdg, mart, broulik
Cc: anthonyfieroni, pino, davidedmundson, filipf, mglb, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D22166: [AdvancedQueryParser] Introduce support for phrase queries

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, ngraham, bruns.
Herald added projects: Frameworks, Baloo.
poboiko requested review of this revision.

REVISION SUMMARY
  AdvancedQueryParser's lexxer can actually handle double quotes:
  for query `a "b c" d`, it returns three tokens (`a`, `b c`, `d`).
  However, when building `Term`, all of them end up having `Auto` comparator,
  which for strings then resolves to `Contains`.
  Finally, inside `SearchStore::constructContainsQuery`, we simply split such
  multi-word term and build an `EngineQuery::StartsWith` query for `b` and `c`.
  
  This patch sets `Equal` comparator for those terms that are inside double 
quotes.
  For that we call `SearchStore::constructEqualsQuery`, which treats it as
  `EngineQuery::Phrase`, which is precicely what we want.
  
  Code-wise, it's more convenient to create a separate class `Token` (instead of
  treating tokens as `QString`), which is aware if this token is inside double 
quotes.
  This patch also moves some of the token-processing routine inside this class
  (see `toVariant`, `toComp`, `toOp` methods)
  
  Also, introduce various tests with double-quoted queries.

TEST PLAN
$ ctest
$ echo "some unique phrase" > ~/test
$ baloosearch '"some unique phrase"'
  
  (only `~/test` should pop up)

REPOSITORY
  R293 Baloo

BRANCH
  phrasesearch

REVISION DETAIL
  https://phabricator.kde.org/D22166

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/advancedqueryparser.cpp

To: poboiko, #baloo, ngraham, bruns
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D10362: Change reveal password button logic

[Nathaniel Graham]

ngraham added a comment.


  I think the idea is that you're not supposed to be typing with the characters 
visible as you type because then anyone else who might be around could just see 
your password. If you're in an environment where security concerns are 
sufficiently low as to permit this, it would probably make more sense to not 
even set a password, or use auto-login.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 141 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/141/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 30 Jun 2019 15:21:42 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report61%
(22/36)64%
(257/402)64%
(257/402)53%
(32662/61081)38%
(16638/43972)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9366/9820)48%
(4289/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8344/14451)50%
(4634/9222)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4595/8217)42%
(1999/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file0%
(0/7)0%
(0/7)0%
(0/1192)0%
(0/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 141 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/141/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 30 Jun 2019 15:21:42 +
 Build duration:
8 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_kprotocolinfotestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22102: Implement apply-on-double-click for all grid view KCM delegates

[Pino Toscano]

pino added a comment.


  In D22102#487806 , @ngraham wrote:
  
  > Right now, I find it *extremely* annoying, slow, and frustrating to test 
new themes, colors, icons, wallpapers, etc. The workflow is to click on the 
delegate, and then click on the Apply button in the corner of the window, or 
use its hidden Alt accelerator. If I want to see 5 items, I do this five times. 
If I want to look through 20 items, I do this 20 times. Every time I do this, I 
get frustrated and feel like it should be doable in a faster way.
  
  
  While I can understand that clicking can be "annoying", OTOH I consider all 
the KCMs you mentioned as "mostly once" configuration items: you generally 
configure the color/wallpaper/icons/etc when you start using Plasma, and then 
you almost never go back to change these configurations again. Maybe my 
perspective is limited, however I do not see e.g. an icon KCM used more than 
once per month (even stretching things a bit), so using them often is not a 
"common case".
  Sure, I agree that 20 clicks for trying a wallpaper might be "slow", although 
most probably you have configured it within 10 minutes...
  
  > This proposal is one way to resolve the issue. I don't personally see a 
problem with the hidden double-click accelerator (obviously, or else I wouldn't 
have submitted the patch :) ),
  
  As I wrote already, this is problematic on its own:
  
  - the general paradigm is OK/Apply/Cancel, so having "pieces" of the 
instant-apply one mixed in (with not even the possibility to disable it) IMHO 
adds more confusion than anything else; I can imagine an user thinking "here I 
can double click to apply instantly" "hmm but here not"
  - corollary of the above: IMHO choosing *one* paradigm and following it is 
the coherent way of doing things; switching to instant-apply (which I don't 
agree with) would require a massive amount of work
  - mis-clicking, even mis-double-clicking happens, and if the user does that, 
they cannot go back to the previous setting, as the action was the equivalent 
of pressing the Apply button
  
  Also, the original proposal mentioned that this would not need explicit 
documentation. This is very bad, as the user faces some hidden behaviour on 
their configuration modules, and they have no way to know that this is actually 
wanted unless they "google it". I do not think our users need to be left in the 
dark about features.
  
  > but if people don't like this approach, I hope we can have a conversation 
about alternative approaches to resolve the underlying issue of the 
test-multiple-items-in-a-grid-view-KCM workflow being quite slow.
  
  Surely I do not want to undermine your own PoV, however how is this a issue 
even? Do we have user reports that point out that this complicates the workflow 
so much?
  From what I can see, the original D18571: Add "apply on double-click" feature 
to most other recent ported KCMs  was done 
by Nate Graham, based on the RFE #398303 requested by Nate Graham, with only a 
later #403384 requested by a single user.
  
  > I can think of a few:
  > 
  > - Move to the instant apply paradigm
  
  -1
  
  > - Add Preview buttons to all delegates that "virtually" apply the item to 
everything visible on screen
  
  What would this Preview button do?
  
  > - Do the above, but on hover or selection, with a visible message that says 
"this is just a preview", click Apply to apply these settings"
  > - Probably way more
  
  Or probably leave things as they are.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22102

To: ngraham, #plasma, #vdg, mart, broulik
Cc: pino, davidedmundson, filipf, mglb, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/131/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 30 Jun 2019 15:21:42 +
 Build duration:
6 min 24 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33429/61104)39%
(17041/43975)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9366/9820)48%
(4289/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8478/14463)51%
(4685/9225)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4594/8217)42%
(1997/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

D10362: Change reveal password button logic

[Noah Davis]

ndavis added a comment.


  In D10362#202435 , @starbuck wrote:
  
  > Would further be also likely more consistent with other toggles in the 
future, like imagined on mobile "wifi crossed out=disabled", etc.
  
  
  The difference between the WiFi toggle and the visibility toggle is that the 
WiFi toggle has a checkbox next to it while this doesn't.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10362: Change reveal password button logic

[Noah Davis]

ndavis added a comment.


  -1 for the current version
  
  How am I supposed to type with 2 hands and see the password at the same time 
if I have to hold down the left mouse button?
  
  -0.75 for the previous version of the patch
  
  We normally show the action that will happen when a button is clicked. Why 
change the behavior here? The state is already know to the user simply by 
seeing that their password is exposed.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22155: Add new activities and virtual desktops icons

[Nathaniel Graham]

ngraham added a comment.


  +1, please mark this patch as a dependency for the other patches and then 
let's land 'em all together once everything looks good.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-new-activities-and-virtual-desktops-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22155

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, michaelh, bruns

D21427: Always skip trailing slashes in FilderedDirIterator

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21427

To: poboiko, #frameworks, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21427: Always skip trailing slashes in FilderedDirIterator

[Igor Poboiko]

poboiko added a reviewer: ngraham.
poboiko added a comment.


  Not entirely sure, but bug 409257 
 might be caused by that (at least 
in my case, it looked the same).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21427

To: poboiko, #frameworks, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22047: Fix translation of actiondisplay

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> imgurplugin.json:105
> +"Name[zh_TW]": "Imgur",
> +"X-Purpose-ActionDisplay": "Imgur"
>  },

same for Imgur :(

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: aspotashev, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> pastebinplugin.json:105
> +"Name[zh_TW]": "Pastebin",
> +"X-Purpose-ActionDisplay": "Pastebin"
>  },

oops, ActionDisplay should have ellipsis, e.g. "Pastebin..."

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: aspotashev, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D10362: Change reveal password button logic

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Méven Car]

meven marked 2 inline comments as done.
meven added a comment.


  Thanks @anthonyfieroni

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, 
michaelh

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Méven Car]

meven updated this revision to Diff 60855.
meven added a comment.


  Use a const ref in the loop use append to add a trailing /

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=58976=60855

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks
Cc: anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, 
michaelh

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 105 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/105/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 30 Jun 2019 06:45:35 +
 Build duration:
6 min 47 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3781/)48%
(5228/10937)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1307/1337)49%
(2613/5353)src79%
(23/29)79%
(23/29)80%
(1301/1633)45%
(547/1228)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3601)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/749)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 111 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/111/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 30 Jun 2019 06:45:35 +
 Build duration:
3 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3781/)48%
(5228/10937)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1307/1337)49%
(2613/5353)src79%
(23/29)79%
(23/29)80%
(1301/1633)45%
(547/1228)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3601)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/749)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D22157: Use debugging category in taglib extractor/writer

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ce0b873f1888: Use debugging category in taglib 
extractor/writer (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22157?vs=60844=60850

REVISION DETAIL
  https://phabricator.kde.org/D22157

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/embeddedimagedata.cpp
  src/extractors/CMakeLists.txt
  src/extractors/taglibextractor.cpp
  src/writers/CMakeLists.txt
  src/writers/taglibwriter.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams