KDE CI: Frameworks » kunitconversion » kf5-qt5 FreeBSDQt5.13 - Build # 3 - Unstable!

2019-07-14 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20FreeBSDQt5.13/3/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 15 Jul 2019 06:30:27 +
 Build duration:
1 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.valuetest

Re: New framework: KCalCore

2019-07-14 Thread Alexander Potashev 
пт, 12 июл. 2019 г. в 19:25, Volker Krause :
> - Alexander P's fundamental objections to the current KCalCore API

After studing kcalcore sources again and also its usages with LXR, I
realize that i would be painful to remove the FileStorage
functionality because it implements format detection, and it's hard to
decide in what use cases we can or cannot drop format detection (vCal1
vs iCal2).

For use cases where file operations have to be asynchronous, the
FileStorage layer can be ignored and
ICalFormat::fromRawString()/fromString()/toString() used directly
instead (however I didn't try this approach yet because it's
uncommon).

All in all, I agree to follow the golden rule "if it works, don't touch it".

-- 
Alexander Potashev

D22144: Add kio recentlyused:/ to access KactivitytStats data

2019-07-14 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks, got it built. However unfortunately it didn't help.
  
  I see that `/home/nate/kde/usr/lib64/plugins/kf5/kio/recentlyused.so` exists, 
and `/home/nate/kde/usr/lib64/plugins` is in my `$QT_PLUGIN_PATH` variable. And 
yet...
  
$ KDE_FORK_SLAVE=1 /home/nate/kde/usr/bin/kioclient5 ls 
recentlyused:/?limit=100
kf5.kio.core: couldn't create slave: "klauncher said: Unknown protocol 
'recentlyused'.\n"
"Unable to create io-slave. klauncher said: Unknown protocol 
'recentlyused'.\n"
  
  Even adding `/home/nate/kde/usr/lib64/plugins/kf5/kio/` to `$QT_PLUGIN_PATH` 
doesn't help. I feel like I must be doing something stupid here.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D21901: Calendar events: allow plugins to show event details

2019-07-14 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> calendareventsplugin.h:236
> + *
> + * @since 5.60
> + */

should be since 5.61 now

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21901

To: dvratil, #frameworks, mart, apol
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
bruns

D21901: Calendar events: allow plugins to show event details

2019-07-14 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21901

To: dvratil, #frameworks, mart, apol
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
bruns

D22425: personsmodel: Add phoneNumber

2019-07-14 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R307 KPeople

BRANCH
  personsmodel-phoneNumber (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22425

To: jbbgameich, #plasma:_mobile, #kde_pim, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

2019-07-14 Thread Sebastian Krzyszkowiak 
dos updated this revision to Diff 61760.
dos added a comment.


  Added context

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22459?vs=61754&id=61760

REVISION DETAIL
  https://phabricator.kde.org/D22459

AFFECTED FILES
  src/server/seat_interface.cpp

To: dos, #kwin
Cc: romangg, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

2019-07-14 Thread Sebastian Krzyszkowiak 
dos added a comment.


  I've been using nested rootston inside KWin and noticed problems with content 
refresh when using touchscreen. It worked better with mouse. After debugging, 
it turned out that:
  
  - rootston doesn't register to wl_touch, so KWin emulates wl_pointer events
  - when emulating, KWin sends naked wl_pointer.motion and wl_pointer.button 
events without sending any wl_pointer.frame with them
  
  wl_pointer.frames are sent when using mouse or using touchscreen with a 
client that listens to wl_touch; they just weren't when emulating wl_pointer 
out of touch for clients that don't.
  
  See also: https://github.com/swaywm/wlroots/pull/1754

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22459

To: dos, #kwin
Cc: romangg, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

2019-07-14 Thread Roman Gilg 
romangg added a comment.


  Please include the context for this diff.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22459

To: dos, #kwin
Cc: romangg, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22460: DrKonqi: improved lldb integration

2019-07-14 Thread René J . V . Bertin 
rjvbb created this revision.
rjvbb added reviewers: kde-frameworks-devel, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rjvbb requested review of this revision.

REVISION SUMMARY
  Since a few versions lldb has had a tendency to remain stuck after the 
initial connection to the crashed application (on Mac). On Linux it would often 
exit cleanly and quickly in a way not foreseen by my previous code, causing 
DrKonqi to report an unexpected debugger termination.
  
  This patch addresses both issues:
  
  - recent lldb versions have no more problems with reading commands from a 
batchfile
  - this make it possible to add an explicit exit command
  - `slotProcessExited()` is called explicitly when lldb has confirmed the exit 
command
  - errors caused by terminating or killing the debugger process are now 
ignored.

TEST PLAN
  Getting a crash backtrace now works as expected on Mac and Linux. No 
regressions are introduced when using the gdb backend on Linux.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22460

AFFECTED FILES
  src/backtracegenerator.cpp
  src/backtracegenerator.h
  src/data/debuggers/internal/lldbrc

To: rjvbb, kde-frameworks-devel, #plasma
Cc: plasma-devel, kde-mac, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21782: Add a warning dialog with details, continue, and cancel button

2019-07-14 Thread Elvis Angelaccio 
elvisangelaccio added inline comments.

INLINE COMMENTS

> kmessagebox.h:329
> + *
> + * @since 5.60
> + */

Needs a bump to 5.61

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

2019-07-14 Thread Sebastian Krzyszkowiak 
dos created this revision.
dos added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dos requested review of this revision.

REVISION SUMMARY
  When touching a surface that doesn't register to wl_touch events, KWin didn't 
send frame events (which it does for regular pointer and touch events), causing 
severe updating issues with some clients.

TEST PLAN
  Launch a client that doesn't attach to wl_touch (for instance, rootston) with 
WAYLAND_DEBUG=client and watch the logs while touching its window.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22459

AFFECTED FILES
  src/server/seat_interface.cpp

To: dos, #kwin
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-14 Thread Igor Poboiko 
poboiko added a comment.


  In D21427#494174 , @bruns wrote:
  
  > In D21427#494010 , @poboiko 
wrote:
  >
  > > Ping!
  > >
  > > Apparently, it does fix bug 409257, which is pretty serious one (db 
corruption, after all).
  >
  >
  > The DB corruption is already fixed in KF5.60.
  
  
  I saw it in master and was wondering if it ended up in 5.60 (and whether it's 
still possible to corrupt it in any other way).
  
  OK, DB corruption apart, I believe this patch is still relevant - we rely on 
paths not having trailing slash in different parts of the code anyways. And it 
clearly doesn't work as expected.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21427

To: poboiko, #frameworks, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

2019-07-14 Thread Alexander Stippich 
astippich abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22144: Add kio recentlyused:/ to access KactivitytStats data

2019-07-14 Thread Méven Car 
meven added a comment.


  In D22144#495277 , @ngraham wrote:
  
  > I wonder if this is the problem:
  >
  >   ls /home/nate/kde/usr/bin/kioclient5
  >   ls: cannot access '/home/nate/kde/usr/bin/kioclient5': No such file or 
directory
  >
  >
  > What actually builds that binary? My KIO doesn't seem to do it.
  
  
  It is in kde-cli-tools, kb kde-cli-tools ;)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KactivitytStats data

2019-07-14 Thread Nathaniel Graham 
ngraham added a comment.


  I wonder if this is the problem:
  
ls /home/nate/kde/usr/bin/kioclient5
ls: cannot access '/home/nate/kde/usr/bin/kioclient5': No such file or 
directory
  
  What actually builds that binary? My KIO doesn't seem to do it.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22339: Make sure solid backends are reentrant

2019-07-14 Thread David Edmundson 
davidedmundson added a comment.


  I don't endorse things being closed whilst there are still review comments, 
but replying purely on the tech side:
  
  > How do you guarantee *each thread local* copy now is connected to the right 
signals, i.e. the socket notifier for the mtab and inotify for fstab?
  
  Even before this patch frontend/DeviceManager puts each Backend in a thread 
local storage.
  
  Each backend (and child tree) is a separate object. It only need to clear 
it's own TLS.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D22339

To: apol, #frameworks, davidedmundson, bruns
Cc: lbeltrame, bruns, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham

D22144: Add kio recentlyused:/ to access KactivitytStats data

2019-07-14 Thread Méven Car 
meven retitled this revision from "- Add kio recentlyused:/ to access 
KactivitytStats data" to "Add kio recentlyused:/ to access KactivitytStats 
data".

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D21902: Calendar: add method to show event details

2019-07-14 Thread Daniel Vrátil 
dvratil added a reviewer: Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

2019-07-14 Thread Daniel Vrátil 
dvratil added a comment.


  Ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

2019-07-14 Thread Daniel Vrátil 
dvratil added a comment.


  Ping?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D21901

To: dvratil, #frameworks, mart
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
bruns